Whamcloud - gitweb
LU-13569 lnet: Add lnet_recovery_limit to lnetctl
[fs/lustre-release.git] / lnet / utils / lnetconfig / liblnetconfig.c
index bc5016a..a5a3eeb 100644 (file)
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <ifaddrs.h>
+#include <rdma/rdma_user_cm.h>
 #include "liblnetconfig.h"
+#include <glob.h>
+#include <libcfs/util/param.h>
 
 #define CONFIG_CMD             "configure"
 #define UNCONFIG_CMD           "unconfigure"
 #define MAX_NUM_IPS            128
 
 #define modparam_path "/sys/module/lnet/parameters/"
+#define o2ib_modparam_path "/sys/module/ko2iblnd/parameters/"
 #define gni_nid_path "/proc/cray_xt/"
 
+#ifndef HAVE_USRSPC_RDMA_PS_TCP
+#define RDMA_PS_TCP 0x0106
+#endif
+
 const char *gmsg_stat_names[] = {"sent_stats", "received_stats",
                                 "dropped_stats"};
 
@@ -248,71 +256,6 @@ void lustre_lnet_init_nw_descr(struct lnet_dlc_network_descr *nw_descr)
        }
 }
 
-static char *get_next_delimiter_in_nid(char *str, char sep)
-{
-       char *at, *comma;
-
-       /* first find the '@' */
-       at = strchr(str, '@');
-       if (!at)
-               return str;
-
-       /* now that you found the at find the sep after */
-       comma = strchr(at, sep);
-       return comma;
-}
-
-int tokenize_nidstr(char *nidstr, char *out[LNET_MAX_STR_LEN], char *err_str)
-{
-       int bracket = 0, num_str = 0;
-       char *strstart, *chptr;
-
-       if (!nidstr) {
-               snprintf(err_str, LNET_MAX_STR_LEN, "supplied nidstr is NULL");
-               return LUSTRE_CFG_RC_BAD_PARAM;
-       }
-
-       /* comma-separated nidranges -> space-separated nidranges */
-       chptr = &nidstr[0];
-       strstart = chptr;
-       while (true) {
-               if (*chptr == '\0') {
-                       out[num_str] = strstart;
-                       num_str++;
-                       break;
-               }
-
-               if (*chptr == '[')
-                       bracket++;
-               else if (*chptr == ']')
-                       bracket--;
-
-               if (bracket < 0) {
-                       snprintf(err_str, LNET_MAX_STR_LEN,
-                                "Mismatched brackets in nidstring \"%s\"",
-                                nidstr);
-                       return LUSTRE_CFG_RC_BAD_PARAM;
-               }
-
-               if (bracket == 0 && *chptr == ',') {
-                       out[num_str] = strstart;
-                       *chptr = '\0';
-                       num_str++;
-                       strstart = chptr + 1;
-               }
-
-               chptr++;
-       }
-
-       if (bracket != 0) {
-               snprintf(err_str, LNET_MAX_STR_LEN,
-                        "Mismatched brackets in nidstring \"%s\"", nidstr);
-               return LUSTRE_CFG_RC_BAD_PARAM;
-       }
-
-       return num_str;
-}
-
 int lustre_lnet_parse_nidstr(char *nidstr, lnet_nid_t *lnet_nidlist,
                             int max_nids, char *err_str)
 {
@@ -345,6 +288,7 @@ int lustre_lnet_parse_nidstr(char *nidstr, lnet_nid_t *lnet_nidlist,
        }
 
        num_nids = cfs_expand_nidlist(&nidlist, lnet_nidlist, max_nids);
+       cfs_free_nidlist(&nidlist);
 
        if (num_nids == -1) {
                snprintf(err_str, LNET_MAX_STR_LEN,
@@ -368,90 +312,6 @@ int lustre_lnet_parse_nidstr(char *nidstr, lnet_nid_t *lnet_nidlist,
        return num_nids;
 }
 
-int lustre_lnet_parse_nids(char *nids, char **array, int size,
-                          char ***out_array)
-{
-       int num_nids = 0;
-       char *comma = nids, *cur, *entry;
-       char **new_array;
-       int i, len, start = 0, finish = 0;
-
-       if (nids == NULL || strlen(nids) == 0)
-               return size;
-
-       /* count the number or new nids, by counting the number of comma*/
-       while (comma) {
-               comma = get_next_delimiter_in_nid(comma, ',');
-               if (comma) {
-                       comma++;
-                       num_nids++;
-               } else {
-                       num_nids++;
-               }
-       }
-
-       /*
-        * if the array is not NULL allocate a large enough array to house
-        * the old and new entries
-        */
-       new_array = calloc(sizeof(char*),
-                          (size > 0) ? size + num_nids : num_nids);
-
-       if (!new_array)
-               goto failed;
-
-       /* parse our the new nids and add them to the tail of the array */
-       comma = nids;
-       cur = nids;
-       start = (size > 0) ? size: 0;
-       finish = (size > 0) ? size + num_nids : num_nids;
-       for (i = start; i < finish; i++) {
-               comma = get_next_delimiter_in_nid(comma, ',');
-               if (!comma)
-                       /*
-                        * the length of the string to be parsed out is
-                        * from cur to end of string. So it's good enough
-                        * to strlen(cur)
-                        */
-                       len = strlen(cur) + 1;
-               else
-                       /* length of the string is comma - cur */
-                       len = (comma - cur) + 1;
-
-               entry = calloc(1, len);
-               if (!entry) {
-                       finish = i > 0 ? i - 1: 0;
-                       goto failed;
-               }
-               memcpy(entry, cur, len - 1);
-               entry[len] = '\0';
-               new_array[i] = entry;
-               if (comma) {
-                       comma++;
-                       cur = comma;
-               }
-       }
-
-       /* add the old entries in the array and delete the old array*/
-       for (i = 0; i < size; i++)
-               new_array[i] = array[i];
-
-       if (array)
-               free(array);
-
-       *out_array = new_array;
-
-       return finish;
-
-failed:
-       for (i = start; i < finish; i++)
-               free(new_array[i]);
-       if (new_array)
-               free(new_array);
-
-       return size;
-}
-
 /*
  * format expected:
  *     <intf>[<expr>], <intf>[<expr>],..
@@ -533,9 +393,7 @@ int lustre_lnet_config_ni_system(bool up, bool load_ni_from_mod,
        struct libcfs_ioctl_data data;
        unsigned int opc;
        int rc;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"Success\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"Success\"";
 
        LIBCFS_IOC_INIT(data);
 
@@ -702,8 +560,7 @@ static int infra_ping_nid(char *ping_nids, char *oper, int param, int ioc_call,
                        goto out;
 
                for (i = 0; i < ping.ping_count; i++) {
-                       if (!strcmp(libcfs_nid2str(ping.ping_buf[i].nid),
-                                   "0@lo"))
+                       if (ping.ping_buf[i].nid == LNET_NID_LO_0)
                                continue;
                        peer_ni = cYAML_create_seq_item(tmp);
                        if (peer_ni == NULL)
@@ -768,116 +625,6 @@ int lustre_lnet_discover_nid(char *ping_nids, int force, int seq_no,
        return rc;
 }
 
-static void lustre_lnet_clean_ip2nets(struct lustre_lnet_ip2nets *ip2nets)
-{
-       struct lustre_lnet_ip_range_descr *ipr, *tmp;
-       struct cfs_expr_list *el, *el_tmp;
-
-       list_for_each_entry_safe(ipr, tmp,
-                                &ip2nets->ip2nets_ip_ranges,
-                                ipr_entry) {
-               list_del(&ipr->ipr_entry);
-               list_for_each_entry_safe(el, el_tmp, &ipr->ipr_expr,
-                                        el_link) {
-                       list_del(&el->el_link);
-                       cfs_expr_list_free(el);
-               }
-               free(ipr);
-       }
-}
-
-/*
- * returns an rc < 0 if there is an error
- * otherwise it returns the number IPs generated
- *  it also has out params: net - network name
- */
-static int lnet_expr2ips(char *nidstr, __u32 *ip_list,
-                        struct lustre_lnet_ip2nets *ip2nets,
-                        __u32 *net, char *err_str)
-{
-       struct lustre_lnet_ip_range_descr *ipr;
-       char *comp1, *comp2;
-       int ip_idx = MAX_NUM_IPS - 1;
-       int ip_range_len, rc = LUSTRE_CFG_RC_NO_ERR;
-       __u32 net_type;
-       char ip_range[LNET_MAX_STR_LEN];
-
-       /* separate the two components of the NID */
-       comp1 = nidstr;
-       comp2 = strchr(nidstr, '@');
-       if (comp2 == NULL) {
-               snprintf(err_str,
-                       LNET_MAX_STR_LEN,
-                       "\"cannot parse NID %s\"", nidstr);
-               err_str[LNET_MAX_STR_LEN - 1] = '\0';
-               rc = LUSTRE_CFG_RC_BAD_PARAM;
-               goto out;
-       }
-
-       /* length of the expected ip-range */
-       ip_range_len = comp2 - comp1;
-       if (ip_range_len >= LNET_MAX_STR_LEN) {
-               snprintf(err_str,
-                       LNET_MAX_STR_LEN,
-                       "\"too long ip_range '%s'\"", nidstr);
-               err_str[LNET_MAX_STR_LEN - 1] = '\0';
-               rc = LUSTRE_CFG_RC_BAD_PARAM;
-               goto out;
-       }
-
-       /* move beyond '@' */
-       comp2++;
-
-       /*
-        * if the net component is either o2ib or tcp then we expect
-        * an IP range which could only be a single IP address.
-        * Parse that.
-        */
-       *net = libcfs_str2net(comp2);
-       net_type = LNET_NETTYP(*net);
-       /* expression support is for o2iblnd and socklnd only */
-       if (net_type != O2IBLND && net_type != SOCKLND)
-               return LUSTRE_CFG_RC_SKIP;
-
-       strncpy(ip_range, comp1, ip_range_len);
-       ip_range[ip_range_len] = '\0';
-       ip2nets->ip2nets_net.nw_id = *net;
-
-       rc = lustre_lnet_add_ip_range(&ip2nets->ip2nets_ip_ranges, ip_range);
-       if (rc != LUSTRE_CFG_RC_NO_ERR) {
-               snprintf(err_str,
-                       LNET_MAX_STR_LEN,
-                       "\"cannot parse ip_range '%.100s'\"", ip_range);
-               err_str[LNET_MAX_STR_LEN - 1] = '\0';
-               rc = LUSTRE_CFG_RC_BAD_PARAM;
-               goto out;
-       }
-
-       /*
-       * Generate all the IP Addresses from the parsed range. For sanity
-       * we allow only a max of MAX_NUM_IPS nids to be configured for
-       * a single peer.
-       */
-       list_for_each_entry(ipr, &ip2nets->ip2nets_ip_ranges, ipr_entry)
-               ip_idx = cfs_ip_addr_range_gen(ip_list, MAX_NUM_IPS,
-                                               &ipr->ipr_expr);
-
-       if (ip_idx == MAX_NUM_IPS - 1) {
-               snprintf(err_str, LNET_MAX_STR_LEN,
-                               "no NIDs provided for configuration");
-               err_str[LNET_MAX_STR_LEN - 1] = '\0';
-               rc = LUSTRE_CFG_RC_NO_MATCH;
-               goto out;
-       } else if (ip_idx == -1) {
-               rc = LUSTRE_CFG_RC_LAST_ELEM;
-       } else {
-               rc = ip_idx;
-       }
-
-out:
-       return rc;
-}
-
 static int lustre_lnet_handle_peer_nidlist(lnet_nid_t *nidlist, int num_nids,
                                           bool is_mr, __u32 cmd,
                                           char *cmd_type, char *err_str)
@@ -931,229 +678,22 @@ static int lustre_lnet_handle_peer_nidlist(lnet_nid_t *nidlist, int num_nids,
        return rc;
 }
 
-static int lustre_lnet_handle_peer_ip2nets(char **nid, int num_nids, bool mr,
-                                          bool range, __u32 cmd,
-                                          char *cmd_type, char *err_str)
-{
-       __u32 net = LNET_NIDNET(LNET_NID_ANY);
-       int ip_idx;
-       int i, j, rc = LUSTRE_CFG_RC_NO_ERR;
-       __u32 ip_list[MAX_NUM_IPS];
-       struct lustre_lnet_ip2nets ip2nets;
-       struct lnet_ioctl_peer_cfg data;
-       lnet_nid_t peer_nid;
-       lnet_nid_t prim_nid = LNET_NID_ANY;
-
-       /* initialize all lists */
-       INIT_LIST_HEAD(&ip2nets.ip2nets_ip_ranges);
-       INIT_LIST_HEAD(&ip2nets.ip2nets_net.network_on_rule);
-       INIT_LIST_HEAD(&ip2nets.ip2nets_net.nw_intflist);
-
-       /* each nid entry is an expression */
-       for (i = 0; i < num_nids; i++) {
-               if (!range && i == 0)
-                       prim_nid = libcfs_str2nid(nid[0]);
-               else if (range)
-                       prim_nid = LNET_NID_ANY;
-
-               rc = lnet_expr2ips(nid[i], ip_list, &ip2nets, &net, err_str);
-               if (rc == LUSTRE_CFG_RC_SKIP)
-                       continue;
-               else if (rc == LUSTRE_CFG_RC_LAST_ELEM)
-                       rc = -1;
-               else if (rc < LUSTRE_CFG_RC_NO_ERR)
-                       goto out;
-
-               ip_idx = rc;
-
-               for (j = MAX_NUM_IPS - 1; j > ip_idx; j--) {
-                       peer_nid = LNET_MKNID(net, ip_list[j]);
-                       if (peer_nid == LNET_NID_ANY) {
-                               snprintf(err_str,
-                                       LNET_MAX_STR_LEN,
-                                       "\"cannot parse NID\"");
-                               err_str[LNET_MAX_STR_LEN - 1] = '\0';
-                               rc = LUSTRE_CFG_RC_BAD_PARAM;
-                               goto out;
-                       }
-
-                       LIBCFS_IOC_INIT_V2(data, prcfg_hdr);
-                       data.prcfg_mr = mr;
-
-                       if (prim_nid == LNET_NID_ANY && j == MAX_NUM_IPS - 1) {
-                               prim_nid = peer_nid;
-                               peer_nid = LNET_NID_ANY;
-                       }
-
-                       if (!range && num_nids > 1 && i == 0 &&
-                           cmd == IOC_LIBCFS_DEL_PEER_NI)
-                               continue;
-                       else if (!range && i == 0)
-                               peer_nid = LNET_NID_ANY;
-
-                       LIBCFS_IOC_INIT_V2(data, prcfg_hdr);
-                       data.prcfg_mr = mr;
-                       data.prcfg_prim_nid = prim_nid;
-                       data.prcfg_cfg_nid = peer_nid;
-
-                       /*
-                       * If prim_nid is not provided then the first nid in the
-                       * list becomes the prim_nid. First time round the loop
-                       * use LNET_NID_ANY for the first parameter, then use
-                       * nid[0] as the key nid after wards
-                       */
-                       rc = dispatch_peer_ni_cmd(cmd, &data, err_str,
-                                                 cmd_type);
-                       if (rc != 0)
-                               goto out;
-
-                       /*
-                        * we just deleted the entire peer using the
-                        * primary_nid. So don't bother iterating through
-                        * the rest of the nids
-                        */
-                       if (prim_nid != LNET_NID_ANY &&
-                           peer_nid == LNET_NID_ANY &&
-                           cmd == IOC_LIBCFS_DEL_PEER_NI)
-                               goto next_nid;
-               }
-next_nid:
-               lustre_lnet_clean_ip2nets(&ip2nets);
-       }
-
-out:
-       lustre_lnet_clean_ip2nets(&ip2nets);
-       return rc;
-}
-
-int lustre_lnet_config_peer_nidlist(char *pnidstr, lnet_nid_t *lnet_nidlist,
-                                   int num_nids, bool is_mr, int seq_no,
-                                   struct cYAML **err_rc)
-{
-       int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
-       lnet_nid_t *lnet_nidlist2 = NULL;
-       lnet_nid_t pnid;
-
-       if (pnidstr) {
-               pnid = libcfs_str2nid(pnidstr);
-               if (pnid == LNET_NID_ANY) {
-                       snprintf(err_str, LNET_MAX_STR_LEN,
-                                "bad primary NID: '%s'", pnidstr);
-                       rc = LUSTRE_CFG_RC_MISSING_PARAM;
-                       goto out;
-               }
-
-               num_nids++;
-
-               lnet_nidlist2 = calloc(sizeof(*lnet_nidlist2), num_nids);
-               if (!lnet_nidlist2) {
-                       snprintf(err_str, LNET_MAX_STR_LEN, "out of memory");
-                       rc = LUSTRE_CFG_RC_OUT_OF_MEM;
-                       goto out;
-               }
-               lnet_nidlist2[0] = pnid;
-               memcpy(&lnet_nidlist2[1], lnet_nidlist, sizeof(*lnet_nidlist) *
-                                                   (num_nids - 1));
-       }
-
-       rc = lustre_lnet_handle_peer_nidlist((pnidstr) ? lnet_nidlist2 :
-                                                        lnet_nidlist,
-                                            num_nids, is_mr,
-                                            IOC_LIBCFS_ADD_PEER_NI, ADD_CMD,
-                                            err_str);
-out:
-       if (lnet_nidlist2)
-               free(lnet_nidlist2);
-
-       cYAML_build_error(rc, seq_no, ADD_CMD, "peer_ni", err_str, err_rc);
-       return rc;
-}
-
-int lustre_lnet_config_peer_nid(char *pnid, char **nid, int num_nids,
-                               bool mr, bool ip2nets, int seq_no,
-                               struct cYAML **err_rc)
-{
-       int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN] = {0};
-       char **nid_array = NULL;
-
-       snprintf(err_str, sizeof(err_str), "\"Success\"");
-
-       if (ip2nets) {
-               rc = lustre_lnet_handle_peer_ip2nets(nid, num_nids, mr,
-                                               ip2nets, IOC_LIBCFS_ADD_PEER_NI,
-                                               ADD_CMD, err_str);
-               goto out;
-       }
-
-       if (pnid) {
-               if (libcfs_str2nid(pnid) == LNET_NID_ANY) {
-                       snprintf(err_str, sizeof(err_str),
-                                "bad primary NID: '%s'",
-                                pnid);
-                       rc = LUSTRE_CFG_RC_MISSING_PARAM;
-                       goto out;
-               }
-
-               num_nids++;
-
-               nid_array = calloc(sizeof(*nid_array), num_nids);
-               if (!nid_array) {
-                       snprintf(err_str, sizeof(err_str),
-                                       "out of memory");
-                       rc = LUSTRE_CFG_RC_OUT_OF_MEM;
-                       goto out;
-               }
-               nid_array[0] = pnid;
-               memcpy(&nid_array[1], nid, sizeof(*nid) * (num_nids - 1));
-       }
-
-       rc = lustre_lnet_handle_peer_ip2nets((pnid) ? nid_array : nid,
-                                            num_nids, mr, ip2nets,
-                                            IOC_LIBCFS_ADD_PEER_NI, ADD_CMD,
-                                            err_str);
-       if (rc)
-               goto out;
-
-out:
-       if (nid_array)
-               free(nid_array);
-
-       cYAML_build_error(rc, seq_no, ADD_CMD, "peer_ni", err_str, err_rc);
-       return rc;
-}
-
-int lustre_lnet_del_peer_nidlist(char *pnidstr, lnet_nid_t *lnet_nidlist,
-                                int num_nids, int seq_no,
-                                struct cYAML **err_rc)
+static int
+lustre_lnet_mod_peer_nidlist(lnet_nid_t pnid, lnet_nid_t *lnet_nidlist,
+                            int cmd, int num_nids, bool is_mr, int seq_no,
+                            struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
        char err_str[LNET_MAX_STR_LEN];
        lnet_nid_t *lnet_nidlist2 = NULL;
-       lnet_nid_t pnid;
-
-       if (!pnidstr) {
-               snprintf(err_str, sizeof(err_str),
-                        "\"Primary nid is not provided\"");
-               rc = LUSTRE_CFG_RC_MISSING_PARAM;
-               goto out;
-       }
-
-       pnid = libcfs_str2nid(pnidstr);
-       if (pnid == LNET_NID_ANY) {
-               rc = LUSTRE_CFG_RC_BAD_PARAM;
-               snprintf(err_str, sizeof(err_str),
-                        "bad key NID: '%s'",
-                        pnidstr);
-               goto out;
-       }
+       int ioc_cmd = (cmd == LNETCTL_ADD_CMD) ? IOC_LIBCFS_ADD_PEER_NI :
+               IOC_LIBCFS_DEL_PEER_NI;
+       char *cmd_str = (cmd == LNETCTL_ADD_CMD) ? ADD_CMD : DEL_CMD;
 
        num_nids++;
        lnet_nidlist2 = calloc(sizeof(*lnet_nidlist2), num_nids);
        if (!lnet_nidlist2) {
-               snprintf(err_str, sizeof(err_str),
-                               "out of memory");
+               snprintf(err_str, LNET_MAX_STR_LEN, "out of memory");
                rc = LUSTRE_CFG_RC_OUT_OF_MEM;
                goto out;
        }
@@ -1161,70 +701,83 @@ int lustre_lnet_del_peer_nidlist(char *pnidstr, lnet_nid_t *lnet_nidlist,
        memcpy(&lnet_nidlist2[1], lnet_nidlist, sizeof(*lnet_nidlist) *
                                                (num_nids - 1));
 
-       rc = lustre_lnet_handle_peer_nidlist(lnet_nidlist2, num_nids, false,
-                                            IOC_LIBCFS_DEL_PEER_NI, DEL_CMD,
-                                            err_str);
+       rc = lustre_lnet_handle_peer_nidlist(lnet_nidlist2,
+                                            num_nids, is_mr, ioc_cmd,
+                                            cmd_str, err_str);
 out:
        if (lnet_nidlist2)
                free(lnet_nidlist2);
 
-       cYAML_build_error(rc, seq_no, DEL_CMD, "peer_ni", err_str, err_rc);
+       cYAML_build_error(rc, seq_no, cmd_str, "peer_ni", err_str, err_rc);
        return rc;
 }
 
-int lustre_lnet_del_peer_nid(char *pnid, char **nid, int num_nids,
-                            bool ip2nets, int seq_no, struct cYAML **err_rc)
+static void
+replace_sep(char *str, char sep, char newsep)
 {
-       int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN] = {0};
-       char **nid_array = NULL;
+       int bracket = 0;
+       int i;
+       if (!str)
+               return;
+       for (i = 0; i < strlen(str); i++) {
+               /* don't replace ',' within [] */
+               if (str[i] == '[')
+                       bracket++;
+               else if (str[i] == ']')
+                       bracket--;
+               else if (str[i] == sep && bracket == 0)
+                       str[i] = newsep;
+       }
+}
 
-       snprintf(err_str, sizeof(err_str), "\"Success\"");
+int lustre_lnet_modify_peer(char *prim_nid, char *nids, bool is_mr,
+                           int cmd, int seq_no, struct cYAML **err_rc)
+{
+       int num_nids, rc;
+       char err_str[LNET_MAX_STR_LEN] = "Error";
+       lnet_nid_t lnet_nidlist[LNET_MAX_NIDS_PER_PEER];
+       lnet_nid_t pnid = LNET_NID_ANY;
 
-       if (ip2nets) {
-               rc = lustre_lnet_handle_peer_ip2nets(nid, num_nids, false,
-                                               ip2nets, IOC_LIBCFS_DEL_PEER_NI,
-                                               DEL_CMD, err_str);
+       if (!prim_nid) {
+               rc = LUSTRE_CFG_RC_BAD_PARAM;
+               snprintf(err_str, LNET_MAX_STR_LEN,
+                        "--prim_nid must be specified");
                goto out;
        }
 
-       if (pnid == NULL) {
-               snprintf(err_str, sizeof(err_str),
-                        "\"Primary nid is not provided\"");
-               rc = LUSTRE_CFG_RC_MISSING_PARAM;
+       pnid = libcfs_str2nid(prim_nid);
+       if (pnid == LNET_NID_ANY) {
+               rc = LUSTRE_CFG_RC_BAD_PARAM;
+               snprintf(err_str, LNET_MAX_STR_LEN,
+                       "badly formatted primary NID: %s", prim_nid);
                goto out;
-       } else if (!ip2nets) {
-               if (libcfs_str2nid(pnid) == LNET_NID_ANY) {
-                       rc = LUSTRE_CFG_RC_BAD_PARAM;
-                       snprintf(err_str, sizeof(err_str),
-                                "bad key NID: '%s'",
-                                pnid);
-                       goto out;
-               }
        }
 
-       num_nids++;
-       nid_array = calloc(sizeof(*nid_array), num_nids);
-       if (!nid_array) {
-               snprintf(err_str, sizeof(err_str),
-                               "out of memory");
-               rc = LUSTRE_CFG_RC_OUT_OF_MEM;
-               goto out;
+       num_nids = 0;
+       if (nids) {
+               /*
+               * if there is no primary nid we need to make the first nid in the
+               * nids list the primary nid
+               */
+               replace_sep(nids, ',', ' ');
+               rc = lustre_lnet_parse_nidstr(nids, lnet_nidlist,
+                                       LNET_MAX_NIDS_PER_PEER, err_str);
+               if (rc < 0)
+                       goto out;
+
+               num_nids = rc;
        }
-       nid_array[0] = pnid;
-       memcpy(&nid_array[1], nid, sizeof(*nid) * (num_nids - 1));
 
-       rc = lustre_lnet_handle_peer_ip2nets(nid_array, num_nids, false,
-                                            ip2nets, IOC_LIBCFS_DEL_PEER_NI,
-                                            DEL_CMD, err_str);
-       if (rc)
-               goto out;
+       rc = lustre_lnet_mod_peer_nidlist(pnid, lnet_nidlist,
+                                         cmd, num_nids, is_mr,
+                                         -1, err_rc);
 
 out:
-       if (nid_array)
-               free(nid_array);
+       if (rc != LUSTRE_CFG_RC_NO_ERR)
+               cYAML_build_error(rc, -1, "peer",
+                               cmd == LNETCTL_ADD_CMD ? "add" : "del",
+                               err_str, err_rc);
 
-       cYAML_build_error(rc, seq_no, DEL_CMD, "peer_ni", err_str, err_rc);
        return rc;
 }
 
@@ -1232,10 +785,9 @@ int lustre_lnet_route_common(char *nw, char *nidstr, int hops, int prio,
                             int sen, int seq_no, struct cYAML **err_rc,
                             int cmd)
 {
-       int rc, num_nids, num_nidstrs, nid_idx, str_idx;
+       int rc, num_nids, idx;
        __u32 rnet;
-       char err_str[LNET_MAX_STR_LEN];
-       char *nidstrarray[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"generic error\"";
        struct lnet_ioctl_config_data data;
        lnet_nid_t lnet_nidlist[LNET_MAX_NIDS_PER_PEER];
 
@@ -1249,28 +801,22 @@ int lustre_lnet_route_common(char *nw, char *nidstr, int hops, int prio,
        }
 
        rnet = libcfs_str2net(nw);
-       if (rnet == LNET_NIDNET(LNET_NID_ANY)) {
+       if (rnet == LNET_NET_ANY) {
                snprintf(err_str, LNET_MAX_STR_LEN,
                         "\"cannot parse remote net %s\"", nw);
                rc = LUSTRE_CFG_RC_BAD_PARAM;
                goto out;
        }
 
-       rc = tokenize_nidstr(nidstr, &nidstrarray[0], err_str);
+       replace_sep(nidstr, ',', ' ');
+       rc = lustre_lnet_parse_nidstr(nidstr, lnet_nidlist,
+                                     LNET_MAX_NIDS_PER_PEER, err_str);
        if (rc < 0)
                goto out;
 
-       num_nidstrs = rc;
-
-       for (str_idx = 0; str_idx < num_nidstrs; str_idx++) {
-               rc = lustre_lnet_parse_nidstr(nidstrarray[str_idx],
-                                             lnet_nidlist,
-                                             LNET_MAX_NIDS_PER_PEER, err_str);
-               if (rc < 0)
-                       goto out;
-
-               num_nids = rc;
+       num_nids = rc;
 
+       for (idx = 0; idx < num_nids; idx++) {
                LIBCFS_IOC_INIT_V2(data, cfg_hdr);
                data.cfg_net = rnet;
                if (cmd == LNETCTL_ADD_CMD) {
@@ -1279,24 +825,28 @@ int lustre_lnet_route_common(char *nw, char *nidstr, int hops, int prio,
                        data.cfg_config_u.cfg_route.rtr_sensitivity = sen;
                }
 
-               for (nid_idx = 0; nid_idx < num_nids; nid_idx++) {
-                       data.cfg_nid = lnet_nidlist[nid_idx];
+               data.cfg_nid = lnet_nidlist[idx];
 
-                       if (cmd == LNETCTL_ADD_CMD)
-                               rc = l_ioctl(LNET_DEV_ID, IOC_LIBCFS_ADD_ROUTE,
-                                            &data);
-                       else
-                               rc = l_ioctl(LNET_DEV_ID, IOC_LIBCFS_DEL_ROUTE,
-                                            &data);
+               if (cmd == LNETCTL_ADD_CMD)
+                       rc = l_ioctl(LNET_DEV_ID, IOC_LIBCFS_ADD_ROUTE,
+                                       &data);
+               else
+                       rc = l_ioctl(LNET_DEV_ID, IOC_LIBCFS_DEL_ROUTE,
+                                       &data);
 
-                       if (rc != 0 && errno != EEXIST &&
-                           errno != EHOSTUNREACH) {
-                               rc = -errno;
-                               snprintf(err_str, LNET_MAX_STR_LEN,
-                                        "route operation failed: %s",
-                                        strerror(errno));
-                               goto out;
-                       }
+               if (rc != 0 && errno != EEXIST &&
+                       errno != EHOSTUNREACH) {
+                       rc = -errno;
+                       snprintf(err_str, LNET_MAX_STR_LEN,
+                                       "route operation failed: %s",
+                                       strerror(errno));
+                       goto out;
+               } else if (errno == EEXIST) {
+                       /*
+                        * continue chugging along if one of the
+                        * routes already exists
+                        */
+                       rc = 0;
                }
        }
 
@@ -1312,7 +862,7 @@ int lustre_lnet_config_route(char *nw, char *nidstr, int hops, int prio,
                             int sen, int seq_no, struct cYAML **err_rc)
 {
        int rc;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"generic error\"";
 
        if (hops == -1) {
                hops = LNET_UNDEFINED_HOPS;
@@ -1346,6 +896,7 @@ int lustre_lnet_config_route(char *nw, char *nidstr, int hops, int prio,
 
        rc = lustre_lnet_route_common(nw, nidstr, hops, prio, sen, seq_no,
                                      err_rc, LNETCTL_ADD_CMD);
+       return rc;
 out:
        cYAML_build_error(rc, seq_no, ADD_CMD, "route", err_str, err_rc);
 
@@ -1367,19 +918,16 @@ int lustre_lnet_show_route(char *nw, char *gw, int hops, int prio, int detail,
        lnet_nid_t gateway_nid;
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        int l_errno = 0;
-       __u32 net = LNET_NIDNET(LNET_NID_ANY);
+       __u32 net = LNET_NET_ANY;
        int i;
        struct cYAML *root = NULL, *route = NULL, *item = NULL;
        struct cYAML *first_seq = NULL;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
        bool exist = false;
 
-       snprintf(err_str, sizeof(err_str),
-                "\"out of memory\"");
-
        if (nw != NULL) {
                net = libcfs_str2net(nw);
-               if (net == LNET_NIDNET(LNET_NID_ANY)) {
+               if (net == LNET_NET_ANY) {
                        snprintf(err_str,
                                 sizeof(err_str),
                                 "\"cannot parse net '%s'\"", nw);
@@ -1389,7 +937,7 @@ int lustre_lnet_show_route(char *nw, char *gw, int hops, int prio, int detail,
 
        } else {
                /* show all routes without filtering on net */
-               net = LNET_NIDNET(LNET_NID_ANY);
+               net = LNET_NET_ANY;
        }
 
        if (gw != NULL) {
@@ -1424,6 +972,9 @@ int lustre_lnet_show_route(char *nw, char *gw, int hops, int prio, int detail,
                goto out;
 
        for (i = 0;; i++) {
+               __u32 rt_alive;
+               __u32 rt_multi_hop;
+
                LIBCFS_IOC_INIT_V2(data, cfg_hdr);
                data.cfg_count = i;
 
@@ -1434,7 +985,7 @@ int lustre_lnet_show_route(char *nw, char *gw, int hops, int prio, int detail,
                }
 
                /* filter on provided data */
-               if (net != LNET_NIDNET(LNET_NID_ANY) &&
+               if (net != LNET_NET_ANY &&
                    net != data.cfg_net)
                        continue;
 
@@ -1486,12 +1037,22 @@ int lustre_lnet_show_route(char *nw, char *gw, int hops, int prio, int detail,
                                                cfg_route.rtr_sensitivity) == NULL)
                                goto out;
 
+                       rt_alive = data.cfg_config_u.cfg_route.rtr_flags &
+                                       LNET_RT_ALIVE;
+                       rt_multi_hop = data.cfg_config_u.cfg_route.rtr_flags &
+                                       LNET_RT_MULTI_HOP;
+
                        if (!backup &&
                            cYAML_create_string(item, "state",
-                                               data.cfg_config_u.cfg_route.
-                                                       rtr_flags ?
+                                               rt_alive ?
                                                "up" : "down") == NULL)
                                goto out;
+
+                       if (!backup &&
+                           cYAML_create_string(item, "type",
+                                               rt_multi_hop?
+                                               "multi-hop" : "single-hop") == NULL)
+                               goto out;
                }
        }
 
@@ -1607,7 +1168,6 @@ static int lustre_lnet_intf2nids(struct lnet_dlc_network_descr *nw,
        if (nw == NULL || nids == NULL) {
                snprintf(err_str, str_len,
                         "\"unexpected parameters to lustre_lnet_intf2nids()\"");
-               err_str[str_len - 1] = '\0';
                return LUSTRE_CFG_RC_BAD_PARAM;
        }
 
@@ -1622,7 +1182,6 @@ static int lustre_lnet_intf2nids(struct lnet_dlc_network_descr *nw,
        if (*nids == NULL) {
                snprintf(err_str, str_len,
                         "\"out of memory\"");
-               err_str[str_len - 1] = '\0';
                return LUSTRE_CFG_RC_OUT_OF_MEM;
        }
        /*
@@ -1636,7 +1195,6 @@ static int lustre_lnet_intf2nids(struct lnet_dlc_network_descr *nw,
                if (rc) {
                        snprintf(err_str, str_len,
                                 "\"cannot read gni nid\"");
-                       err_str[str_len - 1] = '\0';
                        goto failed;
                }
                gni_num = atoi(val);
@@ -1656,7 +1214,6 @@ static int lustre_lnet_intf2nids(struct lnet_dlc_network_descr *nw,
                                snprintf(err_str, str_len,
                                         "\"couldn't query intf %s\"",
                                         intf->intf_name);
-                               err_str[str_len - 1] = '\0';
                                goto failed;
                        }
                        (*nids)[i] = LNET_MKNID(nw->nw_id, num);
@@ -1668,7 +1225,6 @@ static int lustre_lnet_intf2nids(struct lnet_dlc_network_descr *nw,
                                snprintf(err_str, str_len,
                                         "\"couldn't query intf %s\"",
                                         intf->intf_name);
-                               err_str[str_len - 1] = '\0';
                                goto failed;
                        }
                        (*nids)[i] = LNET_MKNID(nw->nw_id, ip);
@@ -1856,7 +1412,6 @@ static int lustre_lnet_resolve_ip2nets_rule(struct lustre_lnet_ip2nets *ip2nets,
        if (rc < 0) {
                snprintf(err_str, str_len,
                         "\"failed to get interface addresses: %d\"", -errno);
-               err_str[str_len - 1] = '\0';
                return -errno;
        }
 
@@ -1866,13 +1421,12 @@ static int lustre_lnet_resolve_ip2nets_rule(struct lustre_lnet_ip2nets *ip2nets,
        if (rc != LUSTRE_CFG_RC_MATCH) {
                snprintf(err_str, str_len,
                         "\"couldn't match ip to existing interfaces\"");
-               err_str[str_len - 1] = '\0';
                freeifaddrs(ifa);
                return rc;
        }
 
        rc = lustre_lnet_intf2nids(&ip2nets->ip2nets_net, nids, nnids,
-                                  err_str, sizeof(err_str));
+                                  err_str, str_len);
        if (rc != LUSTRE_CFG_RC_NO_ERR) {
                *nids = NULL;
                *nnids = 0;
@@ -1973,9 +1527,7 @@ lustre_lnet_config_ip2nets(struct lustre_lnet_ip2nets *ip2nets,
        lnet_nid_t *nids = NULL;
        __u32 nnids = 0;
        int rc;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"success\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
 
        if (!ip2nets) {
                snprintf(err_str,
@@ -2024,7 +1576,7 @@ int lustre_lnet_config_ni(struct lnet_dlc_network_descr *nw_descr,
        struct lnet_ioctl_config_lnd_tunables *tun = NULL;
        char buf[LNET_MAX_STR_LEN];
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        lnet_nid_t *nids = NULL;
        __u32 nnids = 0;
        size_t len;
@@ -2032,8 +1584,6 @@ int lustre_lnet_config_ni(struct lnet_dlc_network_descr *nw_descr,
        struct lnet_dlc_intf_descr *intf_descr, *tmp;
        __u32 *cpt_array;
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        if (ip2net == NULL && (nw_descr == NULL || nw_descr->nw_id == 0 ||
            (list_empty(&nw_descr->nw_intflist) &&
             LNET_NETTYP(nw_descr->nw_id) != GNILND))) {
@@ -2113,7 +1663,7 @@ int lustre_lnet_config_ni(struct lnet_dlc_network_descr *nw_descr,
                goto out;
        }
 
-       if (nw_descr->nw_id == LNET_NIDNET(LNET_NID_ANY)) {
+       if (nw_descr->nw_id == LNET_NET_ANY) {
                snprintf(err_str,
                        sizeof(err_str),
                        "\"cannot parse net '%s'\"",
@@ -2171,13 +1721,11 @@ int lustre_lnet_del_ni(struct lnet_dlc_network_descr *nw_descr,
 {
        struct lnet_ioctl_config_ni data;
        int rc = LUSTRE_CFG_RC_NO_ERR, i;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        lnet_nid_t *nids = NULL;
        __u32 nnids = 0;
        struct lnet_dlc_intf_descr *intf_descr, *tmp;
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        if (nw_descr == NULL || nw_descr->nw_id == 0) {
                snprintf(err_str,
                         sizeof(err_str),
@@ -2191,7 +1739,7 @@ int lustre_lnet_del_ni(struct lnet_dlc_network_descr *nw_descr,
        if (LNET_NETTYP(nw_descr->nw_id) == LOLND)
                return LUSTRE_CFG_RC_NO_ERR;
 
-       if (nw_descr->nw_id == LNET_NIDNET(LNET_NID_ANY)) {
+       if (nw_descr->nw_id == LNET_NET_ANY) {
                snprintf(err_str,
                         sizeof(err_str),
                         "\"cannot parse net '%s'\"",
@@ -2257,9 +1805,7 @@ lustre_lnet_config_healthv(int value, bool all, lnet_nid_t nid,
 {
        struct lnet_ioctl_reset_health_cfg data;
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"success\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
 
        LIBCFS_IOC_INIT_V2(data, rh_hdr);
        data.rh_type = type;
@@ -2357,8 +1903,8 @@ int lustre_lnet_show_net(char *nw, int detail, int seq_no,
        struct lnet_ioctl_element_stats *stats;
        struct lnet_ioctl_element_msg_stats msg_stats;
        struct lnet_ioctl_local_ni_hstats hstats;
-       __u32 net = LNET_NIDNET(LNET_NID_ANY);
-       __u32 prev_net = LNET_NIDNET(LNET_NID_ANY);
+       __u32 net = LNET_NET_ANY;
+       __u32 prev_net = LNET_NET_ANY;
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM, i, j;
        int l_errno = 0;
        struct cYAML *root = NULL, *tunables = NULL,
@@ -2369,13 +1915,11 @@ int lustre_lnet_show_net(char *nw, int detail, int seq_no,
        int str_buf_len = LNET_MAX_SHOW_NUM_CPT * 2;
        char str_buf[str_buf_len];
        char *pos;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
        bool exist = false, new_net = true;
        int net_num = 0;
        size_t buf_size = sizeof(*ni_data) + sizeof(*lnd) + sizeof(*stats);
 
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
-
        buf = calloc(1, buf_size);
        if (buf == NULL)
                goto out;
@@ -2384,7 +1928,7 @@ int lustre_lnet_show_net(char *nw, int detail, int seq_no,
 
        if (nw != NULL) {
                net = libcfs_str2net(nw);
-               if (net == LNET_NIDNET(LNET_NID_ANY)) {
+               if (net == LNET_NET_ANY) {
                        snprintf(err_str,
                                 sizeof(err_str),
                                 "\"cannot parse net '%s'\"", nw);
@@ -2423,7 +1967,7 @@ int lustre_lnet_show_net(char *nw, int detail, int seq_no,
                rc_net = LNET_NIDNET(ni_data->lic_nid);
 
                /* filter on provided data */
-               if (net != LNET_NIDNET(LNET_NID_ANY) &&
+               if (net != LNET_NET_ANY &&
                    net != rc_net)
                        continue;
 
@@ -2700,9 +2244,7 @@ int lustre_lnet_enable_routing(int enable, int seq_no, struct cYAML **err_rc)
 {
        struct lnet_ioctl_config_data data;
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"success\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
 
        LIBCFS_IOC_INIT_V2(data, cfg_hdr);
        data.cfg_config_u.cfg_buffers.buf_enable = (enable) ? 1 : 0;
@@ -2730,9 +2272,7 @@ int ioctl_set_value(__u32 val, int ioc, char *name,
 {
        struct lnet_ioctl_set_value data;
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"success\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
 
        LIBCFS_IOC_INIT_V2(data, sv_hdr);
        data.sv_value = val;
@@ -2754,11 +2294,9 @@ int ioctl_set_value(__u32 val, int ioc, char *name,
 int lustre_lnet_config_recov_intrv(int intrv, int seq_no, struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        char val[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        snprintf(val, sizeof(val), "%d", intrv);
 
        rc = write_sysfs_file(modparam_path, "lnet_recovery_interval", val,
@@ -2776,11 +2314,9 @@ int lustre_lnet_config_recov_intrv(int intrv, int seq_no, struct cYAML **err_rc)
 int lustre_lnet_config_rtr_sensitivity(int sen, int seq_no, struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        char val[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        snprintf(val, sizeof(val), "%d", sen);
 
        rc = write_sysfs_file(modparam_path, "router_sensitivity_percentage", val,
@@ -2798,11 +2334,9 @@ int lustre_lnet_config_rtr_sensitivity(int sen, int seq_no, struct cYAML **err_r
 int lustre_lnet_config_hsensitivity(int sen, int seq_no, struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        char val[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        snprintf(val, sizeof(val), "%d", sen);
 
        rc = write_sysfs_file(modparam_path, "lnet_health_sensitivity", val,
@@ -2820,11 +2354,9 @@ int lustre_lnet_config_hsensitivity(int sen, int seq_no, struct cYAML **err_rc)
 int lustre_lnet_config_transaction_to(int timeout, int seq_no, struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        char val[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        snprintf(val, sizeof(val), "%d", timeout);
 
        rc = write_sysfs_file(modparam_path, "lnet_transaction_timeout", val,
@@ -2842,11 +2374,9 @@ int lustre_lnet_config_transaction_to(int timeout, int seq_no, struct cYAML **er
 int lustre_lnet_config_retry_count(int count, int seq_no, struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        char val[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        snprintf(val, sizeof(val), "%d", count);
 
        rc = write_sysfs_file(modparam_path, "lnet_retry_count", val,
@@ -2861,13 +2391,71 @@ int lustre_lnet_config_retry_count(int count, int seq_no, struct cYAML **err_rc)
        return rc;
 }
 
-int lustre_lnet_config_max_intf(int max, int seq_no, struct cYAML **err_rc)
+int lustre_lnet_config_response_tracking(int val, int seq_no,
+                                        struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
        char err_str[LNET_MAX_STR_LEN];
-       char val[LNET_MAX_STR_LEN];
+       char val_str[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
+       if (val < 0 || val > 3) {
+               rc = LUSTRE_CFG_RC_BAD_PARAM;
+               snprintf(err_str, sizeof(err_str),
+                        "\"Valid values are: 0, 1, 2, or 3\"");
+       } else {
+               snprintf(err_str, sizeof(err_str), "\"success\"");
+
+               snprintf(val_str, sizeof(val_str), "%d", val);
+
+               rc = write_sysfs_file(modparam_path, "lnet_response_tracking",
+                                     val_str, 1, strlen(val_str) + 1);
+               if (rc)
+                       snprintf(err_str, sizeof(err_str),
+                                "\"cannot configure response tracking: %s\"",
+                                strerror(errno));
+       }
+
+       cYAML_build_error(rc, seq_no, ADD_CMD, "response_tracking", err_str,
+                         err_rc);
+
+       return rc;
+}
+
+int lustre_lnet_config_recovery_limit(int val, int seq_no,
+                                     struct cYAML **err_rc)
+{
+       int rc = LUSTRE_CFG_RC_NO_ERR;
+       char err_str[LNET_MAX_STR_LEN];
+       char val_str[LNET_MAX_STR_LEN];
+
+       if (val < 0) {
+               rc = LUSTRE_CFG_RC_BAD_PARAM;
+               snprintf(err_str, sizeof(err_str),
+                        "\"Must be greater than or equal to 0\"");
+       } else {
+               snprintf(err_str, sizeof(err_str), "\"success\"");
+
+               snprintf(val_str, sizeof(val_str), "%d", val);
+
+               rc = write_sysfs_file(modparam_path, "lnet_recovery_limit",
+                                     val_str, 1, strlen(val_str) + 1);
+               if (rc)
+                       snprintf(err_str, sizeof(err_str),
+                                "\"cannot configure recovery limit: %s\"",
+                                strerror(errno));
+       }
+
+       cYAML_build_error(rc, seq_no, ADD_CMD, "recovery_limit", err_str,
+                         err_rc);
+
+       return rc;
+}
+
+int lustre_lnet_config_max_intf(int max, int seq_no, struct cYAML **err_rc)
+{
+       int rc = LUSTRE_CFG_RC_NO_ERR;
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
+       char val[LNET_MAX_STR_LEN];
 
        snprintf(val, sizeof(val), "%d", max);
 
@@ -2886,11 +2474,9 @@ int lustre_lnet_config_max_intf(int max, int seq_no, struct cYAML **err_rc)
 int lustre_lnet_config_discovery(int enable, int seq_no, struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        char val[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        snprintf(val, sizeof(val), "%u", (enable) ? 0 : 1);
 
        rc = write_sysfs_file(modparam_path, "lnet_peer_discovery_disabled", val,
@@ -2910,11 +2496,9 @@ int lustre_lnet_config_drop_asym_route(int drop, int seq_no,
                                       struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
        char val[LNET_MAX_STR_LEN];
 
-       snprintf(err_str, sizeof(err_str), "\"success\"");
-
        snprintf(val, sizeof(val), "%u", (drop) ? 1 : 0);
 
        rc = write_sysfs_file(modparam_path, "lnet_drop_asym_route", val,
@@ -2942,9 +2526,7 @@ int lustre_lnet_config_buffers(int tiny, int small, int large, int seq_no,
 {
        struct lnet_ioctl_config_data data;
        int rc = LUSTRE_CFG_RC_NO_ERR;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"success\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"success\"";
 
        /* -1 indicates to ignore changes to this field */
        if (tiny < -1 || small < -1 || large < -1) {
@@ -2989,12 +2571,10 @@ int lustre_lnet_show_routing(int seq_no, struct cYAML **show_rc,
                     *type_node = NULL, *item = NULL, *cpt = NULL,
                     *first_seq = NULL, *buffers = NULL;
        int i, j;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
        char node_name[LNET_MAX_STR_LEN];
        bool exist = false;
 
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
-
        buf = calloc(1, sizeof(*data) + sizeof(*pool_cfg));
        if (buf == NULL)
                goto out;
@@ -3174,15 +2754,12 @@ int lustre_lnet_show_peer(char *knid, int detail, int seq_no,
                     *first_seq = NULL, *peer_root = NULL, *tmp = NULL,
                     *msg_statistics = NULL, *statistics = NULL,
                     *yhstats;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
        struct lnet_process_id *list = NULL;
        void *data = NULL;
        void *lpni_data;
        bool exist = false;
 
-       snprintf(err_str, sizeof(err_str),
-                "\"out of memory\"");
-
        /* create struct cYAML root object */
        root = cYAML_create_object(NULL, NULL);
        if (root == NULL)
@@ -3485,12 +3062,9 @@ int lustre_lnet_list_peer(int seq_no,
        int i = 0;
        int l_errno = 0;
        struct cYAML *root = NULL, *list_root = NULL, *first_seq = NULL;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
        struct lnet_process_id *list = NULL;
 
-       snprintf(err_str, sizeof(err_str),
-                "\"out of memory\"");
-
        memset(&peer_info, 0, sizeof(peer_info));
 
        /* create struct cYAML root object */
@@ -3602,7 +3176,7 @@ static void add_to_global(struct cYAML *show_rc, struct cYAML *node,
 }
 
 static int build_global_yaml_entry(char *err_str, int err_len, int seq_no,
-                                  char *name, __u32 value,
+                                  char *name, __u64 value,
                                   struct cYAML **show_rc,
                                   struct cYAML **err_rc, int err)
 {
@@ -3654,9 +3228,7 @@ static int ioctl_show_global_values(int ioc, int seq_no, char *name,
        struct lnet_ioctl_set_value data;
        int rc;
        int l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
 
        LIBCFS_IOC_INIT_V2(data, sv_hdr);
 
@@ -3679,9 +3251,7 @@ int lustre_lnet_show_recov_intrv(int seq_no, struct cYAML **show_rc,
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
        int intrv = -1, l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
 
        rc = read_sysfs_file(modparam_path, "lnet_recovery_interval", val,
                             1, sizeof(val));
@@ -3704,9 +3274,7 @@ int lustre_lnet_show_hsensitivity(int seq_no, struct cYAML **show_rc,
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
        int sen = -1, l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
 
        rc = read_sysfs_file(modparam_path, "lnet_health_sensitivity", val,
                             1, sizeof(val));
@@ -3729,9 +3297,7 @@ int lustre_lnet_show_rtr_sensitivity(int seq_no, struct cYAML **show_rc,
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
        int sen = -1, l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
 
        rc = read_sysfs_file(modparam_path, "router_sensitivity_percentage", val,
                             1, sizeof(val));
@@ -3748,15 +3314,64 @@ int lustre_lnet_show_rtr_sensitivity(int seq_no, struct cYAML **show_rc,
                                       err_rc, l_errno);
 }
 
+int lustre_lnet_show_lnd_timeout(int seq_no, struct cYAML **show_rc,
+                                struct cYAML **err_rc)
+{
+       char val[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
+       int lnd_to = -1;
+       int l_errno = 0;
+       int rc;
+       int fd;
+       glob_t path;
+
+       rc = cfs_get_param_paths(&path, "lnet_lnd_timeout");
+       if (rc < 0) {
+               l_errno = -errno;
+               snprintf(err_str, sizeof(err_str),
+                        "\"cannot get LND timeout: %d\"", rc);
+               return build_global_yaml_entry(err_str, sizeof(err_str), seq_no,
+                                              "lnd_timeout", lnd_to, show_rc,
+                                              err_rc, l_errno);
+       }
+
+       fd = open(path.gl_pathv[0], O_RDONLY);
+       if (fd < 0) {
+               l_errno = -errno;
+               snprintf(err_str, sizeof(err_str),
+                        "\"error opening %s\"", path.gl_pathv[0]);
+               goto failed;
+       }
+
+       rc = read(fd, val, sizeof(val));
+       if (rc < 0)
+               l_errno = -errno;
+
+       close(fd);
+
+       if (rc < 0) {
+               snprintf(err_str, sizeof(err_str),
+                        "\"error reading %s\"", path.gl_pathv[0]);
+               goto failed;
+       }
+
+       lnd_to = atoi(val);
+
+failed:
+       cfs_free_param_data(&path);
+
+       return build_global_yaml_entry(err_str, sizeof(err_str), seq_no,
+                                      "lnd_timeout", lnd_to, show_rc,
+                                      err_rc, l_errno);
+}
+
 int lustre_lnet_show_transaction_to(int seq_no, struct cYAML **show_rc,
                                    struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
        int tto = -1, l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
 
        rc = read_sysfs_file(modparam_path, "lnet_transaction_timeout", val,
                             1, sizeof(val));
@@ -3779,9 +3394,7 @@ int lustre_lnet_show_retry_count(int seq_no, struct cYAML **show_rc,
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
        int retry_count = -1, l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
 
        rc = read_sysfs_file(modparam_path, "lnet_retry_count", val,
                             1, sizeof(val));
@@ -3798,15 +3411,35 @@ int lustre_lnet_show_retry_count(int seq_no, struct cYAML **show_rc,
                                       err_rc, l_errno);
 }
 
+int lustre_lnet_calc_service_id(__u64 *service_id)
+{
+       int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
+       char val[LNET_MAX_STR_LEN];
+       int service_port = -1, l_errno = 0;
+
+       rc = read_sysfs_file(o2ib_modparam_path, "service", val,
+                            1, sizeof(val));
+       if (rc) {
+               l_errno = errno;
+               fprintf(stderr, "error:\n    msg: \"cannot get service port: %s (%d)\"\n",
+                       strerror(l_errno), -l_errno);
+               return rc;
+       } else {
+               service_port = atoi(val);
+       }
+
+       *service_id = htobe64(((__u64)RDMA_PS_TCP << 16) + service_port);
+
+       return LUSTRE_CFG_RC_NO_ERR;
+}
+
 int show_recovery_queue(enum lnet_health_type type, char *name, int seq_no,
                        struct cYAML **show_rc, struct cYAML **err_rc)
 {
        struct lnet_ioctl_recovery_list nid_list;
        struct cYAML *root = NULL, *nids = NULL;
        int rc, i;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "failed to print recovery queue\n");
+       char err_str[LNET_MAX_STR_LEN] = "failed to print recovery queue\n";
 
        LIBCFS_IOC_INIT_V2(nid_list, rlst_hdr);
        nid_list.rlst_type = type;
@@ -3885,16 +3518,62 @@ int lustre_lnet_show_peer_ni_recovq(int seq_no, struct cYAML **show_rc,
                                   seq_no, show_rc, err_rc);
 }
 
-int lustre_lnet_show_max_intf(int seq_no, struct cYAML **show_rc,
-                             struct cYAML **err_rc)
+int lustre_lnet_show_response_tracking(int seq_no, struct cYAML **show_rc,
+                                      struct cYAML **err_rc)
 {
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
-       int max_intf = -1, l_errno = 0;
+       int rsp_tracking = -1, l_errno = 0;
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
+
+       rc = read_sysfs_file(modparam_path, "lnet_response_tracking", val,
+                            1, sizeof(val));
+       if (rc) {
+               l_errno = -errno;
+               snprintf(err_str, sizeof(err_str),
+                        "\"cannot get lnet_response_tracking value: %d\"", rc);
+       } else {
+               rsp_tracking = atoi(val);
+       }
+
+       return build_global_yaml_entry(err_str, sizeof(err_str), seq_no,
+                                      "response_tracking", rsp_tracking,
+                                      show_rc, err_rc, l_errno);
+}
+
+int lustre_lnet_show_recovery_limit(int seq_no, struct cYAML **show_rc,
+                                   struct cYAML **err_rc)
+{
+       int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
+       char val[LNET_MAX_STR_LEN];
+       int recov_limit = -1, l_errno = 0;
        char err_str[LNET_MAX_STR_LEN];
 
        snprintf(err_str, sizeof(err_str), "\"out of memory\"");
 
+       rc = read_sysfs_file(modparam_path, "lnet_recovery_limit", val,
+                            1, sizeof(val));
+       if (rc) {
+               l_errno = -errno;
+               snprintf(err_str, sizeof(err_str),
+                        "\"cannot get lnet_recovery_limit value: %d\"", rc);
+       } else {
+               recov_limit = atoi(val);
+       }
+
+       return build_global_yaml_entry(err_str, sizeof(err_str), seq_no,
+                                      "recovery_limit", recov_limit,
+                                      show_rc, err_rc, l_errno);
+}
+
+int lustre_lnet_show_max_intf(int seq_no, struct cYAML **show_rc,
+                             struct cYAML **err_rc)
+{
+       int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
+       char val[LNET_MAX_STR_LEN];
+       int max_intf = -1, l_errno = 0;
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
+
        rc = read_sysfs_file(modparam_path, "lnet_interfaces_max", val,
                             1, sizeof(val));
        if (rc) {
@@ -3916,9 +3595,7 @@ int lustre_lnet_show_discovery(int seq_no, struct cYAML **show_rc,
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
        int discovery = -1, l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN]  = "\"out of memory\"";
 
        rc = read_sysfs_file(modparam_path, "lnet_peer_discovery_disabled", val,
                             1, sizeof(val));
@@ -3946,9 +3623,7 @@ int lustre_lnet_show_drop_asym_route(int seq_no, struct cYAML **show_rc,
        int rc = LUSTRE_CFG_RC_OUT_OF_MEM;
        char val[LNET_MAX_STR_LEN];
        int drop_asym_route = -1, l_errno = 0;
-       char err_str[LNET_MAX_STR_LEN];
-
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
 
        rc = read_sysfs_file(modparam_path, "lnet_drop_asym_route", val,
                             1, sizeof(val));
@@ -3979,11 +3654,9 @@ int lustre_lnet_show_stats(int seq_no, struct cYAML **show_rc,
        struct lnet_counters *cntrs;
        int rc;
        int l_errno;
-       char err_str[LNET_MAX_STR_LEN];
+       char err_str[LNET_MAX_STR_LEN] = "\"out of memory\"";
        struct cYAML *root = NULL, *stats = NULL;
 
-       snprintf(err_str, sizeof(err_str), "\"out of memory\"");
-
        LIBCFS_IOC_INIT_V2(data, st_hdr);
 
        rc = l_ioctl(LNET_DEV_ID, IOC_LIBCFS_GET_LNET_STATS, &data);
@@ -4593,23 +4266,33 @@ static int handle_yaml_peer_common(struct cYAML *tree, struct cYAML **show_rc,
                                   struct cYAML **err_rc, int cmd)
 {
        int rc, num_nids = 0, seqn;
-       bool mr_value;
+       bool mr_value = false;
        char *nidstr = NULL, *prim_nidstr;
        char err_str[LNET_MAX_STR_LEN];
        struct cYAML *seq_no, *prim_nid, *mr, *peer_nis;
        lnet_nid_t lnet_nidlist[LNET_MAX_NIDS_PER_PEER];
+       lnet_nid_t pnid = LNET_NID_ANY;
 
        seq_no = cYAML_get_object_item(tree, "seq_no");
        seqn = seq_no ? seq_no->cy_valueint : -1;
 
        prim_nid = cYAML_get_object_item(tree, "primary nid");
-       prim_nidstr = prim_nid ? prim_nid->cy_valuestring : NULL;
-
        peer_nis = cYAML_get_object_item(tree, "peer ni");
-       if (!(prim_nid || peer_nis)) {
+       if (!prim_nid) {
                rc = LUSTRE_CFG_RC_BAD_PARAM;
                snprintf(err_str, LNET_MAX_STR_LEN,
-                        "Neither \"primary nid\" nor \"peer ni\" are defined");
+                        "\"primary nid\" must be specified");
+               goto failed;
+       }
+
+       prim_nidstr = prim_nid->cy_valuestring;
+
+       /* if the provided primary NID is bad, no need to go any further */
+       pnid = libcfs_str2nid(prim_nidstr);
+       if (pnid == LNET_NID_ANY) {
+               rc = LUSTRE_CFG_RC_BAD_PARAM;
+               snprintf(err_str, LNET_MAX_STR_LEN,
+                       "badly formatted primary NID: %s", prim_nidstr);
                goto failed;
        }
 
@@ -4652,13 +4335,11 @@ static int handle_yaml_peer_common(struct cYAML *tree, struct cYAML **show_rc,
                                goto failed;
                        }
                }
+       }
 
-               rc = lustre_lnet_config_peer_nidlist(prim_nidstr, lnet_nidlist,
-                                                    num_nids, mr_value, seqn,
-                                                    err_rc);
-       } else
-               rc = lustre_lnet_del_peer_nidlist(prim_nidstr, lnet_nidlist,
-                                                 num_nids, seqn, err_rc);
+       rc = lustre_lnet_mod_peer_nidlist(pnid, lnet_nidlist, cmd,
+                                         num_nids, mr_value, seqn,
+                                         err_rc);
 
 failed:
        if (nidstr)
@@ -4872,7 +4553,8 @@ static int handle_yaml_config_global_settings(struct cYAML *tree,
                                              struct cYAML **err_rc)
 {
        struct cYAML *max_intf, *numa, *discovery, *retry, *tto, *seq_no,
-                    *sen, *recov, *rsen, *drop_asym_route;
+                    *sen, *recov, *rsen, *drop_asym_route, *rsp_tracking,
+                    *recov_limit;
        int rc = 0;
 
        seq_no = cYAML_get_object_item(tree, "seq_no");
@@ -4939,6 +4621,20 @@ static int handle_yaml_config_global_settings(struct cYAML *tree,
                                                        : -1,
                                                     err_rc);
 
+       rsp_tracking = cYAML_get_object_item(tree, "response_tracking");
+       if (rsp_tracking)
+               rc = lustre_lnet_config_response_tracking(rsp_tracking->cy_valueint,
+                                                    seq_no ? seq_no->cy_valueint
+                                                       : -1,
+                                                    err_rc);
+
+       recov_limit = cYAML_get_object_item(tree, "recovery_limit");
+       if (recov_limit)
+               rc = lustre_lnet_config_recovery_limit(recov_limit->cy_valueint,
+                                                      seq_no ? seq_no->cy_valueint
+                                                       : -1,
+                                                      err_rc);
+
        return rc;
 }
 
@@ -4986,7 +4682,8 @@ static int handle_yaml_show_global_settings(struct cYAML *tree,
                                            struct cYAML **err_rc)
 {
        struct cYAML *max_intf, *numa, *discovery, *retry, *tto, *seq_no,
-                    *sen, *recov, *rsen, *drop_asym_route;
+                    *sen, *recov, *rsen, *drop_asym_route, *rsp_tracking,
+                    *recov_limit;
        int rc = 0;
 
        seq_no = cYAML_get_object_item(tree, "seq_no");
@@ -5044,6 +4741,20 @@ static int handle_yaml_show_global_settings(struct cYAML *tree,
                                                        : -1,
                                                     show_rc, err_rc);
 
+       rsp_tracking = cYAML_get_object_item(tree, "response_tracking");
+       if (rsp_tracking)
+               rc = lustre_lnet_show_response_tracking(seq_no ?
+                                                       seq_no->cy_valueint :
+                                                       -1,
+                                                       show_rc, err_rc);
+
+       recov_limit = cYAML_get_object_item(tree, "recovery_limit");
+       if (recov_limit)
+               rc = lustre_lnet_show_recovery_limit(seq_no ?
+                                                    seq_no->cy_valueint :
+                                                    -1,
+                                                    show_rc, err_rc);
+
        return rc;
 }