Whamcloud - gitweb
LU-1154 clio: rename coo_attr_set to coo_attr_update
[fs/lustre-release.git] / lnet / selftest / rpc.c
index 301a31a..2845bf6 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, Intel Corporation.
+ * Copyright (c) 2012, 2014, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -54,7 +54,7 @@ typedef enum {
         SRPC_STATE_STOPPING,
 } srpc_state_t;
 
-struct smoketest_rpc {
+static struct smoketest_rpc {
        spinlock_t       rpc_glock;     /* global lock */
        srpc_service_t  *rpc_services[SRPC_SERVICE_MAX_ID + 1];
        lnet_handle_eq_t rpc_lnet_eq;   /* _the_ LNet event queue */
@@ -87,7 +87,7 @@ void srpc_set_counters (const srpc_counters_t *cnt)
        spin_unlock(&srpc_data.rpc_glock);
 }
 
-int
+static int
 srpc_add_bulk_page(srpc_bulk_t *bk, struct page *pg, int i, int nob)
 {
        nob = min(nob, (int)PAGE_CACHE_SIZE);
@@ -142,7 +142,6 @@ srpc_bulk_t *
 srpc_alloc_bulk(int cpt, unsigned bulk_npg, unsigned bulk_len, int sink)
 {
        srpc_bulk_t  *bk;
-       struct page  **pages;
        int           i;
 
        LASSERT(bulk_npg > 0 && bulk_npg <= LNET_MAX_IOV);
@@ -159,18 +158,22 @@ srpc_alloc_bulk(int cpt, unsigned bulk_npg, unsigned bulk_len, int sink)
        bk->bk_len    = bulk_len;
        bk->bk_niov   = bulk_npg;
 #ifndef __KERNEL__
-       LIBCFS_CPT_ALLOC(pages, lnet_cpt_table(), cpt,
-                        sizeof(struct page *) * bulk_npg);
-       if (pages == NULL) {
-               LIBCFS_FREE(bk, offsetof(srpc_bulk_t, bk_iovs[bulk_npg]));
-               CERROR("Can't allocate page array for %d pages\n", bulk_npg);
-               return NULL;
-       }
+       {
+               struct page  **pages;
+
+               LIBCFS_CPT_ALLOC(pages, lnet_cpt_table(), cpt,
+                                sizeof(struct page *) * bulk_npg);
+               if (pages == NULL) {
+                       LIBCFS_FREE(bk, offsetof(srpc_bulk_t,
+                                   bk_iovs[bulk_npg]));
+                       CERROR("Can't allocate page array for %d pages\n",
+                               bulk_npg);
+                       return NULL;
+               }
 
-       memset(pages, 0, sizeof(struct page *) * bulk_npg);
-       bk->bk_pages = pages;
-#else
-       UNUSED(pages);
+               memset(pages, 0, sizeof(struct page *) * bulk_npg);
+               bk->bk_pages = pages;
+       }
 #endif
 
        for (i = 0; i < bulk_npg; i++) {
@@ -202,7 +205,7 @@ srpc_next_id (void)
        return id;
 }
 
-void
+static void
 srpc_init_server_rpc(struct srpc_server_rpc *rpc,
                     struct srpc_service_cd *scd,
                     struct srpc_buffer *buffer)
@@ -227,7 +230,7 @@ srpc_service_fini(struct srpc_service *svc)
        struct srpc_service_cd  *scd;
        struct srpc_server_rpc  *rpc;
        struct srpc_buffer      *buf;
-       cfs_list_t              *q;
+       struct list_head                *q;
        int                     i;
 
        if (svc->sv_cpt_data == NULL)
@@ -235,29 +238,29 @@ srpc_service_fini(struct srpc_service *svc)
 
        cfs_percpt_for_each(scd, i, svc->sv_cpt_data) {
                while (1) {
-                       if (!cfs_list_empty(&scd->scd_buf_posted))
+                       if (!list_empty(&scd->scd_buf_posted))
                                q = &scd->scd_buf_posted;
-                       else if (!cfs_list_empty(&scd->scd_buf_blocked))
+                       else if (!list_empty(&scd->scd_buf_blocked))
                                q = &scd->scd_buf_blocked;
                        else
                                break;
 
-                       while (!cfs_list_empty(q)) {
-                               buf = cfs_list_entry(q->next,
+                       while (!list_empty(q)) {
+                               buf = list_entry(q->next,
                                                     struct srpc_buffer,
                                                     buf_list);
-                               cfs_list_del(&buf->buf_list);
+                               list_del(&buf->buf_list);
                                LIBCFS_FREE(buf, sizeof(*buf));
                        }
                }
 
-               LASSERT(cfs_list_empty(&scd->scd_rpc_active));
+               LASSERT(list_empty(&scd->scd_rpc_active));
 
-               while (!cfs_list_empty(&scd->scd_rpc_free)) {
-                       rpc = cfs_list_entry(scd->scd_rpc_free.next,
+               while (!list_empty(&scd->scd_rpc_free)) {
+                       rpc = list_entry(scd->scd_rpc_free.next,
                                             struct srpc_server_rpc,
                                             srpc_list);
-                       cfs_list_del(&rpc->srpc_list);
+                       list_del(&rpc->srpc_list);
                        LIBCFS_FREE(rpc, sizeof(*rpc));
                }
        }
@@ -301,10 +304,10 @@ srpc_service_init(struct srpc_service *svc)
                scd->scd_cpt = i;
                scd->scd_svc = svc;
                spin_lock_init(&scd->scd_lock);
-               CFS_INIT_LIST_HEAD(&scd->scd_rpc_free);
-               CFS_INIT_LIST_HEAD(&scd->scd_rpc_active);
-               CFS_INIT_LIST_HEAD(&scd->scd_buf_posted);
-               CFS_INIT_LIST_HEAD(&scd->scd_buf_blocked);
+               INIT_LIST_HEAD(&scd->scd_rpc_free);
+               INIT_LIST_HEAD(&scd->scd_rpc_active);
+               INIT_LIST_HEAD(&scd->scd_buf_posted);
+               INIT_LIST_HEAD(&scd->scd_buf_blocked);
 
                scd->scd_ev.ev_data = scd;
                scd->scd_ev.ev_type = SRPC_REQUEST_RCVD;
@@ -329,7 +332,7 @@ srpc_service_init(struct srpc_service *svc)
                                srpc_service_fini(svc);
                                return -ENOMEM;
                        }
-                       cfs_list_add(&rpc->srpc_list, &scd->scd_rpc_free);
+                       list_add(&rpc->srpc_list, &scd->scd_rpc_free);
                }
        }
 
@@ -383,7 +386,7 @@ srpc_remove_service (srpc_service_t *sv)
        return 0;
 }
 
-int
+static int
 srpc_post_passive_rdma(int portal, int local, __u64 matchbits, void *buf,
                       int len, int options, lnet_process_id_t peer,
                       lnet_handle_md_t *mdh, srpc_event_t *ev)
@@ -423,7 +426,7 @@ srpc_post_passive_rdma(int portal, int local, __u64 matchbits, void *buf,
         return 0;
 }
 
-int
+static int
 srpc_post_active_rdma(int portal, __u64 matchbits, void *buf, int len,
                       int options, lnet_process_id_t peer, lnet_nid_t self,
                       lnet_handle_md_t *mdh, srpc_event_t *ev)
@@ -475,7 +478,7 @@ srpc_post_active_rdma(int portal, __u64 matchbits, void *buf, int len,
         return 0;
 }
 
-int
+static int
 srpc_post_active_rqtbuf(lnet_process_id_t peer, int service, void *buf,
                        int len, lnet_handle_md_t *mdh, srpc_event_t *ev)
 {
@@ -484,7 +487,7 @@ srpc_post_active_rqtbuf(lnet_process_id_t peer, int service, void *buf,
                                     LNET_NID_ANY, mdh, ev);
 }
 
-int
+static int
 srpc_post_passive_rqtbuf(int service, int local, void *buf, int len,
                         lnet_handle_md_t *mdh, srpc_event_t *ev)
 {
@@ -498,15 +501,16 @@ srpc_post_passive_rqtbuf(int service, int local, void *buf, int len,
                                      LNET_MD_OP_PUT, any, mdh, ev);
 }
 
-int
+static int
 srpc_service_post_buffer(struct srpc_service_cd *scd, struct srpc_buffer *buf)
+__must_hold(&scd->scd_lock)
 {
        struct srpc_service     *sv = scd->scd_svc;
        struct srpc_msg         *msg = &buf->buf_msg;
        int                     rc;
 
        LNetInvalidateHandle(&buf->buf_mdh);
-       cfs_list_add(&buf->buf_list, &scd->scd_buf_posted);
+       list_add(&buf->buf_list, &scd->scd_buf_posted);
        scd->scd_buf_nposted++;
        spin_unlock(&scd->scd_lock);
 
@@ -537,7 +541,7 @@ srpc_service_post_buffer(struct srpc_service_cd *scd, struct srpc_buffer *buf)
        if (sv->sv_shuttingdown)
                return rc; /* don't allow to change scd_buf_posted */
 
-       cfs_list_del(&buf->buf_list);
+       list_del(&buf->buf_list);
        spin_unlock(&scd->scd_lock);
 
        LIBCFS_FREE(buf, sizeof(*buf));
@@ -697,18 +701,18 @@ srpc_finish_service(struct srpc_service *sv)
                }
 
                if (scd->scd_buf_nposted > 0) {
-                       CDEBUG(D_NET, "waiting for %d posted buffers to unlink",
-                              scd->scd_buf_nposted);
+                       CDEBUG(D_NET, "waiting for %d posted buffers to "
+                              "unlink\n", scd->scd_buf_nposted);
                        spin_unlock(&scd->scd_lock);
                        return 0;
                }
 
-               if (cfs_list_empty(&scd->scd_rpc_active)) {
+               if (list_empty(&scd->scd_rpc_active)) {
                        spin_unlock(&scd->scd_lock);
                        continue;
                }
 
-               rpc = cfs_list_entry(scd->scd_rpc_active.next,
+               rpc = list_entry(scd->scd_rpc_active.next,
                                     struct srpc_server_rpc, srpc_list);
                CNETERR("Active RPC %p on shutdown: sv %s, peer %s, "
                        "wi %s scheduled %d running %d, "
@@ -729,8 +733,9 @@ srpc_finish_service(struct srpc_service *sv)
 }
 
 /* called with sv->sv_lock held */
-void
+static void
 srpc_service_recycle_buffer(struct srpc_service_cd *scd, srpc_buffer_t *buf)
+__must_hold(&scd->scd_lock)
 {
        if (!scd->scd_svc->sv_shuttingdown && scd->scd_buf_adjust >= 0) {
                if (srpc_service_post_buffer(scd, buf) != 0) {
@@ -775,7 +780,7 @@ srpc_abort_service(struct srpc_service *sv)
                /* schedule in-flight RPCs to notice the abort, NB:
                 * racing with incoming RPCs; complete fix should make test
                 * RPCs carry session ID in its headers */
-               cfs_list_for_each_entry(rpc, &scd->scd_rpc_active, srpc_list) {
+               list_for_each_entry(rpc, &scd->scd_rpc_active, srpc_list) {
                        rpc->srpc_aborted = 1;
                        swi_schedule_workitem(&rpc->srpc_wi);
                }
@@ -807,19 +812,19 @@ srpc_shutdown_service(srpc_service_t *sv)
                spin_lock(&scd->scd_lock);
 
                /* schedule in-flight RPCs to notice the shutdown */
-               cfs_list_for_each_entry(rpc, &scd->scd_rpc_active, srpc_list)
+               list_for_each_entry(rpc, &scd->scd_rpc_active, srpc_list)
                        swi_schedule_workitem(&rpc->srpc_wi);
 
                spin_unlock(&scd->scd_lock);
 
                /* OK to traverse scd_buf_posted without lock, since no one
                 * touches scd_buf_posted now */
-               cfs_list_for_each_entry(buf, &scd->scd_buf_posted, buf_list)
+               list_for_each_entry(buf, &scd->scd_buf_posted, buf_list)
                        LNetMDUnlink(buf->buf_mdh);
        }
 }
 
-int
+static int
 srpc_send_request (srpc_client_rpc_t *rpc)
 {
         srpc_event_t *ev = &rpc->crpc_reqstev;
@@ -839,7 +844,7 @@ srpc_send_request (srpc_client_rpc_t *rpc)
         return rc;
 }
 
-int
+static int
 srpc_prepare_reply (srpc_client_rpc_t *rpc)
 {
         srpc_event_t *ev = &rpc->crpc_replyev;
@@ -863,7 +868,7 @@ srpc_prepare_reply (srpc_client_rpc_t *rpc)
         return rc;
 }
 
-int
+static int
 srpc_prepare_bulk (srpc_client_rpc_t *rpc)
 {
         srpc_bulk_t  *bk = &rpc->crpc_bulk;
@@ -899,7 +904,7 @@ srpc_prepare_bulk (srpc_client_rpc_t *rpc)
         return rc;
 }
 
-int
+static int
 srpc_do_bulk (srpc_server_rpc_t *rpc)
 {
         srpc_event_t  *ev = &rpc->srpc_ev;
@@ -931,7 +936,7 @@ srpc_do_bulk (srpc_server_rpc_t *rpc)
 }
 
 /* only called from srpc_handle_rpc */
-void
+static void
 srpc_server_rpc_done(srpc_server_rpc_t *rpc, int status)
 {
        struct srpc_service_cd  *scd = rpc->srpc_scd;
@@ -966,7 +971,7 @@ srpc_server_rpc_done(srpc_server_rpc_t *rpc, int status)
                rpc->srpc_reqstbuf = NULL;
        }
 
-       cfs_list_del(&rpc->srpc_list); /* from scd->scd_rpc_active */
+       list_del(&rpc->srpc_list); /* from scd->scd_rpc_active */
 
        /*
         * No one can schedule me now since:
@@ -977,16 +982,16 @@ srpc_server_rpc_done(srpc_server_rpc_t *rpc, int status)
        LASSERT(rpc->srpc_ev.ev_fired);
        swi_exit_workitem(&rpc->srpc_wi);
 
-       if (!sv->sv_shuttingdown && !cfs_list_empty(&scd->scd_buf_blocked)) {
-               buffer = cfs_list_entry(scd->scd_buf_blocked.next,
+       if (!sv->sv_shuttingdown && !list_empty(&scd->scd_buf_blocked)) {
+               buffer = list_entry(scd->scd_buf_blocked.next,
                                        srpc_buffer_t, buf_list);
-               cfs_list_del(&buffer->buf_list);
+               list_del(&buffer->buf_list);
 
                srpc_init_server_rpc(rpc, scd, buffer);
-               cfs_list_add_tail(&rpc->srpc_list, &scd->scd_rpc_active);
+               list_add_tail(&rpc->srpc_list, &scd->scd_rpc_active);
                swi_schedule_workitem(&rpc->srpc_wi);
        } else {
-               cfs_list_add(&rpc->srpc_list, &scd->scd_rpc_free);
+               list_add(&rpc->srpc_list, &scd->scd_rpc_free);
        }
 
        spin_unlock(&scd->scd_lock);
@@ -1106,7 +1111,7 @@ srpc_handle_rpc(swi_workitem_t *wi)
         return 0;
 }
 
-void
+static void
 srpc_client_rpc_expired (void *data)
 {
         srpc_client_rpc_t *rpc = data;
@@ -1127,20 +1132,21 @@ srpc_client_rpc_expired (void *data)
        spin_unlock(&srpc_data.rpc_glock);
 }
 
-inline void
-srpc_add_client_rpc_timer (srpc_client_rpc_t *rpc)
+static void
+srpc_add_client_rpc_timer(srpc_client_rpc_t *rpc)
 {
-        stt_timer_t *timer = &rpc->crpc_timer;
+       stt_timer_t *timer = &rpc->crpc_timer;
 
-        if (rpc->crpc_timeout == 0) return;
+       if (rpc->crpc_timeout == 0)
+               return;
 
-        CFS_INIT_LIST_HEAD(&timer->stt_list);
-        timer->stt_data    = rpc;
-        timer->stt_func    = srpc_client_rpc_expired;
-        timer->stt_expires = cfs_time_add(rpc->crpc_timeout,
-                                          cfs_time_current_sec());
-        stt_add_timer(timer);
-        return;
+       INIT_LIST_HEAD(&timer->stt_list);
+       timer->stt_data    = rpc;
+       timer->stt_func    = srpc_client_rpc_expired;
+       timer->stt_expires = cfs_time_add(rpc->crpc_timeout,
+                                         cfs_time_current_sec());
+       stt_add_timer(timer);
+       return;
 }
 
 /*
@@ -1148,7 +1154,7 @@ srpc_add_client_rpc_timer (srpc_client_rpc_t *rpc)
  *
  * Upon exit the RPC expiry timer is not queued and the handler is not
  * running on any CPU. */
-void
+static void
 srpc_del_client_rpc_timer (srpc_client_rpc_t *rpc)
 {
        /* timer not planted or already exploded */
@@ -1164,7 +1170,7 @@ srpc_del_client_rpc_timer (srpc_client_rpc_t *rpc)
        while (rpc->crpc_timeout != 0) {
                spin_unlock(&rpc->crpc_lock);
 
-               cfs_schedule();
+               schedule();
 
                spin_lock(&rpc->crpc_lock);
        }
@@ -1173,7 +1179,7 @@ srpc_del_client_rpc_timer (srpc_client_rpc_t *rpc)
 #endif
 }
 
-void
+static void
 srpc_client_rpc_done (srpc_client_rpc_t *rpc, int status)
 {
        swi_workitem_t *wi = &rpc->crpc_wi;
@@ -1437,25 +1443,32 @@ srpc_send_reply(struct srpc_server_rpc *rpc)
 }
 
 /* when in kernel always called with LNET_LOCK() held, and in thread context */
-void
+static void
 srpc_lnet_ev_handler(lnet_event_t *ev)
 {
        struct srpc_service_cd  *scd;
-        srpc_event_t      *rpcev = ev->md.user_ptr;
-        srpc_client_rpc_t *crpc;
-        srpc_server_rpc_t *srpc;
-        srpc_buffer_t     *buffer;
-        srpc_service_t    *sv;
-        srpc_msg_t        *msg;
-        srpc_msg_type_t    type;
+       srpc_event_t      *rpcev = ev->md.user_ptr;
+       srpc_client_rpc_t *crpc;
+       srpc_server_rpc_t *srpc;
+       srpc_buffer_t     *buffer;
+       srpc_service_t    *sv;
+       srpc_msg_t        *msg;
+       srpc_msg_type_t    type;
+
+       LASSERT (!in_interrupt());
 
-        LASSERT (!cfs_in_interrupt());
+       if (ev->status != 0) {
+               __u32 errors;
 
-        if (ev->status != 0) {
                spin_lock(&srpc_data.rpc_glock);
-               srpc_data.rpc_counters.errors++;
+               if (ev->status != -ECANCELED) /* cancellation is not error */
+                       srpc_data.rpc_counters.errors++;
+               errors = srpc_data.rpc_counters.errors;
                spin_unlock(&srpc_data.rpc_glock);
-        }
+
+               CNETERR("LNet event status %d type %d, RPC errors %u\n",
+                       ev->status, ev->type, errors);
+       }
 
         rpcev->ev_lnet = ev->type;
 
@@ -1539,9 +1552,9 @@ srpc_lnet_ev_handler(lnet_event_t *ev)
                        swi_schedule_workitem(&scd->scd_buf_wi);
                }
 
-               cfs_list_del(&buffer->buf_list); /* from scd->scd_buf_posted */
-                msg = &buffer->buf_msg;
-                type = srpc_service2request(sv->sv_id);
+               list_del(&buffer->buf_list); /* from scd->scd_buf_posted */
+               msg = &buffer->buf_msg;
+               type = srpc_service2request(sv->sv_id);
 
                 if (ev->status != 0 || ev->mlength != sizeof(*msg) ||
                     (msg->msg_type != type &&
@@ -1560,19 +1573,19 @@ srpc_lnet_ev_handler(lnet_event_t *ev)
                         msg->msg_magic = 0;
                 }
 
-               if (!cfs_list_empty(&scd->scd_rpc_free)) {
-                       srpc = cfs_list_entry(scd->scd_rpc_free.next,
-                                             struct srpc_server_rpc,
-                                             srpc_list);
-                       cfs_list_del(&srpc->srpc_list);
+               if (!list_empty(&scd->scd_rpc_free)) {
+                       srpc = list_entry(scd->scd_rpc_free.next,
+                                         struct srpc_server_rpc,
+                                         srpc_list);
+                       list_del(&srpc->srpc_list);
 
                        srpc_init_server_rpc(srpc, scd, buffer);
-                       cfs_list_add_tail(&srpc->srpc_list,
-                                         &scd->scd_rpc_active);
+                       list_add_tail(&srpc->srpc_list,
+                                     &scd->scd_rpc_active);
                        swi_schedule_workitem(&srpc->srpc_wi);
                } else {
-                       cfs_list_add_tail(&buffer->buf_list,
-                                         &scd->scd_buf_blocked);
+                       list_add_tail(&buffer->buf_list,
+                                     &scd->scd_buf_blocked);
                }
 
                spin_unlock(&scd->scd_lock);
@@ -1661,10 +1674,10 @@ srpc_startup (void)
         srpc_data.rpc_state = SRPC_STATE_NONE;
 
 #ifdef __KERNEL__
-        rc = LNetNIInit(LUSTRE_SRV_LNET_PID);
+       rc = LNetNIInit(LNET_PID_LUSTRE);
 #else
         if (the_lnet.ln_server_mode_flag)
-                rc = LNetNIInit(LUSTRE_SRV_LNET_PID);
+               rc = LNetNIInit(LNET_PID_LUSTRE);
         else
                 rc = LNetNIInit(getpid() | LNET_PID_USERFLAG);
 #endif