Whamcloud - gitweb
LU-6068 misc: update Intel copyright messages 2014
[fs/lustre-release.git] / lnet / selftest / framework.c
index 71b1677..9296c8b 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, Intel Corporation.
+ * Copyright (c) 2012, 2014, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -104,14 +104,22 @@ do {                                    \
 #define sfw_batch_active(b)     (atomic_read(&(b)->bat_nactive) != 0)
 
 struct smoketest_framework {
-       cfs_list_t         fw_zombie_rpcs;     /* RPCs to be recycled */
-       cfs_list_t         fw_zombie_sessions; /* stopping sessions */
-       cfs_list_t         fw_tests;           /* registered test cases */
-       atomic_t       fw_nzombies;        /* # zombie sessions */
-       spinlock_t         fw_lock;             /* serialise */
-       sfw_session_t     *fw_session;          /* _the_ session */
-       int                fw_shuttingdown;     /* shutdown in progress */
-       srpc_server_rpc_t *fw_active_srpc;      /* running RPC */
+       /* RPCs to be recycled */
+       struct list_head        fw_zombie_rpcs;
+       /* stopping sessions */
+       struct list_head        fw_zombie_sessions;
+       /* registered test cases */
+       struct list_head        fw_tests;
+       /* # zombie sessions */
+       atomic_t                fw_nzombies;
+       /* serialise */
+       spinlock_t              fw_lock;
+       /* _the_ session */
+       sfw_session_t           *fw_session;
+       /* shutdown in progress */
+       int                     fw_shuttingdown;
+       /* running RPC */
+       srpc_server_rpc_t       *fw_active_srpc;
 } sfw_data;
 
 /* forward ref's */
@@ -121,18 +129,17 @@ void sfw_destroy_session (sfw_session_t *sn);
 static inline sfw_test_case_t *
 sfw_find_test_case(int id)
 {
-        sfw_test_case_t *tsc;
+       sfw_test_case_t *tsc;
 
-        LASSERT (id <= SRPC_SERVICE_MAX_ID);
-        LASSERT (id > SRPC_FRAMEWORK_SERVICE_MAX_ID);
+       LASSERT(id <= SRPC_SERVICE_MAX_ID);
+       LASSERT(id > SRPC_FRAMEWORK_SERVICE_MAX_ID);
 
-        cfs_list_for_each_entry_typed (tsc, &sfw_data.fw_tests,
-                                       sfw_test_case_t, tsc_list) {
-                if (tsc->tsc_srv_service->sv_id == id)
-                        return tsc;
-        }
+       list_for_each_entry(tsc, &sfw_data.fw_tests, tsc_list) {
+               if (tsc->tsc_srv_service->sv_id == id)
+                       return tsc;
+       }
 
-        return NULL;
+       return NULL;
 }
 
 static int
@@ -154,8 +161,8 @@ sfw_register_test (srpc_service_t *service, sfw_test_client_ops_t *cliops)
         tsc->tsc_cli_ops     = cliops;
         tsc->tsc_srv_service = service;
 
-        cfs_list_add_tail(&tsc->tsc_list, &sfw_data.fw_tests);
-        return 0;
+       list_add_tail(&tsc->tsc_list, &sfw_data.fw_tests);
+       return 0;
 }
 
 void
@@ -203,6 +210,7 @@ sfw_del_session_timer (void)
 /* called with sfw_data.fw_lock held */
 static void
 sfw_deactivate_session (void)
+__must_hold(&sfw_data.fw_lock)
 {
         sfw_session_t *sn = sfw_data.fw_session;
         int            nactive = 0;
@@ -211,33 +219,31 @@ sfw_deactivate_session (void)
 
         if (sn == NULL) return;
 
-        LASSERT (!sn->sn_timer_active);
+       LASSERT(!sn->sn_timer_active);
 
-        sfw_data.fw_session = NULL;
+       sfw_data.fw_session = NULL;
        atomic_inc(&sfw_data.fw_nzombies);
-        cfs_list_add(&sn->sn_list, &sfw_data.fw_zombie_sessions);
+       list_add(&sn->sn_list, &sfw_data.fw_zombie_sessions);
 
        spin_unlock(&sfw_data.fw_lock);
 
-       cfs_list_for_each_entry_typed(tsc, &sfw_data.fw_tests,
-                                     sfw_test_case_t, tsc_list) {
+       list_for_each_entry(tsc, &sfw_data.fw_tests, tsc_list) {
                srpc_abort_service(tsc->tsc_srv_service);
        }
 
        spin_lock(&sfw_data.fw_lock);
 
-        cfs_list_for_each_entry_typed (tsb, &sn->sn_batches,
-                                       sfw_batch_t, bat_list) {
-                if (sfw_batch_active(tsb)) {
-                        nactive++;
-                        sfw_stop_batch(tsb, 1);
-                }
-        }
+       list_for_each_entry(tsb, &sn->sn_batches, bat_list) {
+               if (sfw_batch_active(tsb)) {
+                       nactive++;
+                       sfw_stop_batch(tsb, 1);
+               }
+       }
 
-        if (nactive != 0)
-                return;   /* wait for active batches to stop */
+       if (nactive != 0)
+               return; /* wait for active batches to stop */
 
-        cfs_list_del_init(&sn->sn_list);
+       list_del_init(&sn->sn_list);
        spin_unlock(&sfw_data.fw_lock);
 
        sfw_destroy_session(sn);
@@ -282,8 +288,8 @@ sfw_init_session(sfw_session_t *sn, lst_sid_t sid,
         stt_timer_t *timer = &sn->sn_timer;
 
         memset(sn, 0, sizeof(sfw_session_t));
-        CFS_INIT_LIST_HEAD(&sn->sn_list);
-        CFS_INIT_LIST_HEAD(&sn->sn_batches);
+       INIT_LIST_HEAD(&sn->sn_list);
+       INIT_LIST_HEAD(&sn->sn_batches);
        atomic_set(&sn->sn_refcount, 1);        /* +1 for caller */
        atomic_set(&sn->sn_brw_errors, 0);
        atomic_set(&sn->sn_ping_errors, 0);
@@ -297,7 +303,7 @@ sfw_init_session(sfw_session_t *sn, lst_sid_t sid,
 
         timer->stt_data = sn;
         timer->stt_func = sfw_session_expired;
-        CFS_INIT_LIST_HEAD(&timer->stt_list);
+       INIT_LIST_HEAD(&timer->stt_list);
 }
 
 /* completion handler for incoming framework RPCs */
@@ -322,25 +328,24 @@ sfw_server_rpc_done(struct srpc_server_rpc *rpc)
 void
 sfw_client_rpc_fini (srpc_client_rpc_t *rpc)
 {
-        LASSERT (rpc->crpc_bulk.bk_niov == 0);
-        LASSERT (cfs_list_empty(&rpc->crpc_list));
-       LASSERT (atomic_read(&rpc->crpc_refcount) == 0);
+       LASSERT(rpc->crpc_bulk.bk_niov == 0);
+       LASSERT(list_empty(&rpc->crpc_list));
+       LASSERT(atomic_read(&rpc->crpc_refcount) == 0);
 #ifndef __KERNEL__
-        LASSERT (rpc->crpc_bulk.bk_pages == NULL);
+       LASSERT(rpc->crpc_bulk.bk_pages == NULL);
 #endif
 
-        CDEBUG (D_NET,
-                "Outgoing framework RPC done: "
-                "service %d, peer %s, status %s:%d:%d\n",
-                rpc->crpc_service, libcfs_id2str(rpc->crpc_dest),
-                swi_state2str(rpc->crpc_wi.swi_state),
-                rpc->crpc_aborted, rpc->crpc_status);
+       CDEBUG(D_NET, "Outgoing framework RPC done: "
+              "service %d, peer %s, status %s:%d:%d\n",
+              rpc->crpc_service, libcfs_id2str(rpc->crpc_dest),
+              swi_state2str(rpc->crpc_wi.swi_state),
+              rpc->crpc_aborted, rpc->crpc_status);
 
        spin_lock(&sfw_data.fw_lock);
 
        /* my callers must finish all RPCs before shutting me down */
        LASSERT(!sfw_data.fw_shuttingdown);
-       cfs_list_add(&rpc->crpc_list, &sfw_data.fw_zombie_rpcs);
+       list_add(&rpc->crpc_list, &sfw_data.fw_zombie_rpcs);
 
        spin_unlock(&sfw_data.fw_lock);
 }
@@ -348,18 +353,17 @@ sfw_client_rpc_fini (srpc_client_rpc_t *rpc)
 sfw_batch_t *
 sfw_find_batch (lst_bid_t bid)
 {
-        sfw_session_t *sn = sfw_data.fw_session;
-        sfw_batch_t   *bat;
+       sfw_session_t *sn = sfw_data.fw_session;
+       sfw_batch_t   *bat;
 
-        LASSERT (sn != NULL);
+       LASSERT(sn != NULL);
 
-        cfs_list_for_each_entry_typed (bat, &sn->sn_batches,
-                                       sfw_batch_t, bat_list) {
-                if (bat->bat_id.bat_id == bid.bat_id)
-                        return bat;
-        }
+       list_for_each_entry(bat, &sn->sn_batches, bat_list) {
+               if (bat->bat_id.bat_id == bid.bat_id)
+                       return bat;
+       }
 
-        return NULL;
+       return NULL;
 }
 
 sfw_batch_t *
@@ -378,14 +382,14 @@ sfw_bid2batch (lst_bid_t bid)
         if (bat == NULL) 
                 return NULL;
 
-        bat->bat_error    = 0;
-        bat->bat_session  = sn;
-        bat->bat_id       = bid;
+       bat->bat_error   = 0;
+       bat->bat_session = sn;
+       bat->bat_id      = bid;
        atomic_set(&bat->bat_nactive, 0);
-        CFS_INIT_LIST_HEAD(&bat->bat_tests);
+       INIT_LIST_HEAD(&bat->bat_tests);
 
-        cfs_list_add_tail(&bat->bat_list, &sn->sn_batches);
-        return bat;
+       list_add_tail(&bat->bat_list, &sn->sn_batches);
+       return bat;
 }
 
 int
@@ -421,15 +425,14 @@ sfw_get_stats (srpc_stat_reqst_t *request, srpc_stat_reply_t *reply)
        cnt->ping_errors     = atomic_read(&sn->sn_ping_errors);
        cnt->zombie_sessions = atomic_read(&sfw_data.fw_nzombies);
 
-        cnt->active_batches = 0;
-        cfs_list_for_each_entry_typed (bat, &sn->sn_batches,
-                                       sfw_batch_t, bat_list) {
+       cnt->active_batches = 0;
+       list_for_each_entry(bat, &sn->sn_batches, bat_list) {
                if (atomic_read(&bat->bat_nactive) > 0)
-                        cnt->active_batches++;
-        }
+                       cnt->active_batches++;
+       }
 
-        reply->str_status = 0;
-        return 0;
+       reply->str_status = 0;
+       return 0;
 }
 
 int
@@ -477,12 +480,12 @@ sfw_make_session(srpc_mksn_reqst_t *request, srpc_mksn_reply_t *reply)
                return 0;
        }
 
-        /* brand new or create by force */
-        LIBCFS_ALLOC(sn, sizeof(sfw_session_t));
-        if (sn == NULL) {
-                CERROR ("Dropping RPC (mksn) under memory pressure.\n");
-                return -ENOMEM;
-        }
+       /* brand new or create by force */
+       LIBCFS_ALLOC(sn, sizeof(sfw_session_t));
+       if (sn == NULL) {
+               CERROR("dropping RPC mksn under memory pressure\n");
+               return -ENOMEM;
+       }
 
        sfw_init_session(sn, request->mksn_sid,
                         msg->msg_ses_feats, &request->mksn_name[0]);
@@ -557,12 +560,12 @@ sfw_debug_session (srpc_debug_reqst_t *request, srpc_debug_reply_t *reply)
 void
 sfw_test_rpc_fini (srpc_client_rpc_t *rpc)
 {
-        sfw_test_unit_t     *tsu = rpc->crpc_priv;
-        sfw_test_instance_t *tsi = tsu->tsu_instance;
+       sfw_test_unit_t     *tsu = rpc->crpc_priv;
+       sfw_test_instance_t *tsi = tsu->tsu_instance;
 
-        /* Called with hold of tsi->tsi_lock */
-        LASSERT (cfs_list_empty(&rpc->crpc_list));
-        cfs_list_add(&rpc->crpc_list, &tsi->tsi_free_rpcs);
+       /* Called with hold of tsi->tsi_lock */
+       LASSERT(list_empty(&rpc->crpc_list));
+       list_add(&rpc->crpc_list, &tsi->tsi_free_rpcs);
 }
 
 static inline int
@@ -649,67 +652,67 @@ sfw_destroy_test_instance (sfw_test_instance_t *tsi)
 
         tsi->tsi_ops->tso_fini(tsi);
 
-        LASSERT (!tsi->tsi_stopping);
-        LASSERT (cfs_list_empty(&tsi->tsi_active_rpcs));
-        LASSERT (!sfw_test_active(tsi));
+       LASSERT(!tsi->tsi_stopping);
+       LASSERT(list_empty(&tsi->tsi_active_rpcs));
+       LASSERT(!sfw_test_active(tsi));
 
-        while (!cfs_list_empty(&tsi->tsi_units)) {
-                tsu = cfs_list_entry(tsi->tsi_units.next,
-                                     sfw_test_unit_t, tsu_list);
-                cfs_list_del(&tsu->tsu_list);
-                LIBCFS_FREE(tsu, sizeof(*tsu));
-        }
+       while (!list_empty(&tsi->tsi_units)) {
+               tsu = list_entry(tsi->tsi_units.next,
+                                sfw_test_unit_t, tsu_list);
+               list_del(&tsu->tsu_list);
+               LIBCFS_FREE(tsu, sizeof(*tsu));
+       }
 
-        while (!cfs_list_empty(&tsi->tsi_free_rpcs)) {
-                rpc = cfs_list_entry(tsi->tsi_free_rpcs.next,
-                                     srpc_client_rpc_t, crpc_list);
-                cfs_list_del(&rpc->crpc_list);
-                LIBCFS_FREE(rpc, srpc_client_rpc_size(rpc));
-        }
+       while (!list_empty(&tsi->tsi_free_rpcs)) {
+               rpc = list_entry(tsi->tsi_free_rpcs.next,
+                                srpc_client_rpc_t, crpc_list);
+               list_del(&rpc->crpc_list);
+               LIBCFS_FREE(rpc, srpc_client_rpc_size(rpc));
+       }
 
 clean:
-        sfw_unload_test(tsi);
-        LIBCFS_FREE(tsi, sizeof(*tsi));
-        return;
+       sfw_unload_test(tsi);
+       LIBCFS_FREE(tsi, sizeof(*tsi));
+       return;
 }
 
 void
 sfw_destroy_batch (sfw_batch_t *tsb)
 {
-        sfw_test_instance_t *tsi;
+       sfw_test_instance_t *tsi;
 
-        LASSERT (!sfw_batch_active(tsb));
-        LASSERT (cfs_list_empty(&tsb->bat_list));
+       LASSERT(!sfw_batch_active(tsb));
+       LASSERT(list_empty(&tsb->bat_list));
 
-        while (!cfs_list_empty(&tsb->bat_tests)) {
-                tsi = cfs_list_entry(tsb->bat_tests.next,
-                                     sfw_test_instance_t, tsi_list);
-                cfs_list_del_init(&tsi->tsi_list);
-                sfw_destroy_test_instance(tsi);
-        }
+       while (!list_empty(&tsb->bat_tests)) {
+               tsi = list_entry(tsb->bat_tests.next,
+                                sfw_test_instance_t, tsi_list);
+               list_del_init(&tsi->tsi_list);
+               sfw_destroy_test_instance(tsi);
+       }
 
-        LIBCFS_FREE(tsb, sizeof(sfw_batch_t));
-        return;
+       LIBCFS_FREE(tsb, sizeof(sfw_batch_t));
+       return;
 }
 
 void
 sfw_destroy_session (sfw_session_t *sn)
 {
-        sfw_batch_t *batch;
+       sfw_batch_t *batch;
 
-        LASSERT (cfs_list_empty(&sn->sn_list));
-        LASSERT (sn != sfw_data.fw_session);
+       LASSERT(list_empty(&sn->sn_list));
+       LASSERT(sn != sfw_data.fw_session);
 
-        while (!cfs_list_empty(&sn->sn_batches)) {
-                batch = cfs_list_entry(sn->sn_batches.next,
-                                       sfw_batch_t, bat_list);
-                cfs_list_del_init(&batch->bat_list);
-                sfw_destroy_batch(batch);
-        }
+       while (!list_empty(&sn->sn_batches)) {
+               batch = list_entry(sn->sn_batches.next,
+                                  sfw_batch_t, bat_list);
+               list_del_init(&batch->bat_list);
+               sfw_destroy_batch(batch);
+       }
 
-        LIBCFS_FREE(sn, sizeof(*sn));
+       LIBCFS_FREE(sn, sizeof(*sn));
        atomic_dec(&sfw_data.fw_nzombies);
-        return;
+       return;
 }
 
 void
@@ -753,8 +756,8 @@ sfw_unpack_addtest_req(srpc_msg_t *msg)
                 return;
         }
 
-        LBUG ();
-        return;
+       LBUG();
+       return;
 }
 
 int
@@ -779,9 +782,9 @@ sfw_add_test_instance (sfw_batch_t *tsb, srpc_server_rpc_t *rpc)
         memset(tsi, 0, sizeof(*tsi));
        spin_lock_init(&tsi->tsi_lock);
        atomic_set(&tsi->tsi_nactive, 0);
-        CFS_INIT_LIST_HEAD(&tsi->tsi_units);
-        CFS_INIT_LIST_HEAD(&tsi->tsi_free_rpcs);
-        CFS_INIT_LIST_HEAD(&tsi->tsi_active_rpcs);
+       INIT_LIST_HEAD(&tsi->tsi_units);
+       INIT_LIST_HEAD(&tsi->tsi_free_rpcs);
+       INIT_LIST_HEAD(&tsi->tsi_active_rpcs);
 
         tsi->tsi_stopping      = 0;
         tsi->tsi_batch         = tsb;
@@ -799,11 +802,11 @@ sfw_add_test_instance (sfw_batch_t *tsb, srpc_server_rpc_t *rpc)
 
         LASSERT (!sfw_batch_active(tsb));
 
-        if (!tsi->tsi_is_client) {
-                /* it's test server, just add it to tsb */
-                cfs_list_add_tail(&tsi->tsi_list, &tsb->bat_tests);
-                return 0;
-        }
+       if (!tsi->tsi_is_client) {
+               /* it's test server, just add it to tsb */
+               list_add_tail(&tsi->tsi_list, &tsb->bat_tests);
+               return 0;
+       }
 
         LASSERT (bk != NULL);
 #ifndef __KERNEL__
@@ -840,24 +843,24 @@ sfw_add_test_instance (sfw_batch_t *tsb, srpc_server_rpc_t *rpc)
                                 goto error;
                         }
 
-                        tsu->tsu_dest.nid = id.nid;
-                        tsu->tsu_dest.pid = id.pid;
-                        tsu->tsu_instance = tsi;
-                        tsu->tsu_private  = NULL;
-                        cfs_list_add_tail(&tsu->tsu_list, &tsi->tsi_units);
-                }
-        }
+                       tsu->tsu_dest.nid = id.nid;
+                       tsu->tsu_dest.pid = id.pid;
+                       tsu->tsu_instance = tsi;
+                       tsu->tsu_private  = NULL;
+                       list_add_tail(&tsu->tsu_list, &tsi->tsi_units);
+               }
+       }
 
-        rc = tsi->tsi_ops->tso_init(tsi);
-        if (rc == 0) {
-                cfs_list_add_tail(&tsi->tsi_list, &tsb->bat_tests);
-                return 0;
-        }
+       rc = tsi->tsi_ops->tso_init(tsi);
+       if (rc == 0) {
+               list_add_tail(&tsi->tsi_list, &tsb->bat_tests);
+               return 0;
+       }
 
 error:
-        LASSERT (rc != 0);
-        sfw_destroy_test_instance(tsi);
-        return rc;
+       LASSERT(rc != 0);
+       sfw_destroy_test_instance(tsi);
+       return rc;
 }
 
 static void
@@ -887,17 +890,16 @@ sfw_test_unit_done (sfw_test_unit_t *tsu)
                 return;
         }
 
-        LASSERT (!cfs_list_empty(&sn->sn_list)); /* I'm a zombie! */
+       LASSERT(!list_empty(&sn->sn_list)); /* I'm a zombie! */
 
-        cfs_list_for_each_entry_typed (tsb, &sn->sn_batches,
-                                       sfw_batch_t, bat_list) {
-                if (sfw_batch_active(tsb)) {
+       list_for_each_entry(tsb, &sn->sn_batches, bat_list) {
+               if (sfw_batch_active(tsb)) {
                        spin_unlock(&sfw_data.fw_lock);
                        return;
                }
        }
 
-       cfs_list_del_init(&sn->sn_list);
+       list_del_init(&sn->sn_list);
        spin_unlock(&sfw_data.fw_lock);
 
        sfw_destroy_session(sn);
@@ -915,10 +917,10 @@ sfw_test_rpc_done (srpc_client_rpc_t *rpc)
 
        spin_lock(&tsi->tsi_lock);
 
-        LASSERT (sfw_test_active(tsi));
-        LASSERT (!cfs_list_empty(&rpc->crpc_list));
+       LASSERT(sfw_test_active(tsi));
+       LASSERT(!list_empty(&rpc->crpc_list));
 
-        cfs_list_del_init(&rpc->crpc_list);
+       list_del_init(&rpc->crpc_list);
 
         /* batch is stopping or loop is done or get error */
         if (tsi->tsi_stopping ||
@@ -952,13 +954,13 @@ sfw_create_test_rpc(sfw_test_unit_t *tsu, lnet_process_id_t peer,
 
         LASSERT (sfw_test_active(tsi));
 
-        if (!cfs_list_empty(&tsi->tsi_free_rpcs)) {
-                /* pick request from buffer */
-                rpc = cfs_list_entry(tsi->tsi_free_rpcs.next,
-                                     srpc_client_rpc_t, crpc_list);
-                LASSERT (nblk == rpc->crpc_bulk.bk_niov);
-                cfs_list_del_init(&rpc->crpc_list);
-        }
+       if (!list_empty(&tsi->tsi_free_rpcs)) {
+               /* pick request from buffer */
+               rpc = list_entry(tsi->tsi_free_rpcs.next,
+                                srpc_client_rpc_t, crpc_list);
+               LASSERT(nblk == rpc->crpc_bulk.bk_niov);
+               list_del_init(&rpc->crpc_list);
+       }
 
        spin_unlock(&tsi->tsi_lock);
 
@@ -1002,7 +1004,7 @@ sfw_run_test (swi_workitem_t *wi)
        spin_lock(&tsi->tsi_lock);
 
        if (tsi->tsi_stopping) {
-               cfs_list_add(&rpc->crpc_list, &tsi->tsi_free_rpcs);
+               list_add(&rpc->crpc_list, &tsi->tsi_free_rpcs);
                spin_unlock(&tsi->tsi_lock);
                goto test_done;
        }
@@ -1010,7 +1012,7 @@ sfw_run_test (swi_workitem_t *wi)
        if (tsu->tsu_loop > 0)
                tsu->tsu_loop--;
 
-       cfs_list_add_tail(&rpc->crpc_list, &tsi->tsi_active_rpcs);
+       list_add_tail(&rpc->crpc_list, &tsi->tsi_active_rpcs);
        spin_unlock(&tsi->tsi_lock);
 
        spin_lock(&rpc->crpc_lock);
@@ -1045,29 +1047,27 @@ sfw_run_batch (sfw_batch_t *tsb)
                 return 0;
         }
 
-        cfs_list_for_each_entry_typed (tsi, &tsb->bat_tests,
-                                       sfw_test_instance_t, tsi_list) {
-                if (!tsi->tsi_is_client) /* skip server instances */
-                        continue;
+       list_for_each_entry(tsi, &tsb->bat_tests, tsi_list) {
+               if (!tsi->tsi_is_client)        /* skip server instances */
+                       continue;
 
-                LASSERT (!tsi->tsi_stopping);
-                LASSERT (!sfw_test_active(tsi));
+               LASSERT(!tsi->tsi_stopping);
+               LASSERT(!sfw_test_active(tsi));
 
                atomic_inc(&tsb->bat_nactive);
 
-                cfs_list_for_each_entry_typed (tsu, &tsi->tsi_units,
-                                               sfw_test_unit_t, tsu_list) {
+               list_for_each_entry(tsu, &tsi->tsi_units, tsu_list) {
                        atomic_inc(&tsi->tsi_nactive);
-                        tsu->tsu_loop = tsi->tsi_loop;
-                        wi = &tsu->tsu_worker;
+                       tsu->tsu_loop = tsi->tsi_loop;
+                       wi = &tsu->tsu_worker;
                        swi_init_workitem(wi, tsu, sfw_run_test,
                                          lst_sched_test[\
                                          lnet_cpt_of_nid(tsu->tsu_dest.nid)]);
-                        swi_schedule_workitem(wi);
-                }
-        }
+                       swi_schedule_workitem(wi);
+               }
+       }
 
-        return 0;
+       return 0;
 }
 
 int
@@ -1081,8 +1081,7 @@ sfw_stop_batch (sfw_batch_t *tsb, int force)
                 return 0;
         }
 
-        cfs_list_for_each_entry_typed (tsi, &tsb->bat_tests,
-                                       sfw_test_instance_t, tsi_list) {
+       list_for_each_entry(tsi, &tsb->bat_tests, tsi_list) {
                spin_lock(&tsi->tsi_lock);
 
                if (!tsi->tsi_is_client ||
@@ -1099,8 +1098,7 @@ sfw_stop_batch (sfw_batch_t *tsb, int force)
                }
 
                /* abort launched rpcs in the test */
-               cfs_list_for_each_entry_typed(rpc, &tsi->tsi_active_rpcs,
-                                             srpc_client_rpc_t, crpc_list) {
+               list_for_each_entry(rpc, &tsi->tsi_active_rpcs, crpc_list) {
                        spin_lock(&rpc->crpc_lock);
 
                        srpc_abort_rpc(rpc, -EINTR);
@@ -1127,8 +1125,7 @@ sfw_query_batch (sfw_batch_t *tsb, int testidx, srpc_batch_reply_t *reply)
                 return 0;
         }
 
-        cfs_list_for_each_entry_typed (tsi, &tsb->bat_tests,
-                                       sfw_test_instance_t, tsi_list) {
+       list_for_each_entry(tsi, &tsb->bat_tests, tsi_list) {
                 if (testidx-- > 1)
                         continue;
 
@@ -1190,9 +1187,9 @@ sfw_add_test (srpc_server_rpc_t *rpc)
                 return 0;
         }
 
-        bat = sfw_bid2batch(request->tsr_bid);
-        if (bat == NULL) {
-                CERROR ("Dropping RPC (%s) from %s under memory pressure.\n",
+       bat = sfw_bid2batch(request->tsr_bid);
+       if (bat == NULL) {
+               CERROR("dropping RPC %s from %s under memory pressure\n",
                        rpc->srpc_scd->scd_svc->sv_name,
                         libcfs_id2str(rpc->srpc_peer));
                 return -ENOMEM;
@@ -1292,7 +1289,7 @@ sfw_handle_server_rpc(struct srpc_server_rpc *rpc)
 
        /* Remove timer to avoid racing with it or expiring active session */
        if (sfw_del_session_timer() != 0) {
-               CERROR("Dropping RPC (%s) from %s: racing with expiry timer.",
+               CERROR("dropping RPC %s from %s: racing with expiry timer\n",
                       sv->sv_name, libcfs_id2str(rpc->srpc_peer));
                spin_unlock(&sfw_data.fw_lock);
                return -EAGAIN;
@@ -1409,7 +1406,7 @@ sfw_bulk_ready(struct srpc_server_rpc *rpc, int status)
        }
 
        if (sfw_del_session_timer() != 0) {
-               CERROR("Dropping RPC (%s) from %s: racing with expiry timer",
+               CERROR("dropping RPC %s from %s: racing with expiry timer\n",
                       sv->sv_name, libcfs_id2str(rpc->srpc_peer));
                spin_unlock(&sfw_data.fw_lock);
                return -EAGAIN;
@@ -1447,10 +1444,10 @@ sfw_create_rpc(lnet_process_id_t peer, int service,
         LASSERT (!sfw_data.fw_shuttingdown);
         LASSERT (service <= SRPC_FRAMEWORK_SERVICE_MAX_ID);
 
-        if (nbulkiov == 0 && !cfs_list_empty(&sfw_data.fw_zombie_rpcs)) {
-                rpc = cfs_list_entry(sfw_data.fw_zombie_rpcs.next,
+       if (nbulkiov == 0 && !list_empty(&sfw_data.fw_zombie_rpcs)) {
+               rpc = list_entry(sfw_data.fw_zombie_rpcs.next,
                                      srpc_client_rpc_t, crpc_list);
-                cfs_list_del(&rpc->crpc_list);
+               list_del(&rpc->crpc_list);
 
                 srpc_init_client_rpc(rpc, peer, service, 0, 0,
                                      done, sfw_client_rpc_fini, priv);
@@ -1633,13 +1630,13 @@ sfw_post_rpc (srpc_client_rpc_t *rpc)
 {
        spin_lock(&rpc->crpc_lock);
 
-        LASSERT (!rpc->crpc_closed);
-        LASSERT (!rpc->crpc_aborted);
-        LASSERT (cfs_list_empty(&rpc->crpc_list));
-        LASSERT (!sfw_data.fw_shuttingdown);
+       LASSERT(!rpc->crpc_closed);
+       LASSERT(!rpc->crpc_aborted);
+       LASSERT(list_empty(&rpc->crpc_list));
+       LASSERT(!sfw_data.fw_shuttingdown);
 
-        rpc->crpc_timeout = rpc_timeout;
-        srpc_post_rpc(rpc);
+       rpc->crpc_timeout = rpc_timeout;
+       srpc_post_rpc(rpc);
 
        spin_unlock(&rpc->crpc_lock);
        return;
@@ -1740,9 +1737,9 @@ sfw_startup (void)
         sfw_data.fw_active_srpc = NULL;
        spin_lock_init(&sfw_data.fw_lock);
        atomic_set(&sfw_data.fw_nzombies, 0);
-        CFS_INIT_LIST_HEAD(&sfw_data.fw_tests);
-        CFS_INIT_LIST_HEAD(&sfw_data.fw_zombie_rpcs);
-        CFS_INIT_LIST_HEAD(&sfw_data.fw_zombie_sessions);
+       INIT_LIST_HEAD(&sfw_data.fw_tests);
+       INIT_LIST_HEAD(&sfw_data.fw_zombie_rpcs);
+       INIT_LIST_HEAD(&sfw_data.fw_zombie_sessions);
 
         brw_init_test_client();
         brw_init_test_service();
@@ -1754,19 +1751,18 @@ sfw_startup (void)
         rc = sfw_register_test(&ping_test_service, &ping_test_client);
         LASSERT (rc == 0);
 
-        error = 0;
-        cfs_list_for_each_entry_typed (tsc, &sfw_data.fw_tests,
-                                       sfw_test_case_t, tsc_list) {
-                sv = tsc->tsc_srv_service;
+       error = 0;
+       list_for_each_entry(tsc, &sfw_data.fw_tests, tsc_list) {
+               sv = tsc->tsc_srv_service;
 
-                rc = srpc_add_service(sv);
-                LASSERT (rc != -EBUSY);
-                if (rc != 0) {
-                        CWARN ("Failed to add %s service: %d\n",
-                               sv->sv_name, rc);
-                        error = rc;
-                }
-        }
+               rc = srpc_add_service(sv);
+               LASSERT(rc != -EBUSY);
+               if (rc != 0) {
+                       CWARN("Failed to add %s service: %d\n",
+                             sv->sv_name, rc);
+                       error = rc;
+               }
+       }
 
         for (i = 0; ; i++) {
                 sv = &sfw_services[i];
@@ -1841,22 +1837,21 @@ sfw_shutdown (void)
                 srpc_remove_service(sv);
         }
 
-        cfs_list_for_each_entry_typed (tsc, &sfw_data.fw_tests,
-                                       sfw_test_case_t, tsc_list) {
+       list_for_each_entry(tsc, &sfw_data.fw_tests, tsc_list) {
                 sv = tsc->tsc_srv_service;
                 srpc_shutdown_service(sv);
                 srpc_remove_service(sv);
         }
 
-        while (!cfs_list_empty(&sfw_data.fw_zombie_rpcs)) {
-                srpc_client_rpc_t *rpc;
+       while (!list_empty(&sfw_data.fw_zombie_rpcs)) {
+               srpc_client_rpc_t *rpc;
 
-                rpc = cfs_list_entry(sfw_data.fw_zombie_rpcs.next, 
-                                     srpc_client_rpc_t, crpc_list);
-                cfs_list_del(&rpc->crpc_list);
+               rpc = list_entry(sfw_data.fw_zombie_rpcs.next,
+                                srpc_client_rpc_t, crpc_list);
+               list_del(&rpc->crpc_list);
 
-                LIBCFS_FREE(rpc, srpc_client_rpc_size(rpc));
-        }
+               LIBCFS_FREE(rpc, srpc_client_rpc_size(rpc));
+       }
 
         for (i = 0; ; i++) {
                 sv = &sfw_services[i];
@@ -1866,15 +1861,15 @@ sfw_shutdown (void)
                 srpc_wait_service_shutdown(sv);
         }
 
-        while (!cfs_list_empty(&sfw_data.fw_tests)) {
-                tsc = cfs_list_entry(sfw_data.fw_tests.next,
-                                     sfw_test_case_t, tsc_list);
+       while (!list_empty(&sfw_data.fw_tests)) {
+               tsc = list_entry(sfw_data.fw_tests.next,
+                                sfw_test_case_t, tsc_list);
 
-                srpc_wait_service_shutdown(tsc->tsc_srv_service);
+               srpc_wait_service_shutdown(tsc->tsc_srv_service);
 
-                cfs_list_del(&tsc->tsc_list);
-                LIBCFS_FREE(tsc, sizeof(*tsc));
-        }
+               list_del(&tsc->tsc_list);
+               LIBCFS_FREE(tsc, sizeof(*tsc));
+       }
 
-        return;
+       return;
 }