Whamcloud - gitweb
LU-9679 lnet: use LIST_HEAD() for local lists.
[fs/lustre-release.git] / lnet / selftest / console.c
index 9409da6..ccaced7 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
@@ -40,7 +36,6 @@
  * Author: Liang Zhen <liangzhen@clusterfs.com>
  */
 
-
 #include <libcfs/libcfs.h>
 #include <lnet/lib-lnet.h>
 #include "console.h"
@@ -59,10 +54,10 @@ do {                                                    \
         (p)->nle_nnode ++;                              \
 } while (0)
 
-lstcon_session_t        console_session;
+struct lstcon_session console_session;
 
 static void
-lstcon_node_get(lstcon_node_t *nd)
+lstcon_node_get(struct lstcon_node *nd)
 {
         LASSERT (nd->nd_ref >= 1);
 
@@ -70,10 +65,11 @@ lstcon_node_get(lstcon_node_t *nd)
 }
 
 static int
-lstcon_node_find(lnet_process_id_t id, lstcon_node_t **ndpp, int create)
+lstcon_node_find(struct lnet_process_id id, struct lstcon_node **ndpp,
+                int create)
 {
-       lstcon_ndlink_t *ndl;
-       unsigned int     idx = LNET_NIDADDR(id.nid) % LST_GLOBAL_HASHSIZE;
+       struct lstcon_ndlink *ndl;
+       unsigned int idx = LNET_NIDADDR(id.nid) % LST_GLOBAL_HASHSIZE;
 
        LASSERT(id.nid != LNET_NID_ANY);
 
@@ -91,20 +87,20 @@ lstcon_node_find(lnet_process_id_t id, lstcon_node_t **ndpp, int create)
         if (!create)
                 return -ENOENT;
 
-        LIBCFS_ALLOC(*ndpp, sizeof(lstcon_node_t) + sizeof(lstcon_ndlink_t));
-        if (*ndpp == NULL)
-                return -ENOMEM;
+       LIBCFS_ALLOC(*ndpp, sizeof(**ndpp) + sizeof(*ndl));
+       if (*ndpp == NULL)
+               return -ENOMEM;
 
-        ndl = (lstcon_ndlink_t *)(*ndpp + 1);
+       ndl = (struct lstcon_ndlink *)(*ndpp + 1);
 
-        ndl->ndl_node = *ndpp;
+       ndl->ndl_node = *ndpp;
 
-        ndl->ndl_node->nd_ref   = 1;
-        ndl->ndl_node->nd_id    = id;
-        ndl->ndl_node->nd_stamp = cfs_time_current();
-        ndl->ndl_node->nd_state = LST_NODE_UNKNOWN;
-        ndl->ndl_node->nd_timeout = 0;
-        memset(&ndl->ndl_node->nd_ping, 0, sizeof(lstcon_rpc_t));
+       ndl->ndl_node->nd_ref   = 1;
+       ndl->ndl_node->nd_id    = id;
+       ndl->ndl_node->nd_stamp = ktime_get();
+       ndl->ndl_node->nd_state = LST_NODE_UNKNOWN;
+       ndl->ndl_node->nd_timeout = 0;
+       memset(&ndl->ndl_node->nd_ping, 0, sizeof(ndl->ndl_node->nd_ping));
 
        /* queued in global hash & list, no refcount is taken by
         * global hash & list, if caller release his refcount,
@@ -116,16 +112,16 @@ lstcon_node_find(lnet_process_id_t id, lstcon_node_t **ndpp, int create)
 }
 
 static void
-lstcon_node_put(lstcon_node_t *nd)
+lstcon_node_put(struct lstcon_node *nd)
 {
-       lstcon_ndlink_t *ndl;
+       struct lstcon_ndlink *ndl;
 
        LASSERT(nd->nd_ref > 0);
 
        if (--nd->nd_ref > 0)
                return;
 
-       ndl = (lstcon_ndlink_t *)(nd + 1);
+       ndl = (struct lstcon_ndlink *)(nd + 1);
 
        LASSERT(!list_empty(&ndl->ndl_link));
        LASSERT(!list_empty(&ndl->ndl_hlink));
@@ -134,17 +130,17 @@ lstcon_node_put(lstcon_node_t *nd)
        list_del(&ndl->ndl_link);
        list_del(&ndl->ndl_hlink);
 
-       LIBCFS_FREE(nd, sizeof(lstcon_node_t) + sizeof(lstcon_ndlink_t));
+       LIBCFS_FREE(nd, sizeof(*nd) + sizeof(*ndl));
 }
 
 static int
-lstcon_ndlink_find(struct list_head *hash,
-                   lnet_process_id_t id, lstcon_ndlink_t **ndlpp, int create)
+lstcon_ndlink_find(struct list_head *hash, struct lnet_process_id id,
+                  struct lstcon_ndlink **ndlpp, int create)
 {
-       unsigned int     idx = LNET_NIDADDR(id.nid) % LST_NODE_HASHSIZE;
-       lstcon_ndlink_t *ndl;
-       lstcon_node_t   *nd;
-       int              rc;
+       unsigned int idx = LNET_NIDADDR(id.nid) % LST_NODE_HASHSIZE;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_node *nd;
+       int rc;
 
        if (id.nid == LNET_NID_ANY)
                return -EINVAL;
@@ -167,7 +163,7 @@ lstcon_ndlink_find(struct list_head *hash,
         if (rc != 0)
                 return rc;
 
-        LIBCFS_ALLOC(ndl, sizeof(lstcon_ndlink_t));
+       LIBCFS_ALLOC(ndl, sizeof(*ndl));
         if (ndl == NULL) {
                 lstcon_node_put(nd);
                 return -ENOMEM;
@@ -183,7 +179,7 @@ lstcon_ndlink_find(struct list_head *hash,
 }
 
 static void
-lstcon_ndlink_release(lstcon_ndlink_t *ndl)
+lstcon_ndlink_release(struct lstcon_ndlink *ndl)
 {
        LASSERT(list_empty(&ndl->ndl_link));
        LASSERT(!list_empty(&ndl->ndl_hlink));
@@ -195,23 +191,20 @@ lstcon_ndlink_release(lstcon_ndlink_t *ndl)
 }
 
 static int
-lstcon_group_alloc(char *name, lstcon_group_t **grpp)
+lstcon_group_alloc(char *name, struct lstcon_group **grpp)
 {
-       lstcon_group_t *grp;
-       int             i;
+       struct lstcon_group *grp;
+       int i;
 
-        LIBCFS_ALLOC(grp, offsetof(lstcon_group_t,
+       LIBCFS_ALLOC(grp, offsetof(struct lstcon_group,
                                    grp_ndl_hash[LST_NODE_HASHSIZE]));
         if (grp == NULL)
                 return -ENOMEM;
 
-        memset(grp, 0, offsetof(lstcon_group_t,
-                                grp_ndl_hash[LST_NODE_HASHSIZE]));
-
         grp->grp_ref = 1;
        if (name != NULL) {
                if (strlen(name) > sizeof(grp->grp_name)-1) {
-                       LIBCFS_FREE(grp, offsetof(lstcon_group_t,
+                       LIBCFS_FREE(grp, offsetof(struct lstcon_group,
                                          grp_ndl_hash[LST_NODE_HASHSIZE]));
                        return -E2BIG;
                }
@@ -231,18 +224,19 @@ lstcon_group_alloc(char *name, lstcon_group_t **grpp)
 }
 
 static void
-lstcon_group_addref(lstcon_group_t *grp)
+lstcon_group_addref(struct lstcon_group *grp)
 {
        grp->grp_ref++;
 }
 
-static void lstcon_group_ndlink_release(lstcon_group_t *, lstcon_ndlink_t *);
+static void lstcon_group_ndlink_release(struct lstcon_group *,
+                                       struct lstcon_ndlink *);
 
 static void
-lstcon_group_drain(lstcon_group_t *grp, int keep)
+lstcon_group_drain(struct lstcon_group *grp, int keep)
 {
-       lstcon_ndlink_t *ndl;
-       lstcon_ndlink_t *tmp;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_ndlink *tmp;
 
        list_for_each_entry_safe(ndl, tmp, &grp->grp_ndl_list, ndl_link) {
                if ((ndl->ndl_node->nd_state & keep) == 0)
@@ -251,7 +245,7 @@ lstcon_group_drain(lstcon_group_t *grp, int keep)
 }
 
 static void
-lstcon_group_decref(lstcon_group_t *grp)
+lstcon_group_decref(struct lstcon_group *grp)
 {
        int i;
 
@@ -266,14 +260,14 @@ lstcon_group_decref(lstcon_group_t *grp)
        for (i = 0; i < LST_NODE_HASHSIZE; i++)
                LASSERT(list_empty(&grp->grp_ndl_hash[i]));
 
-       LIBCFS_FREE(grp, offsetof(lstcon_group_t,
+       LIBCFS_FREE(grp, offsetof(struct lstcon_group,
                                  grp_ndl_hash[LST_NODE_HASHSIZE]));
 }
 
 static int
-lstcon_group_find(const char *name, lstcon_group_t **grpp)
+lstcon_group_find(const char *name, struct lstcon_group **grpp)
 {
-       lstcon_group_t *grp;
+       struct lstcon_group *grp;
 
        list_for_each_entry(grp, &console_session.ses_grp_list, grp_link) {
                if (strncmp(grp->grp_name, name, LST_NAME_SIZE) != 0)
@@ -287,15 +281,9 @@ lstcon_group_find(const char *name, lstcon_group_t **grpp)
        return -ENOENT;
 }
 
-static void
-lstcon_group_put(lstcon_group_t *grp)
-{
-        lstcon_group_decref(grp);
-}
-
 static int
-lstcon_group_ndlink_find(lstcon_group_t *grp, lnet_process_id_t id,
-                         lstcon_ndlink_t **ndlpp, int create)
+lstcon_group_ndlink_find(struct lstcon_group *grp, struct lnet_process_id id,
+                        struct lstcon_ndlink **ndlpp, int create)
 {
        int rc;
 
@@ -313,7 +301,7 @@ lstcon_group_ndlink_find(lstcon_group_t *grp, lnet_process_id_t id,
 }
 
 static void
-lstcon_group_ndlink_release(lstcon_group_t *grp, lstcon_ndlink_t *ndl)
+lstcon_group_ndlink_release(struct lstcon_group *grp, struct lstcon_ndlink *ndl)
 {
        list_del_init(&ndl->ndl_link);
        lstcon_ndlink_release(ndl);
@@ -321,39 +309,35 @@ lstcon_group_ndlink_release(lstcon_group_t *grp, lstcon_ndlink_t *ndl)
 }
 
 static void
-lstcon_group_ndlink_move(lstcon_group_t *old,
-                         lstcon_group_t *new, lstcon_ndlink_t *ndl)
+lstcon_group_ndlink_move(struct lstcon_group *old,
+                        struct lstcon_group *new, struct lstcon_ndlink *ndl)
 {
        unsigned int idx = LNET_NIDADDR(ndl->ndl_node->nd_id.nid) %
                                        LST_NODE_HASHSIZE;
 
-       list_del(&ndl->ndl_hlink);
-       list_del(&ndl->ndl_link);
        old->grp_nnode--;
 
-       list_add_tail(&ndl->ndl_hlink, &new->grp_ndl_hash[idx]);
-       list_add_tail(&ndl->ndl_link, &new->grp_ndl_list);
+       list_move_tail(&ndl->ndl_hlink, &new->grp_ndl_hash[idx]);
+       list_move_tail(&ndl->ndl_link, &new->grp_ndl_list);
        new->grp_nnode++;
-
-       return;
 }
 
 static void
-lstcon_group_move(lstcon_group_t *old, lstcon_group_t *new)
+lstcon_group_move(struct lstcon_group *old, struct lstcon_group *new)
 {
-       lstcon_ndlink_t *ndl;
+       struct lstcon_ndlink *ndl;
 
        while (!list_empty(&old->grp_ndl_list)) {
                ndl = list_entry(old->grp_ndl_list.next,
-                                lstcon_ndlink_t, ndl_link);
+                                struct lstcon_ndlink, ndl_link);
                lstcon_group_ndlink_move(old, new, ndl);
        }
 }
 
 static int
-lstcon_sesrpc_condition(int transop, lstcon_node_t *nd, void *arg)
+lstcon_sesrpc_condition(int transop, struct lstcon_node *nd, void *arg)
 {
-        lstcon_group_t *grp = (lstcon_group_t *)arg;
+       struct lstcon_group *grp = arg;
 
         switch (transop) {
         case LST_TRANS_SESNEW:
@@ -380,10 +364,10 @@ lstcon_sesrpc_condition(int transop, lstcon_node_t *nd, void *arg)
 }
 
 static int
-lstcon_sesrpc_readent(int transop, srpc_msg_t *msg,
-                     lstcon_rpc_ent_t __user *ent_up)
+lstcon_sesrpc_readent(int transop, struct srpc_msg *msg,
+                     struct lstcon_rpc_ent __user *ent_up)
 {
-        srpc_debug_reply_t *rep;
+       struct srpc_debug_reply *rep;
 
         switch (transop) {
         case LST_TRANS_SESNEW:
@@ -409,16 +393,17 @@ lstcon_sesrpc_readent(int transop, srpc_msg_t *msg,
 }
 
 static int
-lstcon_group_nodes_add(lstcon_group_t *grp,
-                      int count, lnet_process_id_t __user *ids_up,
-                      unsigned *featp, struct list_head __user *result_up)
-{
-        lstcon_rpc_trans_t      *trans;
-        lstcon_ndlink_t         *ndl;
-        lstcon_group_t          *tmp;
-        lnet_process_id_t        id;
-        int                      i;
-        int                      rc;
+lstcon_group_nodes_add(struct lstcon_group *grp,
+                      int count, struct lnet_process_id __user *ids_up,
+                      unsigned int *featp,
+                      struct list_head __user *result_up)
+{
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *tmp;
+       struct lnet_process_id id;
+       int i;
+       int rc;
 
         rc = lstcon_group_alloc(NULL, &tmp);
         if (rc != 0) {
@@ -446,7 +431,7 @@ lstcon_group_nodes_add(lstcon_group_t *grp,
         }
 
         if (rc != 0) {
-                lstcon_group_put(tmp);
+               lstcon_group_decref(tmp);
                 return rc;
         }
 
@@ -455,7 +440,7 @@ lstcon_group_nodes_add(lstcon_group_t *grp,
                                      tmp, lstcon_sesrpc_condition, &trans);
         if (rc != 0) {
                 CERROR("Can't create transaction: %d\n", rc);
-                lstcon_group_put(tmp);
+               lstcon_group_decref(tmp);
                 return rc;
         }
 
@@ -470,22 +455,22 @@ lstcon_group_nodes_add(lstcon_group_t *grp,
         lstcon_rpc_trans_destroy(trans);
 
         lstcon_group_move(tmp, grp);
-        lstcon_group_put(tmp);
+       lstcon_group_decref(tmp);
 
         return rc;
 }
 
 static int
-lstcon_group_nodes_remove(lstcon_group_t *grp,
-                         int count, lnet_process_id_t __user *ids_up,
+lstcon_group_nodes_remove(struct lstcon_group *grp,
+                         int count, struct lnet_process_id __user *ids_up,
                          struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t     *trans;
-        lstcon_ndlink_t        *ndl;
-        lstcon_group_t         *tmp;
-        lnet_process_id_t       id;
-        int                     rc;
-        int                     i;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *tmp;
+       struct lnet_process_id id;
+       int rc;
+       int i;
 
         /* End session and remove node from the group */
 
@@ -520,12 +505,12 @@ lstcon_group_nodes_remove(lstcon_group_t *grp,
 
         lstcon_rpc_trans_destroy(trans);
         /* release nodes anyway, because we can't rollback status */
-        lstcon_group_put(tmp);
+       lstcon_group_decref(tmp);
 
         return rc;
 error:
         lstcon_group_move(tmp, grp);
-        lstcon_group_put(tmp);
+       lstcon_group_decref(tmp);
 
         return rc;
 }
@@ -533,13 +518,13 @@ error:
 int
 lstcon_group_add(char *name)
 {
-        lstcon_group_t *grp;
-        int             rc;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = (lstcon_group_find(name, &grp) == 0)? -EEXIST: 0;
         if (rc != 0) {
                 /* find a group with same name */
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return rc;
         }
 
@@ -555,10 +540,10 @@ lstcon_group_add(char *name)
 }
 
 int
-lstcon_nodes_add(char *name, int count, lnet_process_id_t __user *ids_up,
+lstcon_nodes_add(char *name, int count, struct lnet_process_id __user *ids_up,
                 unsigned *featp, struct list_head __user *result_up)
 {
-        lstcon_group_t         *grp;
+       struct lstcon_group         *grp;
         int                     rc;
 
         LASSERT (count > 0);
@@ -573,14 +558,14 @@ lstcon_nodes_add(char *name, int count, lnet_process_id_t __user *ids_up,
         if (grp->grp_ref > 2) {
                 /* referred by other threads or test */
                 CDEBUG(D_NET, "Group %s is busy\n", name);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
 
                 return -EBUSY;
         }
 
        rc = lstcon_group_nodes_add(grp, count, ids_up, featp, result_up);
 
-        lstcon_group_put(grp);
+       lstcon_group_decref(grp);
 
         return rc;
 }
@@ -588,9 +573,9 @@ lstcon_nodes_add(char *name, int count, lnet_process_id_t __user *ids_up,
 int
 lstcon_group_del(char *name)
 {
-        lstcon_rpc_trans_t *trans;
-        lstcon_group_t     *grp;
-        int                 rc;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -601,7 +586,7 @@ lstcon_group_del(char *name)
         if (grp->grp_ref > 2) {
                 /* referred by others threads or test */
                 CDEBUG(D_NET, "Group %s is busy\n", name);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return -EBUSY;
         }
 
@@ -610,7 +595,7 @@ lstcon_group_del(char *name)
                                      grp, lstcon_sesrpc_condition, &trans);
         if (rc != 0) {
                 CERROR("Can't create transaction: %d\n", rc);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return rc;
         }
 
@@ -618,10 +603,10 @@ lstcon_group_del(char *name)
 
         lstcon_rpc_trans_destroy(trans);
 
-        lstcon_group_put(grp);
+       lstcon_group_decref(grp);
         /* -ref for session, it's destroyed,
          * status can't be rolled back, destroy group anway */
-        lstcon_group_put(grp);
+       lstcon_group_decref(grp);
 
         return rc;
 }
@@ -629,8 +614,8 @@ lstcon_group_del(char *name)
 int
 lstcon_group_clean(char *name, int args)
 {
-        lstcon_group_t *grp = NULL;
-        int             rc;
+       struct lstcon_group *grp = NULL;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -641,7 +626,7 @@ lstcon_group_clean(char *name, int args)
         if (grp->grp_ref > 2) {
                 /* referred by test */
                 CDEBUG(D_NET, "Group %s is busy\n", name);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return -EBUSY;
         }
 
@@ -650,21 +635,21 @@ lstcon_group_clean(char *name, int args)
 
         lstcon_group_drain(grp, args);
 
-       lstcon_group_put(grp);
+       lstcon_group_decref(grp);
        /* release empty group */
        if (list_empty(&grp->grp_ndl_list))
-               lstcon_group_put(grp);
+               lstcon_group_decref(grp);
 
        return 0;
 }
 
 int
 lstcon_nodes_remove(char *name, int count,
-                   lnet_process_id_t __user *ids_up,
+                   struct lnet_process_id __user *ids_up,
                    struct list_head __user *result_up)
 {
-        lstcon_group_t *grp = NULL;
-        int             rc;
+       struct lstcon_group *grp = NULL;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -675,16 +660,16 @@ lstcon_nodes_remove(char *name, int count,
         if (grp->grp_ref > 2) {
                 /* referred by test */
                 CDEBUG(D_NET, "Group %s is busy\n", name);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return -EBUSY;
         }
 
         rc = lstcon_group_nodes_remove(grp, count, ids_up, result_up);
 
-       lstcon_group_put(grp);
+       lstcon_group_decref(grp);
        /* release empty group */
        if (list_empty(&grp->grp_ndl_list))
-               lstcon_group_put(grp);
+               lstcon_group_decref(grp);
 
        return rc;
 }
@@ -692,9 +677,9 @@ lstcon_nodes_remove(char *name, int count,
 int
 lstcon_group_refresh(char *name, struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t      *trans;
-        lstcon_group_t          *grp;
-        int                      rc;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -705,7 +690,7 @@ lstcon_group_refresh(char *name, struct list_head __user *result_up)
         if (grp->grp_ref > 2) {
                 /* referred by test */
                 CDEBUG(D_NET, "Group %s is busy\n", name);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return -EBUSY;
         }
 
@@ -716,7 +701,7 @@ lstcon_group_refresh(char *name, struct list_head __user *result_up)
         if (rc != 0) {
                 /* local error, return */
                 CDEBUG(D_NET, "Can't create transaction: %d\n", rc);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return rc;
         }
 
@@ -726,7 +711,7 @@ lstcon_group_refresh(char *name, struct list_head __user *result_up)
 
         lstcon_rpc_trans_destroy(trans);
         /* -ref for me */
-        lstcon_group_put(grp);
+       lstcon_group_decref(grp);
 
         return rc;
 }
@@ -734,7 +719,7 @@ lstcon_group_refresh(char *name, struct list_head __user *result_up)
 int
 lstcon_group_list(int index, int len, char __user *name_up)
 {
-       lstcon_group_t *grp;
+       struct lstcon_group *grp;
 
        LASSERT(index >= 0);
        LASSERT(name_up != NULL);
@@ -751,12 +736,12 @@ lstcon_group_list(int index, int len, char __user *name_up)
 
 static int
 lstcon_nodes_getent(struct list_head *head, int *index_p,
-                   int *count_p, lstcon_node_ent_t __user *dents_up)
+                   int *count_p, struct lstcon_node_ent __user *dents_up)
 {
-        lstcon_ndlink_t  *ndl;
-        lstcon_node_t    *nd;
-        int               count = 0;
-        int               index = 0;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_node *nd;
+       int count = 0;
+       int index = 0;
 
        LASSERT(index_p != NULL && count_p != NULL);
        LASSERT(dents_up != NULL);
@@ -790,14 +775,14 @@ lstcon_nodes_getent(struct list_head *head, int *index_p,
 }
 
 int
-lstcon_group_info(char *name, lstcon_ndlist_ent_t __user *gents_p,
+lstcon_group_info(char *name, struct lstcon_ndlist_ent __user *gents_p,
                  int *index_p, int *count_p,
-                 lstcon_node_ent_t __user *dents_up)
+                 struct lstcon_node_ent __user *dents_up)
 {
-        lstcon_ndlist_ent_t *gentp;
-        lstcon_group_t      *grp;
-        lstcon_ndlink_t     *ndl;
-        int                  rc;
+       struct lstcon_ndlist_ent *gentp;
+       struct lstcon_group *grp;
+       struct lstcon_ndlink *ndl;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -809,39 +794,37 @@ lstcon_group_info(char *name, lstcon_ndlist_ent_t __user *gents_p,
                 /* verbose query */
                 rc = lstcon_nodes_getent(&grp->grp_ndl_list,
                                          index_p, count_p, dents_up);
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
 
                 return rc;
         }
 
         /* non-verbose query */
-        LIBCFS_ALLOC(gentp, sizeof(lstcon_ndlist_ent_t));
+       CFS_ALLOC_PTR(gentp);
         if (gentp == NULL) {
                 CERROR("Can't allocate ndlist_ent\n");
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
 
                 return -ENOMEM;
         }
 
-       memset(gentp, 0, sizeof(lstcon_ndlist_ent_t));
-
        list_for_each_entry(ndl, &grp->grp_ndl_list, ndl_link)
                 LST_NODE_STATE_COUNTER(ndl->ndl_node, gentp);
 
        rc = copy_to_user(gents_p, gentp,
-                         sizeof(lstcon_ndlist_ent_t)) ? -EFAULT : 0;
+                         sizeof(struct lstcon_ndlist_ent)) ? -EFAULT : 0;
 
-       LIBCFS_FREE(gentp, sizeof(lstcon_ndlist_ent_t));
+       CFS_FREE_PTR(gentp);
 
-       lstcon_group_put(grp);
+       lstcon_group_decref(grp);
 
        return 0;
 }
 
 static int
-lstcon_batch_find(const char *name, lstcon_batch_t **batpp)
+lstcon_batch_find(const char *name, struct lstcon_batch **batpp)
 {
-       lstcon_batch_t *bat;
+       struct lstcon_batch *bat;
 
        list_for_each_entry(bat, &console_session.ses_bat_list, bat_link) {
                if (strncmp(bat->bat_name, name, LST_NAME_SIZE) == 0) {
@@ -856,9 +839,9 @@ lstcon_batch_find(const char *name, lstcon_batch_t **batpp)
 int
 lstcon_batch_add(char *name)
 {
-        lstcon_batch_t   *bat;
-        int               i;
-        int               rc;
+       struct lstcon_batch *bat;
+       int i;
+       int rc;
 
         rc = (lstcon_batch_find(name, &bat) == 0)? -EEXIST: 0;
         if (rc != 0) {
@@ -866,17 +849,17 @@ lstcon_batch_add(char *name)
                 return rc;
         }
 
-        LIBCFS_ALLOC(bat, sizeof(lstcon_batch_t));
+       LIBCFS_ALLOC(bat, sizeof(*bat));
         if (bat == NULL) {
                 CERROR("Can't allocate descriptor for batch %s\n", name);
                 return -ENOMEM;
         }
 
-        LIBCFS_ALLOC(bat->bat_cli_hash,
+       LIBCFS_ALLOC(bat->bat_cli_hash,
                     sizeof(struct list_head) * LST_NODE_HASHSIZE);
-        if (bat->bat_cli_hash == NULL) {
-                CERROR("Can't allocate hash for batch %s\n", name);
-                LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+       if (bat->bat_cli_hash == NULL) {
+               CERROR("Can't allocate hash for batch %s\n", name);
+               LIBCFS_FREE(bat, sizeof(*bat));
 
                 return -ENOMEM;
         }
@@ -886,7 +869,7 @@ lstcon_batch_add(char *name)
         if (bat->bat_srv_hash == NULL) {
                 CERROR("Can't allocate hash for batch %s\n", name);
                 LIBCFS_FREE(bat->bat_cli_hash, LST_NODE_HASHSIZE);
-                LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+               LIBCFS_FREE(bat, sizeof(*bat));
 
                 return -ENOMEM;
         }
@@ -894,7 +877,7 @@ lstcon_batch_add(char *name)
        if (strlen(name) > sizeof(bat->bat_name)-1) {
                LIBCFS_FREE(bat->bat_srv_hash, LST_NODE_HASHSIZE);
                LIBCFS_FREE(bat->bat_cli_hash, LST_NODE_HASHSIZE);
-               LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+               LIBCFS_FREE(bat, sizeof(*bat));
                return -E2BIG;
        }
        strncpy(bat->bat_name, name, sizeof(bat->bat_name));
@@ -922,7 +905,7 @@ lstcon_batch_add(char *name)
 int
 lstcon_batch_list(int index, int len, char __user *name_up)
 {
-       lstcon_batch_t *bat;
+       struct lstcon_batch *bat;
 
        LASSERT(name_up != NULL);
        LASSERT(index >= 0);
@@ -938,17 +921,17 @@ lstcon_batch_list(int index, int len, char __user *name_up)
 }
 
 int
-lstcon_batch_info(char *name, lstcon_test_batch_ent_t __user *ent_up,
+lstcon_batch_info(char *name, struct lstcon_test_batch_ent __user *ent_up,
                  int server, int testidx, int *index_p, int *ndent_p,
-                 lstcon_node_ent_t __user *dents_up)
-{
-        lstcon_test_batch_ent_t *entp;
-       struct list_head        *clilst;
-       struct list_head        *srvlst;
-        lstcon_test_t           *test = NULL;
-        lstcon_batch_t          *bat;
-        lstcon_ndlink_t         *ndl;
-        int                      rc;
+                 struct lstcon_node_ent __user *dents_up)
+{
+       struct lstcon_test_batch_ent *entp;
+       struct list_head *clilst;
+       struct list_head *srvlst;
+       struct lstcon_test *test = NULL;
+       struct lstcon_batch *bat;
+       struct lstcon_ndlink *ndl;
+       int rc;
 
         rc = lstcon_batch_find(name, &bat);
         if (rc != 0) {
@@ -981,12 +964,10 @@ lstcon_batch_info(char *name, lstcon_test_batch_ent_t __user *ent_up,
         }
 
         /* non-verbose query */
-        LIBCFS_ALLOC(entp, sizeof(lstcon_test_batch_ent_t));
+       CFS_ALLOC_PTR(entp);
         if (entp == NULL)
                 return -ENOMEM;
 
-        memset(entp, 0, sizeof(lstcon_test_batch_ent_t));
-
         if (test == NULL) {
                 entp->u.tbe_batch.bae_ntest = bat->bat_ntest;
                 entp->u.tbe_batch.bae_state = bat->bat_state;
@@ -1005,15 +986,15 @@ lstcon_batch_info(char *name, lstcon_test_batch_ent_t __user *ent_up,
                LST_NODE_STATE_COUNTER(ndl->ndl_node, &entp->tbe_srv_nle);
 
        rc = copy_to_user(ent_up, entp,
-                         sizeof(lstcon_test_batch_ent_t)) ? -EFAULT : 0;
+                         sizeof(struct lstcon_test_batch_ent)) ? -EFAULT : 0;
 
-       LIBCFS_FREE(entp, sizeof(lstcon_test_batch_ent_t));
+       CFS_FREE_PTR(entp)
 
        return rc;
 }
 
 static int
-lstcon_batrpc_condition(int transop, lstcon_node_t *nd, void *arg)
+lstcon_batrpc_condition(int transop, struct lstcon_node *nd, void *arg)
 {
         switch (transop) {
         case LST_TRANS_TSBRUN:
@@ -1035,10 +1016,10 @@ lstcon_batrpc_condition(int transop, lstcon_node_t *nd, void *arg)
 }
 
 static int
-lstcon_batch_op(lstcon_batch_t *bat, int transop,
+lstcon_batch_op(struct lstcon_batch *bat, int transop,
                struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t *trans;
+       struct lstcon_rpc_trans *trans;
         int                 rc;
 
         rc = lstcon_rpc_trans_ndlist(&bat->bat_cli_list,
@@ -1061,8 +1042,8 @@ lstcon_batch_op(lstcon_batch_t *bat, int transop,
 int
 lstcon_batch_run(char *name, int timeout, struct list_head __user *result_up)
 {
-        lstcon_batch_t *bat;
-        int             rc;
+       struct lstcon_batch *bat;
+       int rc;
 
         if (lstcon_batch_find(name, &bat) != 0) {
                 CDEBUG(D_NET, "Can't find batch %s\n", name);
@@ -1083,8 +1064,8 @@ lstcon_batch_run(char *name, int timeout, struct list_head __user *result_up)
 int
 lstcon_batch_stop(char *name, int force, struct list_head __user *result_up)
 {
-        lstcon_batch_t *bat;
-        int             rc;
+       struct lstcon_batch *bat;
+       int rc;
 
         if (lstcon_batch_find(name, &bat) != 0) {
                 CDEBUG(D_NET, "Can't find batch %s\n", name);
@@ -1103,25 +1084,25 @@ lstcon_batch_stop(char *name, int force, struct list_head __user *result_up)
 }
 
 static void
-lstcon_batch_destroy(lstcon_batch_t *bat)
+lstcon_batch_destroy(struct lstcon_batch *bat)
 {
-        lstcon_ndlink_t    *ndl;
-        lstcon_test_t      *test;
-        int                 i;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_test *test;
+       int i;
 
        list_del(&bat->bat_link);
 
        while (!list_empty(&bat->bat_test_list)) {
                test = list_entry(bat->bat_test_list.next,
-                                 lstcon_test_t, tes_link);
+                                 struct lstcon_test, tes_link);
                LASSERT(list_empty(&test->tes_trans_list));
 
                list_del(&test->tes_link);
 
-               lstcon_group_put(test->tes_src_grp);
-               lstcon_group_put(test->tes_dst_grp);
+               lstcon_group_decref(test->tes_src_grp);
+               lstcon_group_decref(test->tes_dst_grp);
 
-               LIBCFS_FREE(test, offsetof(lstcon_test_t,
+               LIBCFS_FREE(test, offsetof(struct lstcon_test,
                                           tes_param[test->tes_paramlen]));
        }
 
@@ -1129,7 +1110,7 @@ lstcon_batch_destroy(lstcon_batch_t *bat)
 
        while (!list_empty(&bat->bat_cli_list)) {
                ndl = list_entry(bat->bat_cli_list.next,
-                                lstcon_ndlink_t, ndl_link);
+                                struct lstcon_ndlink, ndl_link);
                list_del_init(&ndl->ndl_link);
 
                lstcon_ndlink_release(ndl);
@@ -1137,7 +1118,7 @@ lstcon_batch_destroy(lstcon_batch_t *bat)
 
        while (!list_empty(&bat->bat_srv_list)) {
                ndl = list_entry(bat->bat_srv_list.next,
-                                lstcon_ndlink_t, ndl_link);
+                                struct lstcon_ndlink, ndl_link);
                list_del_init(&ndl->ndl_link);
 
                lstcon_ndlink_release(ndl);
@@ -1152,19 +1133,18 @@ lstcon_batch_destroy(lstcon_batch_t *bat)
                    sizeof(struct list_head) * LST_NODE_HASHSIZE);
        LIBCFS_FREE(bat->bat_srv_hash,
                    sizeof(struct list_head) * LST_NODE_HASHSIZE);
-       LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+       LIBCFS_FREE(bat, sizeof(*bat));
 }
 
 static int
-lstcon_testrpc_condition(int transop, lstcon_node_t *nd, void *arg)
+lstcon_testrpc_condition(int transop, struct lstcon_node *nd, void *arg)
 {
-       lstcon_test_t    *test;
-       lstcon_batch_t   *batch;
-       lstcon_ndlink_t  *ndl;
+       struct lstcon_test *test = arg;
+       struct lstcon_batch *batch;
+       struct lstcon_ndlink *ndl;
        struct list_head *hash;
        struct list_head *head;
 
-       test = (lstcon_test_t *)arg;
        LASSERT(test != NULL);
 
        batch = test->tes_batch;
@@ -1200,12 +1180,13 @@ lstcon_testrpc_condition(int transop, lstcon_node_t *nd, void *arg)
 }
 
 static int
-lstcon_test_nodes_add(lstcon_test_t *test, struct list_head __user *result_up)
+lstcon_test_nodes_add(struct lstcon_test *test,
+                     struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t     *trans;
-        lstcon_group_t         *grp;
-        int                     transop;
-        int                     rc;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       int transop;
+       int rc;
 
         LASSERT (test->tes_src_grp != NULL);
         LASSERT (test->tes_dst_grp != NULL);
@@ -1252,7 +1233,7 @@ again:
 }
 
 static int
-lstcon_verify_batch(const char *name, lstcon_batch_t **batch)
+lstcon_verify_batch(const char *name, struct lstcon_batch **batch)
 {
        int rc;
 
@@ -1271,10 +1252,10 @@ lstcon_verify_batch(const char *name, lstcon_batch_t **batch)
 }
 
 static int
-lstcon_verify_group(const char *name, lstcon_group_t **grp)
+lstcon_verify_group(const char *name, struct lstcon_group **grp)
 {
-       int                     rc;
-       lstcon_ndlink_t         *ndl;
+       int rc;
+       struct lstcon_ndlink *ndl;
 
        rc = lstcon_group_find(name, grp);
        if (rc != 0) {
@@ -1300,11 +1281,11 @@ lstcon_test_add(char *batch_name, int type, int loop,
                void *param, int paramlen, int *retp,
                struct list_head __user *result_up)
 {
-       lstcon_test_t    *test   = NULL;
-       int              rc;
-       lstcon_group_t   *src_grp = NULL;
-       lstcon_group_t   *dst_grp = NULL;
-       lstcon_batch_t   *batch = NULL;
+       struct lstcon_test *test = NULL;
+       int rc;
+       struct lstcon_group *src_grp = NULL;
+       struct lstcon_group *dst_grp = NULL;
+       struct lstcon_batch *batch = NULL;
 
        /*
         * verify that a batch of the given name exists, and the groups
@@ -1326,7 +1307,7 @@ lstcon_test_add(char *batch_name, int type, int loop,
        if (dst_grp->grp_userland)
                *retp = 1;
 
-       LIBCFS_ALLOC(test, offsetof(lstcon_test_t, tes_param[paramlen]));
+       LIBCFS_ALLOC(test, offsetof(struct lstcon_test, tes_param[paramlen]));
        if (!test) {
                CERROR("Can't allocate test descriptor\n");
                rc = -ENOMEM;
@@ -1334,7 +1315,6 @@ lstcon_test_add(char *batch_name, int type, int loop,
                goto out;
        }
 
-       memset(test, 0, offsetof(lstcon_test_t, tes_param[paramlen]));
        test->tes_hdr.tsb_id    = batch->bat_hdr.tsb_id;
        test->tes_batch         = batch;
        test->tes_type          = type;
@@ -1374,21 +1354,23 @@ lstcon_test_add(char *batch_name, int type, int loop,
        return rc;
 out:
        if (test != NULL)
-               LIBCFS_FREE(test, offsetof(lstcon_test_t, tes_param[paramlen]));
+               LIBCFS_FREE(test, offsetof(struct lstcon_test,
+                                          tes_param[paramlen]));
 
        if (dst_grp != NULL)
-               lstcon_group_put(dst_grp);
+               lstcon_group_decref(dst_grp);
 
        if (src_grp != NULL)
-               lstcon_group_put(src_grp);
+               lstcon_group_decref(src_grp);
 
        return rc;
 }
 
 static int
-lstcon_test_find(lstcon_batch_t *batch, int idx, lstcon_test_t **testpp)
+lstcon_test_find(struct lstcon_batch *batch, int idx,
+                struct lstcon_test **testpp)
 {
-       lstcon_test_t *test;
+       struct lstcon_test *test;
 
        list_for_each_entry(test, &batch->bat_test_list, tes_link) {
                if (idx == test->tes_hdr.tsb_index) {
@@ -1401,10 +1383,10 @@ lstcon_test_find(lstcon_batch_t *batch, int idx, lstcon_test_t **testpp)
 }
 
 static int
-lstcon_tsbrpc_readent(int transop, srpc_msg_t *msg,
-                     lstcon_rpc_ent_t __user *ent_up)
+lstcon_tsbrpc_readent(int transop, struct srpc_msg *msg,
+                     struct lstcon_rpc_ent __user *ent_up)
 {
-        srpc_batch_reply_t *rep = &msg->msg_body.bat_reply;
+       struct srpc_batch_reply *rep = &msg->msg_body.bat_reply;
 
         LASSERT (transop == LST_TRANS_TSBCLIQRY ||
                  transop == LST_TRANS_TSBSRVQRY);
@@ -1421,14 +1403,14 @@ int
 lstcon_test_batch_query(char *name, int testidx, int client,
                        int timeout, struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t *trans;
-       struct list_head   *translist;
-       struct list_head   *ndlist;
-        lstcon_tsb_hdr_t   *hdr;
-        lstcon_batch_t     *batch;
-        lstcon_test_t      *test = NULL;
-        int                 transop;
-        int                 rc;
+       struct lstcon_rpc_trans *trans;
+       struct list_head *translist;
+       struct list_head *ndlist;
+       struct lstcon_tsb_hdr *hdr;
+       struct lstcon_batch *batch;
+       struct lstcon_test *test = NULL;
+       int transop;
+       int rc;
 
         rc = lstcon_batch_find(name, &batch);
         if (rc != 0) {
@@ -1480,21 +1462,21 @@ lstcon_test_batch_query(char *name, int testidx, int client,
 }
 
 static int
-lstcon_statrpc_readent(int transop, srpc_msg_t *msg,
-                      lstcon_rpc_ent_t __user *ent_up)
+lstcon_statrpc_readent(int transop, struct srpc_msg *msg,
+                      struct lstcon_rpc_ent __user *ent_up)
 {
-       srpc_stat_reply_t *rep = &msg->msg_body.stat_reply;
-       sfw_counters_t __user  *sfwk_stat;
-       srpc_counters_t __user *srpc_stat;
-       lnet_counters_t __user *lnet_stat;
+       struct srpc_stat_reply *rep = &msg->msg_body.stat_reply;
+       struct sfw_counters __user *sfwk_stat;
+       struct srpc_counters __user *srpc_stat;
+       struct lnet_counters_common __user *lnet_stat;
 
         if (rep->str_status != 0)
                 return 0;
 
-       sfwk_stat = (sfw_counters_t __user *)&ent_up->rpe_payload[0];
-       srpc_stat = (srpc_counters_t __user *)
+       sfwk_stat = (struct sfw_counters __user *)&ent_up->rpe_payload[0];
+       srpc_stat = (struct srpc_counters __user *)
                ((char __user *)sfwk_stat + sizeof(*sfwk_stat));
-       lnet_stat = (lnet_counters_t __user *)
+       lnet_stat = (struct lnet_counters_common __user *)
                ((char __user *)srpc_stat + sizeof(*srpc_stat));
 
        if (copy_to_user(sfwk_stat, &rep->str_fw, sizeof(*sfwk_stat)) ||
@@ -1509,11 +1491,9 @@ static int
 lstcon_ndlist_stat(struct list_head *ndlist,
                   int timeout, struct list_head __user *result_up)
 {
-       struct list_head    head;
-       lstcon_rpc_trans_t *trans;
-       int                 rc;
-
-       INIT_LIST_HEAD(&head);
+       LIST_HEAD(head);
+       struct lstcon_rpc_trans *trans;
+       int rc;
 
         rc = lstcon_rpc_trans_ndlist(ndlist, &head,
                                      LST_TRANS_STATQRY, NULL, NULL, &trans);
@@ -1535,8 +1515,8 @@ int
 lstcon_group_stat(char *grp_name, int timeout,
                  struct list_head __user *result_up)
 {
-        lstcon_group_t     *grp;
-        int                 rc;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(grp_name, &grp);
         if (rc != 0) {
@@ -1546,20 +1526,20 @@ lstcon_group_stat(char *grp_name, int timeout,
 
         rc = lstcon_ndlist_stat(&grp->grp_ndl_list, timeout, result_up);
 
-        lstcon_group_put(grp);
+       lstcon_group_decref(grp);
 
         return rc;
 }
 
 int
-lstcon_nodes_stat(int count, lnet_process_id_t __user *ids_up,
+lstcon_nodes_stat(int count, struct lnet_process_id __user *ids_up,
                  int timeout, struct list_head __user *result_up)
 {
-        lstcon_ndlink_t         *ndl;
-        lstcon_group_t          *tmp;
-        lnet_process_id_t        id;
-        int                      i;
-        int                      rc;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *tmp;
+       struct lnet_process_id id;
+       int i;
+       int rc;
 
         rc = lstcon_group_alloc(NULL, &tmp);
         if (rc != 0) {
@@ -1584,13 +1564,13 @@ lstcon_nodes_stat(int count, lnet_process_id_t __user *ids_up,
         }
 
         if (rc != 0) {
-                lstcon_group_put(tmp);
+               lstcon_group_decref(tmp);
                 return rc;
         }
 
         rc = lstcon_ndlist_stat(&tmp->grp_ndl_list, timeout, result_up);
 
-        lstcon_group_put(tmp);
+       lstcon_group_decref(tmp);
 
         return rc;
 }
@@ -1600,8 +1580,8 @@ lstcon_debug_ndlist(struct list_head *ndlist,
                    struct list_head *translist,
                    int timeout, struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t *trans;
-        int                 rc;
+       struct lstcon_rpc_trans *trans;
+       int rc;
 
         rc = lstcon_rpc_trans_ndlist(ndlist, translist, LST_TRANS_SESQRY,
                                      NULL, lstcon_sesrpc_condition, &trans);
@@ -1630,8 +1610,8 @@ int
 lstcon_batch_debug(int timeout, char *name,
                   int client, struct list_head __user *result_up)
 {
-        lstcon_batch_t *bat;
-        int             rc;
+       struct lstcon_batch *bat;
+       int rc;
 
         rc = lstcon_batch_find(name, &bat);
         if (rc != 0)
@@ -1648,8 +1628,8 @@ int
 lstcon_group_debug(int timeout, char *name,
                   struct list_head __user *result_up)
 {
-        lstcon_group_t *grp;
-        int             rc;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0)
@@ -1657,21 +1637,21 @@ lstcon_group_debug(int timeout, char *name,
 
         rc = lstcon_debug_ndlist(&grp->grp_ndl_list, NULL,
                                  timeout, result_up);
-        lstcon_group_put(grp);
+       lstcon_group_decref(grp);
 
         return rc;
 }
 
 int
-lstcon_nodes_debug(int timeout,
-                  int count, lnet_process_id_t __user *ids_up,
+lstcon_nodes_debug(int timeout, int count,
+                  struct lnet_process_id __user *ids_up,
                   struct list_head __user *result_up)
 {
-        lnet_process_id_t  id;
-        lstcon_ndlink_t   *ndl;
-        lstcon_group_t    *grp;
-        int                i;
-        int                rc;
+       struct lnet_process_id id;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *grp;
+       int i;
+       int rc;
 
         rc = lstcon_group_alloc(NULL, &grp);
         if (rc != 0) {
@@ -1694,40 +1674,40 @@ lstcon_nodes_debug(int timeout,
         }
 
         if (rc != 0) {
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
                 return rc;
         }
 
         rc = lstcon_debug_ndlist(&grp->grp_ndl_list, NULL,
                                  timeout, result_up);
 
-        lstcon_group_put(grp);
+       lstcon_group_decref(grp);
 
         return rc;
 }
 
 int
-lstcon_session_match(lst_sid_t sid)
+lstcon_session_match(struct lst_sid sid)
 {
         return (console_session.ses_id.ses_nid   == sid.ses_nid &&
                 console_session.ses_id.ses_stamp == sid.ses_stamp) ?  1: 0;
 }
 
 static void
-lstcon_new_session_id(lst_sid_t *sid)
+lstcon_new_session_id(struct lst_sid *sid)
 {
-        lnet_process_id_t      id;
+       struct lnet_process_id id;
 
-        LASSERT (console_session.ses_state == LST_SESSION_NONE);
+       LASSERT(console_session.ses_state == LST_SESSION_NONE);
 
-        LNetGetId(1, &id);
-        sid->ses_nid   = id.nid;
-        sid->ses_stamp = cfs_time_current();
+       LNetGetId(1, &id);
+       sid->ses_nid = id.nid;
+       sid->ses_stamp = div_u64(ktime_get_ns(), NSEC_PER_MSEC);
 }
 
 int
 lstcon_session_new(char *name, int key, unsigned feats,
-                  int timeout, int force, lst_sid_t __user *sid_up)
+                  int timeout, int force, struct lst_sid __user *sid_up)
 {
         int     rc = 0;
         int     i;
@@ -1777,7 +1757,7 @@ lstcon_session_new(char *name, int key, unsigned feats,
 
         rc = lstcon_rpc_pinger_start();
         if (rc != 0) {
-                lstcon_batch_t *bat = NULL;
+               struct lstcon_batch *bat = NULL;
 
                 lstcon_batch_find(LST_DEFAULT_BATCH, &bat);
                 lstcon_batch_destroy(bat);
@@ -1786,7 +1766,7 @@ lstcon_session_new(char *name, int key, unsigned feats,
         }
 
        if (copy_to_user(sid_up, &console_session.ses_id,
-                             sizeof(lst_sid_t)) == 0)
+                            sizeof(struct lst_sid)) == 0)
                 return rc;
 
         lstcon_session_end();
@@ -1795,14 +1775,14 @@ lstcon_session_new(char *name, int key, unsigned feats,
 }
 
 int
-lstcon_session_info(lst_sid_t __user *sid_up, int __user *key_up,
+lstcon_session_info(struct lst_sid __user *sid_up, int __user *key_up,
                    unsigned __user *featp,
-                   lstcon_ndlist_ent_t __user *ndinfo_up,
+                   struct lstcon_ndlist_ent __user *ndinfo_up,
                    char __user *name_up, int len)
 {
-        lstcon_ndlist_ent_t *entp;
-        lstcon_ndlink_t     *ndl;
-        int                  rc = 0;
+       struct lstcon_ndlist_ent *entp;
+       struct lstcon_ndlink *ndl;
+       int rc = 0;
 
         if (console_session.ses_state != LST_SESSION_ACTIVE)
                 return -ESRCH;
@@ -1811,13 +1791,11 @@ lstcon_session_info(lst_sid_t __user *sid_up, int __user *key_up,
         if (entp == NULL)
                 return -ENOMEM;
 
-        memset(entp, 0, sizeof(*entp));
-
        list_for_each_entry(ndl, &console_session.ses_ndl_list, ndl_link)
                LST_NODE_STATE_COUNTER(ndl->ndl_node, entp);
 
        if (copy_to_user(sid_up, &console_session.ses_id,
-                             sizeof(lst_sid_t)) ||
+                        sizeof(struct lst_sid)) ||
            copy_to_user(key_up, &console_session.ses_key,
                             sizeof(*key_up)) ||
            copy_to_user(featp, &console_session.ses_features,
@@ -1832,12 +1810,12 @@ lstcon_session_info(lst_sid_t __user *sid_up, int __user *key_up,
 }
 
 int
-lstcon_session_end()
+lstcon_session_end(void)
 {
-        lstcon_rpc_trans_t *trans;
-        lstcon_group_t     *grp;
-        lstcon_batch_t     *bat;
-        int                 rc = 0;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       struct lstcon_batch *bat;
+       int rc = 0;
 
         LASSERT (console_session.ses_state == LST_SESSION_ACTIVE);
 
@@ -1870,7 +1848,7 @@ lstcon_session_end()
        /* destroy all batches */
        while (!list_empty(&console_session.ses_bat_list)) {
                bat = list_entry(console_session.ses_bat_list.next,
-                                lstcon_batch_t, bat_link);
+                                struct lstcon_batch, bat_link);
 
                lstcon_batch_destroy(bat);
        }
@@ -1878,10 +1856,10 @@ lstcon_session_end()
        /* destroy all groups */
        while (!list_empty(&console_session.ses_grp_list)) {
                grp = list_entry(console_session.ses_grp_list.next,
-                                lstcon_group_t, grp_link);
+                                struct lstcon_group, grp_link);
                LASSERT(grp->grp_ref == 1);
 
-               lstcon_group_put(grp);
+               lstcon_group_decref(grp);
        }
 
        /* all nodes should be released */
@@ -1926,15 +1904,15 @@ lstcon_session_feats_check(unsigned feats)
 }
 
 static int
-lstcon_acceptor_handle (srpc_server_rpc_t *rpc)
-{
-        srpc_msg_t        *rep  = &rpc->srpc_replymsg;
-        srpc_msg_t        *req  = &rpc->srpc_reqstbuf->buf_msg;
-        srpc_join_reqst_t *jreq = &req->msg_body.join_reqst;
-        srpc_join_reply_t *jrep = &rep->msg_body.join_reply;
-        lstcon_group_t    *grp  = NULL;
-        lstcon_ndlink_t   *ndl;
-        int                rc   = 0;
+lstcon_acceptor_handle(struct srpc_server_rpc *rpc)
+{
+       struct srpc_msg *rep = &rpc->srpc_replymsg;
+       struct srpc_msg *req = &rpc->srpc_reqstbuf->buf_msg;
+       struct srpc_join_reqst *jreq = &req->msg_body.join_reqst;
+       struct srpc_join_reply *jrep = &rep->msg_body.join_reply;
+       struct lstcon_group *grp = NULL;
+       struct lstcon_ndlink *ndl;
+       int rc = 0;
 
         sfw_unpack_message(req);
 
@@ -2002,14 +1980,15 @@ lstcon_acceptor_handle (srpc_server_rpc_t *rpc)
 out:
        rep->msg_ses_feats = console_session.ses_features;
         if (grp != NULL)
-                lstcon_group_put(grp);
+               lstcon_group_decref(grp);
 
        mutex_unlock(&console_session.ses_mutex);
 
         return rc;
 }
 
-static srpc_service_t lstcon_acceptor_service;
+static struct srpc_service lstcon_acceptor_service;
+
 static void lstcon_init_acceptor_service(void)
 {
         /* initialize selftest console acceptor service table */
@@ -2019,9 +1998,9 @@ static void lstcon_init_acceptor_service(void)
        lstcon_acceptor_service.sv_wi_total = SFW_FRWK_WI_MAX;
 }
 
-int lstcon_ioctl_entry(unsigned int cmd, struct libcfs_ioctl_hdr *hdr);
-
-DECLARE_IOCTL_HANDLER(lstcon_ioctl_handler, lstcon_ioctl_entry);
+static struct notifier_block lstcon_ioctl_handler = {
+       .notifier_call = lstcon_ioctl_entry,
+};
 
 /* initialize console */
 int
@@ -2030,8 +2009,6 @@ lstcon_console_init(void)
         int     i;
         int     rc;
 
-        memset(&console_session, 0, sizeof(lstcon_session_t));
-
        console_session.ses_id              = LST_INVALID_SID;
        console_session.ses_state           = LST_SESSION_NONE;
        console_session.ses_timeout         = 0;
@@ -2039,7 +2016,7 @@ lstcon_console_init(void)
        console_session.ses_expired         = 0;
        console_session.ses_feats_updated   = 0;
        console_session.ses_features        = LST_FEATS_MASK;
-       console_session.ses_laststamp       = cfs_time_current_sec();
+       console_session.ses_laststamp = ktime_get_real_seconds();
 
        mutex_init(&console_session.ses_mutex);
 
@@ -2075,12 +2052,12 @@ lstcon_console_init(void)
                 goto out;
         }
 
-        rc = libcfs_register_ioctl(&lstcon_ioctl_handler);
-
-        if (rc == 0) {
-                lstcon_rpc_module_init();
-                return 0;
-        }
+       rc = blocking_notifier_chain_register(&libcfs_ioctl_list,
+                                             &lstcon_ioctl_handler);
+       if (rc == 0) {
+               lstcon_rpc_module_init();
+               return 0;
+       }
 
 out:
        srpc_shutdown_service(&lstcon_acceptor_service);
@@ -2097,9 +2074,10 @@ out:
 int
 lstcon_console_fini(void)
 {
-        int     i;
+       int i;
 
-        libcfs_deregister_ioctl(&lstcon_ioctl_handler);
+       blocking_notifier_chain_unregister(&libcfs_ioctl_list,
+                                          &lstcon_ioctl_handler);
 
        mutex_lock(&console_session.ses_mutex);