Whamcloud - gitweb
LU-6142 selftest: remove typedefs from lnet selftest
[fs/lustre-release.git] / lnet / selftest / console.c
index f2cf0a4..48b980d 100644 (file)
@@ -55,10 +55,10 @@ do {                                                    \
         (p)->nle_nnode ++;                              \
 } while (0)
 
-lstcon_session_t        console_session;
+struct lstcon_session console_session;
 
 static void
-lstcon_node_get(lstcon_node_t *nd)
+lstcon_node_get(struct lstcon_node *nd)
 {
         LASSERT (nd->nd_ref >= 1);
 
@@ -66,10 +66,11 @@ lstcon_node_get(lstcon_node_t *nd)
 }
 
 static int
-lstcon_node_find(struct lnet_process_id id, lstcon_node_t **ndpp, int create)
+lstcon_node_find(struct lnet_process_id id, struct lstcon_node **ndpp,
+                int create)
 {
-       lstcon_ndlink_t *ndl;
-       unsigned int     idx = LNET_NIDADDR(id.nid) % LST_GLOBAL_HASHSIZE;
+       struct lstcon_ndlink *ndl;
+       unsigned int idx = LNET_NIDADDR(id.nid) % LST_GLOBAL_HASHSIZE;
 
        LASSERT(id.nid != LNET_NID_ANY);
 
@@ -87,11 +88,11 @@ lstcon_node_find(struct lnet_process_id id, lstcon_node_t **ndpp, int create)
         if (!create)
                 return -ENOENT;
 
-        LIBCFS_ALLOC(*ndpp, sizeof(lstcon_node_t) + sizeof(lstcon_ndlink_t));
-        if (*ndpp == NULL)
-                return -ENOMEM;
+       LIBCFS_ALLOC(*ndpp, sizeof(**ndpp) + sizeof(*ndl));
+       if (*ndpp == NULL)
+               return -ENOMEM;
 
-        ndl = (lstcon_ndlink_t *)(*ndpp + 1);
+       ndl = (struct lstcon_ndlink *)(*ndpp + 1);
 
         ndl->ndl_node = *ndpp;
 
@@ -100,7 +101,7 @@ lstcon_node_find(struct lnet_process_id id, lstcon_node_t **ndpp, int create)
         ndl->ndl_node->nd_stamp = cfs_time_current();
         ndl->ndl_node->nd_state = LST_NODE_UNKNOWN;
         ndl->ndl_node->nd_timeout = 0;
-        memset(&ndl->ndl_node->nd_ping, 0, sizeof(lstcon_rpc_t));
+       memset(&ndl->ndl_node->nd_ping, 0, sizeof(ndl->ndl_node->nd_ping));
 
        /* queued in global hash & list, no refcount is taken by
         * global hash & list, if caller release his refcount,
@@ -112,16 +113,16 @@ lstcon_node_find(struct lnet_process_id id, lstcon_node_t **ndpp, int create)
 }
 
 static void
-lstcon_node_put(lstcon_node_t *nd)
+lstcon_node_put(struct lstcon_node *nd)
 {
-       lstcon_ndlink_t *ndl;
+       struct lstcon_ndlink *ndl;
 
        LASSERT(nd->nd_ref > 0);
 
        if (--nd->nd_ref > 0)
                return;
 
-       ndl = (lstcon_ndlink_t *)(nd + 1);
+       ndl = (struct lstcon_ndlink *)(nd + 1);
 
        LASSERT(!list_empty(&ndl->ndl_link));
        LASSERT(!list_empty(&ndl->ndl_hlink));
@@ -130,17 +131,17 @@ lstcon_node_put(lstcon_node_t *nd)
        list_del(&ndl->ndl_link);
        list_del(&ndl->ndl_hlink);
 
-       LIBCFS_FREE(nd, sizeof(lstcon_node_t) + sizeof(lstcon_ndlink_t));
+       LIBCFS_FREE(nd, sizeof(*nd) + sizeof(*ndl));
 }
 
 static int
 lstcon_ndlink_find(struct list_head *hash, struct lnet_process_id id,
-                  lstcon_ndlink_t **ndlpp, int create)
+                  struct lstcon_ndlink **ndlpp, int create)
 {
-       unsigned int     idx = LNET_NIDADDR(id.nid) % LST_NODE_HASHSIZE;
-       lstcon_ndlink_t *ndl;
-       lstcon_node_t   *nd;
-       int              rc;
+       unsigned int idx = LNET_NIDADDR(id.nid) % LST_NODE_HASHSIZE;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_node *nd;
+       int rc;
 
        if (id.nid == LNET_NID_ANY)
                return -EINVAL;
@@ -163,7 +164,7 @@ lstcon_ndlink_find(struct list_head *hash, struct lnet_process_id id,
         if (rc != 0)
                 return rc;
 
-        LIBCFS_ALLOC(ndl, sizeof(lstcon_ndlink_t));
+       LIBCFS_ALLOC(ndl, sizeof(*ndl));
         if (ndl == NULL) {
                 lstcon_node_put(nd);
                 return -ENOMEM;
@@ -179,7 +180,7 @@ lstcon_ndlink_find(struct list_head *hash, struct lnet_process_id id,
 }
 
 static void
-lstcon_ndlink_release(lstcon_ndlink_t *ndl)
+lstcon_ndlink_release(struct lstcon_ndlink *ndl)
 {
        LASSERT(list_empty(&ndl->ndl_link));
        LASSERT(!list_empty(&ndl->ndl_hlink));
@@ -191,12 +192,12 @@ lstcon_ndlink_release(lstcon_ndlink_t *ndl)
 }
 
 static int
-lstcon_group_alloc(char *name, lstcon_group_t **grpp)
+lstcon_group_alloc(char *name, struct lstcon_group **grpp)
 {
-       lstcon_group_t *grp;
-       int             i;
+       struct lstcon_group *grp;
+       int i;
 
-        LIBCFS_ALLOC(grp, offsetof(lstcon_group_t,
+       LIBCFS_ALLOC(grp, offsetof(struct lstcon_group,
                                    grp_ndl_hash[LST_NODE_HASHSIZE]));
         if (grp == NULL)
                 return -ENOMEM;
@@ -204,7 +205,7 @@ lstcon_group_alloc(char *name, lstcon_group_t **grpp)
         grp->grp_ref = 1;
        if (name != NULL) {
                if (strlen(name) > sizeof(grp->grp_name)-1) {
-                       LIBCFS_FREE(grp, offsetof(lstcon_group_t,
+                       LIBCFS_FREE(grp, offsetof(struct lstcon_group,
                                          grp_ndl_hash[LST_NODE_HASHSIZE]));
                        return -E2BIG;
                }
@@ -224,18 +225,19 @@ lstcon_group_alloc(char *name, lstcon_group_t **grpp)
 }
 
 static void
-lstcon_group_addref(lstcon_group_t *grp)
+lstcon_group_addref(struct lstcon_group *grp)
 {
        grp->grp_ref++;
 }
 
-static void lstcon_group_ndlink_release(lstcon_group_t *, lstcon_ndlink_t *);
+static void lstcon_group_ndlink_release(struct lstcon_group *,
+                                       struct lstcon_ndlink *);
 
 static void
-lstcon_group_drain(lstcon_group_t *grp, int keep)
+lstcon_group_drain(struct lstcon_group *grp, int keep)
 {
-       lstcon_ndlink_t *ndl;
-       lstcon_ndlink_t *tmp;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_ndlink *tmp;
 
        list_for_each_entry_safe(ndl, tmp, &grp->grp_ndl_list, ndl_link) {
                if ((ndl->ndl_node->nd_state & keep) == 0)
@@ -244,7 +246,7 @@ lstcon_group_drain(lstcon_group_t *grp, int keep)
 }
 
 static void
-lstcon_group_decref(lstcon_group_t *grp)
+lstcon_group_decref(struct lstcon_group *grp)
 {
        int i;
 
@@ -259,14 +261,14 @@ lstcon_group_decref(lstcon_group_t *grp)
        for (i = 0; i < LST_NODE_HASHSIZE; i++)
                LASSERT(list_empty(&grp->grp_ndl_hash[i]));
 
-       LIBCFS_FREE(grp, offsetof(lstcon_group_t,
+       LIBCFS_FREE(grp, offsetof(struct lstcon_group,
                                  grp_ndl_hash[LST_NODE_HASHSIZE]));
 }
 
 static int
-lstcon_group_find(const char *name, lstcon_group_t **grpp)
+lstcon_group_find(const char *name, struct lstcon_group **grpp)
 {
-       lstcon_group_t *grp;
+       struct lstcon_group *grp;
 
        list_for_each_entry(grp, &console_session.ses_grp_list, grp_link) {
                if (strncmp(grp->grp_name, name, LST_NAME_SIZE) != 0)
@@ -281,8 +283,8 @@ lstcon_group_find(const char *name, lstcon_group_t **grpp)
 }
 
 static int
-lstcon_group_ndlink_find(lstcon_group_t *grp, struct lnet_process_id id,
-                         lstcon_ndlink_t **ndlpp, int create)
+lstcon_group_ndlink_find(struct lstcon_group *grp, struct lnet_process_id id,
+                        struct lstcon_ndlink **ndlpp, int create)
 {
        int rc;
 
@@ -300,7 +302,7 @@ lstcon_group_ndlink_find(lstcon_group_t *grp, struct lnet_process_id id,
 }
 
 static void
-lstcon_group_ndlink_release(lstcon_group_t *grp, lstcon_ndlink_t *ndl)
+lstcon_group_ndlink_release(struct lstcon_group *grp, struct lstcon_ndlink *ndl)
 {
        list_del_init(&ndl->ndl_link);
        lstcon_ndlink_release(ndl);
@@ -308,8 +310,8 @@ lstcon_group_ndlink_release(lstcon_group_t *grp, lstcon_ndlink_t *ndl)
 }
 
 static void
-lstcon_group_ndlink_move(lstcon_group_t *old,
-                         lstcon_group_t *new, lstcon_ndlink_t *ndl)
+lstcon_group_ndlink_move(struct lstcon_group *old,
+                        struct lstcon_group *new, struct lstcon_ndlink *ndl)
 {
        unsigned int idx = LNET_NIDADDR(ndl->ndl_node->nd_id.nid) %
                                        LST_NODE_HASHSIZE;
@@ -326,21 +328,21 @@ lstcon_group_ndlink_move(lstcon_group_t *old,
 }
 
 static void
-lstcon_group_move(lstcon_group_t *old, lstcon_group_t *new)
+lstcon_group_move(struct lstcon_group *old, struct lstcon_group *new)
 {
-       lstcon_ndlink_t *ndl;
+       struct lstcon_ndlink *ndl;
 
        while (!list_empty(&old->grp_ndl_list)) {
                ndl = list_entry(old->grp_ndl_list.next,
-                                lstcon_ndlink_t, ndl_link);
+                                struct lstcon_ndlink, ndl_link);
                lstcon_group_ndlink_move(old, new, ndl);
        }
 }
 
 static int
-lstcon_sesrpc_condition(int transop, lstcon_node_t *nd, void *arg)
+lstcon_sesrpc_condition(int transop, struct lstcon_node *nd, void *arg)
 {
-        lstcon_group_t *grp = (lstcon_group_t *)arg;
+       struct lstcon_group *grp = arg;
 
         switch (transop) {
         case LST_TRANS_SESNEW:
@@ -367,10 +369,10 @@ lstcon_sesrpc_condition(int transop, lstcon_node_t *nd, void *arg)
 }
 
 static int
-lstcon_sesrpc_readent(int transop, srpc_msg_t *msg,
+lstcon_sesrpc_readent(int transop, struct srpc_msg *msg,
                      struct lstcon_rpc_ent __user *ent_up)
 {
-        srpc_debug_reply_t *rep;
+       struct srpc_debug_reply *rep;
 
         switch (transop) {
         case LST_TRANS_SESNEW:
@@ -396,16 +398,17 @@ lstcon_sesrpc_readent(int transop, srpc_msg_t *msg,
 }
 
 static int
-lstcon_group_nodes_add(lstcon_group_t *grp,
+lstcon_group_nodes_add(struct lstcon_group *grp,
                       int count, struct lnet_process_id __user *ids_up,
-                      unsigned *featp, struct list_head __user *result_up)
+                      unsigned int *featp,
+                      struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t      *trans;
-        lstcon_ndlink_t         *ndl;
-        lstcon_group_t          *tmp;
-       struct lnet_process_id        id;
-        int                      i;
-        int                      rc;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *tmp;
+       struct lnet_process_id id;
+       int i;
+       int rc;
 
         rc = lstcon_group_alloc(NULL, &tmp);
         if (rc != 0) {
@@ -463,16 +466,16 @@ lstcon_group_nodes_add(lstcon_group_t *grp,
 }
 
 static int
-lstcon_group_nodes_remove(lstcon_group_t *grp,
+lstcon_group_nodes_remove(struct lstcon_group *grp,
                          int count, struct lnet_process_id __user *ids_up,
                          struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t     *trans;
-        lstcon_ndlink_t        *ndl;
-        lstcon_group_t         *tmp;
-       struct lnet_process_id       id;
-        int                     rc;
-        int                     i;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *tmp;
+       struct lnet_process_id id;
+       int rc;
+       int i;
 
         /* End session and remove node from the group */
 
@@ -520,8 +523,8 @@ error:
 int
 lstcon_group_add(char *name)
 {
-        lstcon_group_t *grp;
-        int             rc;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = (lstcon_group_find(name, &grp) == 0)? -EEXIST: 0;
         if (rc != 0) {
@@ -545,7 +548,7 @@ int
 lstcon_nodes_add(char *name, int count, struct lnet_process_id __user *ids_up,
                 unsigned *featp, struct list_head __user *result_up)
 {
-        lstcon_group_t         *grp;
+       struct lstcon_group         *grp;
         int                     rc;
 
         LASSERT (count > 0);
@@ -575,9 +578,9 @@ lstcon_nodes_add(char *name, int count, struct lnet_process_id __user *ids_up,
 int
 lstcon_group_del(char *name)
 {
-        lstcon_rpc_trans_t *trans;
-        lstcon_group_t     *grp;
-        int                 rc;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -616,8 +619,8 @@ lstcon_group_del(char *name)
 int
 lstcon_group_clean(char *name, int args)
 {
-        lstcon_group_t *grp = NULL;
-        int             rc;
+       struct lstcon_group *grp = NULL;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -650,8 +653,8 @@ lstcon_nodes_remove(char *name, int count,
                    struct lnet_process_id __user *ids_up,
                    struct list_head __user *result_up)
 {
-        lstcon_group_t *grp = NULL;
-        int             rc;
+       struct lstcon_group *grp = NULL;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -679,9 +682,9 @@ lstcon_nodes_remove(char *name, int count,
 int
 lstcon_group_refresh(char *name, struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t      *trans;
-        lstcon_group_t          *grp;
-        int                      rc;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -721,7 +724,7 @@ lstcon_group_refresh(char *name, struct list_head __user *result_up)
 int
 lstcon_group_list(int index, int len, char __user *name_up)
 {
-       lstcon_group_t *grp;
+       struct lstcon_group *grp;
 
        LASSERT(index >= 0);
        LASSERT(name_up != NULL);
@@ -740,10 +743,10 @@ static int
 lstcon_nodes_getent(struct list_head *head, int *index_p,
                    int *count_p, struct lstcon_node_ent __user *dents_up)
 {
-        lstcon_ndlink_t  *ndl;
-        lstcon_node_t    *nd;
-        int               count = 0;
-        int               index = 0;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_node *nd;
+       int count = 0;
+       int index = 0;
 
        LASSERT(index_p != NULL && count_p != NULL);
        LASSERT(dents_up != NULL);
@@ -782,9 +785,9 @@ lstcon_group_info(char *name, struct lstcon_ndlist_ent __user *gents_p,
                  struct lstcon_node_ent __user *dents_up)
 {
        struct lstcon_ndlist_ent *gentp;
-        lstcon_group_t      *grp;
-        lstcon_ndlink_t     *ndl;
-        int                  rc;
+       struct lstcon_group *grp;
+       struct lstcon_ndlink *ndl;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0) {
@@ -824,9 +827,9 @@ lstcon_group_info(char *name, struct lstcon_ndlist_ent __user *gents_p,
 }
 
 static int
-lstcon_batch_find(const char *name, lstcon_batch_t **batpp)
+lstcon_batch_find(const char *name, struct lstcon_batch **batpp)
 {
-       lstcon_batch_t *bat;
+       struct lstcon_batch *bat;
 
        list_for_each_entry(bat, &console_session.ses_bat_list, bat_link) {
                if (strncmp(bat->bat_name, name, LST_NAME_SIZE) == 0) {
@@ -841,9 +844,9 @@ lstcon_batch_find(const char *name, lstcon_batch_t **batpp)
 int
 lstcon_batch_add(char *name)
 {
-        lstcon_batch_t   *bat;
-        int               i;
-        int               rc;
+       struct lstcon_batch *bat;
+       int i;
+       int rc;
 
         rc = (lstcon_batch_find(name, &bat) == 0)? -EEXIST: 0;
         if (rc != 0) {
@@ -851,17 +854,17 @@ lstcon_batch_add(char *name)
                 return rc;
         }
 
-        LIBCFS_ALLOC(bat, sizeof(lstcon_batch_t));
+       LIBCFS_ALLOC(bat, sizeof(*bat));
         if (bat == NULL) {
                 CERROR("Can't allocate descriptor for batch %s\n", name);
                 return -ENOMEM;
         }
 
-        LIBCFS_ALLOC(bat->bat_cli_hash,
+       LIBCFS_ALLOC(bat->bat_cli_hash,
                     sizeof(struct list_head) * LST_NODE_HASHSIZE);
-        if (bat->bat_cli_hash == NULL) {
-                CERROR("Can't allocate hash for batch %s\n", name);
-                LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+       if (bat->bat_cli_hash == NULL) {
+               CERROR("Can't allocate hash for batch %s\n", name);
+               LIBCFS_FREE(bat, sizeof(*bat));
 
                 return -ENOMEM;
         }
@@ -871,7 +874,7 @@ lstcon_batch_add(char *name)
         if (bat->bat_srv_hash == NULL) {
                 CERROR("Can't allocate hash for batch %s\n", name);
                 LIBCFS_FREE(bat->bat_cli_hash, LST_NODE_HASHSIZE);
-                LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+               LIBCFS_FREE(bat, sizeof(*bat));
 
                 return -ENOMEM;
         }
@@ -879,7 +882,7 @@ lstcon_batch_add(char *name)
        if (strlen(name) > sizeof(bat->bat_name)-1) {
                LIBCFS_FREE(bat->bat_srv_hash, LST_NODE_HASHSIZE);
                LIBCFS_FREE(bat->bat_cli_hash, LST_NODE_HASHSIZE);
-               LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+               LIBCFS_FREE(bat, sizeof(*bat));
                return -E2BIG;
        }
        strncpy(bat->bat_name, name, sizeof(bat->bat_name));
@@ -907,7 +910,7 @@ lstcon_batch_add(char *name)
 int
 lstcon_batch_list(int index, int len, char __user *name_up)
 {
-       lstcon_batch_t *bat;
+       struct lstcon_batch *bat;
 
        LASSERT(name_up != NULL);
        LASSERT(index >= 0);
@@ -928,12 +931,12 @@ lstcon_batch_info(char *name, struct lstcon_test_batch_ent __user *ent_up,
                  struct lstcon_node_ent __user *dents_up)
 {
        struct lstcon_test_batch_ent *entp;
-       struct list_head        *clilst;
-       struct list_head        *srvlst;
-        lstcon_test_t           *test = NULL;
-        lstcon_batch_t          *bat;
-        lstcon_ndlink_t         *ndl;
-        int                      rc;
+       struct list_head *clilst;
+       struct list_head *srvlst;
+       struct lstcon_test *test = NULL;
+       struct lstcon_batch *bat;
+       struct lstcon_ndlink *ndl;
+       int rc;
 
         rc = lstcon_batch_find(name, &bat);
         if (rc != 0) {
@@ -996,7 +999,7 @@ lstcon_batch_info(char *name, struct lstcon_test_batch_ent __user *ent_up,
 }
 
 static int
-lstcon_batrpc_condition(int transop, lstcon_node_t *nd, void *arg)
+lstcon_batrpc_condition(int transop, struct lstcon_node *nd, void *arg)
 {
         switch (transop) {
         case LST_TRANS_TSBRUN:
@@ -1018,10 +1021,10 @@ lstcon_batrpc_condition(int transop, lstcon_node_t *nd, void *arg)
 }
 
 static int
-lstcon_batch_op(lstcon_batch_t *bat, int transop,
+lstcon_batch_op(struct lstcon_batch *bat, int transop,
                struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t *trans;
+       struct lstcon_rpc_trans *trans;
         int                 rc;
 
         rc = lstcon_rpc_trans_ndlist(&bat->bat_cli_list,
@@ -1044,8 +1047,8 @@ lstcon_batch_op(lstcon_batch_t *bat, int transop,
 int
 lstcon_batch_run(char *name, int timeout, struct list_head __user *result_up)
 {
-        lstcon_batch_t *bat;
-        int             rc;
+       struct lstcon_batch *bat;
+       int rc;
 
         if (lstcon_batch_find(name, &bat) != 0) {
                 CDEBUG(D_NET, "Can't find batch %s\n", name);
@@ -1066,8 +1069,8 @@ lstcon_batch_run(char *name, int timeout, struct list_head __user *result_up)
 int
 lstcon_batch_stop(char *name, int force, struct list_head __user *result_up)
 {
-        lstcon_batch_t *bat;
-        int             rc;
+       struct lstcon_batch *bat;
+       int rc;
 
         if (lstcon_batch_find(name, &bat) != 0) {
                 CDEBUG(D_NET, "Can't find batch %s\n", name);
@@ -1086,17 +1089,17 @@ lstcon_batch_stop(char *name, int force, struct list_head __user *result_up)
 }
 
 static void
-lstcon_batch_destroy(lstcon_batch_t *bat)
+lstcon_batch_destroy(struct lstcon_batch *bat)
 {
-        lstcon_ndlink_t    *ndl;
-        lstcon_test_t      *test;
-        int                 i;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_test *test;
+       int i;
 
        list_del(&bat->bat_link);
 
        while (!list_empty(&bat->bat_test_list)) {
                test = list_entry(bat->bat_test_list.next,
-                                 lstcon_test_t, tes_link);
+                                 struct lstcon_test, tes_link);
                LASSERT(list_empty(&test->tes_trans_list));
 
                list_del(&test->tes_link);
@@ -1104,7 +1107,7 @@ lstcon_batch_destroy(lstcon_batch_t *bat)
                lstcon_group_decref(test->tes_src_grp);
                lstcon_group_decref(test->tes_dst_grp);
 
-               LIBCFS_FREE(test, offsetof(lstcon_test_t,
+               LIBCFS_FREE(test, offsetof(struct lstcon_test,
                                           tes_param[test->tes_paramlen]));
        }
 
@@ -1112,7 +1115,7 @@ lstcon_batch_destroy(lstcon_batch_t *bat)
 
        while (!list_empty(&bat->bat_cli_list)) {
                ndl = list_entry(bat->bat_cli_list.next,
-                                lstcon_ndlink_t, ndl_link);
+                                struct lstcon_ndlink, ndl_link);
                list_del_init(&ndl->ndl_link);
 
                lstcon_ndlink_release(ndl);
@@ -1120,7 +1123,7 @@ lstcon_batch_destroy(lstcon_batch_t *bat)
 
        while (!list_empty(&bat->bat_srv_list)) {
                ndl = list_entry(bat->bat_srv_list.next,
-                                lstcon_ndlink_t, ndl_link);
+                                struct lstcon_ndlink, ndl_link);
                list_del_init(&ndl->ndl_link);
 
                lstcon_ndlink_release(ndl);
@@ -1135,19 +1138,18 @@ lstcon_batch_destroy(lstcon_batch_t *bat)
                    sizeof(struct list_head) * LST_NODE_HASHSIZE);
        LIBCFS_FREE(bat->bat_srv_hash,
                    sizeof(struct list_head) * LST_NODE_HASHSIZE);
-       LIBCFS_FREE(bat, sizeof(lstcon_batch_t));
+       LIBCFS_FREE(bat, sizeof(*bat));
 }
 
 static int
-lstcon_testrpc_condition(int transop, lstcon_node_t *nd, void *arg)
+lstcon_testrpc_condition(int transop, struct lstcon_node *nd, void *arg)
 {
-       lstcon_test_t    *test;
-       lstcon_batch_t   *batch;
-       lstcon_ndlink_t  *ndl;
+       struct lstcon_test *test = arg;
+       struct lstcon_batch *batch;
+       struct lstcon_ndlink *ndl;
        struct list_head *hash;
        struct list_head *head;
 
-       test = (lstcon_test_t *)arg;
        LASSERT(test != NULL);
 
        batch = test->tes_batch;
@@ -1183,12 +1185,13 @@ lstcon_testrpc_condition(int transop, lstcon_node_t *nd, void *arg)
 }
 
 static int
-lstcon_test_nodes_add(lstcon_test_t *test, struct list_head __user *result_up)
+lstcon_test_nodes_add(struct lstcon_test *test,
+                     struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t     *trans;
-        lstcon_group_t         *grp;
-        int                     transop;
-        int                     rc;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       int transop;
+       int rc;
 
         LASSERT (test->tes_src_grp != NULL);
         LASSERT (test->tes_dst_grp != NULL);
@@ -1235,7 +1238,7 @@ again:
 }
 
 static int
-lstcon_verify_batch(const char *name, lstcon_batch_t **batch)
+lstcon_verify_batch(const char *name, struct lstcon_batch **batch)
 {
        int rc;
 
@@ -1254,10 +1257,10 @@ lstcon_verify_batch(const char *name, lstcon_batch_t **batch)
 }
 
 static int
-lstcon_verify_group(const char *name, lstcon_group_t **grp)
+lstcon_verify_group(const char *name, struct lstcon_group **grp)
 {
-       int                     rc;
-       lstcon_ndlink_t         *ndl;
+       int rc;
+       struct lstcon_ndlink *ndl;
 
        rc = lstcon_group_find(name, grp);
        if (rc != 0) {
@@ -1283,11 +1286,11 @@ lstcon_test_add(char *batch_name, int type, int loop,
                void *param, int paramlen, int *retp,
                struct list_head __user *result_up)
 {
-       lstcon_test_t    *test   = NULL;
-       int              rc;
-       lstcon_group_t   *src_grp = NULL;
-       lstcon_group_t   *dst_grp = NULL;
-       lstcon_batch_t   *batch = NULL;
+       struct lstcon_test *test = NULL;
+       int rc;
+       struct lstcon_group *src_grp = NULL;
+       struct lstcon_group *dst_grp = NULL;
+       struct lstcon_batch *batch = NULL;
 
        /*
         * verify that a batch of the given name exists, and the groups
@@ -1309,7 +1312,7 @@ lstcon_test_add(char *batch_name, int type, int loop,
        if (dst_grp->grp_userland)
                *retp = 1;
 
-       LIBCFS_ALLOC(test, offsetof(lstcon_test_t, tes_param[paramlen]));
+       LIBCFS_ALLOC(test, offsetof(struct lstcon_test, tes_param[paramlen]));
        if (!test) {
                CERROR("Can't allocate test descriptor\n");
                rc = -ENOMEM;
@@ -1356,7 +1359,8 @@ lstcon_test_add(char *batch_name, int type, int loop,
        return rc;
 out:
        if (test != NULL)
-               LIBCFS_FREE(test, offsetof(lstcon_test_t, tes_param[paramlen]));
+               LIBCFS_FREE(test, offsetof(struct lstcon_test,
+                                          tes_param[paramlen]));
 
        if (dst_grp != NULL)
                lstcon_group_decref(dst_grp);
@@ -1368,9 +1372,10 @@ out:
 }
 
 static int
-lstcon_test_find(lstcon_batch_t *batch, int idx, lstcon_test_t **testpp)
+lstcon_test_find(struct lstcon_batch *batch, int idx,
+                struct lstcon_test **testpp)
 {
-       lstcon_test_t *test;
+       struct lstcon_test *test;
 
        list_for_each_entry(test, &batch->bat_test_list, tes_link) {
                if (idx == test->tes_hdr.tsb_index) {
@@ -1383,10 +1388,10 @@ lstcon_test_find(lstcon_batch_t *batch, int idx, lstcon_test_t **testpp)
 }
 
 static int
-lstcon_tsbrpc_readent(int transop, srpc_msg_t *msg,
+lstcon_tsbrpc_readent(int transop, struct srpc_msg *msg,
                      struct lstcon_rpc_ent __user *ent_up)
 {
-        srpc_batch_reply_t *rep = &msg->msg_body.bat_reply;
+       struct srpc_batch_reply *rep = &msg->msg_body.bat_reply;
 
         LASSERT (transop == LST_TRANS_TSBCLIQRY ||
                  transop == LST_TRANS_TSBSRVQRY);
@@ -1403,14 +1408,14 @@ int
 lstcon_test_batch_query(char *name, int testidx, int client,
                        int timeout, struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t *trans;
-       struct list_head   *translist;
-       struct list_head   *ndlist;
-        lstcon_tsb_hdr_t   *hdr;
-        lstcon_batch_t     *batch;
-        lstcon_test_t      *test = NULL;
-        int                 transop;
-        int                 rc;
+       struct lstcon_rpc_trans *trans;
+       struct list_head *translist;
+       struct list_head *ndlist;
+       struct lstcon_tsb_hdr *hdr;
+       struct lstcon_batch *batch;
+       struct lstcon_test *test = NULL;
+       int transop;
+       int rc;
 
         rc = lstcon_batch_find(name, &batch);
         if (rc != 0) {
@@ -1462,11 +1467,11 @@ lstcon_test_batch_query(char *name, int testidx, int client,
 }
 
 static int
-lstcon_statrpc_readent(int transop, srpc_msg_t *msg,
+lstcon_statrpc_readent(int transop, struct srpc_msg *msg,
                       struct lstcon_rpc_ent __user *ent_up)
 {
-       srpc_stat_reply_t *rep = &msg->msg_body.stat_reply;
-       struct sfw_counters __user  *sfwk_stat;
+       struct srpc_stat_reply *rep = &msg->msg_body.stat_reply;
+       struct sfw_counters __user *sfwk_stat;
        struct srpc_counters __user *srpc_stat;
        struct lnet_counters __user *lnet_stat;
 
@@ -1492,7 +1497,7 @@ lstcon_ndlist_stat(struct list_head *ndlist,
                   int timeout, struct list_head __user *result_up)
 {
        struct list_head    head;
-       lstcon_rpc_trans_t *trans;
+       struct lstcon_rpc_trans *trans;
        int                 rc;
 
        INIT_LIST_HEAD(&head);
@@ -1517,8 +1522,8 @@ int
 lstcon_group_stat(char *grp_name, int timeout,
                  struct list_head __user *result_up)
 {
-        lstcon_group_t     *grp;
-        int                 rc;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(grp_name, &grp);
         if (rc != 0) {
@@ -1537,11 +1542,11 @@ int
 lstcon_nodes_stat(int count, struct lnet_process_id __user *ids_up,
                  int timeout, struct list_head __user *result_up)
 {
-        lstcon_ndlink_t         *ndl;
-        lstcon_group_t          *tmp;
-       struct lnet_process_id        id;
-        int                      i;
-        int                      rc;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *tmp;
+       struct lnet_process_id id;
+       int i;
+       int rc;
 
         rc = lstcon_group_alloc(NULL, &tmp);
         if (rc != 0) {
@@ -1582,8 +1587,8 @@ lstcon_debug_ndlist(struct list_head *ndlist,
                    struct list_head *translist,
                    int timeout, struct list_head __user *result_up)
 {
-        lstcon_rpc_trans_t *trans;
-        int                 rc;
+       struct lstcon_rpc_trans *trans;
+       int rc;
 
         rc = lstcon_rpc_trans_ndlist(ndlist, translist, LST_TRANS_SESQRY,
                                      NULL, lstcon_sesrpc_condition, &trans);
@@ -1612,8 +1617,8 @@ int
 lstcon_batch_debug(int timeout, char *name,
                   int client, struct list_head __user *result_up)
 {
-        lstcon_batch_t *bat;
-        int             rc;
+       struct lstcon_batch *bat;
+       int rc;
 
         rc = lstcon_batch_find(name, &bat);
         if (rc != 0)
@@ -1630,8 +1635,8 @@ int
 lstcon_group_debug(int timeout, char *name,
                   struct list_head __user *result_up)
 {
-        lstcon_group_t *grp;
-        int             rc;
+       struct lstcon_group *grp;
+       int rc;
 
         rc = lstcon_group_find(name, &grp);
         if (rc != 0)
@@ -1645,15 +1650,15 @@ lstcon_group_debug(int timeout, char *name,
 }
 
 int
-lstcon_nodes_debug(int timeout,
-                  int count, struct lnet_process_id __user *ids_up,
+lstcon_nodes_debug(int timeout, int count,
+                  struct lnet_process_id __user *ids_up,
                   struct list_head __user *result_up)
 {
-       struct lnet_process_id  id;
-        lstcon_ndlink_t   *ndl;
-        lstcon_group_t    *grp;
-        int                i;
-        int                rc;
+       struct lnet_process_id id;
+       struct lstcon_ndlink *ndl;
+       struct lstcon_group *grp;
+       int i;
+       int rc;
 
         rc = lstcon_group_alloc(NULL, &grp);
         if (rc != 0) {
@@ -1759,7 +1764,7 @@ lstcon_session_new(char *name, int key, unsigned feats,
 
         rc = lstcon_rpc_pinger_start();
         if (rc != 0) {
-                lstcon_batch_t *bat = NULL;
+               struct lstcon_batch *bat = NULL;
 
                 lstcon_batch_find(LST_DEFAULT_BATCH, &bat);
                 lstcon_batch_destroy(bat);
@@ -1783,8 +1788,8 @@ lstcon_session_info(struct lst_sid __user *sid_up, int __user *key_up,
                    char __user *name_up, int len)
 {
        struct lstcon_ndlist_ent *entp;
-        lstcon_ndlink_t     *ndl;
-        int                  rc = 0;
+       struct lstcon_ndlink *ndl;
+       int rc = 0;
 
         if (console_session.ses_state != LST_SESSION_ACTIVE)
                 return -ESRCH;
@@ -1814,10 +1819,10 @@ lstcon_session_info(struct lst_sid __user *sid_up, int __user *key_up,
 int
 lstcon_session_end()
 {
-        lstcon_rpc_trans_t *trans;
-        lstcon_group_t     *grp;
-        lstcon_batch_t     *bat;
-        int                 rc = 0;
+       struct lstcon_rpc_trans *trans;
+       struct lstcon_group *grp;
+       struct lstcon_batch *bat;
+       int rc = 0;
 
         LASSERT (console_session.ses_state == LST_SESSION_ACTIVE);
 
@@ -1850,7 +1855,7 @@ lstcon_session_end()
        /* destroy all batches */
        while (!list_empty(&console_session.ses_bat_list)) {
                bat = list_entry(console_session.ses_bat_list.next,
-                                lstcon_batch_t, bat_link);
+                                struct lstcon_batch, bat_link);
 
                lstcon_batch_destroy(bat);
        }
@@ -1858,7 +1863,7 @@ lstcon_session_end()
        /* destroy all groups */
        while (!list_empty(&console_session.ses_grp_list)) {
                grp = list_entry(console_session.ses_grp_list.next,
-                                lstcon_group_t, grp_link);
+                                struct lstcon_group, grp_link);
                LASSERT(grp->grp_ref == 1);
 
                lstcon_group_decref(grp);
@@ -1906,15 +1911,15 @@ lstcon_session_feats_check(unsigned feats)
 }
 
 static int
-lstcon_acceptor_handle (srpc_server_rpc_t *rpc)
+lstcon_acceptor_handle(struct srpc_server_rpc *rpc)
 {
-        srpc_msg_t        *rep  = &rpc->srpc_replymsg;
-        srpc_msg_t        *req  = &rpc->srpc_reqstbuf->buf_msg;
-        srpc_join_reqst_t *jreq = &req->msg_body.join_reqst;
-        srpc_join_reply_t *jrep = &rep->msg_body.join_reply;
-        lstcon_group_t    *grp  = NULL;
-        lstcon_ndlink_t   *ndl;
-        int                rc   = 0;
+       struct srpc_msg *rep = &rpc->srpc_replymsg;
+       struct srpc_msg *req = &rpc->srpc_reqstbuf->buf_msg;
+       struct srpc_join_reqst *jreq = &req->msg_body.join_reqst;
+       struct srpc_join_reply *jrep = &rep->msg_body.join_reply;
+       struct lstcon_group *grp = NULL;
+       struct lstcon_ndlink *ndl;
+       int rc = 0;
 
         sfw_unpack_message(req);
 
@@ -1989,7 +1994,8 @@ out:
         return rc;
 }
 
-static srpc_service_t lstcon_acceptor_service;
+static struct srpc_service lstcon_acceptor_service;
+
 static void lstcon_init_acceptor_service(void)
 {
         /* initialize selftest console acceptor service table */
@@ -2010,8 +2016,6 @@ lstcon_console_init(void)
         int     i;
         int     rc;
 
-        memset(&console_session, 0, sizeof(lstcon_session_t));
-
        console_session.ses_id              = LST_INVALID_SID;
        console_session.ses_state           = LST_SESSION_NONE;
        console_session.ses_timeout         = 0;