Whamcloud - gitweb
LU-812 kernel: remove smp_lock.h
[fs/lustre-release.git] / lnet / selftest / conrpc.c
index a9ae420..1213ef0 100644 (file)
@@ -1,12 +1,45 @@
-/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*-
- * vim:expandtab:shiftwidth=8:tabstop=8:
- * 
- * Author: Liang Zhen <liangzhen@clusterfs.com>
+/*
+ * GPL HEADER START
  *
- * This file is part of Lustre, http://www.lustre.org
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 only,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License version 2 for more details (a copy is included
+ * in the LICENSE file that accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License
+ * version 2 along with this program; If not, see
+ * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ *
+ * GPL HEADER END
+ */
+/*
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Use is subject to license terms.
+ *
+ * Copyright (c) 2011, Whamcloud, Inc.
+ */
+/*
+ * This file is part of Lustre, http://www.lustre.org/
+ * Lustre is a trademark of Sun Microsystems, Inc.
+ *
+ * lnet/selftest/conctl.c
  *
  * Console framework rpcs
+ *
+ * Author: Liang Zhen <liang@whamcloud.com>
  */
+
 #ifdef __KERNEL__
 
 #include <libcfs/libcfs.h>
 #include "conrpc.h"
 #include "console.h"
 
-void lstcon_rpc_stat_reply(int, srpc_msg_t *,
-                           lstcon_node_t *, lstcon_trans_stat_t *);
+void lstcon_rpc_stat_reply(lstcon_rpc_trans_t *, srpc_msg_t *,
+                          lstcon_node_t *, lstcon_trans_stat_t *);
 
 static void
 lstcon_rpc_done(srpc_client_rpc_t *rpc)
 {
         lstcon_rpc_t *crpc = (lstcon_rpc_t *)rpc->crpc_priv;
 
-        LASSERT (!list_empty(&crpc->crp_link));
         LASSERT (crpc != NULL && rpc == crpc->crp_rpc);
         LASSERT (crpc->crp_posted && !crpc->crp_finished);
 
-        spin_lock(&rpc->crpc_lock);
+        cfs_spin_lock(&rpc->crpc_lock);
 
         if (crpc->crp_trans == NULL) {
-                /* orphan RPC */
-                spin_lock(&console_session.ses_rpc_lock);
-
-                /* delete from orphan rpcs list */
-                console_session.ses_rpc_pending --;
-                list_del_init(&crpc->crp_link);
-
-                spin_unlock(&console_session.ses_rpc_lock);
-
-                spin_unlock(&rpc->crpc_lock);
+                /* Orphan RPC is not in any transaction, 
+                 * I'm just a poor body and nobody loves me */
+                cfs_spin_unlock(&rpc->crpc_lock);
 
                 /* release it */
                 lstcon_rpc_put(crpc);
@@ -57,22 +82,20 @@ lstcon_rpc_done(srpc_client_rpc_t *rpc)
                 crpc->crp_status = rpc->crpc_status;
         }
 
-        /* wakeup thread waiting on the group if 
-         * it's the last rpc in the group */
-        if (atomic_dec_and_test(&crpc->crp_trans->tas_remaining))
+        /* wakeup (transaction)thread if I'm the last RPC in the transaction */
+        if (cfs_atomic_dec_and_test(&crpc->crp_trans->tas_remaining))
                 cfs_waitq_signal(&crpc->crp_trans->tas_waitq);
 
-        spin_unlock(&rpc->crpc_lock);
+        cfs_spin_unlock(&rpc->crpc_lock);
 }
 
 int
-lstcon_rpc_init(lstcon_node_t *nd, int service,
-                int npg, int cached, lstcon_rpc_t *crpc)
+lstcon_rpc_init(lstcon_node_t *nd, int service, unsigned feats,
+               int bulk_npg, int bulk_len, int embedded, lstcon_rpc_t *crpc)
 {
-
-        crpc->crp_rpc = sfw_create_rpc(nd->nd_id, service, 
-                                       npg, npg * CFS_PAGE_SIZE,
-                                       lstcon_rpc_done, (void *)crpc);
+       crpc->crp_rpc = sfw_create_rpc(nd->nd_id, service,
+                                      feats, bulk_npg, bulk_len,
+                                      lstcon_rpc_done, (void *)crpc);
         if (crpc->crp_rpc == NULL)
                 return -ENOMEM;
 
@@ -83,28 +106,30 @@ lstcon_rpc_init(lstcon_node_t *nd, int service,
         crpc->crp_unpacked = 0;
         crpc->crp_status   = 0;
         crpc->crp_stamp    = 0;
-        crpc->crp_static   = !cached;
+       crpc->crp_embedded = embedded;
         CFS_INIT_LIST_HEAD(&crpc->crp_link);
 
+        cfs_atomic_inc(&console_session.ses_rpc_counter);
+
         return 0;
 }
 
 int
-lstcon_rpc_prep(lstcon_node_t *nd, int service,
-                int npg, lstcon_rpc_t **crpcpp)
+lstcon_rpc_prep(lstcon_node_t *nd, int service, unsigned feats,
+               int bulk_npg, int bulk_len, lstcon_rpc_t **crpcpp)
 {
         lstcon_rpc_t  *crpc = NULL;
         int            rc;
 
-        spin_lock(&console_session.ses_rpc_lock);
+        cfs_spin_lock(&console_session.ses_rpc_lock);
 
-        if (!list_empty(&console_session.ses_rpc_freelist)) {
-                crpc = list_entry(console_session.ses_rpc_freelist.next,
-                                  lstcon_rpc_t, crp_link);
-                list_del(&crpc->crp_link);
+        if (!cfs_list_empty(&console_session.ses_rpc_freelist)) {
+                crpc = cfs_list_entry(console_session.ses_rpc_freelist.next,
+                                      lstcon_rpc_t, crp_link);
+                cfs_list_del_init(&crpc->crp_link);
         }
 
-        spin_unlock(&console_session.ses_rpc_lock);
+        cfs_spin_unlock(&console_session.ses_rpc_lock);
 
         if (crpc == NULL) {
                 LIBCFS_ALLOC(crpc, sizeof(*crpc));
@@ -112,7 +137,8 @@ lstcon_rpc_prep(lstcon_node_t *nd, int service,
                         return -ENOMEM;
         }
 
-        rc = lstcon_rpc_init(nd, service, npg, 1, crpc);
+       rc = lstcon_rpc_init(nd, service, feats,
+                            bulk_npg, bulk_len, 0, crpc);
         if (rc == 0) {
                 *crpcpp = crpc;
                 return 0;
@@ -129,7 +155,7 @@ lstcon_rpc_put(lstcon_rpc_t *crpc)
         srpc_bulk_t *bulk = &crpc->crp_rpc->crpc_bulk;
         int          i;
 
-        LASSERT (list_empty(&crpc->crp_link));
+        LASSERT (cfs_list_empty(&crpc->crp_link));
 
         for (i = 0; i < bulk->bk_niov; i++) {
                 if (bulk->bk_iovs[i].kiov_page == NULL)
@@ -140,17 +166,22 @@ lstcon_rpc_put(lstcon_rpc_t *crpc)
 
         srpc_client_rpc_decref(crpc->crp_rpc);
 
-        if (crpc->crp_static) {
-                memset(crpc, 0, sizeof(*crpc));
-                crpc->crp_static = 1;
-                return;
-        }
+       if (crpc->crp_embedded) {
+               /* embedded RPC, don't recycle it */
+               memset(crpc, 0, sizeof(*crpc));
+               crpc->crp_embedded = 1;
 
-        spin_lock(&console_session.ses_rpc_lock);
+        } else {
+                cfs_spin_lock(&console_session.ses_rpc_lock);
 
-        list_add(&crpc->crp_link, &console_session.ses_rpc_freelist);
+                cfs_list_add(&crpc->crp_link,
+                             &console_session.ses_rpc_freelist);
 
-        spin_unlock(&console_session.ses_rpc_lock);
+                cfs_spin_unlock(&console_session.ses_rpc_lock);
+        }
+
+        /* RPC is not alive now */
+        cfs_atomic_dec(&console_session.ses_rpc_counter);
 }
 
 void
@@ -160,7 +191,7 @@ lstcon_rpc_post(lstcon_rpc_t *crpc)
 
         LASSERT (trans != NULL);
 
-        atomic_inc(&trans->tas_remaining);
+        cfs_atomic_inc(&trans->tas_remaining);
         crpc->crp_posted = 1;
 
         sfw_post_rpc(crpc->crp_rpc);
@@ -206,13 +237,14 @@ lstcon_rpc_trans_name(int transop)
 }
 
 int
-lstcon_rpc_trans_prep(struct list_head *translist,
+lstcon_rpc_trans_prep(cfs_list_t *translist,
                       int transop, lstcon_rpc_trans_t **transpp)
 {
         lstcon_rpc_trans_t *trans;
 
         if (translist != NULL) {
-                list_for_each_entry(trans, translist, tas_link) {
+                cfs_list_for_each_entry_typed(trans, translist,
+                                              lstcon_rpc_trans_t, tas_link) {
                         /* Can't enqueue two private transaction on
                          * the same object */
                         if ((trans->tas_opc & transop) == LST_TRANS_PRIVATE)
@@ -224,29 +256,32 @@ lstcon_rpc_trans_prep(struct list_head *translist,
         LIBCFS_ALLOC(trans, sizeof(*trans));
         if (trans == NULL)
                 return -ENOMEM;
-        
+
         trans->tas_opc = transop;
 
-        if (translist == NULL)       
+       if (translist == NULL)
                 CFS_INIT_LIST_HEAD(&trans->tas_olink);
         else
-                list_add_tail(&trans->tas_olink, translist);
+                cfs_list_add_tail(&trans->tas_olink, translist);
 
-        list_add_tail(&trans->tas_link, &console_session.ses_trans_list);
+        cfs_list_add_tail(&trans->tas_link, &console_session.ses_trans_list);
 
         CFS_INIT_LIST_HEAD(&trans->tas_rpcs_list);
-        atomic_set(&trans->tas_remaining, 0);
+        cfs_atomic_set(&trans->tas_remaining, 0);
         cfs_waitq_init(&trans->tas_waitq);
 
-        *transpp = trans;
+       cfs_spin_lock(&console_session.ses_rpc_lock);
+       trans->tas_features = console_session.ses_features;
+       cfs_spin_unlock(&console_session.ses_rpc_lock);
 
-        return 0;
+       *transpp = trans;
+       return 0;
 }
 
 void
 lstcon_rpc_trans_addreq(lstcon_rpc_trans_t *trans, lstcon_rpc_t *crpc)
 {
-        list_add_tail(&crpc->crp_link, &trans->tas_rpcs_list);
+        cfs_list_add_tail(&crpc->crp_link, &trans->tas_rpcs_list);
         crpc->crp_trans = trans;
 }
 
@@ -257,21 +292,26 @@ lstcon_rpc_trans_abort(lstcon_rpc_trans_t *trans, int error)
         lstcon_rpc_t      *crpc;
         lstcon_node_t     *nd;
 
-        list_for_each_entry (crpc, &trans->tas_rpcs_list, crp_link) {
+        cfs_list_for_each_entry_typed (crpc, &trans->tas_rpcs_list,
+                                       lstcon_rpc_t, crp_link) {
                 rpc = crpc->crp_rpc;
 
-                spin_lock(&rpc->crpc_lock);
+                cfs_spin_lock(&rpc->crpc_lock);
 
-                if (!crpc->crp_posted || crpc->crp_stamp != 0) {
-                        /* rpc done or aborted already */
-                        spin_unlock(&rpc->crpc_lock);
+                if (!crpc->crp_posted || /* not posted */
+                    crpc->crp_stamp != 0) { /* rpc done or aborted already */
+                        if (crpc->crp_stamp == 0) {
+                                crpc->crp_stamp = cfs_time_current();
+                                crpc->crp_status = -EINTR;
+                        }
+                        cfs_spin_unlock(&rpc->crpc_lock);
                         continue;
                 }
 
                 crpc->crp_stamp  = cfs_time_current();
                 crpc->crp_status = error;
 
-                spin_unlock(&rpc->crpc_lock);
+                cfs_spin_unlock(&rpc->crpc_lock);
 
                 sfw_abort_rpc(rpc);
 
@@ -291,10 +331,10 @@ static int
 lstcon_rpc_trans_check(lstcon_rpc_trans_t *trans)
 {
         if (console_session.ses_shutdown &&
-            !list_empty(&trans->tas_olink)) /* It's not an end session RPC */
+            !cfs_list_empty(&trans->tas_olink)) /* Not an end session RPC */
                 return 1;
 
-        return (atomic_read(&trans->tas_remaining) == 0) ? 1: 0;
+        return (cfs_atomic_read(&trans->tas_remaining) == 0) ? 1: 0;
 }
 
 int
@@ -303,7 +343,7 @@ lstcon_rpc_trans_postwait(lstcon_rpc_trans_t *trans, int timeout)
         lstcon_rpc_t  *crpc;
         int            rc;
 
-        if (list_empty(&trans->tas_rpcs_list))
+        if (cfs_list_empty(&trans->tas_rpcs_list))
                 return 0;
 
         if (timeout < LST_TRANS_MIN_TIMEOUT)
@@ -313,26 +353,27 @@ lstcon_rpc_trans_postwait(lstcon_rpc_trans_t *trans, int timeout)
                lstcon_rpc_trans_name(trans->tas_opc));
 
         /* post all requests */
-        list_for_each_entry (crpc, &trans->tas_rpcs_list, crp_link) {
+        cfs_list_for_each_entry_typed (crpc, &trans->tas_rpcs_list,
+                                       lstcon_rpc_t, crp_link) {
                 LASSERT (!crpc->crp_posted);
 
                 lstcon_rpc_post(crpc);
         }
 
-        mutex_up(&console_session.ses_mutex);
+        cfs_mutex_unlock(&console_session.ses_mutex);
 
-        rc = wait_event_interruptible_timeout(trans->tas_waitq,
+        cfs_waitq_wait_event_interruptible_timeout(trans->tas_waitq,
                                               lstcon_rpc_trans_check(trans),
-                                              timeout * HZ);
+                                              cfs_time_seconds(timeout), rc);
 
         rc = (rc > 0)? 0: ((rc < 0)? -EINTR: -ETIMEDOUT);
 
-        mutex_down(&console_session.ses_mutex);
+        cfs_mutex_lock(&console_session.ses_mutex);
 
         if (console_session.ses_shutdown)
                 rc = -ESHUTDOWN;
 
-        if (rc != 0) {
+        if (rc != 0 || atomic_read(&trans->tas_remaining) != 0) {
                 /* treat short timeout as canceled */
                 if (rc == -ETIMEDOUT && timeout < LST_TRANS_MIN_TIMEOUT * 2)
                         rc = -EINTR;
@@ -368,7 +409,7 @@ lstcon_rpc_get_reply(lstcon_rpc_t *crpc, srpc_msg_t **msgpp)
                 sfw_unpack_message(*msgpp);
                 crpc->crp_unpacked = 1;
         }
-       
+
         if (cfs_time_after(nd->nd_stamp, crpc->crp_stamp))
                 return 0;
 
@@ -389,7 +430,6 @@ void
 lstcon_rpc_trans_stat(lstcon_rpc_trans_t *trans, lstcon_trans_stat_t *stat)
 {
         lstcon_rpc_t      *crpc;
-        srpc_client_rpc_t *rpc;
         srpc_msg_t        *rep;
         int                error;
 
@@ -397,11 +437,10 @@ lstcon_rpc_trans_stat(lstcon_rpc_trans_t *trans, lstcon_trans_stat_t *stat)
 
         memset(stat, 0, sizeof(*stat));
 
-        list_for_each_entry(crpc, &trans->tas_rpcs_list, crp_link) {
+        cfs_list_for_each_entry_typed(crpc, &trans->tas_rpcs_list,
+                                      lstcon_rpc_t, crp_link) {
                 lstcon_rpc_stat_total(stat, 1);
 
-                rpc = crpc->crp_rpc;
-
                 LASSERT (crpc->crp_stamp != 0);
 
                 error = lstcon_rpc_get_reply(crpc, &rep);
@@ -415,8 +454,12 @@ lstcon_rpc_trans_stat(lstcon_rpc_trans_t *trans, lstcon_trans_stat_t *stat)
 
                 lstcon_rpc_stat_success(stat, 1);
 
-                lstcon_rpc_stat_reply(trans->tas_opc, rep,
-                                      crpc->crp_node, stat);
+               lstcon_rpc_stat_reply(trans, rep, crpc->crp_node, stat);
+       }
+
+       if (trans->tas_opc == LST_TRANS_SESNEW && stat->trs_fwk_errno == 0) {
+               stat->trs_fwk_errno =
+                     lstcon_session_feats_check(trans->tas_features);
         }
 
         CDEBUG(D_NET, "transaction %s : success %d, failure %d, total %d, "
@@ -432,14 +475,13 @@ lstcon_rpc_trans_stat(lstcon_rpc_trans_t *trans, lstcon_trans_stat_t *stat)
 
 int
 lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
-                             struct list_head *head_up,
+                             cfs_list_t *head_up,
                              lstcon_rpc_readent_func_t readent)
 {
-        struct list_head      tmp;
-        struct list_head     *next;
+        cfs_list_t            tmp;
+        cfs_list_t           *next;
         lstcon_rpc_ent_t     *ent;
         srpc_generic_reply_t *rep;
-        srpc_client_rpc_t    *rpc;
         lstcon_rpc_t         *crpc;
         srpc_msg_t           *msg;
         lstcon_node_t        *nd;
@@ -451,8 +493,10 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
 
         next = head_up;
 
-        list_for_each_entry(crpc, &trans->tas_rpcs_list, crp_link) {
-                if (copy_from_user(&tmp, next, sizeof(struct list_head)))
+        cfs_list_for_each_entry_typed(crpc, &trans->tas_rpcs_list,
+                                      lstcon_rpc_t, crp_link) {
+                if (cfs_copy_from_user(&tmp, next,
+                                       sizeof(cfs_list_t)))
                         return -EFAULT;
 
                 if (tmp.next == head_up)
@@ -460,9 +504,7 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
 
                 next = tmp.next;
 
-                ent = list_entry(next, lstcon_rpc_ent_t, rpe_link);
-
-                rpc = crpc->crp_rpc;
+                ent = cfs_list_entry(next, lstcon_rpc_ent_t, rpe_link);
 
                 LASSERT (crpc->crp_stamp != 0);
 
@@ -470,16 +512,17 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
 
                 nd = crpc->crp_node;
 
-                dur = cfs_time_sub(crpc->crp_stamp,
-                                   console_session.ses_id.ses_stamp);
+                dur = (cfs_duration_t)cfs_time_sub(crpc->crp_stamp,
+                      (cfs_time_t)console_session.ses_id.ses_stamp);
                 cfs_duration_usec(dur, &tv);
 
-                if (copy_to_user(&ent->rpe_peer,
-                                 &nd->nd_id, sizeof(lnet_process_id_t)) ||
-                    copy_to_user(&ent->rpe_stamp, &tv, sizeof(tv)) ||
-                    copy_to_user(&ent->rpe_state,
-                                 &nd->nd_state, sizeof(nd->nd_state)) ||
-                    copy_to_user(&ent->rpe_rpc_errno, &error, sizeof(error)))
+                if (cfs_copy_to_user(&ent->rpe_peer,
+                                     &nd->nd_id, sizeof(lnet_process_id_t)) ||
+                    cfs_copy_to_user(&ent->rpe_stamp, &tv, sizeof(tv)) ||
+                    cfs_copy_to_user(&ent->rpe_state,
+                                     &nd->nd_state, sizeof(nd->nd_state)) ||
+                    cfs_copy_to_user(&ent->rpe_rpc_errno, &error,
+                                     sizeof(error)))
                         return -EFAULT;
 
                 if (error != 0)
@@ -488,10 +531,10 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
                 /* RPC is done */
                 rep = (srpc_generic_reply_t *)&msg->msg_body.reply;
 
-                if (copy_to_user(&ent->rpe_sid,
-                                 &rep->sid, sizeof(lst_sid_t)) ||
-                    copy_to_user(&ent->rpe_fwk_errno,
-                                 &rep->status, sizeof(rep->status)))
+                if (cfs_copy_to_user(&ent->rpe_sid,
+                                     &rep->sid, sizeof(lst_sid_t)) ||
+                    cfs_copy_to_user(&ent->rpe_fwk_errno,
+                                     &rep->status, sizeof(rep->status)))
                         return -EFAULT;
 
                 if (readent == NULL)
@@ -511,18 +554,19 @@ lstcon_rpc_trans_destroy(lstcon_rpc_trans_t *trans)
         lstcon_rpc_t      *crpc;
         lstcon_rpc_t      *tmp;
         int                count = 0;
-        
-        list_for_each_entry_safe(crpc, tmp,
-                                 &trans->tas_rpcs_list, crp_link) {
+
+        cfs_list_for_each_entry_safe_typed(crpc, tmp,
+                                           &trans->tas_rpcs_list,
+                                           lstcon_rpc_t, crp_link) {
                 rpc = crpc->crp_rpc;
 
-                spin_lock(&rpc->crpc_lock);
+                cfs_spin_lock(&rpc->crpc_lock);
 
                 /* free it if not posted or finished already */
                 if (!crpc->crp_posted || crpc->crp_finished) {
-                        spin_unlock(&rpc->crpc_lock);
+                        cfs_spin_unlock(&rpc->crpc_lock);
 
-                        list_del_init(&crpc->crp_link);
+                        cfs_list_del_init(&crpc->crp_link);
                         lstcon_rpc_put(crpc);
 
                         continue;
@@ -530,33 +574,26 @@ lstcon_rpc_trans_destroy(lstcon_rpc_trans_t *trans)
 
                 /* rpcs can be still not callbacked (even LNetMDUnlink is called)
                  * because huge timeout for inaccessible network, don't make
-                 * user wait for them, just put rpcs in orphan list */
+                 * user wait for them, just abandon them, they will be recycled
+                 * in callback */
 
                 LASSERT (crpc->crp_status != 0);
 
                 crpc->crp_node  = NULL;
                 crpc->crp_trans = NULL;
-                list_del(&crpc->crp_link);
-
-                spin_lock(&console_session.ses_rpc_lock);
-
+                cfs_list_del_init(&crpc->crp_link);
                 count ++;
-                /* add to orphan list */
-                console_session.ses_rpc_pending ++;
-                list_add_tail(&crpc->crp_link, &console_session.ses_rpc_list);
-
-                spin_unlock(&console_session.ses_rpc_lock);
 
-                spin_unlock(&rpc->crpc_lock);
+                cfs_spin_unlock(&rpc->crpc_lock);
 
-                atomic_dec(&trans->tas_remaining);
+                cfs_atomic_dec(&trans->tas_remaining);
         }
 
-        LASSERT (atomic_read(&trans->tas_remaining) == 0);
+        LASSERT (cfs_atomic_read(&trans->tas_remaining) == 0);
 
-        list_del(&trans->tas_link);
-        if (!list_empty(&trans->tas_olink))
-                list_del(&trans->tas_olink);
+        cfs_list_del(&trans->tas_link);
+        if (!cfs_list_empty(&trans->tas_olink))
+                cfs_list_del(&trans->tas_olink);
 
         CDEBUG(D_NET, "Transaction %s destroyed with %d pending RPCs\n",
                lstcon_rpc_trans_name(trans->tas_opc), count);
@@ -567,7 +604,8 @@ lstcon_rpc_trans_destroy(lstcon_rpc_trans_t *trans)
 }
 
 int
-lstcon_sesrpc_prep(lstcon_node_t *nd, int transop, lstcon_rpc_t **crpc)
+lstcon_sesrpc_prep(lstcon_node_t *nd, int transop,
+                  unsigned feats, lstcon_rpc_t **crpc)
 {
         srpc_mksn_reqst_t *msrq;
         srpc_rmsn_reqst_t *rsrq;
@@ -575,7 +613,8 @@ lstcon_sesrpc_prep(lstcon_node_t *nd, int transop, lstcon_rpc_t **crpc)
 
         switch (transop) {
         case LST_TRANS_SESNEW:
-                rc = lstcon_rpc_prep(nd, SRPC_SERVICE_MAKE_SESSION, 0, crpc);
+               rc = lstcon_rpc_prep(nd, SRPC_SERVICE_MAKE_SESSION,
+                                    feats, 0, 0, crpc);
                 if (rc != 0)
                         return rc;
 
@@ -587,7 +626,8 @@ lstcon_sesrpc_prep(lstcon_node_t *nd, int transop, lstcon_rpc_t **crpc)
                 break;
 
         case LST_TRANS_SESEND:
-                rc = lstcon_rpc_prep(nd, SRPC_SERVICE_REMOVE_SESSION, 0, crpc);
+               rc = lstcon_rpc_prep(nd, SRPC_SERVICE_REMOVE_SESSION,
+                                    feats, 0, 0, crpc);
                 if (rc != 0)
                         return rc;
 
@@ -603,12 +643,12 @@ lstcon_sesrpc_prep(lstcon_node_t *nd, int transop, lstcon_rpc_t **crpc)
 }
 
 int
-lstcon_dbgrpc_prep(lstcon_node_t *nd, lstcon_rpc_t **crpc)
+lstcon_dbgrpc_prep(lstcon_node_t *nd, unsigned feats, lstcon_rpc_t **crpc)
 {
-        srpc_debug_reqst_t *drq;
-        int                 rc;
+       srpc_debug_reqst_t *drq;
+       int                 rc;
 
-        rc = lstcon_rpc_prep(nd, SRPC_SERVICE_DEBUG, 0, crpc);
+       rc = lstcon_rpc_prep(nd, SRPC_SERVICE_DEBUG, feats, 0, 0, crpc);
         if (rc != 0)
                 return rc;
 
@@ -616,19 +656,19 @@ lstcon_dbgrpc_prep(lstcon_node_t *nd, lstcon_rpc_t **crpc)
 
         drq->dbg_sid   = console_session.ses_id;
         drq->dbg_flags = 0;
-        
+
         return rc;
 }
 
 int
-lstcon_batrpc_prep(lstcon_node_t *nd, int transop,
-                   lstcon_tsb_hdr_t *tsb, lstcon_rpc_t **crpc)
+lstcon_batrpc_prep(lstcon_node_t *nd, int transop, unsigned feats,
+                  lstcon_tsb_hdr_t *tsb, lstcon_rpc_t **crpc)
 {
-        lstcon_batch_t     *batch;
-        srpc_batch_reqst_t *brq;
-        int                 rc;
+       lstcon_batch_t     *batch;
+       srpc_batch_reqst_t *brq;
+       int                 rc;
 
-        rc = lstcon_rpc_prep(nd, SRPC_SERVICE_BATCH, 0, crpc);
+       rc = lstcon_rpc_prep(nd, SRPC_SERVICE_BATCH, feats, 0, 0, crpc);
         if (rc != 0)
                 return rc;
 
@@ -649,17 +689,17 @@ lstcon_batrpc_prep(lstcon_node_t *nd, int transop,
 
         batch = (lstcon_batch_t *)tsb;
         brq->bar_arg = batch->bat_arg;
-        
+
         return 0;
 }
 
 int
-lstcon_statrpc_prep(lstcon_node_t *nd, lstcon_rpc_t **crpc)
+lstcon_statrpc_prep(lstcon_node_t *nd, unsigned feats, lstcon_rpc_t **crpc)
 {
-        srpc_stat_reqst_t *srq;
-        int                rc;
+       srpc_stat_reqst_t *srq;
+       int                rc;
 
-        rc = lstcon_rpc_prep(nd, SRPC_SERVICE_QUERY_STAT, 0, crpc);
+       rc = lstcon_rpc_prep(nd, SRPC_SERVICE_QUERY_STAT, feats, 0, 0, crpc);
         if (rc != 0)
                 return rc;
 
@@ -671,31 +711,31 @@ lstcon_statrpc_prep(lstcon_node_t *nd, lstcon_rpc_t **crpc)
         return 0;
 }
 
-lnet_process_id_t *
+lnet_process_id_packed_t *
 lstcon_next_id(int idx, int nkiov, lnet_kiov_t *kiov)
 {
-        lnet_process_id_t *pid;
-        int                i;
+        lnet_process_id_packed_t *pid;
+        int                       i;
 
-        i = idx / (CFS_PAGE_SIZE / sizeof(lnet_process_id_t));
+        i = idx / SFW_ID_PER_PAGE;
         
         LASSERT (i < nkiov);
 
-        pid = (lnet_process_id_t *)cfs_page_address(kiov[i].kiov_page);
+        pid = (lnet_process_id_packed_t *)cfs_page_address(kiov[i].kiov_page);
 
-        return &pid[idx % (CFS_PAGE_SIZE / sizeof(lnet_process_id_t))];
+        return &pid[idx % SFW_ID_PER_PAGE];
 }
 
 int
 lstcon_dstnodes_prep(lstcon_group_t *grp, int idx,
                      int dist, int span, int nkiov, lnet_kiov_t *kiov)
 {
-        lnet_process_id_t *pid;
-        lstcon_ndlink_t   *ndl;
-        lstcon_node_t     *nd;
-        int                start;
-        int                end;
-        int                i = 0;
+        lnet_process_id_packed_t *pid;
+        lstcon_ndlink_t          *ndl;
+        lstcon_node_t            *nd;
+        int                       start;
+        int                       end;
+        int                       i = 0;
 
         LASSERT (dist >= 1);
         LASSERT (span >= 1);
@@ -707,7 +747,8 @@ lstcon_dstnodes_prep(lstcon_group_t *grp, int idx,
         start = ((idx / dist) * span) % grp->grp_nnode;
         end   = ((idx / dist) * span + span - 1) % grp->grp_nnode;
 
-        list_for_each_entry(ndl, &grp->grp_ndl_list, ndl_link) {
+        cfs_list_for_each_entry_typed(ndl, &grp->grp_ndl_list,
+                                      lstcon_ndlink_t, ndl_link) {
                 nd = ndl->ndl_node;
                 if (i < start) {
                         i ++;
@@ -718,20 +759,23 @@ lstcon_dstnodes_prep(lstcon_group_t *grp, int idx,
                         break;
 
                 pid = lstcon_next_id((i - start), nkiov, kiov);
-                *pid = nd->nd_id;
+                pid->nid = nd->nd_id.nid;
+                pid->pid = nd->nd_id.pid;
                 i++;
         }
 
         if (start <= end) /* done */
                 return 0;
 
-        list_for_each_entry(ndl, &grp->grp_ndl_list, ndl_link) {
+        cfs_list_for_each_entry_typed(ndl, &grp->grp_ndl_list,
+                                      lstcon_ndlink_t, ndl_link) {
                 if (i > grp->grp_nnode + end)
                         break;
 
                 nd = ndl->ndl_node;
                 pid = lstcon_next_id((i - start), nkiov, kiov);
-                *pid = nd->nd_id;
+                pid->nid = nd->nd_id.nid;
+                pid->pid = nd->nd_id.pid;
                 i++;
         }
 
@@ -742,7 +786,7 @@ int
 lstcon_pingrpc_prep(lst_test_ping_param_t *param, srpc_test_reqst_t *req)
 {
         test_ping_req_t *prq = &req->tsr_u.ping;
-        
+
         prq->png_size   = param->png_size;
         prq->png_flags  = param->png_flags;
         /* TODO dest */
@@ -750,9 +794,9 @@ lstcon_pingrpc_prep(lst_test_ping_param_t *param, srpc_test_reqst_t *req)
 }
 
 int
-lstcon_bulkrpc_prep(lst_test_bulk_param_t *param, srpc_test_reqst_t *req)
+lstcon_bulkrpc_v0_prep(lst_test_bulk_param_t *param, srpc_test_reqst_t *req)
 {
-        test_bulk_req_t *brq = &req->tsr_u.bulk;
+       test_bulk_req_t *brq = &req->tsr_u.bulk_v0;
 
         brq->blk_opc    = param->blk_opc;
         brq->blk_npg    = (param->blk_size + CFS_PAGE_SIZE - 1) / CFS_PAGE_SIZE;
@@ -762,7 +806,20 @@ lstcon_bulkrpc_prep(lst_test_bulk_param_t *param, srpc_test_reqst_t *req)
 }
 
 int
-lstcon_testrpc_prep(lstcon_node_t *nd, int transop,
+lstcon_bulkrpc_v1_prep(lst_test_bulk_param_t *param, srpc_test_reqst_t *req)
+{
+       test_bulk_req_v1_t *brq = &req->tsr_u.bulk_v1;
+
+       brq->blk_opc    = param->blk_opc;
+       brq->blk_flags  = param->blk_flags;
+       brq->blk_len    = param->blk_size;
+       brq->blk_offset = 0; /* reserved */
+
+       return 0;
+}
+
+int
+lstcon_testrpc_prep(lstcon_node_t *nd, int transop, unsigned feats,
                     lstcon_test_t *test, lstcon_rpc_t **crpc)
 {
         lstcon_group_t    *sgrp = test->tes_src_grp;
@@ -770,14 +827,19 @@ lstcon_testrpc_prep(lstcon_node_t *nd, int transop,
         srpc_test_reqst_t *trq;
         srpc_bulk_t       *bulk;
         int                i;
-        int                n  = 0;
-        int                rc = 0;
-
-        if (transop == LST_TRANS_TSBCLIADD)
-                n = sfw_id_pages(test->tes_span);
-
-        rc = lstcon_rpc_prep(nd, SRPC_SERVICE_TEST, n, crpc);
-        if (rc != 0) 
+       int                npg = 0;
+       int                nob = 0;
+       int                rc  = 0;
+
+       if (transop == LST_TRANS_TSBCLIADD) {
+               npg = sfw_id_pages(test->tes_span);
+               nob = (feats & LST_FEAT_BULK_LEN) == 0 ?
+                     npg * CFS_PAGE_SIZE :
+                     sizeof(lnet_process_id_packed_t) * test->tes_span;
+       }
+
+       rc = lstcon_rpc_prep(nd, SRPC_SERVICE_TEST, feats, npg, nob, crpc);
+       if (rc != 0)
                 return rc;
 
         trq  = &(*crpc)->crp_rpc->crpc_reqstmsg.msg_body.tes_reqst;
@@ -793,16 +855,24 @@ lstcon_testrpc_prep(lstcon_node_t *nd, int transop,
         } else {
                 bulk = &(*crpc)->crp_rpc->crpc_bulk;
 
-                for (i = 0; i < n; i++) {
-                        bulk->bk_iovs[i].kiov_offset = 0;
-                        bulk->bk_iovs[i].kiov_len    = CFS_PAGE_SIZE;
-                        bulk->bk_iovs[i].kiov_page   = cfs_alloc_page(CFS_ALLOC_STD);
+               for (i = 0; i < npg; i++) {
+                       int     len;
 
-                        if (bulk->bk_iovs[i].kiov_page != NULL) 
-                                continue;
+                       LASSERT(nob > 0);
 
-                        lstcon_rpc_put(*crpc);
-                        return -ENOMEM;
+                       len = (feats & LST_FEAT_BULK_LEN) == 0 ?
+                             CFS_PAGE_SIZE : min_t(int, nob, CFS_PAGE_SIZE);
+                       nob -= len;
+
+                       bulk->bk_iovs[i].kiov_offset = 0;
+                       bulk->bk_iovs[i].kiov_len    = len;
+                       bulk->bk_iovs[i].kiov_page   =
+                               cfs_alloc_page(CFS_ALLOC_STD);
+
+                       if (bulk->bk_iovs[i].kiov_page == NULL) {
+                               lstcon_rpc_put(*crpc);
+                               return -ENOMEM;
+                       }
                 }
 
                 bulk->bk_sink = 0;
@@ -810,8 +880,10 @@ lstcon_testrpc_prep(lstcon_node_t *nd, int transop,
                 LASSERT (transop == LST_TRANS_TSBCLIADD);
 
                 rc = lstcon_dstnodes_prep(test->tes_dst_grp,
-                                          test->tes_cliidx++, test->tes_dist,
-                                          test->tes_span, n, &bulk->bk_iovs[0]);
+                                         test->tes_cliidx++,
+                                         test->tes_dist,
+                                         test->tes_span,
+                                         npg, &bulk->bk_iovs[0]);
                 if (rc != 0) {
                         lstcon_rpc_put(*crpc);
                         return rc;
@@ -825,16 +897,25 @@ lstcon_testrpc_prep(lstcon_node_t *nd, int transop,
         trq->tsr_bid        = test->tes_hdr.tsb_id;
         trq->tsr_concur     = test->tes_concur;
         trq->tsr_is_client  = (transop == LST_TRANS_TSBCLIADD) ? 1 : 0;
-        trq->tsr_stop_onerr = test->tes_stop_onerr;
+        trq->tsr_stop_onerr = !!test->tes_stop_onerr;
 
         switch (test->tes_type) {
         case LST_TEST_PING:
                 trq->tsr_service = SRPC_SERVICE_PING;
-                rc = lstcon_pingrpc_prep((lst_test_ping_param_t *)&test->tes_param[0], trq);
-                break;
-        case LST_TEST_BULK:
-                trq->tsr_service = SRPC_SERVICE_BRW;
-                rc = lstcon_bulkrpc_prep((lst_test_bulk_param_t *)&test->tes_param[0], trq);
+               rc = lstcon_pingrpc_prep((lst_test_ping_param_t *)
+                                        &test->tes_param[0], trq);
+               break;
+
+       case LST_TEST_BULK:
+               trq->tsr_service = SRPC_SERVICE_BRW;
+               if ((feats & LST_FEAT_BULK_LEN) == 0) {
+                       rc = lstcon_bulkrpc_v0_prep((lst_test_bulk_param_t *)
+                                                   &test->tes_param[0], trq);
+               } else {
+                       rc = lstcon_bulkrpc_v1_prep((lst_test_bulk_param_t *)
+                                                   &test->tes_param[0], trq);
+               }
+
                 break;
         default:
                 LBUG();
@@ -844,34 +925,69 @@ lstcon_testrpc_prep(lstcon_node_t *nd, int transop,
         return rc;
 }
 
+int
+lstcon_sesnew_stat_reply(lstcon_rpc_trans_t *trans,
+                        lstcon_node_t *nd, srpc_msg_t *reply)
+{
+       srpc_mksn_reply_t *mksn_rep = &reply->msg_body.mksn_reply;
+       int                status   = mksn_rep->mksn_status;
+
+       if (status == 0 &&
+           (reply->msg_ses_feats & ~LST_FEATS_MASK) != 0) {
+               mksn_rep->mksn_status = EPROTO;
+               status = EPROTO;
+       }
+
+       if (status == EPROTO) {
+               CNETERR("session protocol error from %s: %u\n",
+                       libcfs_nid2str(nd->nd_id.nid),
+                       reply->msg_ses_feats);
+       }
+
+       if (status != 0)
+               return status;
+
+       if (!trans->tas_feats_updated) {
+               trans->tas_feats_updated = 1;
+               trans->tas_features = reply->msg_ses_feats;
+       }
+
+       if (reply->msg_ses_feats != trans->tas_features) {
+               CNETERR("Framework features %x from %s is different with "
+                       "features on this transaction: %x\n",
+                        reply->msg_ses_feats, libcfs_nid2str(nd->nd_id.nid),
+                        trans->tas_features);
+               status = mksn_rep->mksn_status = EPROTO;
+       }
+
+       if (status == 0) {
+               /* session timeout on remote node */
+               nd->nd_timeout = mksn_rep->mksn_timeout;
+       }
+
+       return status;
+}
+
 void
-lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
+lstcon_rpc_stat_reply(lstcon_rpc_trans_t *trans, srpc_msg_t *msg,
                       lstcon_node_t *nd, lstcon_trans_stat_t *stat)
 {
-        srpc_mksn_reply_t  *mksn_rep;
         srpc_rmsn_reply_t  *rmsn_rep;
         srpc_debug_reply_t *dbg_rep;
         srpc_batch_reply_t *bat_rep;
         srpc_test_reply_t  *test_rep;
         srpc_stat_reply_t  *stat_rep;
-        int                 errno = 0;
+        int                 rc = 0;
 
-        switch (transop) {
-        case LST_TRANS_SESNEW:
-                mksn_rep = &msg->msg_body.mksn_reply;
-
-                if (mksn_rep->mksn_status == 0) {
+       switch (trans->tas_opc) {
+       case LST_TRANS_SESNEW:
+               rc = lstcon_sesnew_stat_reply(trans, nd, msg);
+               if (rc == 0) {
                         lstcon_sesop_stat_success(stat, 1);
-                        /* session timeout on remote node */
-                        nd->nd_timeout = mksn_rep->mksn_timeout;
                         return;
                 }
 
-                LASSERT (mksn_rep->mksn_status == EBUSY ||
-                         mksn_rep->mksn_status == EINVAL);
-
                 lstcon_sesop_stat_failure(stat, 1);
-                errno = mksn_rep->mksn_status;
                 break;
 
         case LST_TRANS_SESEND:
@@ -883,11 +999,8 @@ lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
                         return;
                 }
 
-                LASSERT (rmsn_rep->rmsn_status == EBUSY ||
-                         rmsn_rep->rmsn_status == EINVAL);
-
                 lstcon_sesop_stat_failure(stat, 1);
-                errno = rmsn_rep->rmsn_status;
+                rc = rmsn_rep->rmsn_status;
                 break;
 
         case LST_TRANS_SESQRY:
@@ -897,9 +1010,7 @@ lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
                 if (dbg_rep->dbg_status == ESRCH) {
                         lstcon_sesqry_stat_unknown(stat, 1);
                         return;
-                } 
-
-                LASSERT (dbg_rep->dbg_status == 0);
+               }
 
                 if (lstcon_session_match(dbg_rep->dbg_sid))
                         lstcon_sesqry_stat_active(stat, 1);
@@ -917,13 +1028,13 @@ lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
                 }
 
                 if (bat_rep->bar_status == EPERM && 
-                    transop == LST_TRANS_TSBSTOP) {
+                   trans->tas_opc == LST_TRANS_TSBSTOP) {
                         lstcon_tsbop_stat_success(stat, 1);
                         return;
                 }
 
                 lstcon_tsbop_stat_failure(stat, 1);
-                errno = bat_rep->bar_status;
+                rc = bat_rep->bar_status;
                 break;
 
         case LST_TRANS_TSBCLIQRY:
@@ -939,7 +1050,7 @@ lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
                         return;
 
                 lstcon_tsbqry_stat_failure(stat, 1);
-                errno = bat_rep->bar_status;
+                rc = bat_rep->bar_status;
                 break;
 
         case LST_TRANS_TSBCLIADD:
@@ -952,7 +1063,7 @@ lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
                 }
 
                 lstcon_tsbop_stat_failure(stat, 1);
-                errno = test_rep->tsr_status;
+                rc = test_rep->tsr_status;
                 break;
 
         case LST_TRANS_STATQRY:
@@ -964,7 +1075,7 @@ lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
                 }
 
                 lstcon_statqry_stat_failure(stat, 1);
-                errno = stat_rep->str_status;
+                rc = stat_rep->str_status;
                 break;
 
         default:
@@ -972,20 +1083,22 @@ lstcon_rpc_stat_reply(int transop, srpc_msg_t *msg,
         }
 
         if (stat->trs_fwk_errno == 0)
-                stat->trs_fwk_errno = errno;
+                stat->trs_fwk_errno = rc;
 
         return;
 }
 
 int
-lstcon_rpc_trans_ndlist(struct list_head *ndlist,
-                        struct list_head *translist, int transop, void *arg,
-                        lstcon_rpc_cond_func_t condition, lstcon_rpc_trans_t **transpp)
+lstcon_rpc_trans_ndlist(cfs_list_t *ndlist,
+                        cfs_list_t *translist, int transop,
+                        void *arg, lstcon_rpc_cond_func_t condition,
+                        lstcon_rpc_trans_t **transpp)
 {
         lstcon_rpc_trans_t *trans;
         lstcon_ndlink_t    *ndl;
         lstcon_node_t      *nd;
         lstcon_rpc_t       *rpc;
+       unsigned            feats;
         int                 rc;
 
         /* Creating session RPG for list of nodes */
@@ -996,7 +1109,8 @@ lstcon_rpc_trans_ndlist(struct list_head *ndlist,
                 return rc;
         }
 
-        list_for_each_entry(ndl, ndlist, ndl_link) {
+       feats = trans->tas_features;
+        cfs_list_for_each_entry_typed(ndl, ndlist, lstcon_ndlink_t, ndl_link) {
                 rc = condition == NULL ? 1 :
                      condition(transop, ndl->ndl_node, arg);
 
@@ -1014,26 +1128,26 @@ lstcon_rpc_trans_ndlist(struct list_head *ndlist,
                 switch (transop) {
                 case LST_TRANS_SESNEW:
                 case LST_TRANS_SESEND:
-                        rc = lstcon_sesrpc_prep(nd, transop, &rpc);
-                        break;
-                case LST_TRANS_SESQRY:
-                case LST_TRANS_SESPING:
-                        rc = lstcon_dbgrpc_prep(nd, &rpc);
-                        break;
-                case LST_TRANS_TSBCLIADD:
-                case LST_TRANS_TSBSRVADD:
-                        rc = lstcon_testrpc_prep(nd, transop,
-                                                 (lstcon_test_t *)arg, &rpc);
-                        break;
-                case LST_TRANS_TSBRUN:
-                case LST_TRANS_TSBSTOP:
-                case LST_TRANS_TSBCLIQRY:
-                case LST_TRANS_TSBSRVQRY:
-                        rc = lstcon_batrpc_prep(nd, transop,
-                                                (lstcon_tsb_hdr_t *)arg, &rpc);
-                        break;
-                case LST_TRANS_STATQRY:
-                        rc = lstcon_statrpc_prep(nd, &rpc);
+                       rc = lstcon_sesrpc_prep(nd, transop, feats, &rpc);
+                       break;
+               case LST_TRANS_SESQRY:
+               case LST_TRANS_SESPING:
+                       rc = lstcon_dbgrpc_prep(nd, feats, &rpc);
+                       break;
+               case LST_TRANS_TSBCLIADD:
+               case LST_TRANS_TSBSRVADD:
+                       rc = lstcon_testrpc_prep(nd, transop, feats,
+                                                (lstcon_test_t *)arg, &rpc);
+                       break;
+               case LST_TRANS_TSBRUN:
+               case LST_TRANS_TSBSTOP:
+               case LST_TRANS_TSBCLIQRY:
+               case LST_TRANS_TSBSRVQRY:
+                       rc = lstcon_batrpc_prep(nd, transop, feats,
+                                               (lstcon_tsb_hdr_t *)arg, &rpc);
+                       break;
+               case LST_TRANS_STATQRY:
+                       rc = lstcon_statrpc_prep(nd, feats, &rpc);
                         break;
                 default:
                         rc = -EINVAL;
@@ -1045,7 +1159,7 @@ lstcon_rpc_trans_ndlist(struct list_head *ndlist,
                                lstcon_rpc_trans_name(transop), rc);
                         break;
                 }
-                                
+
                 lstcon_rpc_trans_addreq(trans, rpc);
         }
 
@@ -1076,23 +1190,24 @@ lstcon_rpc_pinger(void *arg)
         /* RPC pinger is a special case of transaction,
          * it's called by timer at 8 seconds interval.
          */
-        mutex_down(&console_session.ses_mutex);
+        cfs_mutex_lock(&console_session.ses_mutex);
 
         if (console_session.ses_shutdown || console_session.ses_expired) {
-                mutex_up(&console_session.ses_mutex);
+                cfs_mutex_unlock(&console_session.ses_mutex);
                 return;
         }
 
         if (!console_session.ses_expired &&
             cfs_time_current_sec() - console_session.ses_laststamp >
-            console_session.ses_timeout)
+            (time_t)console_session.ses_timeout)
                 console_session.ses_expired = 1;
 
         trans = console_session.ses_ping;
 
         LASSERT (trans != NULL);
 
-        list_for_each_entry(ndl, &console_session.ses_ndl_list, ndl_link) {
+        cfs_list_for_each_entry_typed(ndl, &console_session.ses_ndl_list,
+                                      lstcon_ndlink_t, ndl_link) {
                 nd = ndl->ndl_node;
 
                 if (console_session.ses_expired) {
@@ -1100,7 +1215,8 @@ lstcon_rpc_pinger(void *arg)
                         if (nd->nd_state != LST_NODE_ACTIVE)
                                 continue;
 
-                        rc = lstcon_sesrpc_prep(nd, LST_TRANS_SESEND, &crpc);
+                       rc = lstcon_sesrpc_prep(nd, LST_TRANS_SESEND,
+                                               trans->tas_features, &crpc);
                         if (rc != 0) {
                                 CERROR("Out of memory\n");
                                 break;
@@ -1116,24 +1232,24 @@ lstcon_rpc_pinger(void *arg)
 
                 if (crpc->crp_rpc != NULL) {
                         LASSERT (crpc->crp_trans == trans);
-                        LASSERT (!list_empty(&crpc->crp_link));
+                        LASSERT (!cfs_list_empty(&crpc->crp_link));
 
-                        spin_lock(&crpc->crp_rpc->crpc_lock);
+                        cfs_spin_lock(&crpc->crp_rpc->crpc_lock);
 
                         LASSERT (crpc->crp_posted);
 
                         if (!crpc->crp_finished) {
                                 /* in flight */
-                                spin_unlock(&crpc->crp_rpc->crpc_lock);
+                                cfs_spin_unlock(&crpc->crp_rpc->crpc_lock);
                                 continue;
                         }
 
-                        spin_unlock(&crpc->crp_rpc->crpc_lock);
+                        cfs_spin_unlock(&crpc->crp_rpc->crpc_lock);
 
                         lstcon_rpc_get_reply(crpc, &rep);
 
-                        list_del_init(&crpc->crp_link);
-                
+                        cfs_list_del_init(&crpc->crp_link);
+
                         lstcon_rpc_put(crpc);
                 }
 
@@ -1142,10 +1258,11 @@ lstcon_rpc_pinger(void *arg)
 
                 intv = cfs_duration_sec(cfs_time_sub(cfs_time_current(),
                                                      nd->nd_stamp));
-                if (intv < nd->nd_timeout / 2)
+                if (intv < (time_t)nd->nd_timeout / 2)
                         continue;
 
-                rc = lstcon_rpc_init(nd, SRPC_SERVICE_DEBUG, 0, 0, crpc);
+               rc = lstcon_rpc_init(nd, SRPC_SERVICE_DEBUG,
+                                    trans->tas_features, 0, 0, 1, crpc);
                 if (rc != 0) {
                         CERROR("Out of memory\n");
                         break;
@@ -1163,16 +1280,16 @@ lstcon_rpc_pinger(void *arg)
         }
 
         if (console_session.ses_expired) {
-                mutex_up(&console_session.ses_mutex);
+                cfs_mutex_unlock(&console_session.ses_mutex);
                 return;
         }
 
         CDEBUG(D_NET, "Ping %d nodes in session\n", count);
 
-        ptimer->stt_expires = cfs_time_current_sec() + LST_PING_INTERVAL;
+        ptimer->stt_expires = (cfs_time_t)(cfs_time_current_sec() + LST_PING_INTERVAL);
         stt_add_timer(ptimer);
 
-        mutex_up(&console_session.ses_mutex);
+        cfs_mutex_unlock(&console_session.ses_mutex);
 }
 
 int
@@ -1181,9 +1298,8 @@ lstcon_rpc_pinger_start(void)
         stt_timer_t    *ptimer;
         int             rc;
 
-        LASSERT (console_session.ses_rpc_pending == 0);
-        LASSERT (list_empty(&console_session.ses_rpc_list));
-        LASSERT (list_empty(&console_session.ses_rpc_freelist));
+        LASSERT (cfs_list_empty(&console_session.ses_rpc_freelist));
+        LASSERT (cfs_atomic_read(&console_session.ses_rpc_counter) == 0);
 
         rc = lstcon_rpc_trans_prep(NULL, LST_TRANS_SESPING,
                                    &console_session.ses_ping);
@@ -1193,7 +1309,7 @@ lstcon_rpc_pinger_start(void)
         }
 
         ptimer = &console_session.ses_ping_timer;
-        ptimer->stt_expires = cfs_time_current_sec() + LST_PING_INTERVAL;
+        ptimer->stt_expires = (cfs_time_t)(cfs_time_current_sec() + LST_PING_INTERVAL);
 
         stt_add_timer(ptimer);
 
@@ -1221,47 +1337,50 @@ lstcon_rpc_cleanup_wait(void)
 {
         lstcon_rpc_trans_t *trans;
         lstcon_rpc_t       *crpc;
-        struct list_head   *pacer;
-        struct list_head    zlist;
+        cfs_list_t         *pacer;
+        cfs_list_t          zlist;
+
+        /* Called with hold of global mutex */
 
         LASSERT (console_session.ses_shutdown);
 
-        while (!list_empty(&console_session.ses_trans_list)) { 
-                list_for_each(pacer, &console_session.ses_trans_list) {
-                        trans = list_entry(pacer, lstcon_rpc_trans_t, tas_link);
-                        cfs_waitq_signal(&trans->tas_waitq);
+        while (!cfs_list_empty(&console_session.ses_trans_list)) { 
+                cfs_list_for_each(pacer, &console_session.ses_trans_list) {
+                        trans = cfs_list_entry(pacer, lstcon_rpc_trans_t,
+                                               tas_link);
 
                         CDEBUG(D_NET, "Session closed, wakeup transaction %s\n",
                                lstcon_rpc_trans_name(trans->tas_opc));
+
+                        cfs_waitq_signal(&trans->tas_waitq);
                 }
 
-                mutex_up(&console_session.ses_mutex);
+                cfs_mutex_unlock(&console_session.ses_mutex);
 
-                CWARN("Session is shutting down, close all transactions\n");
+                CWARN("Session is shutting down, "
+                      "waiting for termination of transactions\n");
                 cfs_pause(cfs_time_seconds(1));
 
-                mutex_down(&console_session.ses_mutex);
+                cfs_mutex_lock(&console_session.ses_mutex);
         }
 
-        spin_lock(&console_session.ses_rpc_lock);
+        cfs_spin_lock(&console_session.ses_rpc_lock);
 
-        lst_wait_until(list_empty(&console_session.ses_rpc_list),
+        lst_wait_until((cfs_atomic_read(&console_session.ses_rpc_counter) == 0),
                        console_session.ses_rpc_lock,
                        "Network is not accessable or target is down, "
-                       "waiting for %d console rpcs to die\n",
-                       console_session.ses_rpc_pending);
+                       "waiting for %d console RPCs to being recycled\n",
+                       cfs_atomic_read(&console_session.ses_rpc_counter));
 
-        list_add(&zlist, &console_session.ses_rpc_freelist);
-        list_del_init(&console_session.ses_rpc_freelist);
+        cfs_list_add(&zlist, &console_session.ses_rpc_freelist);
+        cfs_list_del_init(&console_session.ses_rpc_freelist);
 
-        spin_unlock(&console_session.ses_rpc_lock);
+        cfs_spin_unlock(&console_session.ses_rpc_lock);
 
-        LASSERT (console_session.ses_rpc_pending == 0);
+        while (!cfs_list_empty(&zlist)) {
+                crpc = cfs_list_entry(zlist.next, lstcon_rpc_t, crp_link);
 
-        while (!list_empty(&zlist)) {
-                crpc = list_entry(zlist.next, lstcon_rpc_t, crp_link);
-
-                list_del(&crpc->crp_link);
+                cfs_list_del(&crpc->crp_link);
                 LIBCFS_FREE(crpc, sizeof(lstcon_rpc_t));
         }
 }
@@ -1274,9 +1393,9 @@ lstcon_rpc_module_init(void)
         console_session.ses_ping_timer.stt_data = &console_session.ses_ping_timer;
 
         console_session.ses_ping = NULL;
-        console_session.ses_rpc_pending = 0;
-        spin_lock_init(&console_session.ses_rpc_lock);
-        CFS_INIT_LIST_HEAD(&console_session.ses_rpc_list);
+
+        cfs_spin_lock_init(&console_session.ses_rpc_lock);
+        cfs_atomic_set(&console_session.ses_rpc_counter, 0);
         CFS_INIT_LIST_HEAD(&console_session.ses_rpc_freelist);
 
         return 0;
@@ -1285,9 +1404,8 @@ lstcon_rpc_module_init(void)
 void
 lstcon_rpc_module_fini(void)
 {
-        LASSERT (console_session.ses_rpc_pending == 0);
-        LASSERT (list_empty(&console_session.ses_rpc_list));
-        LASSERT (list_empty(&console_session.ses_rpc_freelist));
+        LASSERT (cfs_list_empty(&console_session.ses_rpc_freelist));
+        LASSERT (cfs_atomic_read(&console_session.ses_rpc_counter) == 0);
 }
 
 #endif