Whamcloud - gitweb
LU-482 tests: cleanup clients/OSTs after MDS error
[fs/lustre-release.git] / lnet / lnet / router.c
index b89c5f3..c08ae39 100644 (file)
@@ -1,7 +1,7 @@
-/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*-
- * vim:expandtab:shiftwidth=8:tabstop=8:
+/*
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  *
- * Copyright  2008 Sun Microsystems, Inc. All rights reserved
+ * Copyright (c) 2011, Whamcloud, Inc.
  *
  *   This file is part of Portals
  *   http://sourceforge.net/projects/sandiaportals/
@@ -81,15 +81,15 @@ static int avoid_asym_router_failure = 0;
 CFS_MODULE_PARM(avoid_asym_router_failure, "i", int, 0444,
                 "Avoid asymmetrical failures: reserved, use at your own risk");
 
-int dead_router_check_interval = 0;
+static int dead_router_check_interval = 0;
 CFS_MODULE_PARM(dead_router_check_interval, "i", int, 0444,
                 "Seconds between dead router health checks (<= 0 to disable)");
 
-int live_router_check_interval = 0;
+static int live_router_check_interval = 0;
 CFS_MODULE_PARM(live_router_check_interval, "i", int, 0444,
                 "Seconds between live router health checks (<= 0 to disable)");
 
-int router_ping_timeout = 50;
+static int router_ping_timeout = 50;
 CFS_MODULE_PARM(router_ping_timeout, "i", int, 0444,
                 "Seconds to wait for the reply to a router health query");
 
@@ -179,18 +179,18 @@ lnet_rtr_addref_locked(lnet_peer_t *lp)
 
         lp->lp_rtr_refcount++;
         if (lp->lp_rtr_refcount == 1) {
-                struct list_head *pos;
+                cfs_list_t *pos;
 
                 /* a simple insertion sort */
-                list_for_each_prev(pos, &the_lnet.ln_routers) {
-                        lnet_peer_t *rtr = list_entry(pos, lnet_peer_t, 
-                                                      lp_rtr_list);
+                cfs_list_for_each_prev(pos, &the_lnet.ln_routers) {
+                        lnet_peer_t *rtr = cfs_list_entry(pos, lnet_peer_t,
+                                                          lp_rtr_list);
 
                         if (rtr->lp_nid < lp->lp_nid)
                                 break;
                 }
 
-                list_add(&lp->lp_rtr_list, pos);
+                cfs_list_add(&lp->lp_rtr_list, pos);
                 /* addref for the_lnet.ln_routers */
                 lnet_peer_addref_locked(lp);
                 the_lnet.ln_routers_version++;
@@ -206,12 +206,12 @@ lnet_rtr_decref_locked(lnet_peer_t *lp)
         lp->lp_rtr_refcount--;
         if (lp->lp_rtr_refcount == 0) {
                 if (lp->lp_rcd != NULL) {
-                        list_add(&lp->lp_rcd->rcd_list,
-                                 &the_lnet.ln_zombie_rcd);
+                        cfs_list_add(&lp->lp_rcd->rcd_list,
+                                     &the_lnet.ln_zombie_rcd);
                         lp->lp_rcd = NULL;
                 }
 
-                list_del(&lp->lp_rtr_list);
+                cfs_list_del(&lp->lp_rtr_list);
                 /* decref for the_lnet.ln_routers */
                 lnet_peer_decref_locked(lp);
                 the_lnet.ln_routers_version++;
@@ -222,12 +222,12 @@ lnet_remotenet_t *
 lnet_find_net_locked (__u32 net)
 {
         lnet_remotenet_t *rnet;
-        struct list_head *tmp;
+        cfs_list_t       *tmp;
 
         LASSERT (!the_lnet.ln_shutdown);
 
-        list_for_each (tmp, &the_lnet.ln_remote_nets) {
-                rnet = list_entry(tmp, lnet_remotenet_t, lrn_list);
+        cfs_list_for_each (tmp, &the_lnet.ln_remote_nets) {
+                rnet = cfs_list_entry(tmp, lnet_remotenet_t, lrn_list);
 
                 if (rnet->lrn_net == net)
                         return rnet;
@@ -235,15 +235,69 @@ lnet_find_net_locked (__u32 net)
         return NULL;
 }
 
+static void lnet_shuffle_seed(void)
+{
+        static int seeded = 0;
+        int lnd_type, seed[2];
+        struct timeval tv;
+        lnet_ni_t *ni;
+        cfs_list_t *tmp;
+
+        if (seeded)
+                return;
+
+        cfs_get_random_bytes(seed, sizeof(seed));
+
+        /* Nodes with small feet have little entropy
+         * the NID for this node gives the most entropy in the low bits */
+        cfs_list_for_each(tmp, &the_lnet.ln_nis) {
+                ni = cfs_list_entry(tmp, lnet_ni_t, ni_list);
+                lnd_type = LNET_NETTYP(LNET_NIDNET(ni->ni_nid));
+
+                if (lnd_type != LOLND)
+                        seed[0] ^= (LNET_NIDADDR(ni->ni_nid) | lnd_type);
+        }
+
+        cfs_gettimeofday(&tv);
+        cfs_srand(tv.tv_sec ^ seed[0], tv.tv_usec ^ seed[1]);
+        seeded = 1;
+        return;
+}
+
+/* NB expects LNET_LOCK held */
+void
+lnet_add_route_to_rnet (lnet_remotenet_t *rnet, lnet_route_t *route)
+{
+        unsigned int      len = 0;
+        unsigned int      offset = 0;
+        cfs_list_t       *e;
+
+        lnet_shuffle_seed();
+
+        cfs_list_for_each (e, &rnet->lrn_routes) {
+                len++;
+        }
+
+        /* len+1 positions to add a new entry, also prevents division by 0 */
+        offset = cfs_rand() % (len + 1);
+        cfs_list_for_each (e, &rnet->lrn_routes) {
+                if (offset == 0)
+                        break;
+                offset--;
+        }
+        cfs_list_add(&route->lr_list, e);
+
+        the_lnet.ln_remote_nets_version++;
+        lnet_rtr_addref_locked(route->lr_gateway);
+}
+
 int
 lnet_add_route (__u32 net, unsigned int hops, lnet_nid_t gateway)
 {
-        struct list_head     zombies;
-        struct list_head    *e;
+        cfs_list_t          *e;
         lnet_remotenet_t    *rnet;
         lnet_remotenet_t    *rnet2;
         lnet_route_t        *route;
-        lnet_route_t        *route2;
         lnet_ni_t           *ni;
         int                  add_route;
         int                  rc;
@@ -277,7 +331,7 @@ lnet_add_route (__u32 net, unsigned int hops, lnet_nid_t gateway)
 
         CFS_INIT_LIST_HEAD(&rnet->lrn_routes);
         rnet->lrn_net = net;
-        rnet->lrn_hops = hops;
+        route->lr_hops = hops;
 
         LNET_LOCK();
 
@@ -297,51 +351,33 @@ lnet_add_route (__u32 net, unsigned int hops, lnet_nid_t gateway)
         }
 
         LASSERT (!the_lnet.ln_shutdown);
-        CFS_INIT_LIST_HEAD(&zombies);
 
         rnet2 = lnet_find_net_locked(net);
         if (rnet2 == NULL) {
                 /* new network */
-                list_add_tail(&rnet->lrn_list, &the_lnet.ln_remote_nets);
+                cfs_list_add_tail(&rnet->lrn_list, &the_lnet.ln_remote_nets);
                 rnet2 = rnet;
         }
 
-        if (hops > rnet2->lrn_hops) {
-                /* New route is longer; ignore it */
-                add_route = 0;
-        } else if (hops < rnet2->lrn_hops) {
-                /* new route supercedes all currently known routes to this
-                 * net */
-                list_add(&zombies, &rnet2->lrn_routes);
-                list_del_init(&rnet2->lrn_routes);
-                add_route = 1;
-        } else {
-                add_route = 1;
-                /* New route has the same hopcount as existing routes; search
-                 * for a duplicate route (it's a NOOP if it is) */
-                list_for_each (e, &rnet2->lrn_routes) {
-                        route2 = list_entry(e, lnet_route_t, lr_list);
-
-                        if (route2->lr_gateway == route->lr_gateway) {
-                                add_route = 0;
-                                break;
-                        }
+        /* Search for a duplicate route (it's a NOOP if it is) */
+        add_route = 1;
+        cfs_list_for_each (e, &rnet2->lrn_routes) {
+                lnet_route_t *route2 = cfs_list_entry(e, lnet_route_t, lr_list);
 
-                        /* our loopups must be true */
-                        LASSERT (route2->lr_gateway->lp_nid != gateway);
+                if (route2->lr_gateway == route->lr_gateway) {
+                        add_route = 0;
+                        break;
                 }
+
+                /* our lookups must be true */
+                LASSERT (route2->lr_gateway->lp_nid != gateway);
         }
 
         if (add_route) {
                 ni = route->lr_gateway->lp_ni;
                 lnet_ni_addref_locked(ni);
 
-                LASSERT (rc == 0);
-                list_add_tail(&route->lr_list, &rnet2->lrn_routes);
-                the_lnet.ln_remote_nets_version++;
-
-                lnet_rtr_addref_locked(route->lr_gateway);
-
+                lnet_add_route_to_rnet(rnet2, route);
                 LNET_UNLOCK();
 
                 /* XXX Assume alive */
@@ -358,18 +394,7 @@ lnet_add_route (__u32 net, unsigned int hops, lnet_nid_t gateway)
         if (rnet != rnet2)
                 LIBCFS_FREE(rnet, sizeof(*rnet));
 
-        while (!list_empty(&zombies)) {
-                route = list_entry(zombies.next, lnet_route_t, lr_list);
-                list_del(&route->lr_list);
-
-                LNET_LOCK();
-                lnet_rtr_decref_locked(route->lr_gateway);
-                lnet_peer_decref_locked(route->lr_gateway);
-                LNET_UNLOCK();
-                LIBCFS_FREE(route, sizeof(*route));
-        }
-
-        return rc;
+        return 0;
 }
 
 int
@@ -378,17 +403,17 @@ lnet_check_routes (void)
         lnet_remotenet_t    *rnet;
         lnet_route_t        *route;
         lnet_route_t        *route2;
-        struct list_head    *e1;
-        struct list_head    *e2;
+        cfs_list_t          *e1;
+        cfs_list_t          *e2;
 
         LNET_LOCK();
 
-        list_for_each (e1, &the_lnet.ln_remote_nets) {
-                rnet = list_entry(e1, lnet_remotenet_t, lrn_list);
+        cfs_list_for_each (e1, &the_lnet.ln_remote_nets) {
+                rnet = cfs_list_entry(e1, lnet_remotenet_t, lrn_list);
 
                 route2 = NULL;
-                list_for_each (e2, &rnet->lrn_routes) {
-                        route = list_entry(e2, lnet_route_t, lr_list);
+                cfs_list_for_each (e2, &rnet->lrn_routes) {
+                        route = cfs_list_entry(e2, lnet_route_t, lr_list);
 
                         if (route2 == NULL)
                                 route2 = route;
@@ -414,8 +439,8 @@ lnet_del_route (__u32 net, lnet_nid_t gw_nid)
 {
         lnet_remotenet_t    *rnet;
         lnet_route_t        *route;
-        struct list_head    *e1;
-        struct list_head    *e2;
+        cfs_list_t          *e1;
+        cfs_list_t          *e2;
         int                  rc = -ENOENT;
 
         CDEBUG(D_NET, "Del route: net %s : gw %s\n",
@@ -427,25 +452,25 @@ lnet_del_route (__u32 net, lnet_nid_t gw_nid)
  again:
         LNET_LOCK();
 
-        list_for_each (e1, &the_lnet.ln_remote_nets) {
-                rnet = list_entry(e1, lnet_remotenet_t, lrn_list);
+        cfs_list_for_each (e1, &the_lnet.ln_remote_nets) {
+                rnet = cfs_list_entry(e1, lnet_remotenet_t, lrn_list);
 
                 if (!(net == LNET_NIDNET(LNET_NID_ANY) ||
                       net == rnet->lrn_net))
                         continue;
 
-                list_for_each (e2, &rnet->lrn_routes) {
-                        route = list_entry(e2, lnet_route_t, lr_list);
+                cfs_list_for_each (e2, &rnet->lrn_routes) {
+                        route = cfs_list_entry(e2, lnet_route_t, lr_list);
 
                         if (!(gw_nid == LNET_NID_ANY ||
                               gw_nid == route->lr_gateway->lp_nid))
                                 continue;
 
-                        list_del(&route->lr_list);
+                        cfs_list_del(&route->lr_list);
                         the_lnet.ln_remote_nets_version++;
 
-                        if (list_empty(&rnet->lrn_routes))
-                                list_del(&rnet->lrn_list);
+                        if (cfs_list_empty(&rnet->lrn_routes))
+                                cfs_list_del(&rnet->lrn_list);
                         else
                                 rnet = NULL;
 
@@ -477,22 +502,22 @@ int
 lnet_get_route (int idx, __u32 *net, __u32 *hops,
                lnet_nid_t *gateway, __u32 *alive)
 {
-        struct list_head    *e1;
-        struct list_head    *e2;
+        cfs_list_t          *e1;
+        cfs_list_t          *e2;
         lnet_remotenet_t    *rnet;
         lnet_route_t        *route;
 
         LNET_LOCK();
 
-        list_for_each (e1, &the_lnet.ln_remote_nets) {
-                rnet = list_entry(e1, lnet_remotenet_t, lrn_list);
+        cfs_list_for_each (e1, &the_lnet.ln_remote_nets) {
+                rnet = cfs_list_entry(e1, lnet_remotenet_t, lrn_list);
 
-                list_for_each (e2, &rnet->lrn_routes) {
-                        route = list_entry(e2, lnet_route_t, lr_list);
+                cfs_list_for_each (e2, &rnet->lrn_routes) {
+                        route = cfs_list_entry(e2, lnet_route_t, lr_list);
 
                         if (idx-- == 0) {
                                 *net     = rnet->lrn_net;
-                                *hops    = rnet->lrn_hops;
+                                *hops    = route->lr_hops;
                                 *gateway = route->lr_gateway->lp_nid;
                                 *alive   = route->lr_gateway->lp_alive;
                                 LNET_UNLOCK();
@@ -549,8 +574,8 @@ lnet_router_down_ni(lnet_peer_t *rtr, __u32 net)
         if (info->pi_magic == __swab32(LNET_PROTO_PING_MAGIC)) {
                 lnet_swap_pinginfo(info);
         } else if (info->pi_magic != LNET_PROTO_PING_MAGIC) {
-                CDEBUG(D_NETERROR, "%s: Unexpected magic %08x\n",
-                       libcfs_nid2str(rtr->lp_nid), info->pi_magic);
+                CNETERR("%s: Unexpected magic %08x\n",
+                        libcfs_nid2str(rtr->lp_nid), info->pi_magic);
                 return -EPROTO;
         }
 
@@ -558,8 +583,8 @@ lnet_router_down_ni(lnet_peer_t *rtr, __u32 net)
                 return -ENOENT;  /* v1 doesn't carry NI status info */
 
         if (info->pi_version != LNET_PROTO_PING_VERSION) {
-                CDEBUG(D_NETERROR, "%s: Unexpected version 0x%x\n",
-                       libcfs_nid2str(rtr->lp_nid), info->pi_version);
+                CNETERR("%s: Unexpected version 0x%x\n",
+                        libcfs_nid2str(rtr->lp_nid), info->pi_version);
                 return -EPROTO;
         }
 
@@ -568,8 +593,8 @@ lnet_router_down_ni(lnet_peer_t *rtr, __u32 net)
                 lnet_nid_t        nid = stat->ns_nid;
 
                 if (nid == LNET_NID_ANY) {
-                        CDEBUG(D_NETERROR, "%s: unexpected LNET_NID_ANY\n",
-                               libcfs_nid2str(rtr->lp_nid));
+                        CNETERR("%s: unexpected LNET_NID_ANY\n",
+                                libcfs_nid2str(rtr->lp_nid));
                         return -EPROTO;
                 }
 
@@ -585,8 +610,8 @@ lnet_router_down_ni(lnet_peer_t *rtr, __u32 net)
                 }
 
                 if (stat->ns_status != LNET_NI_STATUS_UP) {
-                        CDEBUG(D_NETERROR, "%s: Unexpected status 0x%x\n",
-                               libcfs_nid2str(rtr->lp_nid), stat->ns_status);
+                        CNETERR("%s: Unexpected status 0x%x\n",
+                                libcfs_nid2str(rtr->lp_nid), stat->ns_status);
                         return -EPROTO;
                 }
 
@@ -606,7 +631,7 @@ void
 lnet_wait_known_routerstate(void)
 {
         lnet_peer_t         *rtr;
-        struct list_head    *entry;
+        cfs_list_t          *entry;
         int                  all_known;
 
         LASSERT (the_lnet.ln_rc_state == LNET_RC_STATE_RUNNING);
@@ -615,8 +640,8 @@ lnet_wait_known_routerstate(void)
                 LNET_LOCK();
 
                 all_known = 1;
-                list_for_each (entry, &the_lnet.ln_routers) {
-                        rtr = list_entry(entry, lnet_peer_t, lp_rtr_list);
+                cfs_list_for_each (entry, &the_lnet.ln_routers) {
+                        rtr = cfs_list_entry(entry, lnet_peer_t, lp_rtr_list);
 
                         if (rtr->lp_alive_count == 0) {
                                 all_known = 0;
@@ -657,7 +682,7 @@ lnet_router_checker_event (lnet_event_t *event)
                 LASSERT (the_lnet.ln_rc_state == LNET_RC_STATE_UNLINKING);
                 the_lnet.ln_rc_state = LNET_RC_STATE_UNLINKED;
 #ifdef __KERNEL__
-                mutex_up(&the_lnet.ln_rc_signal);
+                cfs_up(&the_lnet.ln_rc_signal);
 #endif
                 return;
         }
@@ -719,7 +744,7 @@ lnet_update_ni_status(void)
 
         LNET_LOCK();
 
-        list_for_each_entry (ni, &the_lnet.ln_nis, ni_list) {
+        cfs_list_for_each_entry (ni, &the_lnet.ln_nis, ni_list) {
                 lnet_ni_status_t *ns = ni->ni_status;
 
                 LASSERT (ns != NULL);
@@ -744,7 +769,7 @@ lnet_update_ni_status(void)
 void
 lnet_destroy_rc_data (lnet_rc_data_t *rcd)
 {
-        LASSERT (list_empty(&rcd->rcd_list));
+        LASSERT (cfs_list_empty(&rcd->rcd_list));
         /* detached from network */
         LASSERT (LNetHandleIsInvalid(rcd->rcd_mdh));
 
@@ -841,7 +866,7 @@ lnet_ping_router_locked (lnet_peer_t *rtr)
         if (!lnet_isrouter(rtr)) {
                 lnet_peer_decref_locked(rtr);
                 if (rcd != NULL)
-                        list_add(&rcd->rcd_list, &the_lnet.ln_zombie_rcd);
+                        cfs_list_add(&rcd->rcd_list, &the_lnet.ln_zombie_rcd);
                 return; /* router table changed! */
         }
 
@@ -915,7 +940,7 @@ lnet_router_checker_start(void)
          * outstanding events as it is allowed outstanding sends */
         eqsz = 0;
         version = the_lnet.ln_routers_version;
-        list_for_each_entry(rtr, &the_lnet.ln_routers, lp_rtr_list) {
+        cfs_list_for_each_entry(rtr, &the_lnet.ln_routers, lp_rtr_list) {
                 lnet_ni_t         *ni = rtr->lp_ni;
                 lnet_process_id_t  id;
 
@@ -973,10 +998,10 @@ lnet_router_checker_start(void)
                 return 0;
 
 #ifdef __KERNEL__
-        init_mutex_locked(&the_lnet.ln_rc_signal);
+        cfs_sema_init(&the_lnet.ln_rc_signal, 0);
         /* EQ size doesn't matter; the callback is guaranteed to get every
          * event */
-        eqsz = 1;
+       eqsz = 0;
         rc = LNetEQAlloc(eqsz, lnet_router_checker_event,
                          &the_lnet.ln_rc_eqh);
 #else
@@ -1006,14 +1031,14 @@ lnet_router_checker_start(void)
 
         the_lnet.ln_rc_state = LNET_RC_STATE_RUNNING;
 #ifdef __KERNEL__
-        rc = (int)cfs_kernel_thread(lnet_router_checker, NULL, 0);
+        rc = cfs_create_thread(lnet_router_checker, NULL, 0);
         if (rc < 0) {
                 CERROR("Can't start router checker thread: %d\n", rc);
                 the_lnet.ln_rc_state = LNET_RC_STATE_UNLINKING;
                 rc = LNetMDUnlink(the_lnet.ln_rc_mdh);
                 LASSERT (rc == 0);
                 /* block until event callback signals exit */
-                mutex_down(&the_lnet.ln_rc_signal);
+                cfs_down(&the_lnet.ln_rc_signal);
                 rc = LNetEQFree(the_lnet.ln_rc_eqh);
                 LASSERT (rc == 0);
                 the_lnet.ln_rc_state = LNET_RC_STATE_SHUTDOWN;
@@ -1044,7 +1069,7 @@ lnet_router_checker_stop (void)
 
 #ifdef __KERNEL__
         /* block until event callback signals exit */
-        mutex_down(&the_lnet.ln_rc_signal);
+        cfs_down(&the_lnet.ln_rc_signal);
 #else
         while (the_lnet.ln_rc_state != LNET_RC_STATE_UNLINKED) {
                 lnet_router_checker();
@@ -1066,7 +1091,7 @@ lnet_prune_zombie_rcd (int wait_unlink)
 {
         lnet_rc_data_t   *rcd;
         lnet_rc_data_t   *tmp;
-        struct list_head  free_rcd;
+        cfs_list_t        free_rcd;
         int               i;
         __u64             version;
 
@@ -1075,10 +1100,11 @@ lnet_prune_zombie_rcd (int wait_unlink)
         LNET_LOCK();
 rescan:
         version = the_lnet.ln_routers_version;
-        list_for_each_entry_safe (rcd, tmp, &the_lnet.ln_zombie_rcd, rcd_list) {
+        cfs_list_for_each_entry_safe (rcd, tmp, &the_lnet.ln_zombie_rcd,
+                                      rcd_list) {
                 if (LNetHandleIsInvalid(rcd->rcd_mdh)) {
-                        list_del(&rcd->rcd_list);
-                        list_add(&rcd->rcd_list, &free_rcd);
+                        cfs_list_del(&rcd->rcd_list);
+                        cfs_list_add(&rcd->rcd_list, &free_rcd);
                         continue;
                 }
 
@@ -1092,12 +1118,12 @@ rescan:
         }
 
         i = 2;
-        while (wait_unlink && !list_empty(&the_lnet.ln_zombie_rcd)) {
-                rcd = list_entry(the_lnet.ln_zombie_rcd.next,
-                                 lnet_rc_data_t, rcd_list);
+        while (wait_unlink && !cfs_list_empty(&the_lnet.ln_zombie_rcd)) {
+                rcd = cfs_list_entry(the_lnet.ln_zombie_rcd.next,
+                                     lnet_rc_data_t, rcd_list);
                 if (LNetHandleIsInvalid(rcd->rcd_mdh)) {
-                        list_del(&rcd->rcd_list);
-                        list_add(&rcd->rcd_list, &free_rcd);
+                        cfs_list_del(&rcd->rcd_list);
+                        cfs_list_add(&rcd->rcd_list, &free_rcd);
                         continue;
                 }
 
@@ -1115,9 +1141,9 @@ rescan:
 
         LNET_UNLOCK();
 
-        while (!list_empty(&free_rcd)) {
-                rcd = list_entry(free_rcd.next, lnet_rc_data_t, rcd_list);
-                list_del_init(&rcd->rcd_list);
+        while (!cfs_list_empty(&free_rcd)) {
+                rcd = cfs_list_entry(free_rcd.next, lnet_rc_data_t, rcd_list);
+                cfs_list_del_init(&rcd->rcd_list);
                 lnet_destroy_rc_data(rcd);
         }
         return;
@@ -1128,14 +1154,11 @@ lnet_router_checker(void *arg)
 {
         int                rc;
         lnet_peer_t       *rtr;
-        struct list_head  *entry;
-        lnet_process_id_t  rtr_id;
+        cfs_list_t        *entry;
 
         cfs_daemonize("router_checker");
         cfs_block_allsigs();
 
-        rtr_id.pid = LUSTRE_SRV_LNET_PID;
-
         LASSERT (the_lnet.ln_rc_state == LNET_RC_STATE_RUNNING);
 
         while (the_lnet.ln_rc_state == LNET_RC_STATE_RUNNING) {
@@ -1145,8 +1168,8 @@ lnet_router_checker(void *arg)
 rescan:
                 version = the_lnet.ln_routers_version;
 
-                list_for_each (entry, &the_lnet.ln_routers) {
-                        rtr = list_entry(entry, lnet_peer_t, lp_rtr_list);
+                cfs_list_for_each (entry, &the_lnet.ln_routers) {
+                        rtr = cfs_list_entry(entry, lnet_peer_t, lp_rtr_list);
                         lnet_ping_router_locked(rtr);
 
                         /* NB dropped lock */
@@ -1166,20 +1189,20 @@ rescan:
                 /* Call cfs_pause() here always adds 1 to load average 
                  * because kernel counts # active tasks as nr_running 
                  * + nr_uninterruptible. */
-                cfs_schedule_timeout(CFS_TASK_INTERRUPTIBLE,
-                                     cfs_time_seconds(1));
+                cfs_schedule_timeout_and_set_state(CFS_TASK_INTERRUPTIBLE,
+                                                   cfs_time_seconds(1));
         }
 
         LNET_LOCK();
 
-        list_for_each (entry, &the_lnet.ln_routers) {
-                rtr = list_entry(entry, lnet_peer_t, lp_rtr_list);
+        cfs_list_for_each (entry, &the_lnet.ln_routers) {
+                rtr = cfs_list_entry(entry, lnet_peer_t, lp_rtr_list);
 
                 if (rtr->lp_rcd == NULL)
                         continue;
 
-                LASSERT (list_empty(&rtr->lp_rcd->rcd_list));
-                list_add(&rtr->lp_rcd->rcd_list, &the_lnet.ln_zombie_rcd);
+                LASSERT (cfs_list_empty(&rtr->lp_rcd->rcd_list));
+                cfs_list_add(&rtr->lp_rcd->rcd_list, &the_lnet.ln_zombie_rcd);
                 rtr->lp_rcd = NULL;
         }
 
@@ -1248,15 +1271,15 @@ lnet_rtrpool_free_bufs(lnet_rtrbufpool_t *rbp)
         int            nbuffers = 0;
         lnet_rtrbuf_t *rb;
 
-        LASSERT (list_empty(&rbp->rbp_msgs));
+        LASSERT (cfs_list_empty(&rbp->rbp_msgs));
         LASSERT (rbp->rbp_credits == rbp->rbp_nbuffers);
 
-        while (!list_empty(&rbp->rbp_bufs)) {
+        while (!cfs_list_empty(&rbp->rbp_bufs)) {
                 LASSERT (rbp->rbp_credits > 0);
 
-                rb = list_entry(rbp->rbp_bufs.next,
-                                lnet_rtrbuf_t, rb_list);
-                list_del(&rb->rb_list);
+                rb = cfs_list_entry(rbp->rbp_bufs.next,
+                                    lnet_rtrbuf_t, rb_list);
+                cfs_list_del(&rb->rb_list);
                 lnet_destroy_rtrbuf(rb, npages);
                 nbuffers++;
         }
@@ -1290,7 +1313,7 @@ lnet_rtrpool_alloc_bufs(lnet_rtrbufpool_t *rbp, int nbufs)
                 rbp->rbp_nbuffers++;
                 rbp->rbp_credits++;
                 rbp->rbp_mincredits++;
-                list_add(&rb->rb_list, &rbp->rbp_bufs);
+                cfs_list_add(&rb->rb_list, &rbp->rbp_bufs);
 
                 /* No allocation "under fire" */
                 /* Otherwise we'd need code to schedule blocked msgs etc */
@@ -1405,7 +1428,7 @@ lnet_notify (lnet_ni_t *ni, lnet_nid_t nid, int alive, cfs_time_t when)
         lnet_peer_t *lp = NULL;
         cfs_time_t   now = cfs_time_current();
 
-        LASSERT (!in_interrupt ());
+        LASSERT (!cfs_in_interrupt ());
 
         CDEBUG (D_NET, "%s notifying %s: %s\n",
                 (ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),
@@ -1502,9 +1525,9 @@ lnet_router_checker (void)
         if (last != 0 &&
             interval > MAX(live_router_check_interval,
                            dead_router_check_interval))
-                CDEBUG(D_NETERROR, "Checker(%d/%d) not called for %d seconds\n",
-                       live_router_check_interval, dead_router_check_interval,
-                       interval);
+                CNETERR("Checker(%d/%d) not called for %d seconds\n",
+                        live_router_check_interval, dead_router_check_interval,
+                        interval);
 
         LNET_LOCK();
         LASSERT (!running); /* recursion check */
@@ -1554,7 +1577,7 @@ lnet_router_checker (void)
         LNET_LOCK();
 
         version = the_lnet.ln_routers_version;
-        list_for_each_entry (rtr, &the_lnet.ln_routers, lp_rtr_list) {
+        cfs_list_for_each_entry (rtr, &the_lnet.ln_routers, lp_rtr_list) {
                 lnet_ping_router_locked(rtr);
                 LASSERT (version == the_lnet.ln_routers_version);
         }