*
* Copyright (c) 2011, 2017, Intel Corporation.
*
- * This file is part of Lustre, https://wiki.hpdd.intel.com/
+ * This file is part of Lustre, https://wiki.whamcloud.com/
*
* Portals is free software; you can redistribute it and/or
* modify it under the terms of version 2 of the GNU General Public
*/
#define DEBUG_SUBSYSTEM S_LNET
+
+#include <linux/random.h>
#include <lnet/lib-lnet.h>
#define LNET_NRB_TINY_MIN 512 /* min value for each CPT */
module_param(avoid_asym_router_failure, int, 0644);
MODULE_PARM_DESC(avoid_asym_router_failure, "Avoid asymmetrical router failures (0 to disable)");
-static int dead_router_check_interval = 60;
-module_param(dead_router_check_interval, int, 0644);
-MODULE_PARM_DESC(dead_router_check_interval, "Seconds between dead router health checks (<= 0 to disable)");
+int dead_router_check_interval = INT_MIN;
+module_param(dead_router_check_interval, int, 0444);
+MODULE_PARM_DESC(dead_router_check_interval, "(DEPRECATED - Use alive_router_check_interval)");
+
+int live_router_check_interval = INT_MIN;
+module_param(live_router_check_interval, int, 0444);
+MODULE_PARM_DESC(live_router_check_interval, "(DEPRECATED - Use alive_router_check_interval)");
-static int live_router_check_interval = 60;
-module_param(live_router_check_interval, int, 0644);
-MODULE_PARM_DESC(live_router_check_interval, "Seconds between live router health checks (<= 0 to disable)");
+int alive_router_check_interval = 60;
+module_param(alive_router_check_interval, int, 0644);
+MODULE_PARM_DESC(alive_router_check_interval, "Seconds between live router health checks (<= 0 to disable)");
static int router_ping_timeout = 50;
module_param(router_ping_timeout, int, 0644);
MODULE_PARM_DESC(router_ping_timeout, "Seconds to wait for the reply to a router health query");
-int
-lnet_peers_start_down(void)
+/*
+ * A value between 0 and 100. 0 meaning that even if router's interfaces
+ * have the worse health still consider the gateway usable.
+ * 100 means that at least one interface on the route's remote net is 100%
+ * healthy to consider the route alive.
+ * The default is set to 100 to ensure we maintain the original behavior.
+ */
+unsigned int router_sensitivity_percentage = 100;
+static int rtr_sensitivity_set(const char *val, cfs_kernel_param_arg_t *kp);
+static struct kernel_param_ops param_ops_rtr_sensitivity = {
+ .set = rtr_sensitivity_set,
+ .get = param_get_int,
+};
+#define param_check_rtr_sensitivity(name, p) \
+ __param_check(name, p, int)
+#ifdef HAVE_KERNEL_PARAM_OPS
+module_param(router_sensitivity_percentage, rtr_sensitivity, S_IRUGO|S_IWUSR);
+#else
+module_param_call(router_sensitivity_percentage, rtr_sensitivity_set, param_get_int,
+ &router_sensitivity_percentage, S_IRUGO|S_IWUSR);
+#endif
+MODULE_PARM_DESC(router_sensitivity_percentage,
+ "How healthy a gateway should be to be used in percent");
+
+static void lnet_add_route_to_rnet(struct lnet_remotenet *rnet,
+ struct lnet_route *route);
+static void lnet_del_route_from_rnet(struct lnet_nid *gw_nid,
+ struct list_head *route_list,
+ struct list_head *zombies);
+
+static int
+rtr_sensitivity_set(const char *val, cfs_kernel_param_arg_t *kp)
{
- return check_routers_before_use;
+ int rc;
+ unsigned *sen = (unsigned *)kp->arg;
+ unsigned long value;
+
+ rc = kstrtoul(val, 0, &value);
+ if (rc) {
+ CERROR("Invalid module parameter value for 'router_sensitivity_percentage'\n");
+ return rc;
+ }
+
+ if (value < 0 || value > 100) {
+ CERROR("Invalid value: %lu for 'router_sensitivity_percentage'\n", value);
+ return -EINVAL;
+ }
+
+ /*
+ * The purpose of locking the api_mutex here is to ensure that
+ * the correct value ends up stored properly.
+ */
+ mutex_lock(&the_lnet.ln_api_mutex);
+
+ *sen = value;
+
+ mutex_unlock(&the_lnet.ln_api_mutex);
+
+ return 0;
}
void
-lnet_notify_locked(struct lnet_peer_ni *lp, int notifylnd, int alive,
- time64_t when)
+lnet_move_route(struct lnet_route *route, struct lnet_peer *lp,
+ struct list_head *rt_list)
{
- if (lp->lpni_timestamp > when) { /* out of date information */
- CDEBUG(D_NET, "Out of date\n");
- return;
- }
+ struct lnet_remotenet *rnet;
+ struct list_head zombies;
+ struct list_head *l;
+
+ INIT_LIST_HEAD(&zombies);
+
+ if (rt_list)
+ l = rt_list;
+ else
+ l = &zombies;
+
+ rnet = lnet_find_rnet_locked(route->lr_net);
+ LASSERT(rnet);
+
+ CDEBUG(D_NET, "deleting route %s->%s\n",
+ libcfs_net2str(route->lr_net),
+ libcfs_nidstr(&route->lr_nid));
/*
- * This function can be called with different cpt locks being
- * held. lpni_alive_count modification needs to be properly protected.
- * Significant reads to lpni_alive_count are also protected with
- * the same lock
+ * use the gateway's lp_primary_nid to delete the route as the
+ * lr_nid can be a constituent NID of the peer
*/
- spin_lock(&lp->lpni_lock);
+ lnet_del_route_from_rnet(
+ &route->lr_gateway->lp_primary_nid,
+ &rnet->lrn_routes, l);
+
+ if (lp) {
+ route = list_first_entry(l, struct lnet_route,
+ lr_list);
+ route->lr_gateway = lp;
+ lnet_add_route_to_rnet(rnet, route);
+ } else {
+ while (!list_empty(l) && !rt_list) {
+ route = list_first_entry(l, struct lnet_route,
+ lr_list);
+ list_del(&route->lr_list);
+ LIBCFS_FREE(route, sizeof(*route));
+ }
+ }
+}
- lp->lpni_timestamp = when; /* update timestamp */
- lp->lpni_ping_deadline = 0; /* disable ping timeout */
+void
+lnet_rtr_transfer_to_peer(struct lnet_peer *src, struct lnet_peer *target)
+{
+ struct lnet_route *route;
+ struct lnet_route *tmp, *tmp2;
- if (lp->lpni_alive_count != 0 && /* got old news */
- (!lp->lpni_alive) == (!alive)) { /* new date for old news */
- spin_unlock(&lp->lpni_lock);
- CDEBUG(D_NET, "Old news\n");
- return;
+ lnet_net_lock(LNET_LOCK_EX);
+ CDEBUG(D_NET, "transfering routes from %s -> %s\n",
+ libcfs_nidstr(&src->lp_primary_nid),
+ libcfs_nidstr(&target->lp_primary_nid));
+ list_for_each_entry(route, &src->lp_routes, lr_gwlist) {
+ CDEBUG(D_NET, "%s: %s->%s\n",
+ libcfs_nidstr(&src->lp_primary_nid),
+ libcfs_net2str(route->lr_net),
+ libcfs_nidstr(&route->lr_nid));
+ }
+ list_splice_init(&src->lp_rtrq, &target->lp_rtrq);
+ list_for_each_entry_safe(route, tmp, &src->lp_routes, lr_gwlist) {
+ struct lnet_route *r2;
+ bool present = false;
+ list_for_each_entry_safe(r2, tmp2, &target->lp_routes, lr_gwlist) {
+ if (route->lr_net == r2->lr_net) {
+ if (route->lr_priority >= r2->lr_priority)
+ present = true;
+ else if (route->lr_hops >= r2->lr_hops)
+ present = true;
+ else
+ lnet_move_route(r2, NULL, NULL);
+ }
+ }
+ if (present)
+ lnet_move_route(route, NULL, NULL);
+ else
+ lnet_move_route(route, target, NULL);
}
- /* Flag that notification is outstanding */
-
- lp->lpni_alive_count++;
- lp->lpni_alive = (alive) ? 1 : 0;
- lp->lpni_notify = 1;
- lp->lpni_notifylnd = notifylnd;
- if (lp->lpni_alive)
- lp->lpni_ping_feats = LNET_PING_FEAT_INVAL; /* reset */
+ if (list_empty(&target->lp_rtr_list)) {
+ lnet_peer_addref_locked(target);
+ list_add_tail(&target->lp_rtr_list, &the_lnet.ln_routers);
+ }
- spin_unlock(&lp->lpni_lock);
+ the_lnet.ln_routers_version++;
+ lnet_net_unlock(LNET_LOCK_EX);
+}
- CDEBUG(D_NET, "set %s %d\n", libcfs_nid2str(lp->lpni_nid), alive);
+int
+lnet_peers_start_down(void)
+{
+ return check_routers_before_use;
}
/*
- * This function will always be called with lp->lpni_cpt lock held.
+ * The peer_net of a gateway is alive if at least one of the peer_ni's on
+ * that peer_net is alive.
*/
-static void
-lnet_ni_notify_locked(struct lnet_ni *ni, struct lnet_peer_ni *lp)
+static bool
+lnet_is_gateway_net_alive(struct lnet_peer_net *lpn)
{
- int alive;
- int notifylnd;
+ struct lnet_peer_ni *lpni;
- /* Notify only in 1 thread at any time to ensure ordered notification.
- * NB individual events can be missed; the only guarantee is that you
- * always get the most recent news */
+ list_for_each_entry(lpni, &lpn->lpn_peer_nis, lpni_peer_nis) {
+ if (lnet_is_peer_ni_alive(lpni))
+ return true;
+ }
- spin_lock(&lp->lpni_lock);
+ return false;
+}
- if (lp->lpni_notifying || ni == NULL) {
- spin_unlock(&lp->lpni_lock);
- return;
+/*
+ * a gateway is alive only if all its nets are alive
+ * called with cpt lock held
+ */
+bool lnet_is_gateway_alive(struct lnet_peer *gw)
+{
+ struct lnet_peer_net *lpn;
+
+ if (!gw->lp_alive)
+ return false;
+
+ list_for_each_entry(lpn, &gw->lp_peer_nets, lpn_peer_nets) {
+ if (!lnet_is_gateway_net_alive(lpn))
+ return false;
}
- lp->lpni_notifying = 1;
+ return true;
+}
+
+/*
+ * lnet_is_route_alive() needs to be called with cpt lock held
+ * A route is alive if the gateway can route between the local network and
+ * the remote network of the route.
+ * This means at least one NI is alive on each of the local and remote
+ * networks of the gateway.
+ */
+bool lnet_is_route_alive(struct lnet_route *route)
+{
+ struct lnet_peer *gw = route->lr_gateway;
+ struct lnet_peer_net *llpn;
+ struct lnet_peer_net *rlpn;
+
+ /* If the gateway is down then all routes are considered down */
+ if (!gw->lp_alive)
+ return false;
/*
- * lp->lpni_notify needs to be protected because it can be set in
- * lnet_notify_locked().
+ * if discovery is disabled then rely on the cached aliveness
+ * information. This is handicapped information which we log when
+ * we receive the discovery ping response. The most uptodate
+ * aliveness information can only be obtained when discovery is
+ * enabled.
*/
- while (lp->lpni_notify) {
- alive = lp->lpni_alive;
- notifylnd = lp->lpni_notifylnd;
+ if (lnet_is_discovery_disabled(gw))
+ return atomic_read(&route->lr_alive) == 1;
- lp->lpni_notifylnd = 0;
- lp->lpni_notify = 0;
+ /*
+ * check the gateway's interfaces on the local network
+ */
+ llpn = lnet_peer_get_net_locked(gw, route->lr_lnet);
+ if (!llpn)
+ return false;
- if (notifylnd && ni->ni_net->net_lnd->lnd_notify != NULL) {
- spin_unlock(&lp->lpni_lock);
- lnet_net_unlock(lp->lpni_cpt);
+ if (!lnet_is_gateway_net_alive(llpn))
+ return false;
- /* A new notification could happen now; I'll handle it
- * when control returns to me */
+ /*
+ * For single hop routes avoid_asym_router_failure dictates
+ * that the remote net must exist on the gateway. For multi-hop
+ * routes the next-hop will not have the remote net.
+ */
+ if (avoid_asym_router_failure &&
+ (route->lr_hops == 1 || route->lr_single_hop)) {
+ rlpn = lnet_peer_get_net_locked(gw, route->lr_net);
+ if (!rlpn)
+ return false;
+ if (!lnet_is_gateway_net_alive(rlpn))
+ return false;
+ }
+
+ spin_lock(&gw->lp_lock);
+ if (!(gw->lp_state & LNET_PEER_ROUTER_ENABLED)) {
+ spin_unlock(&gw->lp_lock);
+ if (gw->lp_rtr_refcount > 0)
+ CERROR("peer %s is being used as a gateway but routing feature is not turned on\n",
+ libcfs_nidstr(&gw->lp_primary_nid));
+ return false;
+ }
+ spin_unlock(&gw->lp_lock);
+
+ return true;
+}
- (ni->ni_net->net_lnd->lnd_notify)(ni, lp->lpni_nid,
- alive);
+void
+lnet_consolidate_routes_locked(struct lnet_peer *orig_lp,
+ struct lnet_peer *new_lp)
+{
+ struct lnet_peer_ni *lpni;
+ struct lnet_route *route;
- lnet_net_lock(lp->lpni_cpt);
- spin_lock(&lp->lpni_lock);
+ /*
+ * Although a route is correlated with a peer, but when it's added
+ * a specific NID is used. That NID refers to a peer_ni within
+ * a peer. There could be other peer_nis on the same net, which
+ * can be used to send to that gateway. However when we are
+ * consolidating gateways because of discovery, the nid used to
+ * add the route might've moved between gateway peers. In this
+ * case we want to move the route to the new gateway as well. The
+ * intent here is not to confuse the user who added the route.
+ */
+ list_for_each_entry(route, &orig_lp->lp_routes, lr_gwlist) {
+ lpni = lnet_peer_ni_get_locked(orig_lp, &route->lr_nid);
+ if (!lpni) {
+ lnet_net_lock(LNET_LOCK_EX);
+ list_move(&route->lr_gwlist, &new_lp->lp_routes);
+ lnet_net_unlock(LNET_LOCK_EX);
}
}
+}
- lp->lpni_notifying = 0;
- spin_unlock(&lp->lpni_lock);
+static inline void
+lnet_check_route_inconsistency(struct lnet_route *route)
+{
+ if (!route->lr_single_hop &&
+ (route->lr_hops == 1 || route->lr_hops == LNET_UNDEFINED_HOPS) &&
+ avoid_asym_router_failure) {
+ CWARN("route %s->%s is detected to be multi-hop but hop count is set to %d\n",
+ libcfs_net2str(route->lr_net),
+ libcfs_nidstr(&route->lr_gateway->lp_primary_nid),
+ (int) route->lr_hops);
+ }
}
static void
-lnet_rtr_addref_locked(struct lnet_peer_ni *lp)
+lnet_set_route_hop_type(struct lnet_peer *gw, struct lnet_route *route)
{
- LASSERT(atomic_read(&lp->lpni_refcount) > 0);
- LASSERT(lp->lpni_rtr_refcount >= 0);
+ struct lnet_peer_net *lpn;
+ bool single_hop = false;
- /* lnet_net_lock must be exclusively locked */
- lp->lpni_rtr_refcount++;
- if (lp->lpni_rtr_refcount == 1) {
- struct list_head *pos;
+ list_for_each_entry(lpn, &gw->lp_peer_nets, lpn_peer_nets) {
+ if (route->lr_net == lpn->lpn_net_id) {
+ single_hop = true;
+ break;
+ }
+ }
+ route->lr_single_hop = single_hop;
+ lnet_check_route_inconsistency(route);
+}
- /* a simple insertion sort */
- list_for_each_prev(pos, &the_lnet.ln_routers) {
- struct lnet_peer_ni *rtr;
+/* Must hold net_lock/EX */
+void
+lnet_router_discovery_ping_reply(struct lnet_peer *lp)
+{
+ struct lnet_ping_buffer *pbuf = lp->lp_data;
+ struct lnet_peer_net *llpn;
+ struct lnet_route *route;
+ bool single_hop = false;
+ bool net_up = false;
+ unsigned lp_state;
+ __u32 net;
+ int i;
- rtr = list_entry(pos, struct lnet_peer_ni,
- lpni_rtr_list);
- if (rtr->lpni_nid < lp->lpni_nid)
- break;
+
+ spin_lock(&lp->lp_lock);
+ lp_state = lp->lp_state;
+
+ /* only handle replies if discovery is disabled. */
+ if (!lnet_is_discovery_disabled_locked(lp)) {
+ spin_unlock(&lp->lp_lock);
+ return;
+ }
+
+ spin_unlock(&lp->lp_lock);
+
+ if (lp_state & LNET_PEER_PING_FAILED ||
+ pbuf->pb_info.pi_features & LNET_PING_FEAT_RTE_DISABLED) {
+ CDEBUG(D_NET, "Set routes down for gw %s because %s %d\n",
+ libcfs_nidstr(&lp->lp_primary_nid),
+ lp_state & LNET_PEER_PING_FAILED ? "ping failed" :
+ "route feature is disabled", lp->lp_ping_error);
+ /* If the ping failed or the peer has routing disabled then
+ * mark the routes served by this peer down
+ */
+ list_for_each_entry(route, &lp->lp_routes, lr_gwlist)
+ lnet_set_route_aliveness(route, false);
+ return;
+ }
+
+ CDEBUG(D_NET, "Discovery is disabled. Processing reply for gw: %s:%d\n",
+ libcfs_nidstr(&lp->lp_primary_nid), pbuf->pb_info.pi_nnis);
+
+ /*
+ * examine the ping response to determine if the routes on that
+ * gateway should be declared alive.
+ * The route is alive if:
+ * 1. local network to reach the route is alive and
+ * 2. route is single hop, avoid_async_router_failure is set and
+ * there exists at least one NI on the route's remote net
+ */
+ list_for_each_entry(route, &lp->lp_routes, lr_gwlist) {
+ llpn = lnet_peer_get_net_locked(lp, route->lr_lnet);
+ if (!llpn) {
+ lnet_set_route_aliveness(route, false);
+ continue;
+ }
+
+ if (!lnet_is_gateway_net_alive(llpn)) {
+ lnet_set_route_aliveness(route, false);
+ continue;
+ }
+
+ single_hop = net_up = false;
+ for (i = 1; i < pbuf->pb_info.pi_nnis; i++) {
+ net = LNET_NIDNET(pbuf->pb_info.pi_ni[i].ns_nid);
+
+ if (route->lr_net == net) {
+ single_hop = true;
+ if (pbuf->pb_info.pi_ni[i].ns_status ==
+ LNET_NI_STATUS_UP) {
+ net_up = true;
+ break;
+ }
+ }
+ }
+
+ route->lr_single_hop = single_hop;
+ if (avoid_asym_router_failure &&
+ (route->lr_hops == 1 || route->lr_single_hop))
+ lnet_set_route_aliveness(route, net_up);
+ else
+ lnet_set_route_aliveness(route, true);
+
+ /*
+ * warn that the route is configured as single-hop but it
+ * really is multi-hop as far as we can tell.
+ */
+ lnet_check_route_inconsistency(route);
+ }
+}
+
+void
+lnet_router_discovery_complete(struct lnet_peer *lp)
+{
+ struct lnet_peer_ni *lpni = NULL;
+ struct lnet_route *route;
+
+ spin_lock(&lp->lp_lock);
+ lp->lp_state &= ~LNET_PEER_RTR_DISCOVERY;
+ lp->lp_state |= LNET_PEER_RTR_DISCOVERED;
+ lp->lp_alive = lp->lp_dc_error == 0;
+ spin_unlock(&lp->lp_lock);
+
+ if (!lp->lp_dc_error) {
+ /* ping replies are being handled when discovery is disabled */
+ if (lnet_is_discovery_disabled_locked(lp))
+ return;
+
+ /*
+ * mark single-hop routes. If the remote net is not configured on
+ * the gateway we assume this is intentional and we mark the
+ * gateway as multi-hop
+ */
+ list_for_each_entry(route, &lp->lp_routes, lr_gwlist) {
+ lnet_set_route_aliveness(route, true);
+ lnet_set_route_hop_type(lp, route);
}
- list_add(&lp->lpni_rtr_list, pos);
+ return;
+ }
+
+ /*
+ * We do not send messages directly to the remote interfaces
+ * of an LNet router. As such, we rely on the PING response
+ * to determine the up/down status of these interfaces. If
+ * a PING response is not receieved, or some other problem with
+ * discovery occurs that prevents us from getting this status,
+ * we assume all interfaces are down until we're able to
+ * determine otherwise.
+ */
+ CDEBUG(D_NET, "%s: Router discovery failed %d\n",
+ libcfs_nidstr(&lp->lp_primary_nid), lp->lp_dc_error);
+ while ((lpni = lnet_get_next_peer_ni_locked(lp, NULL, lpni)) != NULL)
+ lpni->lpni_ns_status = LNET_NI_STATUS_DOWN;
+
+ list_for_each_entry(route, &lp->lp_routes, lr_gwlist)
+ lnet_set_route_aliveness(route, false);
+}
+
+static void
+lnet_rtr_addref_locked(struct lnet_peer *lp)
+{
+ LASSERT(lp->lp_rtr_refcount >= 0);
+
+ /* lnet_net_lock must be exclusively locked */
+ lp->lp_rtr_refcount++;
+ if (lp->lp_rtr_refcount == 1) {
+ list_add_tail(&lp->lp_rtr_list, &the_lnet.ln_routers);
/* addref for the_lnet.ln_routers */
- lnet_peer_ni_addref_locked(lp);
+ lnet_peer_addref_locked(lp);
the_lnet.ln_routers_version++;
}
}
static void
-lnet_rtr_decref_locked(struct lnet_peer_ni *lp)
+lnet_rtr_decref_locked(struct lnet_peer *lp)
{
- LASSERT(atomic_read(&lp->lpni_refcount) > 0);
- LASSERT(lp->lpni_rtr_refcount > 0);
+ LASSERT(atomic_read(&lp->lp_refcount) > 0);
+ LASSERT(lp->lp_rtr_refcount > 0);
/* lnet_net_lock must be exclusively locked */
- lp->lpni_rtr_refcount--;
- if (lp->lpni_rtr_refcount == 0) {
- LASSERT(list_empty(&lp->lpni_routes));
-
- if (lp->lpni_rcd != NULL) {
- list_add(&lp->lpni_rcd->rcd_list,
- &the_lnet.ln_rcd_deathrow);
- lp->lpni_rcd = NULL;
- }
+ lp->lp_rtr_refcount--;
+ if (lp->lp_rtr_refcount == 0) {
+ LASSERT(list_empty(&lp->lp_routes));
- list_del(&lp->lpni_rtr_list);
+ list_del(&lp->lp_rtr_list);
/* decref for the_lnet.ln_routers */
- lnet_peer_ni_decref_locked(lp);
+ lnet_peer_decref_locked(lp);
the_lnet.ln_routers_version++;
}
}
lnet_find_rnet_locked(__u32 net)
{
struct lnet_remotenet *rnet;
- struct list_head *tmp;
struct list_head *rn_list;
LASSERT(the_lnet.ln_state == LNET_STATE_RUNNING);
rn_list = lnet_net2rnethash(net);
- list_for_each(tmp, rn_list) {
- rnet = list_entry(tmp, struct lnet_remotenet, lrn_list);
-
+ list_for_each_entry(rnet, rn_list, lrn_list) {
if (rnet->lrn_net == net)
return rnet;
}
static void lnet_shuffle_seed(void)
{
static int seeded;
- __u32 lnd_type;
- __u32 seed[2];
- struct timespec64 ts;
struct lnet_ni *ni = NULL;
if (seeded)
return;
- cfs_get_random_bytes(seed, sizeof(seed));
-
/* Nodes with small feet have little entropy
* the NID for this node gives the most entropy in the low bits */
- while ((ni = lnet_get_next_ni_locked(NULL, ni))) {
- lnd_type = LNET_NETTYP(LNET_NIDNET(ni->ni_nid));
-
- if (lnd_type != LOLND)
- seed[0] ^= (LNET_NIDADDR(ni->ni_nid) | lnd_type);
- }
+ while ((ni = lnet_get_next_ni_locked(NULL, ni)))
+ add_device_randomness(&ni->ni_nid, sizeof(ni->ni_nid));
- ktime_get_ts64(&ts);
- cfs_srand(ts.tv_sec ^ seed[0], ts.tv_nsec ^ seed[1]);
seeded = 1;
- return;
}
/* NB expects LNET_LOCK held */
static void
lnet_add_route_to_rnet(struct lnet_remotenet *rnet, struct lnet_route *route)
{
- unsigned int len = 0;
- unsigned int offset = 0;
+ struct lnet_peer_net *lpn;
+ unsigned int offset = 0;
+ unsigned int len = 0;
struct list_head *e;
+ time64_t now;
lnet_shuffle_seed();
- list_for_each(e, &rnet->lrn_routes) {
+ list_for_each(e, &rnet->lrn_routes)
len++;
- }
- /* len+1 positions to add a new entry, also prevents division by 0 */
- offset = cfs_rand() % (len + 1);
+ /*
+ * Randomly adding routes to the list is done to ensure that when
+ * different nodes are using the same list of routers, they end up
+ * preferring different routers.
+ */
+ offset = prandom_u32_max(len + 1);
list_for_each(e, &rnet->lrn_routes) {
if (offset == 0)
break;
offset--;
}
list_add(&route->lr_list, e);
- list_add(&route->lr_gwlist, &route->lr_gateway->lpni_routes);
+ /*
+ * force a router check on the gateway to make sure the route is
+ * alive
+ */
+ now = ktime_get_real_seconds();
+ list_for_each_entry(lpn, &route->lr_gateway->lp_peer_nets,
+ lpn_peer_nets) {
+ lpn->lpn_next_ping = now;
+ }
the_lnet.ln_remote_nets_version++;
+
+ /* add the route on the gateway list */
+ list_add(&route->lr_gwlist, &route->lr_gateway->lp_routes);
+
+ /* take a router reference count on the gateway */
lnet_rtr_addref_locked(route->lr_gateway);
}
int
-lnet_add_route(__u32 net, __u32 hops, lnet_nid_t gateway,
- unsigned int priority)
+lnet_add_route(__u32 net, __u32 hops, struct lnet_nid *gateway,
+ __u32 priority, __u32 sensitivity)
{
- struct list_head *e;
- struct lnet_remotenet *rnet;
- struct lnet_remotenet *rnet2;
- struct lnet_route *route;
- struct lnet_ni *ni;
- struct lnet_peer_ni *lpni;
- int add_route;
- int rc;
-
- CDEBUG(D_NET, "Add route: net %s hops %d priority %u gw %s\n",
- libcfs_net2str(net), hops, priority, libcfs_nid2str(gateway));
-
- if (gateway == LNET_NID_ANY ||
- LNET_NETTYP(LNET_NIDNET(gateway)) == LOLND ||
- net == LNET_NIDNET(LNET_NID_ANY) ||
+ struct list_head *route_entry;
+ struct lnet_remotenet *rnet;
+ struct lnet_remotenet *rnet2;
+ struct lnet_route *route;
+ struct lnet_peer_ni *lpni;
+ struct lnet_peer *gw;
+ int add_route;
+ int rc;
+
+ CDEBUG(D_NET, "Add route: remote net %s hops %d priority %u gw %s\n",
+ libcfs_net2str(net), hops, priority, libcfs_nidstr(gateway));
+
+ if (LNET_NID_IS_ANY(gateway) ||
+ nid_is_lo0(gateway) ||
+ net == LNET_NET_ANY ||
LNET_NETTYP(net) == LOLND ||
- LNET_NIDNET(gateway) == net ||
+ LNET_NID_NET(gateway) == net ||
(hops != LNET_UNDEFINED_HOPS && (hops < 1 || hops > 255)))
return -EINVAL;
- if (lnet_islocalnet(net)) /* it's a local network */
+ /* it's a local network */
+ if (lnet_islocalnet(net))
return -EEXIST;
+ if (!lnet_islocalnet(LNET_NID_NET(gateway))) {
+ CERROR("Cannot add route with gateway %s. There is no local interface configured on LNet %s\n",
+ libcfs_nidstr(gateway),
+ libcfs_net2str(LNET_NID_NET(gateway)));
+ return -EHOSTUNREACH;
+ }
+
/* Assume net, route, all new */
LIBCFS_ALLOC(route, sizeof(*route));
LIBCFS_ALLOC(rnet, sizeof(*rnet));
if (route == NULL || rnet == NULL) {
CERROR("Out of memory creating route %s %d %s\n",
- libcfs_net2str(net), hops, libcfs_nid2str(gateway));
+ libcfs_net2str(net), hops, libcfs_nidstr(gateway));
if (route != NULL)
LIBCFS_FREE(route, sizeof(*route));
if (rnet != NULL)
INIT_LIST_HEAD(&rnet->lrn_routes);
rnet->lrn_net = net;
- route->lr_hops = hops;
+ /* store the local and remote net that the route represents */
+ route->lr_lnet = LNET_NID_NET(gateway);
route->lr_net = net;
+ route->lr_nid = *gateway;
route->lr_priority = priority;
+ route->lr_hops = hops;
+ if (lnet_peers_start_down())
+ atomic_set(&route->lr_alive, 0);
+ else
+ atomic_set(&route->lr_alive, 1);
lnet_net_lock(LNET_LOCK_EX);
- lpni = lnet_nid2peerni_ex(gateway, LNET_LOCK_EX);
+ /*
+ * lnet_nid2peerni_ex() grabs a ref on the lpni. We will need to
+ * lose that once we're done
+ */
+ lpni = lnet_nid2peerni_ex(gateway);
if (IS_ERR(lpni)) {
lnet_net_unlock(LNET_LOCK_EX);
LIBCFS_FREE(rnet, sizeof(*rnet));
rc = PTR_ERR(lpni);
- if (rc == -EHOSTUNREACH) /* gateway is not on a local net. */
- return rc; /* ignore the route entry */
CERROR("Error %d creating route %s %d %s\n", rc,
libcfs_net2str(net), hops,
- libcfs_nid2str(gateway));
+ libcfs_nidstr(gateway));
return rc;
}
- route->lr_gateway = lpni;
- LASSERT(the_lnet.ln_state == LNET_STATE_RUNNING);
+
+ LASSERT(lpni);
+ LASSERT(lpni->lpni_peer_net);
+ LASSERT(lpni->lpni_peer_net->lpn_peer);
+ gw = lpni->lpni_peer_net->lpn_peer;
+
+ route->lr_gateway = gw;
rnet2 = lnet_find_rnet_locked(net);
if (rnet2 == NULL) {
/* Search for a duplicate route (it's a NOOP if it is) */
add_route = 1;
- list_for_each(e, &rnet2->lrn_routes) {
+ list_for_each(route_entry, &rnet2->lrn_routes) {
struct lnet_route *route2;
- route2 = list_entry(e, struct lnet_route, lr_list);
+ route2 = list_entry(route_entry, struct lnet_route, lr_list);
if (route2->lr_gateway == route->lr_gateway) {
add_route = 0;
break;
}
/* our lookups must be true */
- LASSERT(route2->lr_gateway->lpni_nid != gateway);
+ LASSERT(!nid_same(&route2->lr_gateway->lp_primary_nid,
+ gateway));
}
+ /*
+ * It is possible to add multiple routes through the same peer,
+ * but it'll be using a different NID of that peer. When the
+ * gateway is discovered, discovery will consolidate the different
+ * peers into one peer. In this case the discovery code will have
+ * to move the routes from the peer that's being deleted to the
+ * consolidated peer lp_routes list
+ */
if (add_route) {
- lnet_peer_ni_addref_locked(route->lr_gateway); /* +1 for notify */
+ gw->lp_health_sensitivity = sensitivity;
lnet_add_route_to_rnet(rnet2, route);
-
- ni = lnet_get_next_ni_locked(route->lr_gateway->lpni_net, NULL);
- lnet_net_unlock(LNET_LOCK_EX);
-
- /* XXX Assume alive */
- if (ni->ni_net->net_lnd->lnd_notify != NULL)
- (ni->ni_net->net_lnd->lnd_notify)(ni, gateway, 1);
-
- lnet_net_lock(LNET_LOCK_EX);
+ if (lnet_peer_discovery_disabled)
+ CWARN("Consider turning discovery on to enable full Multi-Rail routing functionality\n");
}
- /* -1 for notify or !add_route */
- lnet_peer_ni_decref_locked(route->lr_gateway);
+ /*
+ * get rid of the reference on the lpni.
+ */
+ lnet_peer_ni_decref_locked(lpni);
lnet_net_unlock(LNET_LOCK_EX);
+ /* If avoid_asym_router_failure is enabled and hop count is not
+ * set to 1 for a route that is actually single-hop, then the
+ * feature will fail to prevent the router from being selected
+ * if it is missing a NI on the remote network due to misconfiguration.
+ */
+ if (avoid_asym_router_failure && hops == LNET_UNDEFINED_HOPS)
+ CWARN("Use hops = 1 for a single-hop route when avoid_asym_router_failure feature is enabled\n");
+
rc = 0;
if (!add_route) {
LIBCFS_FREE(rnet, sizeof(*rnet));
/* kick start the monitor thread to handle the added route */
- wake_up(&the_lnet.ln_mt_waitq);
+ complete(&the_lnet.ln_mt_wait_complete);
return rc;
}
-int
-lnet_check_routes(void)
+void
+lnet_del_route_from_rnet(struct lnet_nid *gw_nid,
+ struct list_head *route_list,
+ struct list_head *zombies)
{
- struct lnet_remotenet *rnet;
- struct lnet_route *route;
- struct lnet_route *route2;
- struct list_head *e1;
- struct list_head *e2;
- int cpt;
- struct list_head *rn_list;
- int i;
+ struct lnet_peer *gateway;
+ struct lnet_route *route;
+ struct lnet_route *tmp;
- cpt = lnet_net_lock_current();
-
- for (i = 0; i < LNET_REMOTE_NETS_HASH_SIZE; i++) {
- rn_list = &the_lnet.ln_remote_nets_hash[i];
- list_for_each(e1, rn_list) {
- rnet = list_entry(e1, struct lnet_remotenet, lrn_list);
-
- route2 = NULL;
- list_for_each(e2, &rnet->lrn_routes) {
- lnet_nid_t nid1;
- lnet_nid_t nid2;
- int net;
-
- route = list_entry(e2, struct lnet_route,
- lr_list);
-
- if (route2 == NULL) {
- route2 = route;
- continue;
- }
-
- if (route->lr_gateway->lpni_net ==
- route2->lr_gateway->lpni_net)
- continue;
-
- nid1 = route->lr_gateway->lpni_nid;
- nid2 = route2->lr_gateway->lpni_nid;
- net = rnet->lrn_net;
+ list_for_each_entry_safe(route, tmp, route_list, lr_list) {
+ gateway = route->lr_gateway;
+ if (gw_nid && !nid_same(gw_nid, &gateway->lp_primary_nid))
+ continue;
- lnet_net_unlock(cpt);
+ /*
+ * move to zombie to delete outside the lock
+ * Note that this function is called with the
+ * ln_api_mutex held as well as the exclusive net
+ * lock. Adding to the remote net list happens
+ * under the same conditions. Same goes for the
+ * gateway router list
+ */
+ list_move(&route->lr_list, zombies);
+ the_lnet.ln_remote_nets_version++;
- CERROR("Routes to %s via %s and %s not "
- "supported\n",
- libcfs_net2str(net),
- libcfs_nid2str(nid1),
- libcfs_nid2str(nid2));
- return -EINVAL;
- }
- }
+ list_del(&route->lr_gwlist);
+ lnet_rtr_decref_locked(gateway);
}
-
- lnet_net_unlock(cpt);
- return 0;
}
int
-lnet_del_route(__u32 net, lnet_nid_t gw_nid)
+lnet_del_route(__u32 net, struct lnet_nid *gw)
{
- struct lnet_peer_ni *gateway;
- struct lnet_remotenet *rnet;
- struct lnet_route *route;
- struct list_head *e1;
- struct list_head *e2;
- int rc = -ENOENT;
- struct list_head *rn_list;
- int idx = 0;
+ LIST_HEAD(rnet_zombies);
+ struct lnet_remotenet *rnet;
+ struct lnet_remotenet *tmp;
+ struct list_head *rn_list;
+ struct lnet_peer_ni *lpni;
+ struct lnet_route *route;
+ struct lnet_nid gw_nid;
+ LIST_HEAD(zombies);
+ struct lnet_peer *lp = NULL;
+ int i = 0;
CDEBUG(D_NET, "Del route: net %s : gw %s\n",
- libcfs_net2str(net), libcfs_nid2str(gw_nid));
+ libcfs_net2str(net), libcfs_nidstr(gw));
/* NB Caller may specify either all routes via the given gateway
* or a specific route entry actual NIDs) */
lnet_net_lock(LNET_LOCK_EX);
- if (net == LNET_NIDNET(LNET_NID_ANY))
- rn_list = &the_lnet.ln_remote_nets_hash[0];
- else
- rn_list = lnet_net2rnethash(net);
-
-again:
- list_for_each(e1, rn_list) {
- rnet = list_entry(e1, struct lnet_remotenet, lrn_list);
- if (!(net == LNET_NIDNET(LNET_NID_ANY) ||
- net == rnet->lrn_net))
- continue;
-
- list_for_each(e2, &rnet->lrn_routes) {
- route = list_entry(e2, struct lnet_route, lr_list);
-
- gateway = route->lr_gateway;
- if (!(gw_nid == LNET_NID_ANY ||
- gw_nid == gateway->lpni_nid))
- continue;
+ if (gw)
+ lpni = lnet_peer_ni_find_locked(gw);
+ else
+ lpni = NULL;
+ if (lpni) {
+ lp = lpni->lpni_peer_net->lpn_peer;
+ LASSERT(lp);
+ gw_nid = lp->lp_primary_nid;
+ gw = &gw_nid;
+ lnet_peer_ni_decref_locked(lpni);
+ }
+
+ if (net != LNET_NET_ANY) {
+ rnet = lnet_find_rnet_locked(net);
+ if (!rnet) {
+ lnet_net_unlock(LNET_LOCK_EX);
+ return -ENOENT;
+ }
+ lnet_del_route_from_rnet(gw, &rnet->lrn_routes,
+ &zombies);
+ if (list_empty(&rnet->lrn_routes))
+ list_move(&rnet->lrn_list, &rnet_zombies);
+ goto delete_zombies;
+ }
- list_del(&route->lr_list);
- list_del(&route->lr_gwlist);
- the_lnet.ln_remote_nets_version++;
+ for (i = 0; i < LNET_REMOTE_NETS_HASH_SIZE; i++) {
+ rn_list = &the_lnet.ln_remote_nets_hash[i];
+ list_for_each_entry_safe(rnet, tmp, rn_list, lrn_list) {
+ lnet_del_route_from_rnet(gw, &rnet->lrn_routes,
+ &zombies);
if (list_empty(&rnet->lrn_routes))
- list_del(&rnet->lrn_list);
- else
- rnet = NULL;
-
- lnet_rtr_decref_locked(gateway);
- lnet_peer_ni_decref_locked(gateway);
-
- lnet_net_unlock(LNET_LOCK_EX);
+ list_move(&rnet->lrn_list, &rnet_zombies);
+ }
+ }
- LIBCFS_FREE(route, sizeof(*route));
+delete_zombies:
+ /*
+ * check if there are any routes remaining on the gateway
+ * If there are no more routes make sure to set the peer's
+ * lp_disc_net_id to 0 (invalid), in case we add more routes in
+ * the future on that gateway, then we start our discovery process
+ * from scratch
+ */
+ if (lpni) {
+ if (list_empty(&lp->lp_routes))
+ lp->lp_disc_net_id = 0;
+ }
- if (rnet != NULL)
- LIBCFS_FREE(rnet, sizeof(*rnet));
+ lnet_net_unlock(LNET_LOCK_EX);
- rc = 0;
- lnet_net_lock(LNET_LOCK_EX);
- goto again;
- }
+ while (!list_empty(&zombies)) {
+ route = list_first_entry(&zombies, struct lnet_route, lr_list);
+ list_del(&route->lr_list);
+ LIBCFS_FREE(route, sizeof(*route));
}
- if (net == LNET_NIDNET(LNET_NID_ANY) &&
- ++idx < LNET_REMOTE_NETS_HASH_SIZE) {
- rn_list = &the_lnet.ln_remote_nets_hash[idx];
- goto again;
+ while (!list_empty(&rnet_zombies)) {
+ rnet = list_first_entry(&rnet_zombies, struct lnet_remotenet,
+ lrn_list);
+ list_del(&rnet->lrn_list);
+ LIBCFS_FREE(rnet, sizeof(*rnet));
}
- lnet_net_unlock(LNET_LOCK_EX);
- return rc;
+ return 0;
}
void
-lnet_destroy_routes (void)
+lnet_destroy_routes(void)
{
- lnet_del_route(LNET_NIDNET(LNET_NID_ANY), LNET_NID_ANY);
+ lnet_del_route(LNET_NET_ANY, NULL);
}
-int lnet_get_rtr_pool_cfg(int idx, struct lnet_ioctl_pool_cfg *pool_cfg)
+int lnet_get_rtr_pool_cfg(int cpt, struct lnet_ioctl_pool_cfg *pool_cfg)
{
+ struct lnet_rtrbufpool *rbp;
int i, rc = -ENOENT, j;
if (the_lnet.ln_rtrpools == NULL)
return rc;
- for (i = 0; i < LNET_NRBPOOLS; i++) {
- struct lnet_rtrbufpool *rbp;
- lnet_net_lock(LNET_LOCK_EX);
- cfs_percpt_for_each(rbp, j, the_lnet.ln_rtrpools) {
- if (i++ != idx)
- continue;
+ cfs_percpt_for_each(rbp, i, the_lnet.ln_rtrpools) {
+ if (i != cpt)
+ continue;
- pool_cfg->pl_pools[i].pl_npages = rbp[i].rbp_npages;
- pool_cfg->pl_pools[i].pl_nbuffers = rbp[i].rbp_nbuffers;
- pool_cfg->pl_pools[i].pl_credits = rbp[i].rbp_credits;
- pool_cfg->pl_pools[i].pl_mincredits = rbp[i].rbp_mincredits;
- rc = 0;
- break;
+ lnet_net_lock(i);
+ for (j = 0; j < LNET_NRBPOOLS; j++) {
+ pool_cfg->pl_pools[j].pl_npages = rbp[j].rbp_npages;
+ pool_cfg->pl_pools[j].pl_nbuffers = rbp[j].rbp_nbuffers;
+ pool_cfg->pl_pools[j].pl_credits = rbp[j].rbp_credits;
+ pool_cfg->pl_pools[j].pl_mincredits = rbp[j].rbp_mincredits;
}
- lnet_net_unlock(LNET_LOCK_EX);
+ lnet_net_unlock(i);
+ rc = 0;
+ break;
}
lnet_net_lock(LNET_LOCK_EX);
}
int
-lnet_get_route(int idx, __u32 *net, __u32 *hops,
- lnet_nid_t *gateway, __u32 *alive, __u32 *priority)
+lnet_get_route(int idx, __u32 *net, __u32 *hops, lnet_nid_t *gateway,
+ __u32 *flags, __u32 *priority, __u32 *sensitivity)
{
- struct list_head *e1;
- struct list_head *e2;
struct lnet_remotenet *rnet;
- struct lnet_route *route;
- int cpt;
- int i;
struct list_head *rn_list;
+ struct lnet_route *route;
+ int cpt;
+ int i;
cpt = lnet_net_lock_current();
for (i = 0; i < LNET_REMOTE_NETS_HASH_SIZE; i++) {
rn_list = &the_lnet.ln_remote_nets_hash[i];
- list_for_each(e1, rn_list) {
- rnet = list_entry(e1, struct lnet_remotenet, lrn_list);
-
- list_for_each(e2, &rnet->lrn_routes) {
- route = list_entry(e2, struct lnet_route,
- lr_list);
-
+ list_for_each_entry(rnet, rn_list, lrn_list) {
+ list_for_each_entry(route, &rnet->lrn_routes, lr_list) {
if (idx-- == 0) {
*net = rnet->lrn_net;
+ *gateway = lnet_nid_to_nid4(&route->lr_nid);
*hops = route->lr_hops;
*priority = route->lr_priority;
- *gateway = route->lr_gateway->lpni_nid;
- *alive = lnet_is_route_alive(route);
+ *sensitivity = route->lr_gateway->
+ lp_health_sensitivity;
+ if (lnet_is_route_alive(route))
+ *flags |= LNET_RT_ALIVE;
+ else
+ *flags &= ~LNET_RT_ALIVE;
+ if (route->lr_single_hop)
+ *flags &= ~LNET_RT_MULTI_HOP;
+ else
+ *flags |= LNET_RT_MULTI_HOP;
lnet_net_unlock(cpt);
return 0;
}
return -ENOENT;
}
-void
-lnet_swap_pinginfo(struct lnet_ping_buffer *pbuf)
-{
- struct lnet_ni_status *stat;
- int nnis;
- int i;
-
- __swab32s(&pbuf->pb_info.pi_magic);
- __swab32s(&pbuf->pb_info.pi_features);
- __swab32s(&pbuf->pb_info.pi_pid);
- __swab32s(&pbuf->pb_info.pi_nnis);
- nnis = pbuf->pb_info.pi_nnis;
- if (nnis > pbuf->pb_nnis)
- nnis = pbuf->pb_nnis;
- for (i = 0; i < nnis; i++) {
- stat = &pbuf->pb_info.pi_ni[i];
- __swab64s(&stat->ns_nid);
- __swab32s(&stat->ns_status);
- }
- return;
-}
-
-/**
- * parse router-checker pinginfo, record number of down NIs for remote
- * networks on that router.
- */
-static void
-lnet_parse_rc_info(struct lnet_rc_data *rcd)
-{
- struct lnet_ping_buffer *pbuf = rcd->rcd_pingbuffer;
- struct lnet_peer_ni *gw = rcd->rcd_gateway;
- struct lnet_route *rte;
- int nnis;
-
- if (!gw->lpni_alive || !pbuf)
- return;
-
- /*
- * Protect gw->lpni_ping_feats. This can be set from
- * lnet_notify_locked with different locks being held
- */
- spin_lock(&gw->lpni_lock);
-
- if (pbuf->pb_info.pi_magic == __swab32(LNET_PROTO_PING_MAGIC))
- lnet_swap_pinginfo(pbuf);
-
- /* NB always racing with network! */
- if (pbuf->pb_info.pi_magic != LNET_PROTO_PING_MAGIC) {
- CDEBUG(D_NET, "%s: Unexpected magic %08x\n",
- libcfs_nid2str(gw->lpni_nid), pbuf->pb_info.pi_magic);
- gw->lpni_ping_feats = LNET_PING_FEAT_INVAL;
- goto out;
- }
-
- gw->lpni_ping_feats = pbuf->pb_info.pi_features;
-
- /* Without NI status info there's nothing more to do. */
- if ((gw->lpni_ping_feats & LNET_PING_FEAT_NI_STATUS) == 0)
- goto out;
-
- /* Determine the number of NIs for which there is data. */
- nnis = pbuf->pb_info.pi_nnis;
- if (pbuf->pb_nnis < nnis) {
- if (rcd->rcd_nnis < nnis)
- rcd->rcd_nnis = nnis;
- nnis = pbuf->pb_nnis;
- }
-
- list_for_each_entry(rte, &gw->lpni_routes, lr_gwlist) {
- int down = 0;
- int up = 0;
- int i;
-
- /* If routing disabled then the route is down. */
- if ((gw->lpni_ping_feats & LNET_PING_FEAT_RTE_DISABLED) != 0) {
- rte->lr_downis = 1;
- continue;
- }
-
- for (i = 0; i < nnis; i++) {
- struct lnet_ni_status *stat = &pbuf->pb_info.pi_ni[i];
- lnet_nid_t nid = stat->ns_nid;
-
- if (nid == LNET_NID_ANY) {
- CDEBUG(D_NET, "%s: unexpected LNET_NID_ANY\n",
- libcfs_nid2str(gw->lpni_nid));
- gw->lpni_ping_feats = LNET_PING_FEAT_INVAL;
- goto out;
- }
-
- if (LNET_NETTYP(LNET_NIDNET(nid)) == LOLND)
- continue;
-
- if (stat->ns_status == LNET_NI_STATUS_DOWN) {
- down++;
- continue;
- }
-
- if (stat->ns_status == LNET_NI_STATUS_UP) {
- if (LNET_NIDNET(nid) == rte->lr_net) {
- up = 1;
- break;
- }
- continue;
- }
-
- CDEBUG(D_NET, "%s: Unexpected status 0x%x\n",
- libcfs_nid2str(gw->lpni_nid), stat->ns_status);
- gw->lpni_ping_feats = LNET_PING_FEAT_INVAL;
- goto out;
- }
-
- if (up) { /* ignore downed NIs if NI for dest network is up */
- rte->lr_downis = 0;
- continue;
- }
- /* if @down is zero and this route is single-hop, it means
- * we can't find NI for target network */
- if (down == 0 && rte->lr_hops == 1)
- down = 1;
-
- rte->lr_downis = down;
- }
-out:
- spin_unlock(&gw->lpni_lock);
-}
-
-static void
-lnet_router_checker_event(struct lnet_event *event)
-{
- struct lnet_rc_data *rcd = event->md.user_ptr;
- struct lnet_peer_ni *lp;
-
- LASSERT(rcd != NULL);
-
- if (event->unlinked) {
- LNetInvalidateMDHandle(&rcd->rcd_mdh);
- return;
- }
-
- LASSERT(event->type == LNET_EVENT_SEND ||
- event->type == LNET_EVENT_REPLY);
-
- lp = rcd->rcd_gateway;
- LASSERT(lp != NULL);
-
- /* NB: it's called with holding lnet_res_lock, we have a few
- * places need to hold both locks at the same time, please take
- * care of lock ordering */
- lnet_net_lock(lp->lpni_cpt);
- if (!lnet_isrouter(lp) || lp->lpni_rcd != rcd) {
- /* ignore if no longer a router or rcd is replaced */
- goto out;
- }
-
- if (event->type == LNET_EVENT_SEND) {
- lp->lpni_ping_notsent = 0;
- if (event->status == 0)
- goto out;
- }
-
- /* LNET_EVENT_REPLY */
- /* A successful REPLY means the router is up. If _any_ comms
- * to the router fail I assume it's down (this will happen if
- * we ping alive routers to try to detect router death before
- * apps get burned). */
-
- lnet_notify_locked(lp, 1, !event->status, ktime_get_seconds());
- /* The router checker will wake up very shortly and do the
- * actual notification.
- * XXX If 'lp' stops being a router before then, it will still
- * have the notification pending!!! */
-
- if (avoid_asym_router_failure && event->status == 0)
- lnet_parse_rc_info(rcd);
-
- out:
- lnet_net_unlock(lp->lpni_cpt);
-}
-
static void
lnet_wait_known_routerstate(void)
{
- struct lnet_peer_ni *rtr;
- struct list_head *entry;
+ struct lnet_peer *rtr;
int all_known;
LASSERT(the_lnet.ln_mt_state == LNET_MT_STATE_RUNNING);
int cpt = lnet_net_lock_current();
all_known = 1;
- list_for_each(entry, &the_lnet.ln_routers) {
- rtr = list_entry(entry, struct lnet_peer_ni,
- lpni_rtr_list);
-
- spin_lock(&rtr->lpni_lock);
+ list_for_each_entry(rtr, &the_lnet.ln_routers, lp_rtr_list) {
+ spin_lock(&rtr->lp_lock);
- if (rtr->lpni_alive_count == 0) {
+ if ((rtr->lp_state & LNET_PEER_RTR_DISCOVERED) == 0) {
all_known = 0;
- spin_unlock(&rtr->lpni_lock);
+ spin_unlock(&rtr->lp_lock);
break;
}
- spin_unlock(&rtr->lpni_lock);
+ spin_unlock(&rtr->lp_lock);
}
lnet_net_unlock(cpt);
if (all_known)
return;
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(cfs_time_seconds(1));
+ schedule_timeout_uninterruptible(cfs_time_seconds(1));
}
}
-void
-lnet_router_ni_update_locked(struct lnet_peer_ni *gw, __u32 net)
+static inline bool
+lnet_net_set_status_locked(struct lnet_net *net, __u32 status)
{
- struct lnet_route *rte;
+ struct lnet_ni *ni;
+ bool update = false;
- if ((gw->lpni_ping_feats & LNET_PING_FEAT_NI_STATUS) != 0) {
- list_for_each_entry(rte, &gw->lpni_routes, lr_gwlist) {
- if (rte->lr_net == net) {
- rte->lr_downis = 0;
- break;
- }
- }
- }
+ list_for_each_entry(ni, &net->net_ni_list, ni_netlist)
+ if (lnet_ni_set_status(ni, status))
+ update = true;
+
+ return update;
}
-static void
+static bool
lnet_update_ni_status_locked(void)
{
- struct lnet_ni *ni = NULL;
+ struct lnet_net *net;
+ struct lnet_ni *ni;
+ bool push = false;
time64_t now;
time64_t timeout;
LASSERT(the_lnet.ln_routing);
- timeout = router_ping_timeout +
- MAX(live_router_check_interval, dead_router_check_interval);
+ timeout = router_ping_timeout + alive_router_check_interval;
- now = ktime_get_real_seconds();
- while ((ni = lnet_get_next_ni_locked(NULL, ni))) {
- if (ni->ni_net->net_lnd->lnd_type == LOLND)
+ now = ktime_get_seconds();
+ list_for_each_entry(net, &the_lnet.ln_nets, net_list) {
+ if (net->net_lnd->lnd_type == LOLND)
continue;
- if (now < ni->ni_last_alive + timeout)
- continue;
+ if (now < net->net_last_alive + timeout)
+ goto check_ni_fatal;
- lnet_ni_lock(ni);
+ spin_lock(&net->net_lock);
/* re-check with lock */
- if (now < ni->ni_last_alive + timeout) {
- lnet_ni_unlock(ni);
+ if (now < net->net_last_alive + timeout) {
+ spin_unlock(&net->net_lock);
+ goto check_ni_fatal;
+ }
+ spin_unlock(&net->net_lock);
+
+ /*
+ * if the net didn't receive any traffic for past the
+ * timeout on any of its constituent NIs, then mark all
+ * the NIs down.
+ */
+ if (lnet_net_set_status_locked(net, LNET_NI_STATUS_DOWN)) {
+ push = true;
continue;
}
- LASSERT(ni->ni_status != NULL);
-
- if (ni->ni_status->ns_status != LNET_NI_STATUS_DOWN) {
- CDEBUG(D_NET, "NI(%s:%lld) status changed to down\n",
- libcfs_nid2str(ni->ni_nid), timeout);
- /* NB: so far, this is the only place to set
- * NI status to "down" */
- ni->ni_status->ns_status = LNET_NI_STATUS_DOWN;
+check_ni_fatal:
+ list_for_each_entry(ni, &net->net_ni_list, ni_netlist) {
+ /* lnet_ni_set_status() will perform the same check of
+ * ni_status while holding the ni lock. We can safely
+ * check ni_status without that lock because it is only
+ * written to under net_lock/EX and our caller is
+ * holding a net lock.
+ */
+ if (atomic_read(&ni->ni_fatal_error_on) &&
+ ni->ni_status &&
+ ni->ni_status->ns_status != LNET_NI_STATUS_DOWN &&
+ lnet_ni_set_status(ni, LNET_NI_STATUS_DOWN))
+ push = true;
}
- lnet_ni_unlock(ni);
}
-}
-
-static void
-lnet_destroy_rc_data(struct lnet_rc_data *rcd)
-{
- LASSERT(list_empty(&rcd->rcd_list));
- /* detached from network */
- LASSERT(LNetMDHandleIsInvalid(rcd->rcd_mdh));
-
- if (rcd->rcd_gateway != NULL) {
- int cpt = rcd->rcd_gateway->lpni_cpt;
- lnet_net_lock(cpt);
- lnet_peer_ni_decref_locked(rcd->rcd_gateway);
- lnet_net_unlock(cpt);
- }
-
- if (rcd->rcd_pingbuffer != NULL)
- lnet_ping_buffer_decref(rcd->rcd_pingbuffer);
-
- LIBCFS_FREE(rcd, sizeof(*rcd));
+ return push;
}
-static struct lnet_rc_data *
-lnet_update_rc_data_locked(struct lnet_peer_ni *gateway)
-{
- struct lnet_handle_md mdh;
- struct lnet_rc_data *rcd;
- struct lnet_ping_buffer *pbuf = NULL;
- int nnis = LNET_INTERFACES_MIN;
- int rc;
- int i;
-
- rcd = gateway->lpni_rcd;
- if (rcd) {
- nnis = rcd->rcd_nnis;
- mdh = rcd->rcd_mdh;
- LNetInvalidateMDHandle(&rcd->rcd_mdh);
- pbuf = rcd->rcd_pingbuffer;
- rcd->rcd_pingbuffer = NULL;
- } else {
- LNetInvalidateMDHandle(&mdh);
- }
-
- lnet_net_unlock(gateway->lpni_cpt);
-
- if (rcd) {
- LNetMDUnlink(mdh);
- lnet_ping_buffer_decref(pbuf);
- } else {
- LIBCFS_ALLOC(rcd, sizeof(*rcd));
- if (rcd == NULL)
- goto out;
-
- LNetInvalidateMDHandle(&rcd->rcd_mdh);
- INIT_LIST_HEAD(&rcd->rcd_list);
- rcd->rcd_nnis = nnis;
- }
-
- pbuf = lnet_ping_buffer_alloc(nnis, GFP_NOFS);
- if (pbuf == NULL)
- goto out;
-
- for (i = 0; i < nnis; i++) {
- pbuf->pb_info.pi_ni[i].ns_nid = LNET_NID_ANY;
- pbuf->pb_info.pi_ni[i].ns_status = LNET_NI_STATUS_INVALID;
- }
- rcd->rcd_pingbuffer = pbuf;
-
- LASSERT(!LNetEQHandleIsInvalid(the_lnet.ln_rc_eqh));
- rc = LNetMDBind((struct lnet_md){.start = &pbuf->pb_info,
- .user_ptr = rcd,
- .length = LNET_PING_INFO_SIZE(nnis),
- .threshold = LNET_MD_THRESH_INF,
- .options = LNET_MD_TRUNCATE,
- .eq_handle = the_lnet.ln_rc_eqh},
- LNET_UNLINK,
- &rcd->rcd_mdh);
- if (rc < 0) {
- CERROR("Can't bind MD: %d\n", rc);
- goto out_ping_buffer_decref;
- }
- LASSERT(rc == 0);
-
- lnet_net_lock(gateway->lpni_cpt);
- /* Check if this is still a router. */
- if (!lnet_isrouter(gateway))
- goto out_unlock;
- /* Check if someone else installed router data. */
- if (gateway->lpni_rcd && gateway->lpni_rcd != rcd)
- goto out_unlock;
-
- /* Install and/or update the router data. */
- if (!gateway->lpni_rcd) {
- lnet_peer_ni_addref_locked(gateway);
- rcd->rcd_gateway = gateway;
- gateway->lpni_rcd = rcd;
- }
- gateway->lpni_ping_notsent = 0;
-
- return rcd;
-
-out_unlock:
- lnet_net_unlock(gateway->lpni_cpt);
- rc = LNetMDUnlink(mdh);
- LASSERT(rc == 0);
-out_ping_buffer_decref:
- lnet_ping_buffer_decref(pbuf);
-out:
- if (rcd && rcd != gateway->lpni_rcd)
- lnet_destroy_rc_data(rcd);
- lnet_net_lock(gateway->lpni_cpt);
- return gateway->lpni_rcd;
-}
-
-static int
-lnet_router_check_interval(struct lnet_peer_ni *rtr)
-{
- int secs;
-
- secs = rtr->lpni_alive ? live_router_check_interval :
- dead_router_check_interval;
- if (secs < 0)
- secs = 0;
-
- return secs;
-}
-
-static void
-lnet_ping_router_locked(struct lnet_peer_ni *rtr)
-{
- struct lnet_rc_data *rcd = NULL;
- time64_t now = ktime_get_seconds();
- time64_t secs;
- struct lnet_ni *ni;
-
- lnet_peer_ni_addref_locked(rtr);
-
- if (rtr->lpni_ping_deadline != 0 && /* ping timed out? */
- now > rtr->lpni_ping_deadline)
- lnet_notify_locked(rtr, 1, 0, now);
-
- /* Run any outstanding notifications */
- ni = lnet_get_next_ni_locked(rtr->lpni_net, NULL);
- lnet_ni_notify_locked(ni, rtr);
-
- if (!lnet_isrouter(rtr) ||
- the_lnet.ln_mt_state != LNET_MT_STATE_RUNNING) {
- /* router table changed or router checker is shutting down */
- lnet_peer_ni_decref_locked(rtr);
- return;
- }
-
- rcd = rtr->lpni_rcd;
- if (!rcd || rcd->rcd_nnis > rcd->rcd_pingbuffer->pb_nnis)
- rcd = lnet_update_rc_data_locked(rtr);
- if (rcd == NULL)
- return;
-
- secs = lnet_router_check_interval(rtr);
-
- CDEBUG(D_NET,
- "rtr %s %lld: deadline %lld ping_notsent %d alive %d "
- "alive_count %d lpni_ping_timestamp %lld\n",
- libcfs_nid2str(rtr->lpni_nid), secs,
- rtr->lpni_ping_deadline, rtr->lpni_ping_notsent,
- rtr->lpni_alive, rtr->lpni_alive_count, rtr->lpni_ping_timestamp);
-
- if (secs != 0 && !rtr->lpni_ping_notsent &&
- now > rtr->lpni_ping_timestamp + secs) {
- int rc;
- struct lnet_process_id id;
- struct lnet_handle_md mdh;
-
- id.nid = rtr->lpni_nid;
- id.pid = LNET_PID_LUSTRE;
- CDEBUG(D_NET, "Check: %s\n", libcfs_id2str(id));
-
- rtr->lpni_ping_notsent = 1;
- rtr->lpni_ping_timestamp = now;
-
- mdh = rcd->rcd_mdh;
-
- if (rtr->lpni_ping_deadline == 0) {
- rtr->lpni_ping_deadline = ktime_get_seconds() +
- router_ping_timeout;
- }
-
- lnet_net_unlock(rtr->lpni_cpt);
-
- rc = LNetGet(LNET_NID_ANY, mdh, id, LNET_RESERVED_PORTAL,
- LNET_PROTO_PING_MATCHBITS, 0, false);
-
- lnet_net_lock(rtr->lpni_cpt);
- if (rc != 0)
- rtr->lpni_ping_notsent = 0; /* no event pending */
- }
-
- lnet_peer_ni_decref_locked(rtr);
- return;
-}
-
-int lnet_router_pre_mt_start(void)
-{
- int rc;
-
- if (check_routers_before_use &&
- dead_router_check_interval <= 0) {
- LCONSOLE_ERROR_MSG(0x10a, "'dead_router_check_interval' must be"
- " set if 'check_routers_before_use' is set"
- "\n");
- return -EINVAL;
- }
-
- rc = LNetEQAlloc(0, lnet_router_checker_event, &the_lnet.ln_rc_eqh);
- if (rc != 0) {
- CERROR("Can't allocate EQ(0): %d\n", rc);
- return -ENOMEM;
- }
-
- return 0;
-}
-
-void lnet_router_post_mt_start(void)
+void lnet_wait_router_start(void)
{
if (check_routers_before_use) {
/* Note that a helpful side-effect of pinging all known routers
}
}
-void
-lnet_router_cleanup(void)
-{
- int rc;
-
- rc = LNetEQFree(the_lnet.ln_rc_eqh);
- LASSERT(rc == 0);
- return;
-}
-
-void
-lnet_prune_rc_data(int wait_unlink)
-{
- struct lnet_rc_data *rcd;
- struct lnet_rc_data *tmp;
- struct lnet_peer_ni *lp;
- struct list_head head;
- int i = 2;
-
- if (likely(the_lnet.ln_mt_state == LNET_MT_STATE_RUNNING &&
- list_empty(&the_lnet.ln_rcd_deathrow) &&
- list_empty(&the_lnet.ln_rcd_zombie)))
- return;
-
- INIT_LIST_HEAD(&head);
-
- lnet_net_lock(LNET_LOCK_EX);
-
- if (the_lnet.ln_mt_state != LNET_MT_STATE_RUNNING) {
- /* router checker is stopping, prune all */
- list_for_each_entry(lp, &the_lnet.ln_routers,
- lpni_rtr_list) {
- if (lp->lpni_rcd == NULL)
- continue;
-
- LASSERT(list_empty(&lp->lpni_rcd->rcd_list));
- list_add(&lp->lpni_rcd->rcd_list,
- &the_lnet.ln_rcd_deathrow);
- lp->lpni_rcd = NULL;
- }
- }
-
- /* unlink all RCDs on deathrow list */
- list_splice_init(&the_lnet.ln_rcd_deathrow, &head);
-
- if (!list_empty(&head)) {
- lnet_net_unlock(LNET_LOCK_EX);
-
- list_for_each_entry(rcd, &head, rcd_list)
- LNetMDUnlink(rcd->rcd_mdh);
-
- lnet_net_lock(LNET_LOCK_EX);
- }
-
- list_splice_init(&head, &the_lnet.ln_rcd_zombie);
-
- /* release all zombie RCDs */
- while (!list_empty(&the_lnet.ln_rcd_zombie)) {
- list_for_each_entry_safe(rcd, tmp, &the_lnet.ln_rcd_zombie,
- rcd_list) {
- if (LNetMDHandleIsInvalid(rcd->rcd_mdh))
- list_move(&rcd->rcd_list, &head);
- }
-
- wait_unlink = wait_unlink &&
- !list_empty(&the_lnet.ln_rcd_zombie);
-
- lnet_net_unlock(LNET_LOCK_EX);
-
- while (!list_empty(&head)) {
- rcd = list_entry(head.next,
- struct lnet_rc_data, rcd_list);
- list_del_init(&rcd->rcd_list);
- lnet_destroy_rc_data(rcd);
- }
-
- if (!wait_unlink)
- return;
-
- i++;
- CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET,
- "Waiting for rc buffers to unlink\n");
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(cfs_time_seconds(1) / 4);
-
- lnet_net_lock(LNET_LOCK_EX);
- }
-
- lnet_net_unlock(LNET_LOCK_EX);
-}
-
/*
* This function is called from the monitor thread to check if there are
* any active routers that need to be checked.
*/
-inline bool
-lnet_router_checker_active(void)
+bool lnet_router_checker_active(void)
{
- if (the_lnet.ln_mt_state != LNET_MT_STATE_RUNNING)
- return true;
-
/* Router Checker thread needs to run when routing is enabled in
* order to call lnet_update_ni_status_locked() */
if (the_lnet.ln_routing)
return true;
- /* if there are routers that need to be cleaned up then do so */
- if (!list_empty(&the_lnet.ln_rcd_deathrow) ||
- !list_empty(&the_lnet.ln_rcd_zombie))
- return true;
-
return !list_empty(&the_lnet.ln_routers) &&
- (live_router_check_interval > 0 ||
- dead_router_check_interval > 0);
+ alive_router_check_interval > 0;
}
void
lnet_check_routers(void)
{
- struct lnet_peer_ni *rtr;
- struct list_head *entry;
- __u64 version;
- int cpt;
- int cpt2;
+ struct lnet_peer_net *first_lpn;
+ struct lnet_peer_net *lpn;
+ struct lnet_peer_ni *lpni;
+ struct lnet_peer *rtr;
+ bool push = false;
+ bool needs_ping;
+ bool found_lpn;
+ __u64 version;
+ __u32 net_id;
+ time64_t now;
+ int cpt;
+ int rc;
cpt = lnet_net_lock_current();
rescan:
version = the_lnet.ln_routers_version;
- list_for_each(entry, &the_lnet.ln_routers) {
- rtr = list_entry(entry, struct lnet_peer_ni,
- lpni_rtr_list);
+ list_for_each_entry(rtr, &the_lnet.ln_routers, lp_rtr_list) {
+ /* If we're currently discovering the peer then don't
+ * issue another discovery
+ */
+ if (rtr->lp_state & LNET_PEER_RTR_DISCOVERY)
+ continue;
- cpt2 = rtr->lpni_cpt;
- if (cpt != cpt2) {
- lnet_net_unlock(cpt);
- cpt = cpt2;
- lnet_net_lock(cpt);
- /* the routers list has changed */
- if (version != the_lnet.ln_routers_version)
- goto rescan;
+ now = ktime_get_real_seconds();
+
+ /* find the next local peer net which needs to be ping'd */
+ needs_ping = false;
+ first_lpn = NULL;
+ found_lpn = false;
+ net_id = rtr->lp_disc_net_id;
+ do {
+ lpn = lnet_get_next_peer_net_locked(rtr, net_id);
+ if (!lpn) {
+ CERROR("gateway %s has no networks\n",
+ libcfs_nidstr(&rtr->lp_primary_nid));
+ break;
+ }
+
+ /* We looped back to the first peer net */
+ if (first_lpn == lpn)
+ break;
+ if (!first_lpn)
+ first_lpn = lpn;
+
+ net_id = lpn->lpn_net_id;
+ if (!lnet_islocalnet_locked(net_id))
+ continue;
+
+ found_lpn = true;
+
+ CDEBUG(D_NET, "rtr %s(%p) %s(%p) next ping %lld\n",
+ libcfs_nidstr(&rtr->lp_primary_nid), rtr,
+ libcfs_net2str(net_id), lpn,
+ lpn->lpn_next_ping);
+
+ needs_ping = now >= lpn->lpn_next_ping;
+
+ } while (!needs_ping);
+
+ if (!found_lpn || !lpn) {
+ CERROR("no local network found for gateway %s\n",
+ libcfs_nidstr(&rtr->lp_primary_nid));
+ continue;
+ }
+
+ if (!needs_ping)
+ continue;
+
+ spin_lock(&rtr->lp_lock);
+ /* make sure we fully discover the router */
+ rtr->lp_state &= ~LNET_PEER_NIDS_UPTODATE;
+ rtr->lp_state |= LNET_PEER_FORCE_PING | LNET_PEER_FORCE_PUSH |
+ LNET_PEER_RTR_DISCOVERY;
+ spin_unlock(&rtr->lp_lock);
+
+ /* find the peer_ni associated with the primary NID */
+ lpni = lnet_peer_ni_get_locked(rtr, &rtr->lp_primary_nid);
+ if (!lpni) {
+ CDEBUG(D_NET, "Expected to find an lpni for %s, but non found\n",
+ libcfs_nidstr(&rtr->lp_primary_nid));
+ continue;
}
+ lnet_peer_ni_addref_locked(lpni);
- lnet_ping_router_locked(rtr);
+ /* specify the net to use */
+ rtr->lp_disc_net_id = lpn->lpn_net_id;
- /* NB dropped lock */
+ /* discover the router */
+ CDEBUG(D_NET, "discover %s, cpt = %d\n",
+ libcfs_nidstr(&lpni->lpni_nid), cpt);
+ rc = lnet_discover_peer_locked(lpni, cpt, false);
+
+ /* drop ref taken above */
+ lnet_peer_ni_decref_locked(lpni);
+
+ if (!rc)
+ lpn->lpn_next_ping = now + alive_router_check_interval;
+ else
+ CERROR("Failed to discover router %s\n",
+ libcfs_nidstr(&rtr->lp_primary_nid));
+
+ /* NB cpt lock was dropped in lnet_discover_peer_locked() */
if (version != the_lnet.ln_routers_version) {
/* the routers list has changed */
goto rescan;
}
if (the_lnet.ln_routing)
- lnet_update_ni_status_locked();
+ push = lnet_update_ni_status_locked();
lnet_net_unlock(cpt);
- lnet_prune_rc_data(0); /* don't wait for UNLINK */
+ /* if the status of the ni changed update the peers */
+ if (push)
+ lnet_push_update_to_peers(1);
}
void
int sz = offsetof(struct lnet_rtrbuf, rb_kiov[npages]);
while (--npages >= 0)
- __free_page(rb->rb_kiov[npages].kiov_page);
+ __free_page(rb->rb_kiov[npages].bv_page);
LIBCFS_FREE(rb, sz);
}
rb->rb_pool = rbp;
for (i = 0; i < npages; i++) {
- page = cfs_page_cpt_alloc(lnet_cpt_table(), cpt,
- GFP_KERNEL | __GFP_ZERO);
+ page = cfs_page_cpt_alloc(lnet_cpt_table(), cpt, GFP_KERNEL |
+ __GFP_ZERO | __GFP_NORETRY);
if (page == NULL) {
while (--i >= 0)
- __free_page(rb->rb_kiov[i].kiov_page);
+ __free_page(rb->rb_kiov[i].bv_page);
LIBCFS_FREE(rb, sz);
return NULL;
}
- rb->rb_kiov[i].kiov_len = PAGE_SIZE;
- rb->rb_kiov[i].kiov_offset = 0;
- rb->rb_kiov[i].kiov_page = page;
+ rb->rb_kiov[i].bv_len = PAGE_SIZE;
+ rb->rb_kiov[i].bv_offset = 0;
+ rb->rb_kiov[i].bv_page = page;
}
return rb;
{
int npages = rbp->rbp_npages;
struct lnet_rtrbuf *rb;
- struct list_head tmp;
+ LIST_HEAD(tmp);
if (rbp->rbp_nbuffers == 0) /* not initialized or already freed */
return;
- INIT_LIST_HEAD(&tmp);
-
lnet_net_lock(cpt);
list_splice_init(&rbp->rbp_msgs, &tmp);
lnet_drop_routed_msgs_locked(&tmp, cpt);
/* Free buffers on the free list. */
while (!list_empty(&tmp)) {
- rb = list_entry(tmp.next, struct lnet_rtrbuf, rb_list);
+ rb = list_first_entry(&tmp, struct lnet_rtrbuf, rb_list);
list_del(&rb->rb_list);
lnet_destroy_rtrbuf(rb, npages);
}
static int
lnet_rtrpool_adjust_bufs(struct lnet_rtrbufpool *rbp, int nbufs, int cpt)
{
- struct list_head rb_list;
+ LIST_HEAD(rb_list);
struct lnet_rtrbuf *rb;
int num_rb;
int num_buffers = 0;
rbp->rbp_req_nbuffers = nbufs;
lnet_net_unlock(cpt);
- INIT_LIST_HEAD(&rb_list);
-
/* allocate the buffers on a local list first. If all buffers are
* allocated successfully then join this list to the rbp buffer
* list. If not then free all allocated buffers. */
while (num_rb-- > 0) {
rb = lnet_new_rtrbuf(rbp, cpt);
if (rb == NULL) {
- CERROR("Failed to allocate %d route bufs of %d pages\n",
- nbufs, npages);
+ CERROR("lnet: error allocating %ux%u page router buffers on CPT %u: rc = %d\n",
+ nbufs, npages, cpt, -ENOMEM);
lnet_net_lock(cpt);
rbp->rbp_req_nbuffers = old_req_nbufs;
return 0;
failed:
- while (!list_empty(&rb_list)) {
- rb = list_entry(rb_list.next, struct lnet_rtrbuf, rb_list);
+ while ((rb = list_first_entry_or_null(&rb_list,
+ struct lnet_rtrbuf,
+ rb_list)) != NULL) {
list_del(&rb->rb_list);
lnet_destroy_rtrbuf(rb, npages);
}
} else if (!strcmp(forwarding, "enabled")) {
/* explicitly enabled */
} else {
- LCONSOLE_ERROR_MSG(0x10b, "'forwarding' not set to either "
- "'enabled' or 'disabled'\n");
- return -EINVAL;
+ rc = -EINVAL;
+ LCONSOLE_ERROR_MSG(0x10b,
+ "lnet: forwarding='%s' not set to either 'enabled' or 'disabled': rc = %d\n",
+ forwarding, rc);
+ return rc;
}
nrb_tiny = lnet_nrb_tiny_calculate();
LNET_NRBPOOLS *
sizeof(struct lnet_rtrbufpool));
if (the_lnet.ln_rtrpools == NULL) {
+ rc = -ENOMEM;
LCONSOLE_ERROR_MSG(0x10c,
- "Failed to initialize router buffe pool\n");
- return -ENOMEM;
+ "lnet: error allocating router buffer pool: rc = %d\n",
+ rc);
+ return rc;
}
cfs_percpt_for_each(rtrp, i, the_lnet.ln_rtrpools) {
lnet_rtrpool_init(&rtrp[LNET_TINY_BUF_IDX], 0);
rc = lnet_rtrpool_adjust_bufs(&rtrp[LNET_TINY_BUF_IDX],
nrb_tiny, i);
- if (rc != 0)
+ if (rc)
goto failed;
lnet_rtrpool_init(&rtrp[LNET_SMALL_BUF_IDX],
LNET_NRB_SMALL_PAGES);
rc = lnet_rtrpool_adjust_bufs(&rtrp[LNET_SMALL_BUF_IDX],
nrb_small, i);
- if (rc != 0)
+ if (rc)
goto failed;
lnet_rtrpool_init(&rtrp[LNET_LARGE_BUF_IDX],
LNET_NRB_LARGE_PAGES);
rc = lnet_rtrpool_adjust_bufs(&rtrp[LNET_LARGE_BUF_IDX],
nrb_large, i);
- if (rc != 0)
+ if (rc)
goto failed;
}
lnet_net_lock(LNET_LOCK_EX);
the_lnet.ln_routing = 1;
lnet_net_unlock(LNET_LOCK_EX);
+ complete(&the_lnet.ln_mt_wait_complete);
return 0;
failed:
~LNET_PING_FEAT_RTE_DISABLED;
lnet_net_unlock(LNET_LOCK_EX);
+ if (lnet_peer_discovery_disabled)
+ CWARN("Consider turning discovery on to enable full "
+ "Multi-Rail routing functionality\n");
+
return rc;
}
lnet_rtrpools_free(1);
}
+static inline void
+lnet_notify_peer_down(struct lnet_ni *ni, struct lnet_nid *nid)
+{
+ if (ni->ni_net->net_lnd->lnd_notify_peer_down != NULL)
+ (ni->ni_net->net_lnd->lnd_notify_peer_down)(nid);
+}
+
+/*
+ * ni: local NI used to communicate with the peer
+ * nid: peer NID
+ * alive: true if peer is alive, false otherwise
+ * reset: reset health value. This is requested by the LND.
+ * when: notificaiton time.
+ */
int
-lnet_notify(struct lnet_ni *ni, lnet_nid_t nid, int alive, time64_t when)
+lnet_notify(struct lnet_ni *ni, lnet_nid_t nid4, bool alive, bool reset,
+ time64_t when)
{
- struct lnet_peer_ni *lp = NULL;
+ struct lnet_peer_ni *lpni = NULL;
+ struct lnet_route *route;
+ struct lnet_peer *lp;
time64_t now = ktime_get_seconds();
- int cpt = lnet_cpt_of_nid(nid, ni);
+ struct lnet_nid nid;
+ int cpt;
- LASSERT (!in_interrupt ());
+ lnet_nid4_to_nid(nid4, &nid);
+ LASSERT(!in_interrupt());
- CDEBUG (D_NET, "%s notifying %s: %s\n",
- (ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),
- libcfs_nid2str(nid),
- alive ? "up" : "down");
+ CDEBUG(D_NET, "%s notifying %s: %s\n",
+ (ni == NULL) ? "userspace" : libcfs_nidstr(&ni->ni_nid),
+ libcfs_nidstr(&nid), alive ? "up" : "down");
if (ni != NULL &&
- LNET_NIDNET(ni->ni_nid) != LNET_NIDNET(nid)) {
+ LNET_NID_NET(&ni->ni_nid) != LNET_NID_NET(&nid)) {
CWARN("Ignoring notification of %s %s by %s (different net)\n",
- libcfs_nid2str(nid), alive ? "birth" : "death",
- libcfs_nid2str(ni->ni_nid));
+ libcfs_nidstr(&nid), alive ? "birth" : "death",
+ libcfs_nidstr(&ni->ni_nid));
return -EINVAL;
}
/* can't do predictions... */
if (when > now) {
- CWARN("Ignoring prediction from %s of %s %s "
- "%lld seconds in the future\n",
- (ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),
- libcfs_nid2str(nid), alive ? "up" : "down", when - now);
+ CWARN("Ignoring prediction from %s of %s %s %lld seconds in the future\n",
+ ni ? libcfs_nidstr(&ni->ni_nid) : "userspace",
+ libcfs_nidstr(&nid), alive ? "up" : "down", when - now);
return -EINVAL;
}
return 0;
}
- lnet_net_lock(cpt);
+ /* must lock 0 since this is used for synchronization */
+ lnet_net_lock(0);
if (the_lnet.ln_state != LNET_STATE_RUNNING) {
- lnet_net_unlock(cpt);
+ lnet_net_unlock(0);
return -ESHUTDOWN;
}
- lp = lnet_find_peer_ni_locked(nid);
- if (lp == NULL) {
+ lpni = lnet_peer_ni_find_locked(&nid);
+ if (lpni == NULL) {
/* nid not found */
- lnet_net_unlock(cpt);
- CDEBUG(D_NET, "%s not found\n", libcfs_nid2str(nid));
+ lnet_net_unlock(0);
+ CDEBUG(D_NET, "%s not found\n", libcfs_nidstr(&nid));
return 0;
}
- /*
- * It is possible for this function to be called for the same peer
- * but with different NIs. We want to synchronize the notification
- * between the different calls. So we will use the lpni_cpt to
- * grab the net lock.
- */
- if (lp->lpni_cpt != cpt) {
- lnet_net_unlock(cpt);
- cpt = lp->lpni_cpt;
- lnet_net_lock(cpt);
- }
-
- /* We can't fully trust LND on reporting exact peer last_alive
- * if he notifies us about dead peer. For example ksocklnd can
- * call us with when == _time_when_the_node_was_booted_ if
- * no connections were successfully established */
- if (ni != NULL && !alive && when < lp->lpni_last_alive)
- when = lp->lpni_last_alive;
+ if (alive) {
+ if (reset) {
+ lpni->lpni_ns_status = LNET_NI_STATUS_UP;
+ lnet_set_lpni_healthv_locked(lpni,
+ LNET_MAX_HEALTH_VALUE);
+ } else {
+ __u32 sensitivity = lpni->lpni_peer_net->
+ lpn_peer->lp_health_sensitivity;
- lnet_notify_locked(lp, ni == NULL, alive, when);
+ lnet_inc_lpni_healthv_locked(lpni,
+ (sensitivity) ? sensitivity :
+ lnet_health_sensitivity);
+ }
+ } else if (reset) {
+ lpni->lpni_ns_status = LNET_NI_STATUS_DOWN;
+ }
+
+ /* recalculate aliveness */
+ alive = lnet_is_peer_ni_alive(lpni);
+
+ lp = lpni->lpni_peer_net->lpn_peer;
+ /* If this is an LNet router then update route aliveness */
+ if (lp->lp_rtr_refcount) {
+ if (reset)
+ /* reset flag indicates gateway peer went up or down */
+ lp->lp_alive = alive;
+
+ /* If discovery is disabled, locally or on the gateway, then
+ * any routes using lpni as next-hop need to be updated
+ *
+ * NB: We can get many notifications while a route is down, so
+ * we try and avoid the expensive net_lock/EX here for the
+ * common case of receiving duplicate lnet_notify() calls (i.e.
+ * only grab EX lock when we actually need to update the route
+ * aliveness).
+ */
+ if (lnet_is_discovery_disabled(lp)) {
+ list_for_each_entry(route, &lp->lp_routes, lr_gwlist) {
+ if (nid_same(&route->lr_nid, &lpni->lpni_nid))
+ lnet_set_route_aliveness(route, alive);
+ }
+ }
+ }
- if (ni != NULL)
- lnet_ni_notify_locked(ni, lp);
+ lnet_net_unlock(0);
- lnet_peer_ni_decref_locked(lp);
+ if (ni != NULL && !alive)
+ lnet_notify_peer_down(ni, &lpni->lpni_nid);
+ cpt = lpni->lpni_cpt;
+ lnet_net_lock(cpt);
+ lnet_peer_ni_decref_locked(lpni);
lnet_net_unlock(cpt);
+
return 0;
}
EXPORT_SYMBOL(lnet_notify);