Whamcloud - gitweb
LU-6142 lnet: use list_first_entry() in lnet/lnet subdirectory.
[fs/lustre-release.git] / lnet / lnet / nidstrings.c
index f97b464..2af9d8a 100644 (file)
  * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, 2016, Intel Corporation.
+ * Copyright (c) 2011, 2015, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
  *
  * lnet/lnet/nidstrings.c
  *
 
 #define DEBUG_SUBSYSTEM S_LNET
 
+#include <linux/sunrpc/addr.h>
 #include <libcfs/libcfs.h>
-#include <lnet/nidstr.h>
+#include <uapi/linux/lnet/nidstr.h>
+#include <lnet/lib-types.h>
 
 /* max value for numeric network address */
 #define MAX_NUMERIC_VALUE 0xffffffff
@@ -165,7 +166,7 @@ parse_addrange(const struct cfs_lstr *src, struct nidrange *nidrange)
                return 0;
        }
 
-       LIBCFS_ALLOC(addrrange, sizeof(struct addrrange));
+       CFS_ALLOC_PTR(addrrange);
        if (addrrange == NULL)
                return -ENOMEM;
        list_add_tail(&addrrange->ar_link, &nidrange->nr_addrranges);
@@ -222,7 +223,7 @@ add_nidrange(const struct cfs_lstr *src,
                return nr;
        }
 
-       LIBCFS_ALLOC(nr, sizeof(struct nidrange));
+       CFS_ALLOC_PTR(nr);
        if (nr == NULL)
                return NULL;
        list_add_tail(&nr->nr_link, nidlist);
@@ -276,14 +277,14 @@ failed:
 static void
 free_addrranges(struct list_head *list)
 {
-       while (!list_empty(list)) {
-               struct addrrange *ar;
-
-               ar = list_entry(list->next, struct addrrange, ar_link);
+       struct addrrange *ar;
 
+       while ((ar = list_first_entry_or_null(list,
+                                             struct addrrange,
+                                             ar_link)) != NULL) {
                cfs_expr_list_free_list(&ar->ar_numaddr_ranges);
                list_del(&ar->ar_link);
-               LIBCFS_FREE(ar, sizeof(struct addrrange));
+               CFS_FREE_PTR(ar);
        }
 }
 
@@ -305,7 +306,7 @@ cfs_free_nidlist(struct list_head *list)
                nr = list_entry(pos, struct nidrange, nr_link);
                free_addrranges(&nr->nr_addrranges);
                list_del(pos);
-               LIBCFS_FREE(nr, sizeof(struct nidrange));
+               CFS_FREE_PTR(nr);
        }
 }
 EXPORT_SYMBOL(cfs_free_nidlist);
@@ -451,318 +452,6 @@ int cfs_print_nidlist(char *buffer, int count, struct list_head *nidlist)
 }
 EXPORT_SYMBOL(cfs_print_nidlist);
 
-/**
- * Determines minimum and maximum addresses for a single
- * numeric address range
- *
- * \param      ar
- * \param      min_nid
- * \param      max_nid
- */
-static void cfs_ip_ar_min_max(struct addrrange *ar, __u32 *min_nid,
-                             __u32 *max_nid)
-{
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       __u32 tmp_ip_addr = 0;
-       unsigned int min_ip[4] = {0};
-       unsigned int max_ip[4] = {0};
-       int re_count = 0;
-
-       list_for_each_entry(el, &ar->ar_numaddr_ranges, el_link) {
-               list_for_each_entry(re, &el->el_exprs, re_link) {
-                       min_ip[re_count] = re->re_lo;
-                       max_ip[re_count] = re->re_hi;
-                       re_count++;
-               }
-       }
-
-       tmp_ip_addr = ((min_ip[0] << 24) | (min_ip[1] << 16) |
-                      (min_ip[2] << 8) | min_ip[3]);
-
-       if (min_nid != NULL)
-               *min_nid = tmp_ip_addr;
-
-       tmp_ip_addr = ((max_ip[0] << 24) | (max_ip[1] << 16) |
-                      (max_ip[2] << 8) | max_ip[3]);
-
-       if (max_nid != NULL)
-               *max_nid = tmp_ip_addr;
-}
-
-/**
- * Determines minimum and maximum addresses for a single
- * numeric address range
- *
- * \param      ar
- * \param      min_nid
- * \param      max_nid
- */
-static void cfs_num_ar_min_max(struct addrrange *ar, __u32 *min_nid,
-                              __u32 *max_nid)
-{
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       unsigned int min_addr = 0;
-       unsigned int max_addr = 0;
-
-       list_for_each_entry(el, &ar->ar_numaddr_ranges, el_link) {
-               list_for_each_entry(re, &el->el_exprs, re_link) {
-                       if (re->re_lo < min_addr || min_addr == 0)
-                               min_addr = re->re_lo;
-                       if (re->re_hi > max_addr)
-                               max_addr = re->re_hi;
-               }
-       }
-
-       if (min_nid != NULL)
-               *min_nid = min_addr;
-       if (max_nid != NULL)
-               *max_nid = max_addr;
-}
-
-/**
- * Determines whether an expression list in an nidrange contains exactly
- * one contiguous address range. Calls the correct netstrfns for the LND
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-bool cfs_nidrange_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange *nr;
-       struct netstrfns *nf = NULL;
-       char *lndname = NULL;
-       int netnum = -1;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               nf = nr->nr_netstrfns;
-               if (lndname == NULL)
-                       lndname = nf->nf_name;
-               if (netnum == -1)
-                       netnum = nr->nr_netnum;
-
-               if (strcmp(lndname, nf->nf_name) != 0 ||
-                   netnum != nr->nr_netnum)
-                       return false;
-       }
-
-       if (nf == NULL)
-               return false;
-
-       if (!nf->nf_is_contiguous(nidlist))
-               return false;
-
-       return true;
-}
-EXPORT_SYMBOL(cfs_nidrange_is_contiguous);
-
-/**
- * Determines whether an expression list in an num nidrange contains exactly
- * one contiguous address range.
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-static bool cfs_num_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       int last_hi = 0;
-       __u32 last_end_nid = 0;
-       __u32 current_start_nid = 0;
-       __u32 current_end_nid = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_num_ar_min_max(ar, &current_start_nid,
-                                          &current_end_nid);
-                       if (last_end_nid != 0 &&
-                           (current_start_nid - last_end_nid != 1))
-                                       return false;
-                       last_end_nid = current_end_nid;
-                       list_for_each_entry(el, &ar->ar_numaddr_ranges,
-                                           el_link) {
-                               list_for_each_entry(re, &el->el_exprs,
-                                                   re_link) {
-                                       if (re->re_stride > 1)
-                                               return false;
-                                       else if (last_hi != 0 &&
-                                                re->re_hi - last_hi != 1)
-                                               return false;
-                                       last_hi = re->re_hi;
-                               }
-                       }
-               }
-       }
-
-       return true;
-}
-
-/**
- * Determines whether an expression list in an ip nidrange contains exactly
- * one contiguous address range.
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-static bool cfs_ip_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       int expr_count;
-       int last_hi = 255;
-       int last_diff = 0;
-       __u32 last_end_nid = 0;
-       __u32 current_start_nid = 0;
-       __u32 current_end_nid = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       last_hi = 255;
-                       last_diff = 0;
-                       cfs_ip_ar_min_max(ar, &current_start_nid,
-                                         &current_end_nid);
-                       if (last_end_nid != 0 &&
-                           (current_start_nid - last_end_nid != 1))
-                                       return false;
-                       last_end_nid = current_end_nid;
-                       list_for_each_entry(el,
-                                           &ar->ar_numaddr_ranges,
-                                           el_link) {
-                               expr_count = 0;
-                               list_for_each_entry(re, &el->el_exprs,
-                                                   re_link) {
-                                       expr_count++;
-                                       if (re->re_stride > 1 ||
-                                           (last_diff > 0 && last_hi != 255) ||
-                                           (last_diff > 0 && last_hi == 255 &&
-                                            re->re_lo > 0))
-                                               return false;
-                                       last_hi = re->re_hi;
-                                       last_diff = re->re_hi - re->re_lo;
-                               }
-                       }
-               }
-       }
-
-       return true;
-}
-
-/**
- * Takes a linked list of nidrange expressions, determines the minimum
- * and maximum nid and creates appropriate nid structures
- *
- * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
- */
-void cfs_nidrange_find_min_max(struct list_head *nidlist, char *min_nid,
-                              char *max_nid, size_t nidstr_length)
-{
-       struct nidrange *nr;
-       struct netstrfns *nf = NULL;
-       int netnum = -1;
-       __u32 min_addr;
-       __u32 max_addr;
-       char *lndname = NULL;
-       char min_addr_str[IPSTRING_LENGTH];
-       char max_addr_str[IPSTRING_LENGTH];
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               nf = nr->nr_netstrfns;
-               lndname = nf->nf_name;
-               if (netnum == -1)
-                       netnum = nr->nr_netnum;
-
-               nf->nf_min_max(nidlist, &min_addr, &max_addr);
-       }
-       nf->nf_addr2str(min_addr, min_addr_str, sizeof(min_addr_str));
-       nf->nf_addr2str(max_addr, max_addr_str, sizeof(max_addr_str));
-
-       snprintf(min_nid, nidstr_length, "%s@%s%d", min_addr_str, lndname,
-                netnum);
-       snprintf(max_nid, nidstr_length, "%s@%s%d", max_addr_str, lndname,
-                netnum);
-}
-EXPORT_SYMBOL(cfs_nidrange_find_min_max);
-
-/**
- * Determines the min and max NID values for num LNDs
- *
- * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
- */
-static void cfs_num_min_max(struct list_head *nidlist, __u32 *min_nid,
-                           __u32 *max_nid)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       unsigned int tmp_min_addr = 0;
-       unsigned int tmp_max_addr = 0;
-       unsigned int min_addr = 0;
-       unsigned int max_addr = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_num_ar_min_max(ar, &tmp_min_addr,
-                                          &tmp_max_addr);
-                       if (tmp_min_addr < min_addr || min_addr == 0)
-                               min_addr = tmp_min_addr;
-                       if (tmp_max_addr > max_addr)
-                               max_addr = tmp_min_addr;
-               }
-       }
-       *max_nid = max_addr;
-       *min_nid = min_addr;
-}
-
-/**
- * Takes an nidlist and determines the minimum and maximum
- * ip addresses.
- *
- * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
- */
-static void cfs_ip_min_max(struct list_head *nidlist, __u32 *min_nid,
-                          __u32 *max_nid)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       __u32 tmp_min_ip_addr = 0;
-       __u32 tmp_max_ip_addr = 0;
-       __u32 min_ip_addr = 0;
-       __u32 max_ip_addr = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_ip_ar_min_max(ar, &tmp_min_ip_addr,
-                                         &tmp_max_ip_addr);
-                       if (tmp_min_ip_addr < min_ip_addr || min_ip_addr == 0)
-                               min_ip_addr = tmp_min_ip_addr;
-                       if (tmp_max_ip_addr > max_ip_addr)
-                               max_ip_addr = tmp_max_ip_addr;
-               }
-       }
-
-       if (min_nid != NULL)
-               *min_nid = min_ip_addr;
-       if (max_nid != NULL)
-               *max_nid = max_ip_addr;
-}
-
 static int
 libcfs_lo_str2addr(const char *str, int nob, __u32 *addr)
 {
@@ -778,6 +467,30 @@ libcfs_ip_addr2str(__u32 addr, char *str, size_t size)
                 (addr >> 8) & 0xff, addr & 0xff);
 }
 
+static void
+libcfs_ip_addr2str_size(const __be32 *addr, size_t asize,
+                       char *str, size_t size)
+{
+       struct sockaddr_storage sa = {};
+
+       switch (asize) {
+       case 4:
+               sa.ss_family = AF_INET;
+               memcpy(&((struct sockaddr_in *)(&sa))->sin_addr.s_addr,
+                      addr, asize);
+               break;
+       case 16:
+               sa.ss_family = AF_INET6;
+               memcpy(&((struct sockaddr_in6 *)(&sa))->sin6_addr.s6_addr,
+                      addr, asize);
+               break;
+       default:
+               return;
+       }
+
+       rpc_ntop((struct sockaddr *)&sa, str, size);
+}
+
 /* CAVEAT EMPTOR XscanfX
  * I use "%n" at the end of a sscanf format to detect trailing junk.  However
  * sscanf may return immediately if it sees the terminating '0' in a string, so
@@ -804,6 +517,38 @@ libcfs_ip_str2addr(const char *str, int nob, __u32 *addr)
        return 0;
 }
 
+static int
+libcfs_ip_str2addr_size(const char *str, int nob,
+                       __be32 *addr, size_t *alen)
+{
+       struct sockaddr_storage sa;
+
+       /* Note: 'net' arg to rpc_pton is only needed for link-local
+        * addresses.  Such addresses would not work with LNet routing,
+        * so we can assume they aren't used.  So it doesn't matter
+        * which net namespace is passed.
+        */
+       if (rpc_pton(&init_net, str, nob,
+                    (struct sockaddr *)&sa, sizeof(sa)) == 0)
+               return 0;
+       if (sa.ss_family == AF_INET6) {
+               memcpy(addr,
+                      &((struct sockaddr_in6 *)(&sa))->sin6_addr.s6_addr,
+                      16);
+               *alen = 16;
+               return 1;
+       }
+       if (sa.ss_family == AF_INET) {
+               memcpy(addr,
+                      &((struct sockaddr_in *)(&sa))->sin_addr.s_addr,
+                      4);
+               *alen = 4;
+               return 1;
+       }
+       return 0;
+}
+
+
 /* Used by lnet/config.c so it can't be static */
 int
 cfs_ip_addr_parse(char *str, int len, struct list_head *list)
@@ -919,7 +664,7 @@ libcfs_num_str2addr(const char *str, int nob, __u32 *addr)
  * \retval 0 if \a str parsed to numeric address
  * \retval errno otherwise
  */
-static int
+int
 libcfs_num_parse(char *str, int len, struct list_head *list)
 {
        struct cfs_expr_list *el;
@@ -957,7 +702,7 @@ libcfs_num_match(__u32 addr, struct list_head *numaddr)
        struct cfs_expr_list *el;
 
        LASSERT(!list_empty(numaddr));
-       el = list_entry(numaddr->next, struct cfs_expr_list, el_link);
+       el = list_first_entry(numaddr, struct cfs_expr_list, el_link);
 
        return cfs_expr_list_match(addr, el);
 }
@@ -970,19 +715,19 @@ static struct netstrfns libcfs_netstrfns[] = {
          .nf_str2addr          = libcfs_lo_str2addr,
          .nf_parse_addrlist    = libcfs_num_parse,
          .nf_print_addrlist    = libcfs_num_addr_range_print,
-         .nf_match_addr        = libcfs_num_match,
-         .nf_is_contiguous     = cfs_num_is_contiguous,
-         .nf_min_max           = cfs_num_min_max },
+         .nf_match_addr        = libcfs_num_match
+       },
        { .nf_type              = SOCKLND,
          .nf_name              = "tcp",
          .nf_modname           = "ksocklnd",
          .nf_addr2str          = libcfs_ip_addr2str,
+         .nf_addr2str_size     = libcfs_ip_addr2str_size,
          .nf_str2addr          = libcfs_ip_str2addr,
+         .nf_str2addr_size     = libcfs_ip_str2addr_size,
          .nf_parse_addrlist    = cfs_ip_addr_parse,
          .nf_print_addrlist    = libcfs_ip_addr_range_print,
-         .nf_match_addr        = cfs_ip_addr_match,
-         .nf_is_contiguous     = cfs_ip_is_contiguous,
-         .nf_min_max           = cfs_ip_min_max },
+         .nf_match_addr        = cfs_ip_addr_match
+       },
        { .nf_type              = O2IBLND,
          .nf_name              = "o2ib",
          .nf_modname           = "ko2iblnd",
@@ -990,9 +735,8 @@ static struct netstrfns libcfs_netstrfns[] = {
          .nf_str2addr          = libcfs_ip_str2addr,
          .nf_parse_addrlist    = cfs_ip_addr_parse,
          .nf_print_addrlist    = libcfs_ip_addr_range_print,
-         .nf_match_addr        = cfs_ip_addr_match,
-         .nf_is_contiguous     = cfs_ip_is_contiguous,
-         .nf_min_max           = cfs_ip_min_max },
+         .nf_match_addr        = cfs_ip_addr_match
+       },
        { .nf_type              = GNILND,
          .nf_name              = "gni",
          .nf_modname           = "kgnilnd",
@@ -1000,9 +744,8 @@ static struct netstrfns libcfs_netstrfns[] = {
          .nf_str2addr          = libcfs_num_str2addr,
          .nf_parse_addrlist    = libcfs_num_parse,
          .nf_print_addrlist    = libcfs_num_addr_range_print,
-         .nf_match_addr        = libcfs_num_match,
-         .nf_is_contiguous     = cfs_num_is_contiguous,
-         .nf_min_max           = cfs_num_min_max },
+         .nf_match_addr        = libcfs_num_match
+       },
        { .nf_type              = GNIIPLND,
          .nf_name              = "gip",
          .nf_modname           = "kgnilnd",
@@ -1010,9 +753,8 @@ static struct netstrfns libcfs_netstrfns[] = {
          .nf_str2addr          = libcfs_ip_str2addr,
          .nf_parse_addrlist    = cfs_ip_addr_parse,
          .nf_print_addrlist    = libcfs_ip_addr_range_print,
-         .nf_match_addr        = cfs_ip_addr_match,
-         .nf_is_contiguous     = cfs_ip_is_contiguous,
-         .nf_min_max           = cfs_ip_min_max },
+         .nf_match_addr        = cfs_ip_addr_match
+       },
        { .nf_type              = PTL4LND,
          .nf_name              = "ptlf",
          .nf_modname           = "kptl4lnd",
@@ -1020,14 +762,80 @@ static struct netstrfns libcfs_netstrfns[] = {
          .nf_str2addr          = libcfs_num_str2addr,
          .nf_parse_addrlist    = libcfs_num_parse,
          .nf_print_addrlist    = libcfs_num_addr_range_print,
-         .nf_match_addr        = libcfs_num_match,
-         .nf_is_contiguous     = cfs_num_is_contiguous,
-         .nf_min_max           = cfs_num_min_max},
+         .nf_match_addr        = libcfs_num_match
+       },
 };
 
 static const size_t libcfs_nnetstrfns = ARRAY_SIZE(libcfs_netstrfns);
 
 static struct netstrfns *
+type2net_info(__u32 net_type)
+{
+       int i;
+
+       for (i = 0; i < libcfs_nnetstrfns; i++) {
+               if (libcfs_netstrfns[i].nf_type == net_type)
+                       return &libcfs_netstrfns[i];
+       }
+
+       return NULL;
+}
+
+int
+cfs_match_net(__u32 net_id, __u32 net_type, struct list_head *net_num_list)
+{
+       __u32 net_num;
+
+       if (!net_num_list)
+               return 0;
+
+       if (net_type != LNET_NETTYP(net_id))
+               return 0;
+
+       net_num = LNET_NETNUM(net_id);
+
+       /* if there is a net number but the list passed in is empty, then
+        * there is no match.
+        */
+       if (!net_num && list_empty(net_num_list))
+               return 1;
+       else if (list_empty(net_num_list))
+               return 0;
+
+       if (!libcfs_num_match(net_num, net_num_list))
+               return 0;
+
+       return 1;
+}
+
+int
+cfs_match_nid_net(struct lnet_nid *nid, __u32 net_type,
+                  struct list_head *net_num_list,
+                  struct list_head *addr)
+{
+       __u32 address;
+       struct netstrfns *nf;
+
+       if (!addr || !net_num_list)
+               return 0;
+
+       nf = type2net_info(LNET_NETTYP(LNET_NID_NET(nid)));
+       if (!nf || !net_num_list || !addr)
+               return 0;
+
+       /* FIXME handle long-addr nid */
+       address = LNET_NIDADDR(lnet_nid_to_nid4(nid));
+
+       /* if either the address or net number don't match then no match */
+       if (!nf->nf_match_addr(address, addr) ||
+           !cfs_match_net(LNET_NID_NET(nid), net_type, net_num_list))
+               return 0;
+
+       return 1;
+}
+EXPORT_SYMBOL(cfs_match_nid_net);
+
+static struct netstrfns *
 libcfs_lnd2netstrfns(__u32 lnd)
 {
        int     i;
@@ -1162,6 +970,52 @@ libcfs_nid2str_r(lnet_nid_t nid, char *buf, size_t buf_size)
 }
 EXPORT_SYMBOL(libcfs_nid2str_r);
 
+char *
+libcfs_nidstr_r(const struct lnet_nid *nid, char *buf, size_t buf_size)
+{
+       __u32 nnum;
+       __u32 lnd;
+       struct netstrfns *nf;
+
+       if (LNET_NID_IS_ANY(nid)) {
+               strncpy(buf, "<?>", buf_size);
+               buf[buf_size - 1] = '\0';
+               return buf;
+       }
+
+       nnum = be16_to_cpu(nid->nid_num);
+       lnd = nid->nid_type;
+       nf = libcfs_lnd2netstrfns(lnd);
+       if (nf) {
+               size_t addr_len;
+
+               if (nf->nf_addr2str_size)
+                       nf->nf_addr2str_size(nid->nid_addr, NID_ADDR_BYTES(nid),
+                                            buf, buf_size);
+               else
+                       nf->nf_addr2str(ntohl(nid->nid_addr[0]), buf, buf_size);
+               addr_len = strlen(buf);
+               if (nnum == 0)
+                       snprintf(buf + addr_len, buf_size - addr_len, "@%s",
+                                nf->nf_name);
+               else
+                       snprintf(buf + addr_len, buf_size - addr_len, "@%s%u",
+                                nf->nf_name, nnum);
+       } else {
+               int l = 0;
+               int words = DIV_ROUND_UP(NID_ADDR_BYTES(nid), 4);
+               int i;
+
+               for (i = 0; i < words && i < 4; i++)
+                       l = snprintf(buf+l, buf_size-l, "%s%x",
+                                    i ? ":" : "", ntohl(nid->nid_addr[i]));
+               snprintf(buf+l, buf_size-l, "@<%u:%u>", lnd, nnum);
+       }
+
+       return buf;
+}
+EXPORT_SYMBOL(libcfs_nidstr_r);
+
 static struct netstrfns *
 libcfs_str2net_internal(const char *str, __u32 *net)
 {
@@ -1206,7 +1060,7 @@ libcfs_str2net(const char *str)
        if (libcfs_str2net_internal(str, &net) != NULL)
                return net;
 
-       return LNET_NIDNET(LNET_NID_ANY);
+       return LNET_NET_ANY;
 }
 EXPORT_SYMBOL(libcfs_str2net);
 
@@ -1236,8 +1090,48 @@ libcfs_str2nid(const char *str)
 }
 EXPORT_SYMBOL(libcfs_str2nid);
 
+int
+libcfs_strnid(struct lnet_nid *nid, const char *str)
+{
+       const char       *sep = strchr(str, '@');
+       struct netstrfns *nf;
+       __u32             net;
+
+       if (sep != NULL) {
+               nf = libcfs_str2net_internal(sep + 1, &net);
+               if (nf == NULL)
+                       return -EINVAL;
+       } else {
+               sep = str + strlen(str);
+               net = LNET_MKNET(SOCKLND, 0);
+               nf = libcfs_lnd2netstrfns(SOCKLND);
+               LASSERT(nf != NULL);
+       }
+
+       memset(nid, 0, sizeof(*nid));
+       nid->nid_type = LNET_NETTYP(net);
+       nid->nid_num = htons(LNET_NETNUM(net));
+       if (nf->nf_str2addr_size) {
+               size_t asize = 0;
+
+               if (!nf->nf_str2addr_size(str, (int)(sep - str),
+                                         nid->nid_addr, &asize))
+                       return -EINVAL;
+               nid->nid_size = asize - 4;
+       } else {
+               __u32 addr;
+
+               if (!nf->nf_str2addr(str, (int)(sep - str), &addr))
+                       return -EINVAL;
+               nid->nid_addr[0] = htonl(addr);
+               nid->nid_size = 0;
+       }
+       return 0;
+}
+EXPORT_SYMBOL(libcfs_strnid);
+
 char *
-libcfs_id2str(lnet_process_id_t id)
+libcfs_id2str(struct lnet_process_id id)
 {
        char *str = libcfs_next_nidstring();
 
@@ -1254,6 +1148,24 @@ libcfs_id2str(lnet_process_id_t id)
 }
 EXPORT_SYMBOL(libcfs_id2str);
 
+char *
+libcfs_idstr(struct lnet_processid *id)
+{
+       char *str = libcfs_next_nidstring();
+
+       if (id->pid == LNET_PID_ANY) {
+               snprintf(str, LNET_NIDSTR_SIZE,
+                        "LNET_PID_ANY-%s", libcfs_nidstr(&id->nid));
+               return str;
+       }
+
+       snprintf(str, LNET_NIDSTR_SIZE, "%s%u-%s",
+                ((id->pid & LNET_PID_USERFLAG) != 0) ? "U" : "",
+                (id->pid & ~LNET_PID_USERFLAG), libcfs_nidstr(&id->nid));
+       return str;
+}
+EXPORT_SYMBOL(libcfs_idstr);
+
 int
 libcfs_str2anynid(lnet_nid_t *nidp, const char *str)
 {