Whamcloud - gitweb
LU-12036 ofd: add "no_precreate" mount option
[fs/lustre-release.git] / lnet / lnet / nidstrings.c
index 8f7808d..2061142 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
@@ -27,7 +23,7 @@
  * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, 2014, Intel Corporation.
+ * Copyright (c) 2011, 2015, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -41,7 +37,7 @@
 #define DEBUG_SUBSYSTEM S_LNET
 
 #include <libcfs/libcfs.h>
-#include <lnet/nidstr.h>
+#include <uapi/linux/lnet/nidstr.h>
 
 /* max value for numeric network address */
 #define MAX_NUMERIC_VALUE 0xffffffff
@@ -60,8 +56,8 @@
  * between getting its string and using it.
  */
 
-static char      libcfs_nidstrings[LNET_NIDSTR_COUNT][LNET_NIDSTR_SIZE];
-static int       libcfs_nidstring_idx;
+static char     libcfs_nidstrings[LNET_NIDSTR_COUNT][LNET_NIDSTR_SIZE];
+static int      libcfs_nidstring_idx;
 
 static DEFINE_SPINLOCK(libcfs_nidstring_lock);
 
@@ -70,7 +66,7 @@ static struct netstrfns *libcfs_namenum2netstrfns(const char *name);
 char *
 libcfs_next_nidstring(void)
 {
-       char          *str;
+       char          *str;
        unsigned long  flags;
 
        spin_lock_irqsave(&libcfs_nidstring_lock, flags);
@@ -88,22 +84,22 @@ EXPORT_SYMBOL(libcfs_next_nidstring);
  * Nid range list syntax.
  * \verbatim
  *
- * <nidlist>         :== <nidrange> [ ' ' <nidrange> ]
- * <nidrange>        :== <addrrange> '@' <net>
- * <addrrange>       :== '*' |
- *                       <ipaddr_range> |
+ * <nidlist>        :== <nidrange> [ ' ' <nidrange> ]
+ * <nidrange>       :== <addrrange> '@' <net>
+ * <addrrange>      :== '*' |
+ *                      <ipaddr_range> |
  *                      <cfs_expr_list>
  * <ipaddr_range>    :== <cfs_expr_list>.<cfs_expr_list>.<cfs_expr_list>.
  *                      <cfs_expr_list>
  * <cfs_expr_list>   :== <number> |
- *                       <expr_list>
- * <expr_list>       :== '[' <range_expr> [ ',' <range_expr>] ']'
+ *                      <expr_list>
+ * <expr_list>      :== '[' <range_expr> [ ',' <range_expr>] ']'
  * <range_expr>      :== <number> |
- *                       <number> '-' <number> |
- *                       <number> '-' <number> '/' <number>
- * <net>             :== <netname> | <netname><number>
- * <netname>         :== "lo" | "tcp" | "o2ib" | "cib" | "openib" | "iib" |
- *                       "vib" | "ra" | "elan" | "mx" | "ptl"
+ *                      <number> '-' <number> |
+ *                      <number> '-' <number> '/' <number>
+ * <net>            :== <netname> | <netname><number>
+ * <netname>        :== "lo" | "tcp" | "o2ib" | "cib" | "openib" | "iib" |
+ *                      "vib" | "ra" | "elan" | "mx" | "ptl"
  * \endverbatim
  */
 
@@ -169,7 +165,7 @@ parse_addrange(const struct cfs_lstr *src, struct nidrange *nidrange)
                return 0;
        }
 
-       LIBCFS_ALLOC(addrrange, sizeof(struct addrrange));
+       CFS_ALLOC_PTR(addrrange);
        if (addrrange == NULL)
                return -ENOMEM;
        list_add_tail(&addrrange->ar_link, &nidrange->nr_addrranges);
@@ -226,7 +222,7 @@ add_nidrange(const struct cfs_lstr *src,
                return nr;
        }
 
-       LIBCFS_ALLOC(nr, sizeof(struct nidrange));
+       CFS_ALLOC_PTR(nr);
        if (nr == NULL)
                return NULL;
        list_add_tail(&nr->nr_link, nidlist);
@@ -249,10 +245,8 @@ parse_nidrange(struct cfs_lstr *src, struct list_head *nidlist)
 {
        struct cfs_lstr addrrange;
        struct cfs_lstr net;
-       struct cfs_lstr tmp;
        struct nidrange *nr;
 
-       tmp = *src;
        if (cfs_gettok(src, '@', &addrrange) == 0)
                goto failed;
 
@@ -268,7 +262,6 @@ parse_nidrange(struct cfs_lstr *src, struct list_head *nidlist)
 
        return 1;
 failed:
-       CWARN("can't parse nidrange: \"%.*s\"\n", tmp.ls_len, tmp.ls_str);
        return 0;
 }
 
@@ -290,7 +283,7 @@ free_addrranges(struct list_head *list)
 
                cfs_expr_list_free_list(&ar->ar_numaddr_ranges);
                list_del(&ar->ar_link);
-               LIBCFS_FREE(ar, sizeof(struct addrrange));
+               CFS_FREE_PTR(ar);
        }
 }
 
@@ -312,7 +305,7 @@ cfs_free_nidlist(struct list_head *list)
                nr = list_entry(pos, struct nidrange, nr_link);
                free_addrranges(&nr->nr_addrranges);
                list_del(pos);
-               LIBCFS_FREE(nr, sizeof(struct nidrange));
+               CFS_FREE_PTR(nr);
        }
 }
 EXPORT_SYMBOL(cfs_free_nidlist);
@@ -458,318 +451,6 @@ int cfs_print_nidlist(char *buffer, int count, struct list_head *nidlist)
 }
 EXPORT_SYMBOL(cfs_print_nidlist);
 
-/**
- * Determines minimum and maximum addresses for a single
- * numeric address range
- *
- * \param      ar
- * \param      min_nid
- * \param      max_nid
- */
-static void cfs_ip_ar_min_max(struct addrrange *ar, __u32 *min_nid,
-                             __u32 *max_nid)
-{
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       __u32 tmp_ip_addr = 0;
-       unsigned int min_ip[4] = {0};
-       unsigned int max_ip[4] = {0};
-       int re_count = 0;
-
-       list_for_each_entry(el, &ar->ar_numaddr_ranges, el_link) {
-               list_for_each_entry(re, &el->el_exprs, re_link) {
-                       min_ip[re_count] = re->re_lo;
-                       max_ip[re_count] = re->re_hi;
-                       re_count++;
-               }
-       }
-
-       tmp_ip_addr = ((min_ip[0] << 24) | (min_ip[1] << 16) |
-                      (min_ip[2] << 8) | min_ip[3]);
-
-       if (min_nid != NULL)
-               *min_nid = tmp_ip_addr;
-
-       tmp_ip_addr = ((max_ip[0] << 24) | (max_ip[1] << 16) |
-                      (max_ip[2] << 8) | max_ip[3]);
-
-       if (max_nid != NULL)
-               *max_nid = tmp_ip_addr;
-}
-
-/**
- * Determines minimum and maximum addresses for a single
- * numeric address range
- *
- * \param      ar
- * \param      min_nid
- * \param      max_nid
- */
-static void cfs_num_ar_min_max(struct addrrange *ar, __u32 *min_nid,
-                              __u32 *max_nid)
-{
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       unsigned int min_addr = 0;
-       unsigned int max_addr = 0;
-
-       list_for_each_entry(el, &ar->ar_numaddr_ranges, el_link) {
-               list_for_each_entry(re, &el->el_exprs, re_link) {
-                       if (re->re_lo < min_addr || min_addr == 0)
-                               min_addr = re->re_lo;
-                       if (re->re_hi > max_addr)
-                               max_addr = re->re_hi;
-               }
-       }
-
-       if (min_nid != NULL)
-               *min_nid = min_addr;
-       if (max_nid != NULL)
-               *max_nid = max_addr;
-}
-
-/**
- * Determines whether an expression list in an nidrange contains exactly
- * one contiguous address range. Calls the correct netstrfns for the LND
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-bool cfs_nidrange_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange *nr;
-       struct netstrfns *nf = NULL;
-       char *lndname = NULL;
-       int netnum = -1;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               nf = nr->nr_netstrfns;
-               if (lndname == NULL)
-                       lndname = nf->nf_name;
-               if (netnum == -1)
-                       netnum = nr->nr_netnum;
-
-               if (strcmp(lndname, nf->nf_name) != 0 ||
-                   netnum != nr->nr_netnum)
-                       return false;
-       }
-
-       if (nf == NULL)
-               return false;
-
-       if (!nf->nf_is_contiguous(nidlist))
-               return false;
-
-       return true;
-}
-EXPORT_SYMBOL(cfs_nidrange_is_contiguous);
-
-/**
- * Determines whether an expression list in an num nidrange contains exactly
- * one contiguous address range.
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-static bool cfs_num_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       int last_hi = 0;
-       __u32 last_end_nid = 0;
-       __u32 current_start_nid = 0;
-       __u32 current_end_nid = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_num_ar_min_max(ar, &current_start_nid,
-                                          &current_end_nid);
-                       if (last_end_nid != 0 &&
-                           (current_start_nid - last_end_nid != 1))
-                                       return false;
-                       last_end_nid = current_end_nid;
-                       list_for_each_entry(el, &ar->ar_numaddr_ranges,
-                                           el_link) {
-                               list_for_each_entry(re, &el->el_exprs,
-                                                   re_link) {
-                                       if (re->re_stride > 1)
-                                               return false;
-                                       else if (last_hi != 0 &&
-                                                re->re_hi - last_hi != 1)
-                                               return false;
-                                       last_hi = re->re_hi;
-                               }
-                       }
-               }
-       }
-
-       return true;
-}
-
-/**
- * Determines whether an expression list in an ip nidrange contains exactly
- * one contiguous address range.
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-static bool cfs_ip_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       struct cfs_expr_list *el;
-       struct cfs_range_expr *re;
-       int expr_count;
-       int last_hi = 255;
-       int last_diff = 0;
-       __u32 last_end_nid = 0;
-       __u32 current_start_nid = 0;
-       __u32 current_end_nid = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       last_hi = 255;
-                       last_diff = 0;
-                       cfs_ip_ar_min_max(ar, &current_start_nid,
-                                         &current_end_nid);
-                       if (last_end_nid != 0 &&
-                           (current_start_nid - last_end_nid != 1))
-                                       return false;
-                       last_end_nid = current_end_nid;
-                       list_for_each_entry(el,
-                                           &ar->ar_numaddr_ranges,
-                                           el_link) {
-                               expr_count = 0;
-                               list_for_each_entry(re, &el->el_exprs,
-                                                   re_link) {
-                                       expr_count++;
-                                       if (re->re_stride > 1 ||
-                                           (last_diff > 0 && last_hi != 255) ||
-                                           (last_diff > 0 && last_hi == 255 &&
-                                            re->re_lo > 0))
-                                               return false;
-                                       last_hi = re->re_hi;
-                                       last_diff = re->re_hi - re->re_lo;
-                               }
-                       }
-               }
-       }
-
-       return true;
-}
-
-/**
- * Takes a linked list of nidrange expressions, determines the minimum
- * and maximum nid and creates appropriate nid structures
- *
- * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
- */
-void cfs_nidrange_find_min_max(struct list_head *nidlist, char *min_nid,
-                              char *max_nid, size_t nidstr_length)
-{
-       struct nidrange *nr;
-       struct netstrfns *nf = NULL;
-       int netnum = -1;
-       __u32 min_addr;
-       __u32 max_addr;
-       char *lndname = NULL;
-       char min_addr_str[IPSTRING_LENGTH];
-       char max_addr_str[IPSTRING_LENGTH];
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               nf = nr->nr_netstrfns;
-               lndname = nf->nf_name;
-               if (netnum == -1)
-                       netnum = nr->nr_netnum;
-
-               nf->nf_min_max(nidlist, &min_addr, &max_addr);
-       }
-       nf->nf_addr2str(min_addr, min_addr_str, sizeof(min_addr_str));
-       nf->nf_addr2str(max_addr, max_addr_str, sizeof(max_addr_str));
-
-       snprintf(min_nid, nidstr_length, "%s@%s%d", min_addr_str, lndname,
-                netnum);
-       snprintf(max_nid, nidstr_length, "%s@%s%d", max_addr_str, lndname,
-                netnum);
-}
-EXPORT_SYMBOL(cfs_nidrange_find_min_max);
-
-/**
- * Determines the min and max NID values for num LNDs
- *
- * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
- */
-static void cfs_num_min_max(struct list_head *nidlist, __u32 *min_nid,
-                           __u32 *max_nid)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       unsigned int tmp_min_addr = 0;
-       unsigned int tmp_max_addr = 0;
-       unsigned int min_addr = 0;
-       unsigned int max_addr = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_num_ar_min_max(ar, &tmp_min_addr,
-                                          &tmp_max_addr);
-                       if (tmp_min_addr < min_addr || min_addr == 0)
-                               min_addr = tmp_min_addr;
-                       if (tmp_max_addr > max_addr)
-                               max_addr = tmp_min_addr;
-               }
-       }
-       *max_nid = max_addr;
-       *min_nid = min_addr;
-}
-
-/**
- * Takes an nidlist and determines the minimum and maximum
- * ip addresses.
- *
- * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
- */
-static void cfs_ip_min_max(struct list_head *nidlist, __u32 *min_nid,
-                          __u32 *max_nid)
-{
-       struct nidrange *nr;
-       struct addrrange *ar;
-       __u32 tmp_min_ip_addr = 0;
-       __u32 tmp_max_ip_addr = 0;
-       __u32 min_ip_addr = 0;
-       __u32 max_ip_addr = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_ip_ar_min_max(ar, &tmp_min_ip_addr,
-                                         &tmp_max_ip_addr);
-                       if (tmp_min_ip_addr < min_ip_addr || min_ip_addr == 0)
-                               min_ip_addr = tmp_min_ip_addr;
-                       if (tmp_max_ip_addr > max_ip_addr)
-                               max_ip_addr = tmp_max_ip_addr;
-               }
-       }
-
-       if (min_nid != NULL)
-               *min_nid = min_ip_addr;
-       if (max_nid != NULL)
-               *max_nid = max_ip_addr;
-}
-
 static int
 libcfs_lo_str2addr(const char *str, int nob, __u32 *addr)
 {
@@ -898,16 +579,10 @@ libcfs_decnum_addr2str(__u32 addr, char *str, size_t size)
        snprintf(str, size, "%u", addr);
 }
 
-static void
-libcfs_hexnum_addr2str(__u32 addr, char *str, size_t size)
-{
-       snprintf(str, size, "0x%x", addr);
-}
-
 static int
 libcfs_num_str2addr(const char *str, int nob, __u32 *addr)
 {
-       int     n;
+       int     n;
 
        n = nob;
        if (sscanf(str, "0x%x%n", addr, &n) >= 1 && n == nob)
@@ -975,147 +650,61 @@ libcfs_num_match(__u32 addr, struct list_head *numaddr)
        return cfs_expr_list_match(addr, el);
 }
 
-static struct netstrfns  libcfs_netstrfns[] = {
-       {/* .nf_type      */  LOLND,
-        /* .nf_name      */  "lo",
-        /* .nf_modname   */  "klolnd",
-        /* .nf_addr2str  */  libcfs_decnum_addr2str,
-        /* .nf_str2addr  */  libcfs_lo_str2addr,
-        /* .nf_parse_addr*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */  SOCKLND,
-        /* .nf_name      */  "tcp",
-        /* .nf_modname   */  "ksocklnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  O2IBLND,
-        /* .nf_name      */  "o2ib",
-        /* .nf_modname   */  "ko2iblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  CIBLND,
-        /* .nf_name      */  "cib",
-        /* .nf_modname   */  "kciblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  OPENIBLND,
-        /* .nf_name      */  "openib",
-        /* .nf_modname   */  "kopeniblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  IIBLND,
-        /* .nf_name      */  "iib",
-        /* .nf_modname   */  "kiiblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  VIBLND,
-        /* .nf_name      */  "vib",
-        /* .nf_modname   */  "kviblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  RALND,
-        /* .nf_name      */  "ra",
-        /* .nf_modname   */  "kralnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */      QSWLND,
-        /* .nf_name      */      "elan",
-        /* .nf_modname   */      "kqswlnd",
-        /* .nf_addr2str  */      libcfs_decnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      GMLND,
-        /* .nf_name      */      "gm",
-        /* .nf_modname   */      "kgmlnd",
-        /* .nf_addr2str  */      libcfs_hexnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      MXLND,
-        /* .nf_name      */      "mx",
-        /* .nf_modname   */      "kmxlnd",
-        /* .nf_addr2str  */      libcfs_ip_addr2str,
-        /* .nf_str2addr  */      libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */      PTLLND,
-        /* .nf_name      */      "ptl",
-        /* .nf_modname   */      "kptllnd",
-        /* .nf_addr2str  */      libcfs_decnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      GNILND,
-        /* .nf_name      */      "gni",
-        /* .nf_modname   */      "kgnilnd",
-        /* .nf_addr2str  */      libcfs_decnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      GNIIPLND,
-        /* .nf_name      */      "gip",
-        /* .nf_modname   */      "kgnilnd",
-        /* .nf_addr2str  */      libcfs_ip_addr2str,
-        /* .nf_str2addr  */      libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
+static struct netstrfns libcfs_netstrfns[] = {
+       { .nf_type              = LOLND,
+         .nf_name              = "lo",
+         .nf_modname           = "klolnd",
+         .nf_addr2str          = libcfs_decnum_addr2str,
+         .nf_str2addr          = libcfs_lo_str2addr,
+         .nf_parse_addrlist    = libcfs_num_parse,
+         .nf_print_addrlist    = libcfs_num_addr_range_print,
+         .nf_match_addr        = libcfs_num_match
+       },
+       { .nf_type              = SOCKLND,
+         .nf_name              = "tcp",
+         .nf_modname           = "ksocklnd",
+         .nf_addr2str          = libcfs_ip_addr2str,
+         .nf_str2addr          = libcfs_ip_str2addr,
+         .nf_parse_addrlist    = cfs_ip_addr_parse,
+         .nf_print_addrlist    = libcfs_ip_addr_range_print,
+         .nf_match_addr        = cfs_ip_addr_match
+       },
+       { .nf_type              = O2IBLND,
+         .nf_name              = "o2ib",
+         .nf_modname           = "ko2iblnd",
+         .nf_addr2str          = libcfs_ip_addr2str,
+         .nf_str2addr          = libcfs_ip_str2addr,
+         .nf_parse_addrlist    = cfs_ip_addr_parse,
+         .nf_print_addrlist    = libcfs_ip_addr_range_print,
+         .nf_match_addr        = cfs_ip_addr_match
+       },
+       { .nf_type              = GNILND,
+         .nf_name              = "gni",
+         .nf_modname           = "kgnilnd",
+         .nf_addr2str          = libcfs_decnum_addr2str,
+         .nf_str2addr          = libcfs_num_str2addr,
+         .nf_parse_addrlist    = libcfs_num_parse,
+         .nf_print_addrlist    = libcfs_num_addr_range_print,
+         .nf_match_addr        = libcfs_num_match
+       },
+       { .nf_type              = GNIIPLND,
+         .nf_name              = "gip",
+         .nf_modname           = "kgnilnd",
+         .nf_addr2str          = libcfs_ip_addr2str,
+         .nf_str2addr          = libcfs_ip_str2addr,
+         .nf_parse_addrlist    = cfs_ip_addr_parse,
+         .nf_print_addrlist    = libcfs_ip_addr_range_print,
+         .nf_match_addr        = cfs_ip_addr_match
+       },
+       { .nf_type              = PTL4LND,
+         .nf_name              = "ptlf",
+         .nf_modname           = "kptl4lnd",
+         .nf_addr2str          = libcfs_decnum_addr2str,
+         .nf_str2addr          = libcfs_num_str2addr,
+         .nf_parse_addrlist    = libcfs_num_parse,
+         .nf_print_addrlist    = libcfs_num_addr_range_print,
+         .nf_match_addr        = libcfs_num_match
+       },
 };
 
 static const size_t libcfs_nnetstrfns = ARRAY_SIZE(libcfs_netstrfns);
@@ -1136,7 +725,7 @@ static struct netstrfns *
 libcfs_namenum2netstrfns(const char *name)
 {
        struct netstrfns *nf;
-       int               i;
+       int               i;
 
        for (i = 0; i < libcfs_nnetstrfns; i++) {
                nf = &libcfs_netstrfns[i];
@@ -1182,7 +771,7 @@ libcfs_str2lnd(const char *str)
        if (nf != NULL)
                return nf->nf_type;
 
-       return -1;
+       return -ENXIO;
 }
 EXPORT_SYMBOL(libcfs_str2lnd);
 
@@ -1306,10 +895,10 @@ EXPORT_SYMBOL(libcfs_str2net);
 lnet_nid_t
 libcfs_str2nid(const char *str)
 {
-       const char       *sep = strchr(str, '@');
+       const char       *sep = strchr(str, '@');
        struct netstrfns *nf;
-       __u32             net;
-       __u32             addr;
+       __u32             net;
+       __u32             addr;
 
        if (sep != NULL) {
                nf = libcfs_str2net_internal(sep + 1, &net);
@@ -1330,7 +919,7 @@ libcfs_str2nid(const char *str)
 EXPORT_SYMBOL(libcfs_str2nid);
 
 char *
-libcfs_id2str(lnet_process_id_t id)
+libcfs_id2str(struct lnet_process_id id)
 {
        char *str = libcfs_next_nidstring();