Whamcloud - gitweb
LU-14649 lnet: Correct distance calculation of local NIDs
[fs/lustre-release.git] / lnet / lnet / lib-move.c
index 3f0f07c..e458bbf 100644 (file)
@@ -27,7 +27,6 @@
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
  *
  * lnet/lnet/lib-move.c
  *
@@ -726,7 +725,7 @@ lnet_prep_send(struct lnet_msg *msg, int type, struct lnet_process_id target,
        msg->msg_hdr.payload_length = cpu_to_le32(len);
 }
 
-static void
+void
 lnet_ni_send(struct lnet_ni *ni, struct lnet_msg *msg)
 {
        void *priv = msg->msg_private;
@@ -928,6 +927,12 @@ lnet_post_send_locked(struct lnet_msg *msg, int do_send)
                }
        }
 
+       if (unlikely(!list_empty(&the_lnet.ln_delay_rules)) &&
+           lnet_delay_rule_match_locked(&msg->msg_hdr, msg)) {
+               msg->msg_tx_delayed = 1;
+               return LNET_CREDIT_WAIT;
+       }
+
        /* unset the tx_delay flag as we're going to send it now */
        msg->msg_tx_delayed = 0;
 
@@ -2099,7 +2104,6 @@ lnet_handle_find_routed_path(struct lnet_send_data *sd,
                             struct lnet_peer **gw_peer)
 {
        int rc;
-       __u32 local_lnet;
        struct lnet_peer *gw;
        struct lnet_peer *lp;
        struct lnet_peer_net *lpn;
@@ -2128,10 +2132,8 @@ lnet_handle_find_routed_path(struct lnet_send_data *sd,
                if (gwni) {
                        gw = gwni->lpni_peer_net->lpn_peer;
                        lnet_peer_ni_decref_locked(gwni);
-                       if (gw->lp_rtr_refcount) {
-                               local_lnet = LNET_NIDNET(sd->sd_rtr_nid);
+                       if (gw->lp_rtr_refcount)
                                route_found = true;
-                       }
                } else {
                        CWARN("No peer NI for gateway %s. Attempting to find an alternative route.\n",
                               libcfs_nid2str(sd->sd_rtr_nid));
@@ -2247,7 +2249,6 @@ use_lpn:
 
                gw = best_route->lr_gateway;
                LASSERT(gw == gwni->lpni_peer_net->lpn_peer);
-               local_lnet = best_route->lr_lnet;
        }
 
        /*
@@ -2255,22 +2256,20 @@ use_lpn:
         * This means we might delay the message until discovery has
         * completed
         */
-       sd->sd_msg->msg_src_nid_param = sd->sd_src_nid;
        rc = lnet_initiate_peer_discovery(gwni, sd->sd_msg, sd->sd_cpt);
        if (rc)
                return rc;
 
-       if (!sd->sd_best_ni)
-               sd->sd_best_ni = lnet_find_best_ni_on_spec_net(NULL, gw,
-                                       lnet_peer_get_net_locked(gw,
-                                                                local_lnet),
-                                       sd->sd_md_cpt);
-
        if (!sd->sd_best_ni) {
-               CERROR("Internal Error. Expected local ni on %s but non found :%s\n",
-                      libcfs_net2str(local_lnet),
-                      libcfs_nid2str(sd->sd_src_nid));
-               return -EFAULT;
+               lpn = gwni->lpni_peer_net;
+               sd->sd_best_ni = lnet_find_best_ni_on_spec_net(NULL, gw, lpn,
+                                                              sd->sd_md_cpt);
+               if (!sd->sd_best_ni) {
+                       CERROR("Internal Error. Expected local ni on %s but non found: %s\n",
+                              libcfs_net2str(lpn->lpn_net_id),
+                              libcfs_nid2str(sd->sd_src_nid));
+                       return -EFAULT;
+               }
        }
 
        *gw_lpni = gwni;
@@ -3349,6 +3348,7 @@ lnet_recover_local_nis(void)
        lnet_nid_t nid;
        int healthv;
        int rc;
+       time64_t now;
 
        /*
         * splice the recovery queue on a local queue. We will iterate
@@ -3362,6 +3362,8 @@ lnet_recover_local_nis(void)
                         &local_queue);
        lnet_net_unlock(0);
 
+       now = ktime_get_seconds();
+
        list_for_each_entry_safe(ni, tmp, &local_queue, ni_recovery) {
                /*
                 * if an NI is being deleted or it is now healthy, there
@@ -3395,9 +3397,15 @@ lnet_recover_local_nis(void)
                        ni->ni_recovery_state &= ~LNET_NI_RECOVERY_FAILED;
                }
 
+
                lnet_ni_unlock(ni);
-               lnet_net_unlock(0);
 
+               if (now < ni->ni_next_ping) {
+                       lnet_net_unlock(0);
+                       continue;
+               }
+
+               lnet_net_unlock(0);
 
                CDEBUG(D_NET, "attempting to recover local ni: %s\n",
                       libcfs_nid2str(ni->ni_nid));
@@ -3465,30 +3473,20 @@ lnet_recover_local_nis(void)
                                LNetMDUnlink(mdh);
                                continue;
                        }
-                       /*
-                        * Same note as in lnet_recover_peer_nis(). When
-                        * we're sending the ping, the NI is free to be
-                        * deleted or manipulated. By this point it
-                        * could've been added back on the recovery queue,
-                        * and a refcount taken on it.
-                        * So we can't just add it blindly again or we'll
-                        * corrupt the queue. We must check under lock if
-                        * it's not on any list and if not then add it
-                        * to the processed list, which will eventually be
-                        * spliced back on to the recovery queue.
-                        */
+                       ni->ni_ping_count++;
+
                        ni->ni_ping_mdh = mdh;
-                       if (list_empty(&ni->ni_recovery)) {
-                               list_add_tail(&ni->ni_recovery, &processed_list);
-                               lnet_ni_addref_locked(ni, 0);
-                       }
-                       lnet_net_unlock(0);
+                       lnet_ni_add_to_recoveryq_locked(ni, &processed_list,
+                                                       now);
 
-                       lnet_ni_lock(ni);
-                       if (rc)
+                       if (rc) {
+                               lnet_ni_lock(ni);
                                ni->ni_recovery_state &= ~LNET_NI_RECOVERY_PENDING;
-               }
-               lnet_ni_unlock(ni);
+                               lnet_ni_unlock(ni);
+                       }
+                       lnet_net_unlock(0);
+               } else
+                       lnet_ni_unlock(ni);
        }
 
        /*
@@ -3610,6 +3608,7 @@ lnet_recover_peer_nis(void)
        lnet_nid_t nid;
        int healthv;
        int rc;
+       time64_t now;
 
        /*
         * Always use cpt 0 for locking across all interactions with
@@ -3620,6 +3619,8 @@ lnet_recover_peer_nis(void)
                         &local_queue);
        lnet_net_unlock(0);
 
+       now = ktime_get_seconds();
+
        list_for_each_entry_safe(lpni, tmp, &local_queue,
                                 lpni_recovery) {
                /*
@@ -3650,6 +3651,12 @@ lnet_recover_peer_nis(void)
                }
 
                spin_unlock(&lpni->lpni_lock);
+
+               if (now < lpni->lpni_next_ping) {
+                       lnet_net_unlock(0);
+                       continue;
+               }
+
                lnet_net_unlock(0);
 
                /*
@@ -3699,30 +3706,24 @@ lnet_recover_peer_nis(void)
                                continue;
                        }
 
+                       lpni->lpni_ping_count++;
+
                        lpni->lpni_recovery_ping_mdh = mdh;
-                       /*
-                        * While we're unlocked the lpni could've been
-                        * readded on the recovery queue. In this case we
-                        * don't need to add it to the local queue, since
-                        * it's already on there and the thread that added
-                        * it would've incremented the refcount on the
-                        * peer, which means we need to decref the refcount
-                        * that was implicitly grabbed by find_peer_ni_locked.
-                        * Otherwise, if the lpni is still not on
-                        * the recovery queue, then we'll add it to the
-                        * processed list.
-                        */
-                       if (list_empty(&lpni->lpni_recovery))
-                               list_add_tail(&lpni->lpni_recovery, &processed_list);
-                       else
-                               lnet_peer_ni_decref_locked(lpni);
-                       lnet_net_unlock(0);
 
-                       spin_lock(&lpni->lpni_lock);
-                       if (rc)
+                       lnet_peer_ni_add_to_recoveryq_locked(lpni,
+                                                            &processed_list,
+                                                            now);
+                       if (rc) {
+                               spin_lock(&lpni->lpni_lock);
                                lpni->lpni_state &= ~LNET_PEER_NI_RECOVERY_PENDING;
-               }
-               spin_unlock(&lpni->lpni_lock);
+                               spin_unlock(&lpni->lpni_lock);
+                       }
+
+                       /* Drop the ref taken by lnet_find_peer_ni_locked() */
+                       lnet_peer_ni_decref_locked(lpni);
+                       lnet_net_unlock(0);
+               } else
+                       spin_unlock(&lpni->lpni_lock);
        }
 
        list_splice_init(&processed_list, &local_queue);
@@ -3734,9 +3735,7 @@ lnet_recover_peer_nis(void)
 static int
 lnet_monitor_thread(void *arg)
 {
-       time64_t recovery_timeout = 0;
        time64_t rsp_timeout = 0;
-       int interval;
        time64_t now;
 
        wait_for_completion(&the_lnet.ln_started);
@@ -3763,11 +3762,8 @@ lnet_monitor_thread(void *arg)
                        rsp_timeout = now + (lnet_transaction_timeout / 2);
                }
 
-               if (now >= recovery_timeout) {
-                       lnet_recover_local_nis();
-                       lnet_recover_peer_nis();
-                       recovery_timeout = now + lnet_recovery_interval;
-               }
+               lnet_recover_local_nis();
+               lnet_recover_peer_nis();
 
                /*
                 * TODO do we need to check if we should sleep without
@@ -3777,18 +3773,10 @@ lnet_monitor_thread(void *arg)
                 * if we wake up every 1 second? Although, we've seen
                 * cases where we get a complaint that an idle thread
                 * is waking up unnecessarily.
-                *
-                * Take into account the current net_count when you wake
-                * up for alive router checking, since we need to check
-                * possibly as many networks as we have configured.
                 */
-               interval = min(lnet_recovery_interval,
-                              min((unsigned int) alive_router_check_interval /
-                                       lnet_current_net_count,
-                                  lnet_transaction_timeout / 2));
                wait_for_completion_interruptible_timeout(
                        &the_lnet.ln_mt_wait_complete,
-                       cfs_time_seconds(interval));
+                       cfs_time_seconds(1));
                /* Must re-init the completion before testing anything,
                 * including ln_mt_state.
                 */
@@ -4573,61 +4561,6 @@ lnet_parse(struct lnet_ni *ni, struct lnet_hdr *hdr, lnet_nid_t from_nid,
                goto drop;
        }
 
-       if (lnet_drop_asym_route && for_me &&
-           LNET_NIDNET(src_nid) != LNET_NIDNET(from_nid)) {
-               struct lnet_net *net;
-               struct lnet_remotenet *rnet;
-               bool found = true;
-
-               /* we are dealing with a routed message,
-                * so see if route to reach src_nid goes through from_nid
-                */
-               lnet_net_lock(cpt);
-               net = lnet_get_net_locked(LNET_NIDNET(ni->ni_nid));
-               if (!net) {
-                       lnet_net_unlock(cpt);
-                       CERROR("net %s not found\n",
-                              libcfs_net2str(LNET_NIDNET(ni->ni_nid)));
-                       return -EPROTO;
-               }
-
-               rnet = lnet_find_rnet_locked(LNET_NIDNET(src_nid));
-               if (rnet) {
-                       struct lnet_peer *gw = NULL;
-                       struct lnet_peer_ni *lpni = NULL;
-                       struct lnet_route *route;
-
-                       list_for_each_entry(route, &rnet->lrn_routes, lr_list) {
-                               found = false;
-                               gw = route->lr_gateway;
-                               if (route->lr_lnet != net->net_id)
-                                       continue;
-                               /*
-                                * if the nid is one of the gateway's NIDs
-                                * then this is a valid gateway
-                                */
-                               while ((lpni = lnet_get_next_peer_ni_locked(gw,
-                                               NULL, lpni)) != NULL) {
-                                       if (lpni->lpni_nid == from_nid) {
-                                               found = true;
-                                               break;
-                                       }
-                               }
-                       }
-               }
-               lnet_net_unlock(cpt);
-               if (!found) {
-                       /* we would not use from_nid to route a message to
-                        * src_nid
-                        * => asymmetric routing detected but forbidden
-                        */
-                       CERROR("%s, src %s: Dropping asymmetrical route %s\n",
-                              libcfs_nid2str(from_nid),
-                              libcfs_nid2str(src_nid), lnet_msgtyp2str(type));
-                       goto drop;
-               }
-       }
-
        msg = lnet_msg_alloc();
        if (msg == NULL) {
                CERROR("%s, src %s: Dropping %s (out of memory)\n",
@@ -4678,8 +4611,65 @@ lnet_parse(struct lnet_ni *ni, struct lnet_hdr *hdr, lnet_nid_t from_nid,
                goto drop;
        }
 
-       if (the_lnet.ln_routing)
-               lpni->lpni_last_alive = ktime_get_seconds();
+       /* If this message was forwarded to us from a router then we may need
+        * to update router aliveness or check for an asymmetrical route
+        * (or both)
+        */
+       if (((lnet_drop_asym_route && for_me) ||
+            !lpni->lpni_peer_net->lpn_peer->lp_alive) &&
+           LNET_NIDNET(src_nid) != LNET_NIDNET(from_nid)) {
+               __u32 src_net_id = LNET_NIDNET(src_nid);
+               struct lnet_peer *gw = lpni->lpni_peer_net->lpn_peer;
+               struct lnet_route *route;
+               bool found = false;
+
+               list_for_each_entry(route, &gw->lp_routes, lr_gwlist) {
+                       if (route->lr_net == src_net_id) {
+                               found = true;
+                               /* If we're transitioning the gateway from
+                                * dead -> alive, and discovery is disabled
+                                * locally or on the gateway, then we need to
+                                * update the cached route aliveness for each
+                                * route to the src_nid's net.
+                                *
+                                * Otherwise, we're only checking for
+                                * symmetrical route, and we can break the
+                                * loop
+                                */
+                               if (!gw->lp_alive &&
+                                   lnet_is_discovery_disabled(gw))
+                                       lnet_set_route_aliveness(route, true);
+                               else
+                                       break;
+                       }
+               }
+               if (lnet_drop_asym_route && for_me && !found) {
+                       lnet_net_unlock(cpt);
+                       /* we would not use from_nid to route a message to
+                        * src_nid
+                        * => asymmetric routing detected but forbidden
+                        */
+                       CERROR("%s, src %s: Dropping asymmetrical route %s\n",
+                              libcfs_nid2str(from_nid),
+                              libcfs_nid2str(src_nid), lnet_msgtyp2str(type));
+                       lnet_msg_free(msg);
+                       goto drop;
+               }
+               if (!gw->lp_alive) {
+                       struct lnet_peer_net *lpn;
+                       struct lnet_peer_ni *lpni2;
+
+                       gw->lp_alive = true;
+                       /* Mark all remote NIs on src_nid's net UP */
+                       lpn = lnet_peer_get_net_locked(gw, src_net_id);
+                       if (lpn)
+                               list_for_each_entry(lpni2, &lpn->lpn_peer_nis,
+                                                   lpni_peer_nis)
+                                       lpni2->lpni_ns_status = LNET_NI_STATUS_UP;
+               }
+       }
+
+       lpni->lpni_last_alive = ktime_get_seconds();
 
        msg->msg_rxpeer = lpni;
        msg->msg_rxni = ni;
@@ -5252,6 +5242,7 @@ LNetDist(lnet_nid_t dstnid, lnet_nid_t *srcnidp, __u32 *orderp)
        int cpt;
        __u32 order = 2;
        struct list_head *rn_list;
+       bool matched_dstnet = false;
 
        /* if !local_nid_dist_zero, I don't return a distance of 0 ever
         * (when lustre sees a distance of 0, it substitutes 0@lo), so I
@@ -5277,25 +5268,40 @@ LNetDist(lnet_nid_t dstnid, lnet_nid_t *srcnidp, __u32 *orderp)
                        return local_nid_dist_zero ? 0 : 1;
                }
 
-               if (LNET_NIDNET(ni->ni_nid) == dstnet) {
-                       /* Check if ni was originally created in
-                        * current net namespace.
-                        * If not, assign order above 0xffff0000,
-                        * to make this ni not a priority. */
-                       if (current->nsproxy &&
-                           !net_eq(ni->ni_net_ns, current->nsproxy->net_ns))
-                                       order += 0xffff0000;
-                       if (srcnidp != NULL)
+               if (!matched_dstnet && LNET_NIDNET(ni->ni_nid) == dstnet) {
+                       matched_dstnet = true;
+                       /* We matched the destination net, but we may have
+                        * additional local NIs to inspect.
+                        *
+                        * We record the nid and order as appropriate, but
+                        * they may be overwritten if we match local NI above.
+                        */
+                       if (srcnidp)
                                *srcnidp = ni->ni_nid;
-                       if (orderp != NULL)
-                               *orderp = order;
-                       lnet_net_unlock(cpt);
-                       return 1;
+
+                       if (orderp) {
+                               /* Check if ni was originally created in
+                                * current net namespace.
+                                * If not, assign order above 0xffff0000,
+                                * to make this ni not a priority.
+                                */
+                               if (current->nsproxy &&
+                                   !net_eq(ni->ni_net_ns,
+                                           current->nsproxy->net_ns))
+                                       *orderp = order + 0xffff0000;
+                               else
+                                       *orderp = order;
+                       }
                }
 
                order++;
        }
 
+       if (matched_dstnet) {
+               lnet_net_unlock(cpt);
+               return 1;
+       }
+
        rn_list = lnet_net2rnethash(dstnet);
        list_for_each(e, rn_list) {
                rnet = list_entry(e, struct lnet_remotenet, lrn_list);