Whamcloud - gitweb
LU-1346 libcfs: cleanup macros in kp30.h
[fs/lustre-release.git] / lnet / klnds / socklnd / socklnd_cb.c
index 453bd0e..e624753 100644 (file)
@@ -1,8 +1,8 @@
-/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*-
- * vim:expandtab:shiftwidth=8:tabstop=8:
- *
+/*
  * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved.
  *
+ * Copyright (c) 2011, 2012, Intel Corporation.
+ *
  *   Author: Zach Brown <zab@zabbo.net>
  *   Author: Peter J. Braam <braam@clusterfs.com>
  *   Author: Phil Schwan <phil@clusterfs.com>
 ksock_tx_t *
 ksocknal_alloc_tx(int type, int size)
 {
-        ksock_tx_t *tx = NULL;
+       ksock_tx_t *tx = NULL;
 
-        if (type == KSOCK_MSG_NOOP) {
-                LASSERT (size == KSOCK_NOOP_TX_SIZE);
+       if (type == KSOCK_MSG_NOOP) {
+               LASSERT(size == KSOCK_NOOP_TX_SIZE);
 
-                /* searching for a noop tx in free list */
-                cfs_spin_lock(&ksocknal_data.ksnd_tx_lock);
+               /* searching for a noop tx in free list */
+               spin_lock(&ksocknal_data.ksnd_tx_lock);
 
-                if (!cfs_list_empty(&ksocknal_data.ksnd_idle_noop_txs)) {
-                        tx = cfs_list_entry(ksocknal_data.ksnd_idle_noop_txs. \
-                                            next, ksock_tx_t, tx_list);
-                        LASSERT(tx->tx_desc_size == size);
-                        cfs_list_del(&tx->tx_list);
-                }
+               if (!cfs_list_empty(&ksocknal_data.ksnd_idle_noop_txs)) {
+                       tx = cfs_list_entry(ksocknal_data.ksnd_idle_noop_txs. \
+                                           next, ksock_tx_t, tx_list);
+                       LASSERT(tx->tx_desc_size == size);
+                       cfs_list_del(&tx->tx_list);
+               }
 
-                cfs_spin_unlock(&ksocknal_data.ksnd_tx_lock);
+               spin_unlock(&ksocknal_data.ksnd_tx_lock);
         }
 
         if (tx == NULL)
@@ -54,6 +54,7 @@ ksocknal_alloc_tx(int type, int size)
                 return NULL;
 
         cfs_atomic_set(&tx->tx_refcount, 1);
+        tx->tx_zc_aborted = 0;
         tx->tx_zc_capable = 0;
         tx->tx_zc_checked = 0;
         tx->tx_desc_size  = size;
@@ -92,18 +93,18 @@ ksocknal_alloc_tx_noop(__u64 cookie, int nonblk)
 void
 ksocknal_free_tx (ksock_tx_t *tx)
 {
-        cfs_atomic_dec(&ksocknal_data.ksnd_nactive_txs);
+       cfs_atomic_dec(&ksocknal_data.ksnd_nactive_txs);
 
-        if (tx->tx_lnetmsg == NULL && tx->tx_desc_size == KSOCK_NOOP_TX_SIZE) {
-                /* it's a noop tx */
-                cfs_spin_lock(&ksocknal_data.ksnd_tx_lock);
+       if (tx->tx_lnetmsg == NULL && tx->tx_desc_size == KSOCK_NOOP_TX_SIZE) {
+               /* it's a noop tx */
+               spin_lock(&ksocknal_data.ksnd_tx_lock);
 
-                cfs_list_add(&tx->tx_list, &ksocknal_data.ksnd_idle_noop_txs);
+               cfs_list_add(&tx->tx_list, &ksocknal_data.ksnd_idle_noop_txs);
 
-                cfs_spin_unlock(&ksocknal_data.ksnd_tx_lock);
-        } else {
-                LIBCFS_FREE(tx, tx->tx_desc_size);
-        }
+               spin_unlock(&ksocknal_data.ksnd_tx_lock);
+       } else {
+               LIBCFS_FREE(tx, tx->tx_desc_size);
+       }
 }
 
 int
@@ -387,7 +388,7 @@ void
 ksocknal_tx_done (lnet_ni_t *ni, ksock_tx_t *tx)
 {
         lnet_msg_t  *lnetmsg = tx->tx_lnetmsg;
-        int          rc = (tx->tx_resid == 0) ? 0 : -EIO;
+        int          rc = (tx->tx_resid == 0 && !tx->tx_zc_aborted) ? 0 : -EIO;
         ENTRY;
 
         LASSERT(ni != NULL || tx->tx_conn != NULL);
@@ -414,13 +415,13 @@ ksocknal_txlist_done (lnet_ni_t *ni, cfs_list_t *txlist, int error)
                 tx = cfs_list_entry (txlist->next, ksock_tx_t, tx_list);
 
                 if (error && tx->tx_lnetmsg != NULL) {
-                        CDEBUG (D_NETERROR, "Deleting packet type %d len %d %s->%s\n",
+                        CNETERR("Deleting packet type %d len %d %s->%s\n",
                                 le32_to_cpu (tx->tx_lnetmsg->msg_hdr.type),
                                 le32_to_cpu (tx->tx_lnetmsg->msg_hdr.payload_length),
                                 libcfs_nid2str(le64_to_cpu(tx->tx_lnetmsg->msg_hdr.src_nid)),
                                 libcfs_nid2str(le64_to_cpu(tx->tx_lnetmsg->msg_hdr.dest_nid)));
                 } else if (error) {
-                        CDEBUG (D_NETERROR, "Deleting noop packet\n");
+                        CNETERR("Deleting noop packet\n");
                 }
 
                 cfs_list_del (&tx->tx_list);
@@ -456,7 +457,7 @@ ksocknal_check_zc_req(ksock_tx_t *tx)
 
         ksocknal_tx_addref(tx);
 
-        cfs_spin_lock(&peer->ksnp_lock);
+       spin_lock(&peer->ksnp_lock);
 
         /* ZC_REQ is going to be pinned to the peer */
         tx->tx_deadline =
@@ -471,33 +472,33 @@ ksocknal_check_zc_req(ksock_tx_t *tx)
 
         cfs_list_add_tail(&tx->tx_zc_list, &peer->ksnp_zc_req_list);
 
-        cfs_spin_unlock(&peer->ksnp_lock);
+       spin_unlock(&peer->ksnp_lock);
 }
 
 static void
 ksocknal_uncheck_zc_req(ksock_tx_t *tx)
 {
-        ksock_peer_t   *peer = tx->tx_conn->ksnc_peer;
+       ksock_peer_t   *peer = tx->tx_conn->ksnc_peer;
 
-        LASSERT (tx->tx_msg.ksm_type != KSOCK_MSG_NOOP);
-        LASSERT (tx->tx_zc_capable);
+       LASSERT(tx->tx_msg.ksm_type != KSOCK_MSG_NOOP);
+       LASSERT(tx->tx_zc_capable);
 
-        tx->tx_zc_checked = 0;
+       tx->tx_zc_checked = 0;
 
-        cfs_spin_lock(&peer->ksnp_lock);
+       spin_lock(&peer->ksnp_lock);
 
-        if (tx->tx_msg.ksm_zc_cookies[0] == 0) {
-                /* Not waiting for an ACK */
-                cfs_spin_unlock(&peer->ksnp_lock);
-                return;
-        }
+       if (tx->tx_msg.ksm_zc_cookies[0] == 0) {
+               /* Not waiting for an ACK */
+               spin_unlock(&peer->ksnp_lock);
+               return;
+       }
 
-        tx->tx_msg.ksm_zc_cookies[0] = 0;
-        cfs_list_del(&tx->tx_zc_list);
+       tx->tx_msg.ksm_zc_cookies[0] = 0;
+       cfs_list_del(&tx->tx_zc_list);
 
-        cfs_spin_unlock(&peer->ksnp_lock);
+       spin_unlock(&peer->ksnp_lock);
 
-        ksocknal_tx_decref(tx);
+       ksocknal_tx_decref(tx);
 }
 
 int
@@ -531,7 +532,7 @@ ksocknal_process_transmit (ksock_conn_t *conn, ksock_tx_t *tx)
                               counter, conn, cfs_atomic_read(&libcfs_kmemory));
 
                 /* Queue on ksnd_enomem_conns for retry after a timeout */
-                cfs_spin_lock_bh (&ksocknal_data.ksnd_reaper_lock);
+               spin_lock_bh(&ksocknal_data.ksnd_reaper_lock);
 
                 /* enomem list takes over scheduler's ref... */
                 LASSERT (conn->ksnc_tx_scheduled);
@@ -542,7 +543,7 @@ ksocknal_process_transmit (ksock_conn_t *conn, ksock_tx_t *tx)
                                    ksocknal_data.ksnd_reaper_waketime))
                         cfs_waitq_signal (&ksocknal_data.ksnd_reaper_waitq);
 
-                cfs_spin_unlock_bh (&ksocknal_data.ksnd_reaper_lock);
+               spin_unlock_bh(&ksocknal_data.ksnd_reaper_lock);
                 return (rc);
         }
 
@@ -593,13 +594,13 @@ ksocknal_launch_connection_locked (ksock_route_t *route)
         route->ksnr_scheduled = 1;              /* scheduling conn for connd */
         ksocknal_route_addref(route);           /* extra ref for connd */
 
-        cfs_spin_lock_bh (&ksocknal_data.ksnd_connd_lock);
+       spin_lock_bh(&ksocknal_data.ksnd_connd_lock);
 
-        cfs_list_add_tail (&route->ksnr_connd_list,
-                           &ksocknal_data.ksnd_connd_routes);
-        cfs_waitq_signal (&ksocknal_data.ksnd_connd_waitq);
+       cfs_list_add_tail(&route->ksnr_connd_list,
+                         &ksocknal_data.ksnd_connd_routes);
+       cfs_waitq_signal(&ksocknal_data.ksnd_connd_waitq);
 
-        cfs_spin_unlock_bh (&ksocknal_data.ksnd_connd_lock);
+       spin_unlock_bh(&ksocknal_data.ksnd_connd_lock);
 }
 
 void
@@ -728,7 +729,7 @@ ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn)
          * but they're used inside spinlocks a lot.
          */
         bufnob = libcfs_sock_wmem_queued(conn->ksnc_sock);
-        cfs_spin_lock_bh (&sched->kss_lock);
+       spin_lock_bh(&sched->kss_lock);
 
         if (cfs_list_empty(&conn->ksnc_tx_queue) && bufnob == 0) {
                 /* First packet starts the timeout */
@@ -774,7 +775,7 @@ ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn)
                 cfs_waitq_signal (&sched->kss_waitq);
         }
 
-        cfs_spin_unlock_bh (&sched->kss_lock);
+       spin_unlock_bh(&sched->kss_lock);
 }
 
 
@@ -838,7 +839,7 @@ ksocknal_launch_packet (lnet_ni_t *ni, ksock_tx_t *tx, lnet_process_id_t id)
 {
         ksock_peer_t     *peer;
         ksock_conn_t     *conn;
-        cfs_rwlock_t     *g_lock;
+       rwlock_t     *g_lock;
         int               retry;
         int               rc;
 
@@ -847,7 +848,7 @@ ksocknal_launch_packet (lnet_ni_t *ni, ksock_tx_t *tx, lnet_process_id_t id)
         g_lock = &ksocknal_data.ksnd_global_lock;
 
         for (retry = 0;; retry = 1) {
-                cfs_read_lock (g_lock);
+               read_lock(g_lock);
                 peer = ksocknal_find_peer_locked(ni, id);
                 if (peer != NULL) {
                         if (ksocknal_find_connectable_route_locked(peer) == NULL) {
@@ -857,22 +858,22 @@ ksocknal_launch_packet (lnet_ni_t *ni, ksock_tx_t *tx, lnet_process_id_t id)
                                          * connecting and I do have an actual
                                          * connection... */
                                         ksocknal_queue_tx_locked (tx, conn);
-                                        cfs_read_unlock (g_lock);
+                                       read_unlock(g_lock);
                                         return (0);
                                 }
                         }
                 }
 
                 /* I'll need a write lock... */
-                cfs_read_unlock (g_lock);
+               read_unlock(g_lock);
 
-                cfs_write_lock_bh (g_lock);
+               write_lock_bh(g_lock);
 
                 peer = ksocknal_find_peer_locked(ni, id);
                 if (peer != NULL)
                         break;
 
-                cfs_write_unlock_bh (g_lock);
+               write_unlock_bh(g_lock);
 
                 if ((id.pid & LNET_PID_USERFLAG) != 0) {
                         CERROR("Refusing to create a connection to "
@@ -901,7 +902,7 @@ ksocknal_launch_packet (lnet_ni_t *ni, ksock_tx_t *tx, lnet_process_id_t id)
         if (conn != NULL) {
                 /* Connection exists; queue message on it */
                 ksocknal_queue_tx_locked (tx, conn);
-                cfs_write_unlock_bh (g_lock);
+               write_unlock_bh(g_lock);
                 return (0);
         }
 
@@ -913,20 +914,21 @@ ksocknal_launch_packet (lnet_ni_t *ni, ksock_tx_t *tx, lnet_process_id_t id)
 
                 /* Queue the message until a connection is established */
                 cfs_list_add_tail (&tx->tx_list, &peer->ksnp_tx_queue);
-                cfs_write_unlock_bh (g_lock);
+               write_unlock_bh(g_lock);
                 return 0;
         }
 
-        cfs_write_unlock_bh (g_lock);
+       write_unlock_bh(g_lock);
 
         /* NB Routes may be ignored if connections to them failed recently */
-        CDEBUG(D_NETERROR, "No usable routes to %s\n", libcfs_id2str(id));
+        CNETERR("No usable routes to %s\n", libcfs_id2str(id));
         return (-EHOSTUNREACH);
 }
 
 int
 ksocknal_send(lnet_ni_t *ni, void *private, lnet_msg_t *lntmsg)
 {
+        int               mpflag = 0;
         int               type = lntmsg->msg_type;
         lnet_process_id_t target = lntmsg->msg_target;
         unsigned int      payload_niov = lntmsg->msg_niov;
@@ -957,10 +959,14 @@ ksocknal_send(lnet_ni_t *ni, void *private, lnet_msg_t *lntmsg)
                 desc_size = offsetof(ksock_tx_t,
                                      tx_frags.paged.kiov[payload_niov]);
 
+        if (lntmsg->msg_vmflush)
+                mpflag = cfs_memory_pressure_get_and_set();
         tx = ksocknal_alloc_tx(KSOCK_MSG_LNET, desc_size);
         if (tx == NULL) {
                 CERROR("Can't allocate tx desc type %d size %d\n",
                        type, desc_size);
+                if (lntmsg->msg_vmflush)
+                        cfs_memory_pressure_restore(mpflag);
                 return (-ENOMEM);
         }
 
@@ -991,6 +997,8 @@ ksocknal_send(lnet_ni_t *ni, void *private, lnet_msg_t *lntmsg)
 
         /* The first fragment will be set later in pro_pack */
         rc = ksocknal_launch_packet(ni, tx, target);
+        if (lntmsg->msg_vmflush)
+                cfs_memory_pressure_restore(mpflag);
         if (rc == 0)
                 return (0);
 
@@ -999,25 +1007,25 @@ ksocknal_send(lnet_ni_t *ni, void *private, lnet_msg_t *lntmsg)
 }
 
 int
-ksocknal_thread_start (int (*fn)(void *arg), void *arg)
+ksocknal_thread_start(int (*fn)(void *arg), void *arg, char *name)
 {
-        long          pid = cfs_kernel_thread (fn, arg, 0);
+       cfs_task_t *task = kthread_run(fn, arg, name);
 
-        if (pid < 0)
-                return ((int)pid);
+       if (IS_ERR(task))
+               return PTR_ERR(task);
 
-        cfs_write_lock_bh (&ksocknal_data.ksnd_global_lock);
-        ksocknal_data.ksnd_nthreads++;
-        cfs_write_unlock_bh (&ksocknal_data.ksnd_global_lock);
-        return (0);
+       write_lock_bh(&ksocknal_data.ksnd_global_lock);
+       ksocknal_data.ksnd_nthreads++;
+       write_unlock_bh(&ksocknal_data.ksnd_global_lock);
+       return 0;
 }
 
 void
 ksocknal_thread_fini (void)
 {
-        cfs_write_lock_bh (&ksocknal_data.ksnd_global_lock);
+       write_lock_bh(&ksocknal_data.ksnd_global_lock);
         ksocknal_data.ksnd_nthreads--;
-        cfs_write_unlock_bh (&ksocknal_data.ksnd_global_lock);
+       write_unlock_bh(&ksocknal_data.ksnd_global_lock);
 }
 
 int
@@ -1344,7 +1352,7 @@ ksocknal_recv (lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
 
         LASSERT (conn->ksnc_rx_scheduled);
 
-        cfs_spin_lock_bh (&sched->kss_lock);
+       spin_lock_bh(&sched->kss_lock);
 
         switch (conn->ksnc_rx_state) {
         case SOCKNAL_RX_PARSE_WAIT:
@@ -1360,44 +1368,48 @@ ksocknal_recv (lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
 
         conn->ksnc_rx_state = SOCKNAL_RX_LNET_PAYLOAD;
 
-        cfs_spin_unlock_bh (&sched->kss_lock);
-        ksocknal_conn_decref(conn);
-        return (0);
+       spin_unlock_bh(&sched->kss_lock);
+       ksocknal_conn_decref(conn);
+       return 0;
 }
 
 static inline int
 ksocknal_sched_cansleep(ksock_sched_t *sched)
 {
-        int           rc;
+       int           rc;
 
-        cfs_spin_lock_bh (&sched->kss_lock);
+       spin_lock_bh(&sched->kss_lock);
 
-        rc = (!ksocknal_data.ksnd_shuttingdown &&
-              cfs_list_empty(&sched->kss_rx_conns) &&
-              cfs_list_empty(&sched->kss_tx_conns));
+       rc = (!ksocknal_data.ksnd_shuttingdown &&
+             cfs_list_empty(&sched->kss_rx_conns) &&
+             cfs_list_empty(&sched->kss_tx_conns));
 
-        cfs_spin_unlock_bh (&sched->kss_lock);
-        return (rc);
+       spin_unlock_bh(&sched->kss_lock);
+       return rc;
 }
 
-int ksocknal_scheduler (void *arg)
+int ksocknal_scheduler(void *arg)
 {
-        ksock_sched_t     *sched = (ksock_sched_t *)arg;
-        ksock_conn_t      *conn;
-        ksock_tx_t        *tx;
-        int                rc;
-        int                nloops = 0;
-        int                id = (int)(sched - ksocknal_data.ksnd_schedulers);
-        char               name[16];
+       struct ksock_sched_info *info;
+       ksock_sched_t           *sched;
+       ksock_conn_t            *conn;
+       ksock_tx_t              *tx;
+       int                     rc;
+       int                     nloops = 0;
+       long                    id = (long)arg;
 
-        snprintf (name, sizeof (name),"socknal_sd%02d", id);
-        cfs_daemonize (name);
-        cfs_block_allsigs ();
+       info = ksocknal_data.ksnd_sched_info[KSOCK_THREAD_CPT(id)];
+       sched = &info->ksi_scheds[KSOCK_THREAD_SID(id)];
 
-        if (ksocknal_lib_bind_thread_to_cpu(id))
-                CERROR ("Can't set CPU affinity for %s to %d\n", name, id);
+       cfs_block_allsigs();
 
-        cfs_spin_lock_bh (&sched->kss_lock);
+       rc = cfs_cpt_bind(lnet_cpt_table(), info->ksi_cpt);
+       if (rc != 0) {
+               CERROR("Can't set CPT affinity to %d: %d\n",
+                      info->ksi_cpt, rc);
+       }
+
+       spin_lock_bh(&sched->kss_lock);
 
         while (!ksocknal_data.ksnd_shuttingdown) {
                 int did_something = 0;
@@ -1417,11 +1429,11 @@ int ksocknal_scheduler (void *arg)
                          * data_ready can set it any time after we release
                          * kss_lock. */
                         conn->ksnc_rx_ready = 0;
-                        cfs_spin_unlock_bh (&sched->kss_lock);
+                       spin_unlock_bh(&sched->kss_lock);
 
-                        rc = ksocknal_process_receive(conn);
+                       rc = ksocknal_process_receive(conn);
 
-                        cfs_spin_lock_bh (&sched->kss_lock);
+                       spin_lock_bh(&sched->kss_lock);
 
                         /* I'm the only one that can clear this flag */
                         LASSERT(conn->ksnc_rx_scheduled);
@@ -1479,7 +1491,7 @@ int ksocknal_scheduler (void *arg)
                          * write_space can set it any time after we release
                          * kss_lock. */
                         conn->ksnc_tx_ready = 0;
-                        cfs_spin_unlock_bh (&sched->kss_lock);
+                       spin_unlock_bh(&sched->kss_lock);
 
                         if (!cfs_list_empty(&zlist)) {
                                 /* free zombie noop txs, it's fast because 
@@ -1491,14 +1503,14 @@ int ksocknal_scheduler (void *arg)
 
                         if (rc == -ENOMEM || rc == -EAGAIN) {
                                 /* Incomplete send: replace tx on HEAD of tx_queue */
-                                cfs_spin_lock_bh (&sched->kss_lock);
-                                cfs_list_add (&tx->tx_list,
-                                              &conn->ksnc_tx_queue);
-                        } else {
-                                /* Complete send; tx -ref */
-                                ksocknal_tx_decref (tx);
-
-                                cfs_spin_lock_bh (&sched->kss_lock);
+                               spin_lock_bh(&sched->kss_lock);
+                               cfs_list_add(&tx->tx_list,
+                                            &conn->ksnc_tx_queue);
+                       } else {
+                               /* Complete send; tx -ref */
+                               ksocknal_tx_decref(tx);
+
+                               spin_lock_bh(&sched->kss_lock);
                                 /* assume space for more */
                                 conn->ksnc_tx_ready = 1;
                         }
@@ -1521,7 +1533,7 @@ int ksocknal_scheduler (void *arg)
                 }
                 if (!did_something ||           /* nothing to do */
                     ++nloops == SOCKNAL_RESCHED) { /* hogging CPU? */
-                        cfs_spin_unlock_bh (&sched->kss_lock);
+                       spin_unlock_bh(&sched->kss_lock);
 
                         nloops = 0;
 
@@ -1534,13 +1546,13 @@ int ksocknal_scheduler (void *arg)
                                 cfs_cond_resched();
                         }
 
-                        cfs_spin_lock_bh (&sched->kss_lock);
-                }
-        }
+                       spin_lock_bh(&sched->kss_lock);
+               }
+       }
 
-        cfs_spin_unlock_bh (&sched->kss_lock);
-        ksocknal_thread_fini ();
-        return (0);
+       spin_unlock_bh(&sched->kss_lock);
+       ksocknal_thread_fini();
+       return 0;
 }
 
 /*
@@ -1549,12 +1561,12 @@ int ksocknal_scheduler (void *arg)
  */
 void ksocknal_read_callback (ksock_conn_t *conn)
 {
-        ksock_sched_t *sched;
-        ENTRY;
+       ksock_sched_t *sched;
+       ENTRY;
 
-        sched = conn->ksnc_scheduler;
+       sched = conn->ksnc_scheduler;
 
-        cfs_spin_lock_bh (&sched->kss_lock);
+       spin_lock_bh(&sched->kss_lock);
 
         conn->ksnc_rx_ready = 1;
 
@@ -1567,9 +1579,9 @@ void ksocknal_read_callback (ksock_conn_t *conn)
 
                 cfs_waitq_signal (&sched->kss_waitq);
         }
-        cfs_spin_unlock_bh (&sched->kss_lock);
+       spin_unlock_bh(&sched->kss_lock);
 
-        EXIT;
+       EXIT;
 }
 
 /*
@@ -1578,12 +1590,12 @@ void ksocknal_read_callback (ksock_conn_t *conn)
  */
 void ksocknal_write_callback (ksock_conn_t *conn)
 {
-        ksock_sched_t *sched;
-        ENTRY;
+       ksock_sched_t *sched;
+       ENTRY;
 
-        sched = conn->ksnc_scheduler;
+       sched = conn->ksnc_scheduler;
 
-        cfs_spin_lock_bh (&sched->kss_lock);
+       spin_lock_bh(&sched->kss_lock);
 
         conn->ksnc_tx_ready = 1;
 
@@ -1598,9 +1610,9 @@ void ksocknal_write_callback (ksock_conn_t *conn)
                 cfs_waitq_signal (&sched->kss_waitq);
         }
 
-        cfs_spin_unlock_bh (&sched->kss_lock);
+       spin_unlock_bh(&sched->kss_lock);
 
-        EXIT;
+       EXIT;
 }
 
 ksock_proto_t *
@@ -1847,7 +1859,7 @@ ksocknal_connect (ksock_route_t *route)
         deadline = cfs_time_add(cfs_time_current(),
                                 cfs_time_seconds(*ksocknal_tunables.ksnd_timeout));
 
-        cfs_write_lock_bh (&ksocknal_data.ksnd_global_lock);
+       write_lock_bh(&ksocknal_data.ksnd_global_lock);
 
         LASSERT (route->ksnr_scheduled);
         LASSERT (!route->ksnr_connecting);
@@ -1887,7 +1899,7 @@ ksocknal_connect (ksock_route_t *route)
                         type = SOCKLND_CONN_BULK_OUT;
                 }
 
-                cfs_write_unlock_bh (&ksocknal_data.ksnd_global_lock);
+               write_unlock_bh(&ksocknal_data.ksnd_global_lock);
 
                 if (cfs_time_aftereq(cfs_time_current(), deadline)) {
                         rc = -ETIMEDOUT;
@@ -1918,7 +1930,7 @@ ksocknal_connect (ksock_route_t *route)
                         CDEBUG(D_NET, "peer %s: conn race, retry later.\n",
                                libcfs_nid2str(peer->ksnp_id.nid));
 
-                cfs_write_lock_bh (&ksocknal_data.ksnd_global_lock);
+               write_lock_bh(&ksocknal_data.ksnd_global_lock);
         }
 
         route->ksnr_scheduled = 0;
@@ -1943,11 +1955,11 @@ ksocknal_connect (ksock_route_t *route)
                 ksocknal_launch_connection_locked(route);
         }
 
-        cfs_write_unlock_bh (&ksocknal_data.ksnd_global_lock);
+       write_unlock_bh(&ksocknal_data.ksnd_global_lock);
         return retry_later;
 
  failed:
-        cfs_write_lock_bh (&ksocknal_data.ksnd_global_lock);
+       write_lock_bh(&ksocknal_data.ksnd_global_lock);
 
         route->ksnr_scheduled = 0;
         route->ksnr_connecting = 0;
@@ -1990,27 +2002,124 @@ ksocknal_connect (ksock_route_t *route)
                 cfs_list_add_tail(&route->ksnr_list, &peer->ksnp_routes);
         }
 #endif
-        cfs_write_unlock_bh (&ksocknal_data.ksnd_global_lock);
+       write_unlock_bh(&ksocknal_data.ksnd_global_lock);
 
         ksocknal_peer_failed(peer);
         ksocknal_txlist_done(peer->ksnp_ni, &zombies, 1);
         return 0;
 }
 
-/* Go through connd_routes queue looking for a route that
-   we can process right now */
+/*
+ * check whether we need to create more connds.
+ * It will try to create new thread if it's necessary, @timeout can
+ * be updated if failed to create, so caller wouldn't keep try while
+ * running out of resource.
+ */
+static int
+ksocknal_connd_check_start(long sec, long *timeout)
+{
+       char name[16];
+        int rc;
+        int total = ksocknal_data.ksnd_connd_starting +
+                    ksocknal_data.ksnd_connd_running;
+
+        if (unlikely(ksocknal_data.ksnd_init < SOCKNAL_INIT_ALL)) {
+                /* still in initializing */
+                return 0;
+        }
+
+        if (total >= *ksocknal_tunables.ksnd_nconnds_max ||
+            total > ksocknal_data.ksnd_connd_connecting + SOCKNAL_CONND_RESV) {
+                /* can't create more connd, or still have enough
+                 * threads to handle more connecting */
+                return 0;
+        }
+
+        if (list_empty(&ksocknal_data.ksnd_connd_routes)) {
+                /* no pending connecting request */
+                return 0;
+        }
+
+        if (sec - ksocknal_data.ksnd_connd_failed_stamp <= 1) {
+                /* may run out of resource, retry later */
+                *timeout = cfs_time_seconds(1);
+                return 0;
+        }
+
+        if (ksocknal_data.ksnd_connd_starting > 0) {
+                /* serialize starting to avoid flood */
+                return 0;
+        }
+
+        ksocknal_data.ksnd_connd_starting_stamp = sec;
+        ksocknal_data.ksnd_connd_starting++;
+       spin_unlock_bh(&ksocknal_data.ksnd_connd_lock);
+
+       /* NB: total is the next id */
+       snprintf(name, sizeof(name), "socknal_cd%02d", total);
+       rc = ksocknal_thread_start(ksocknal_connd, NULL, name);
+
+       spin_lock_bh(&ksocknal_data.ksnd_connd_lock);
+        if (rc == 0)
+                return 1;
+
+        /* we tried ... */
+        LASSERT(ksocknal_data.ksnd_connd_starting > 0);
+        ksocknal_data.ksnd_connd_starting--;
+        ksocknal_data.ksnd_connd_failed_stamp = cfs_time_current_sec();
+
+        return 1;
+}
+
+/*
+ * check whether current thread can exit, it will return 1 if there are too
+ * many threads and no creating in past 120 seconds.
+ * Also, this function may update @timeout to make caller come back
+ * again to recheck these conditions.
+ */
+static int
+ksocknal_connd_check_stop(long sec, long *timeout)
+{
+        int val;
+
+        if (unlikely(ksocknal_data.ksnd_init < SOCKNAL_INIT_ALL)) {
+                /* still in initializing */
+                return 0;
+        }
+
+        if (ksocknal_data.ksnd_connd_starting > 0) {
+                /* in progress of starting new thread */
+                return 0;
+        }
+
+        if (ksocknal_data.ksnd_connd_running <=
+            *ksocknal_tunables.ksnd_nconnds) { /* can't shrink */
+                return 0;
+        }
+
+        /* created thread in past 120 seconds? */
+        val = (int)(ksocknal_data.ksnd_connd_starting_stamp +
+                    SOCKNAL_CONND_TIMEOUT - sec);
+
+        *timeout = (val > 0) ? cfs_time_seconds(val) :
+                               cfs_time_seconds(SOCKNAL_CONND_TIMEOUT);
+        if (val > 0)
+                return 0;
+
+        /* no creating in past 120 seconds */
+
+        return ksocknal_data.ksnd_connd_running >
+               ksocknal_data.ksnd_connd_connecting + SOCKNAL_CONND_RESV;
+}
+
+/* Go through connd_routes queue looking for a route that we can process
+ * right now, @timeout_p can be updated if we need to come back later */
 static ksock_route_t *
 ksocknal_connd_get_route_locked(signed long *timeout_p)
 {
         ksock_route_t *route;
         cfs_time_t     now;
 
-        /* Only handle an outgoing connection request if there
-         * is someone left to handle incoming connections */
-        if ((ksocknal_data.ksnd_connd_connecting + 1) >=
-            *ksocknal_tunables.ksnd_nconnds)
-                return NULL;
-
         now = cfs_time_current();
 
         /* connd_routes can contain both pending and ordinary routes */
@@ -2032,27 +2141,38 @@ ksocknal_connd_get_route_locked(signed long *timeout_p)
 int
 ksocknal_connd (void *arg)
 {
-        long               id = (long)(long_ptr_t)arg;
-        char               name[16];
+       spinlock_t    *connd_lock = &ksocknal_data.ksnd_connd_lock;
         ksock_connreq_t   *cr;
-        ksock_route_t     *route;
         cfs_waitlink_t     wait;
-        signed long        timeout;
         int                nloops = 0;
         int                cons_retry = 0;
-        int                dropped_lock;
 
-        snprintf (name, sizeof (name), "socknal_cd%02ld", id);
-        cfs_daemonize (name);
         cfs_block_allsigs ();
 
         cfs_waitlink_init (&wait);
 
-        cfs_spin_lock_bh (&ksocknal_data.ksnd_connd_lock);
+       spin_lock_bh(connd_lock);
+
+        LASSERT(ksocknal_data.ksnd_connd_starting > 0);
+        ksocknal_data.ksnd_connd_starting--;
+        ksocknal_data.ksnd_connd_running++;
 
         while (!ksocknal_data.ksnd_shuttingdown) {
+                ksock_route_t *route = NULL;
+                long sec = cfs_time_current_sec();
+                long timeout = CFS_MAX_SCHEDULE_TIMEOUT;
+                int  dropped_lock = 0;
+
+                if (ksocknal_connd_check_stop(sec, &timeout)) {
+                        /* wakeup another one to check stop */
+                        cfs_waitq_signal(&ksocknal_data.ksnd_connd_waitq);
+                        break;
+                }
 
-                dropped_lock = 0;
+                if (ksocknal_connd_check_start(sec, &timeout)) {
+                        /* created new thread */
+                        dropped_lock = 1;
+                }
 
                 if (!cfs_list_empty(&ksocknal_data.ksnd_connd_connreqs)) {
                         /* Connection accepted by the listener */
@@ -2060,27 +2180,28 @@ ksocknal_connd (void *arg)
                                             next, ksock_connreq_t, ksncr_list);
 
                         cfs_list_del(&cr->ksncr_list);
-                        cfs_spin_unlock_bh (&ksocknal_data.ksnd_connd_lock);
-                        dropped_lock = 1;
+                       spin_unlock_bh(connd_lock);
+                       dropped_lock = 1;
 
-                        ksocknal_create_conn(cr->ksncr_ni, NULL,
-                                             cr->ksncr_sock, SOCKLND_CONN_NONE);
-                        lnet_ni_decref(cr->ksncr_ni);
-                        LIBCFS_FREE(cr, sizeof(*cr));
+                       ksocknal_create_conn(cr->ksncr_ni, NULL,
+                                            cr->ksncr_sock, SOCKLND_CONN_NONE);
+                       lnet_ni_decref(cr->ksncr_ni);
+                       LIBCFS_FREE(cr, sizeof(*cr));
 
-                        cfs_spin_lock_bh (&ksocknal_data.ksnd_connd_lock);
+                       spin_lock_bh(connd_lock);
                 }
 
-                /* Sleep till explicit wake_up if no pending routes present */
-                timeout = CFS_MAX_SCHEDULE_TIMEOUT;
-
-                /* Connection request */
-                route = ksocknal_connd_get_route_locked(&timeout);
-
+                /* Only handle an outgoing connection request if there
+                 * is a thread left to handle incoming connections and
+                 * create new connd */
+                if (ksocknal_data.ksnd_connd_connecting + SOCKNAL_CONND_RESV <
+                    ksocknal_data.ksnd_connd_running) {
+                        route = ksocknal_connd_get_route_locked(&timeout);
+                }
                 if (route != NULL) {
                         cfs_list_del (&route->ksnr_connd_list);
                         ksocknal_data.ksnd_connd_connecting++;
-                        cfs_spin_unlock_bh (&ksocknal_data.ksnd_connd_lock);
+                       spin_unlock_bh(connd_lock);
                         dropped_lock = 1;
 
                         if (ksocknal_connect(route)) {
@@ -2097,38 +2218,37 @@ ksocknal_connd (void *arg)
 
                         ksocknal_route_decref(route);
 
-                        cfs_spin_lock_bh (&ksocknal_data.ksnd_connd_lock);
-                        ksocknal_data.ksnd_connd_connecting--;
-                }
-
-                if (dropped_lock) {
-                        if (++nloops < SOCKNAL_RESCHED)
-                                continue;
-                        cfs_spin_unlock_bh(&ksocknal_data.ksnd_connd_lock);
-                        nloops = 0;
-                        cfs_cond_resched();
-                        cfs_spin_lock_bh(&ksocknal_data.ksnd_connd_lock);
-                        continue;
-                }
-
-                /* Nothing to do for 'timeout'  */
-                cfs_set_current_state (CFS_TASK_INTERRUPTIBLE);
-                cfs_waitq_add_exclusive (&ksocknal_data.ksnd_connd_waitq,
-                                         &wait);
-                cfs_spin_unlock_bh (&ksocknal_data.ksnd_connd_lock);
-
-                nloops = 0;
-                cfs_waitq_timedwait (&wait, CFS_TASK_INTERRUPTIBLE, timeout);
-
-                cfs_set_current_state (CFS_TASK_RUNNING);
-                cfs_waitq_del (&ksocknal_data.ksnd_connd_waitq, &wait);
-                cfs_spin_lock_bh (&ksocknal_data.ksnd_connd_lock);
-        }
-
-        cfs_spin_unlock_bh (&ksocknal_data.ksnd_connd_lock);
-
-        ksocknal_thread_fini ();
-        return (0);
+                       spin_lock_bh(connd_lock);
+                       ksocknal_data.ksnd_connd_connecting--;
+               }
+
+               if (dropped_lock) {
+                       if (++nloops < SOCKNAL_RESCHED)
+                               continue;
+                       spin_unlock_bh(connd_lock);
+                       nloops = 0;
+                       cfs_cond_resched();
+                       spin_lock_bh(connd_lock);
+                       continue;
+               }
+
+               /* Nothing to do for 'timeout'  */
+               cfs_set_current_state(CFS_TASK_INTERRUPTIBLE);
+               cfs_waitq_add_exclusive(&ksocknal_data.ksnd_connd_waitq, &wait);
+               spin_unlock_bh(connd_lock);
+
+               nloops = 0;
+               cfs_waitq_timedwait(&wait, CFS_TASK_INTERRUPTIBLE, timeout);
+
+               cfs_set_current_state(CFS_TASK_RUNNING);
+               cfs_waitq_del(&ksocknal_data.ksnd_connd_waitq, &wait);
+               spin_lock_bh(connd_lock);
+       }
+       ksocknal_data.ksnd_connd_running--;
+       spin_unlock_bh(connd_lock);
+
+       ksocknal_thread_fini();
+       return 0;
 }
 
 ksock_conn_t *
@@ -2153,28 +2273,28 @@ ksocknal_find_timed_out_conn (ksock_peer_t *peer)
 
                         switch (error) {
                         case ECONNRESET:
-                                CDEBUG(D_NETERROR, "A connection with %s "
-                                       "(%u.%u.%u.%u:%d) was reset; "
-                                       "it may have rebooted.\n",
-                                       libcfs_id2str(peer->ksnp_id),
-                                       HIPQUAD(conn->ksnc_ipaddr),
-                                       conn->ksnc_port);
+                                CNETERR("A connection with %s "
+                                        "(%u.%u.%u.%u:%d) was reset; "
+                                        "it may have rebooted.\n",
+                                        libcfs_id2str(peer->ksnp_id),
+                                        HIPQUAD(conn->ksnc_ipaddr),
+                                        conn->ksnc_port);
                                 break;
                         case ETIMEDOUT:
-                                CDEBUG(D_NETERROR, "A connection with %s "
-                                       "(%u.%u.%u.%u:%d) timed out; the "
-                                       "network or node may be down.\n",
-                                       libcfs_id2str(peer->ksnp_id),
-                                       HIPQUAD(conn->ksnc_ipaddr),
-                                       conn->ksnc_port);
+                                CNETERR("A connection with %s "
+                                        "(%u.%u.%u.%u:%d) timed out; the "
+                                        "network or node may be down.\n",
+                                        libcfs_id2str(peer->ksnp_id),
+                                        HIPQUAD(conn->ksnc_ipaddr),
+                                        conn->ksnc_port);
                                 break;
                         default:
-                                CDEBUG(D_NETERROR, "An unexpected network error %d "
-                                       "occurred with %s "
-                                       "(%u.%u.%u.%u:%d\n", error,
-                                       libcfs_id2str(peer->ksnp_id),
-                                       HIPQUAD(conn->ksnc_ipaddr),
-                                       conn->ksnc_port);
+                                CNETERR("An unexpected network error %d "
+                                        "occurred with %s "
+                                        "(%u.%u.%u.%u:%d\n", error,
+                                        libcfs_id2str(peer->ksnp_id),
+                                        HIPQUAD(conn->ksnc_ipaddr),
+                                        conn->ksnc_port);
                                 break;
                         }
 
@@ -2186,14 +2306,14 @@ ksocknal_find_timed_out_conn (ksock_peer_t *peer)
                                      conn->ksnc_rx_deadline)) {
                         /* Timed out incomplete incoming message */
                         ksocknal_conn_addref(conn);
-                        CDEBUG(D_NETERROR, "Timeout receiving from %s "
-                               "(%u.%u.%u.%u:%d), state %d wanted %d left %d\n",
-                               libcfs_id2str(peer->ksnp_id),
-                               HIPQUAD(conn->ksnc_ipaddr),
-                               conn->ksnc_port,
-                               conn->ksnc_rx_state,
-                               conn->ksnc_rx_nob_wanted,
-                               conn->ksnc_rx_nob_left);
+                        CNETERR("Timeout receiving from %s (%u.%u.%u.%u:%d), "
+                                "state %d wanted %d left %d\n",
+                                libcfs_id2str(peer->ksnp_id),
+                                HIPQUAD(conn->ksnc_ipaddr),
+                                conn->ksnc_port,
+                                conn->ksnc_rx_state,
+                                conn->ksnc_rx_nob_wanted,
+                                conn->ksnc_rx_nob_left);
                         return (conn);
                 }
 
@@ -2204,12 +2324,11 @@ ksocknal_find_timed_out_conn (ksock_peer_t *peer)
                         /* Timed out messages queued for sending or
                          * buffered in the socket's send buffer */
                         ksocknal_conn_addref(conn);
-                        CDEBUG(D_NETERROR, "Timeout sending data to %s "
-                               "(%u.%u.%u.%u:%d) the network or that "
-                               "node may be down.\n",
-                               libcfs_id2str(peer->ksnp_id),
-                               HIPQUAD(conn->ksnc_ipaddr),
-                               conn->ksnc_port);
+                        CNETERR("Timeout sending data to %s (%u.%u.%u.%u:%d) "
+                                "the network or that node may be down.\n",
+                                libcfs_id2str(peer->ksnp_id),
+                                HIPQUAD(conn->ksnc_ipaddr),
+                                conn->ksnc_port);
                         return (conn);
                 }
         }
@@ -2223,7 +2342,7 @@ ksocknal_flush_stale_txs(ksock_peer_t *peer)
         ksock_tx_t        *tx;
         CFS_LIST_HEAD      (stale_txs);
 
-        cfs_write_lock_bh (&ksocknal_data.ksnd_global_lock);
+       write_lock_bh(&ksocknal_data.ksnd_global_lock);
 
         while (!cfs_list_empty (&peer->ksnp_tx_queue)) {
                 tx = cfs_list_entry (peer->ksnp_tx_queue.next,
@@ -2237,7 +2356,7 @@ ksocknal_flush_stale_txs(ksock_peer_t *peer)
                 cfs_list_add_tail (&tx->tx_list, &stale_txs);
         }
 
-        cfs_write_unlock_bh (&ksocknal_data.ksnd_global_lock);
+       write_unlock_bh(&ksocknal_data.ksnd_global_lock);
 
         ksocknal_txlist_done(peer->ksnp_ni, &stale_txs, 1);
 }
@@ -2273,34 +2392,34 @@ ksocknal_send_keepalive_locked(ksock_peer_t *peer)
         if (conn != NULL) {
                 sched = conn->ksnc_scheduler;
 
-                cfs_spin_lock_bh (&sched->kss_lock);
-                if (!cfs_list_empty(&conn->ksnc_tx_queue)) {
-                        cfs_spin_unlock_bh(&sched->kss_lock);
-                        /* there is an queued ACK, don't need keepalive */
-                        return 0;
-                }
+               spin_lock_bh(&sched->kss_lock);
+               if (!cfs_list_empty(&conn->ksnc_tx_queue)) {
+                       spin_unlock_bh(&sched->kss_lock);
+                       /* there is an queued ACK, don't need keepalive */
+                       return 0;
+               }
 
-                cfs_spin_unlock_bh(&sched->kss_lock);
-        }
+               spin_unlock_bh(&sched->kss_lock);
+       }
 
-        cfs_read_unlock(&ksocknal_data.ksnd_global_lock);
+       read_unlock(&ksocknal_data.ksnd_global_lock);
 
-        /* cookie = 1 is reserved for keepalive PING */
-        tx = ksocknal_alloc_tx_noop(1, 1);
-        if (tx == NULL) {
-                cfs_read_lock(&ksocknal_data.ksnd_global_lock);
-                return -ENOMEM;
-        }
+       /* cookie = 1 is reserved for keepalive PING */
+       tx = ksocknal_alloc_tx_noop(1, 1);
+       if (tx == NULL) {
+               read_lock(&ksocknal_data.ksnd_global_lock);
+               return -ENOMEM;
+       }
 
-        if (ksocknal_launch_packet(peer->ksnp_ni, tx, peer->ksnp_id) == 0) {
-                cfs_read_lock(&ksocknal_data.ksnd_global_lock);
-                return 1;
-        }
+       if (ksocknal_launch_packet(peer->ksnp_ni, tx, peer->ksnp_id) == 0) {
+               read_lock(&ksocknal_data.ksnd_global_lock);
+               return 1;
+       }
 
-        ksocknal_free_tx(tx);
-        cfs_read_lock(&ksocknal_data.ksnd_global_lock);
+       ksocknal_free_tx(tx);
+       read_lock(&ksocknal_data.ksnd_global_lock);
 
-        return -EIO;
+       return -EIO;
 }
 
 
@@ -2316,7 +2435,7 @@ ksocknal_check_peer_timeouts (int idx)
         /* NB. We expect to have a look at all the peers and not find any
          * connections to time out, so we just use a shared lock while we
          * take a look... */
-        cfs_read_lock (&ksocknal_data.ksnd_global_lock);
+       read_lock(&ksocknal_data.ksnd_global_lock);
 
         cfs_list_for_each_entry_typed(peer, peers, ksock_peer_t, ksnp_list) {
                 cfs_time_t  deadline = 0;
@@ -2324,14 +2443,14 @@ ksocknal_check_peer_timeouts (int idx)
                 int         n     = 0;
 
                 if (ksocknal_send_keepalive_locked(peer) != 0) {
-                        cfs_read_unlock (&ksocknal_data.ksnd_global_lock);
+                       read_unlock(&ksocknal_data.ksnd_global_lock);
                         goto again;
                 }
 
                 conn = ksocknal_find_timed_out_conn (peer);
 
                 if (conn != NULL) {
-                        cfs_read_unlock (&ksocknal_data.ksnd_global_lock);
+                       read_unlock(&ksocknal_data.ksnd_global_lock);
 
                         ksocknal_close_conn_and_siblings (conn, -ETIMEDOUT);
 
@@ -2353,7 +2472,7 @@ ksocknal_check_peer_timeouts (int idx)
                                              tx->tx_deadline)) {
 
                                 ksocknal_peer_addref(peer);
-                                cfs_read_unlock (&ksocknal_data.ksnd_global_lock);
+                               read_unlock(&ksocknal_data.ksnd_global_lock);
 
                                 ksocknal_flush_stale_txs(peer);
 
@@ -2365,7 +2484,7 @@ ksocknal_check_peer_timeouts (int idx)
                 if (cfs_list_empty(&peer->ksnp_zc_req_list))
                         continue;
 
-                cfs_spin_lock(&peer->ksnp_lock);
+               spin_lock(&peer->ksnp_lock);
                 cfs_list_for_each_entry_typed(tx, &peer->ksnp_zc_req_list,
                                               ksock_tx_t, tx_zc_list) {
                         if (!cfs_time_aftereq(cfs_time_current(),
@@ -2378,7 +2497,7 @@ ksocknal_check_peer_timeouts (int idx)
                 }
 
                 if (n == 0) {
-                        cfs_spin_unlock(&peer->ksnp_lock);
+                       spin_unlock(&peer->ksnp_lock);
                         continue;
                 }
 
@@ -2389,8 +2508,8 @@ ksocknal_check_peer_timeouts (int idx)
                 conn     = tx->tx_conn;
                 ksocknal_conn_addref(conn);
 
-                cfs_spin_unlock(&peer->ksnp_lock);
-                cfs_read_unlock (&ksocknal_data.ksnd_global_lock);
+               spin_unlock(&peer->ksnp_lock);
+               read_unlock(&ksocknal_data.ksnd_global_lock);
 
                 CERROR("Total %d stale ZC_REQs for peer %s detected; the "
                        "oldest(%p) timed out %ld secs ago, "
@@ -2404,7 +2523,7 @@ ksocknal_check_peer_timeouts (int idx)
                 goto again;
         }
 
-        cfs_read_unlock (&ksocknal_data.ksnd_global_lock);
+       read_unlock(&ksocknal_data.ksnd_global_lock);
 }
 
 int
@@ -2420,13 +2539,12 @@ ksocknal_reaper (void *arg)
         int                peer_index = 0;
         cfs_time_t         deadline = cfs_time_current();
 
-        cfs_daemonize ("socknal_reaper");
         cfs_block_allsigs ();
 
         CFS_INIT_LIST_HEAD(&enomem_conns);
         cfs_waitlink_init (&wait);
 
-        cfs_spin_lock_bh (&ksocknal_data.ksnd_reaper_lock);
+       spin_lock_bh(&ksocknal_data.ksnd_reaper_lock);
 
         while (!ksocknal_data.ksnd_shuttingdown) {
 
@@ -2436,12 +2554,12 @@ ksocknal_reaper (void *arg)
                                                ksock_conn_t, ksnc_list);
                         cfs_list_del (&conn->ksnc_list);
 
-                        cfs_spin_unlock_bh (&ksocknal_data.ksnd_reaper_lock);
+                       spin_unlock_bh(&ksocknal_data.ksnd_reaper_lock);
 
-                        ksocknal_terminate_conn (conn);
-                        ksocknal_conn_decref(conn);
+                       ksocknal_terminate_conn(conn);
+                       ksocknal_conn_decref(conn);
 
-                        cfs_spin_lock_bh (&ksocknal_data.ksnd_reaper_lock);
+                       spin_lock_bh(&ksocknal_data.ksnd_reaper_lock);
                         continue;
                 }
 
@@ -2450,11 +2568,11 @@ ksocknal_reaper (void *arg)
                                                next, ksock_conn_t, ksnc_list);
                         cfs_list_del (&conn->ksnc_list);
 
-                        cfs_spin_unlock_bh (&ksocknal_data.ksnd_reaper_lock);
+                       spin_unlock_bh(&ksocknal_data.ksnd_reaper_lock);
 
-                        ksocknal_destroy_conn (conn);
+                       ksocknal_destroy_conn(conn);
 
-                        cfs_spin_lock_bh (&ksocknal_data.ksnd_reaper_lock);
+                       spin_lock_bh(&ksocknal_data.ksnd_reaper_lock);
                         continue;
                 }
 
@@ -2464,7 +2582,7 @@ ksocknal_reaper (void *arg)
                         cfs_list_del_init(&ksocknal_data.ksnd_enomem_conns);
                 }
 
-                cfs_spin_unlock_bh (&ksocknal_data.ksnd_reaper_lock);
+               spin_unlock_bh(&ksocknal_data.ksnd_reaper_lock);
 
                 /* reschedule all the connections that stalled with ENOMEM... */
                 nenomem_conns = 0;
@@ -2475,15 +2593,15 @@ ksocknal_reaper (void *arg)
 
                         sched = conn->ksnc_scheduler;
 
-                        cfs_spin_lock_bh (&sched->kss_lock);
+                       spin_lock_bh(&sched->kss_lock);
 
-                        LASSERT (conn->ksnc_tx_scheduled);
-                        conn->ksnc_tx_ready = 1;
-                        cfs_list_add_tail(&conn->ksnc_tx_list,
-                                          &sched->kss_tx_conns);
-                        cfs_waitq_signal (&sched->kss_waitq);
+                       LASSERT(conn->ksnc_tx_scheduled);
+                       conn->ksnc_tx_ready = 1;
+                       cfs_list_add_tail(&conn->ksnc_tx_list,
+                                         &sched->kss_tx_conns);
+                       cfs_waitq_signal(&sched->kss_waitq);
 
-                        cfs_spin_unlock_bh (&sched->kss_lock);
+                       spin_unlock_bh(&sched->kss_lock);
                         nenomem_conns++;
                 }
 
@@ -2537,11 +2655,11 @@ ksocknal_reaper (void *arg)
                 cfs_set_current_state (CFS_TASK_RUNNING);
                 cfs_waitq_del (&ksocknal_data.ksnd_reaper_waitq, &wait);
 
-                cfs_spin_lock_bh (&ksocknal_data.ksnd_reaper_lock);
-        }
+               spin_lock_bh(&ksocknal_data.ksnd_reaper_lock);
+       }
 
-        cfs_spin_unlock_bh (&ksocknal_data.ksnd_reaper_lock);
+       spin_unlock_bh(&ksocknal_data.ksnd_reaper_lock);
 
-        ksocknal_thread_fini ();
-        return (0);
+       ksocknal_thread_fini();
+       return 0;
 }