Whamcloud - gitweb
LU-14392 gnilnd: re-enable large I/o buffers
[fs/lustre-release.git] / lnet / klnds / gnilnd / gnilnd.c
index cf1b263..857dc20 100644 (file)
@@ -25,7 +25,7 @@
 #include "gnilnd.h"
 
 /* Primary entry points from LNET.  There are no guarantees against reentrance. */
-struct lnet_lnd the_kgnilnd = {
+const struct lnet_lnd the_kgnilnd = {
        .lnd_type       = GNILND,
        .lnd_startup    = kgnilnd_startup,
        .lnd_shutdown   = kgnilnd_shutdown,
@@ -33,7 +33,6 @@ struct lnet_lnd the_kgnilnd = {
        .lnd_send       = kgnilnd_send,
        .lnd_recv       = kgnilnd_recv,
        .lnd_eager_recv = kgnilnd_eager_recv,
-       .lnd_query      = kgnilnd_query,
 };
 
 kgn_data_t      kgnilnd_data;
@@ -88,16 +87,14 @@ kgnilnd_start_sd_threads(void)
 int
 kgnilnd_close_stale_conns_locked(kgn_peer_t *peer, kgn_conn_t *newconn)
 {
-       kgn_conn_t         *conn;
-       struct list_head   *ctmp, *cnxt;
+       kgn_conn_t *conn, *cnxt;
        int                 loopback;
        int                 count = 0;
 
-       loopback = peer->gnp_nid == peer->gnp_net->gnn_ni->ni_nid;
-
-       list_for_each_safe(ctmp, cnxt, &peer->gnp_conns) {
-               conn = list_entry(ctmp, kgn_conn_t, gnc_list);
+       loopback = (peer->gnp_nid ==
+                   lnet_nid_to_nid4(&peer->gnp_net->gnn_ni->ni_nid));
 
+       list_for_each_entry_safe(conn, cnxt, &peer->gnp_conns, gnc_list) {
                if (conn->gnc_state != GNILND_CONN_ESTABLISHED)
                        continue;
 
@@ -162,14 +159,13 @@ int
 kgnilnd_conn_isdup_locked(kgn_peer_t *peer, kgn_conn_t *newconn)
 {
        kgn_conn_t       *conn;
-       struct list_head *tmp;
        int               loopback;
        ENTRY;
 
-       loopback = peer->gnp_nid == peer->gnp_net->gnn_ni->ni_nid;
+       loopback = (peer->gnp_nid ==
+                   lnet_nid_to_nid4(&peer->gnp_net->gnn_ni->ni_nid));
 
-       list_for_each(tmp, &peer->gnp_conns) {
-               conn = list_entry(tmp, kgn_conn_t, gnc_list);
+       list_for_each_entry(conn, &peer->gnp_conns, gnc_list) {
                CDEBUG(D_NET, "checking conn 0x%p for peer %s"
                        " lo %d new %llu existing %llu"
                        " new peer %llu existing peer %llu"
@@ -272,7 +268,7 @@ kgnilnd_create_conn(kgn_conn_t **connp, kgn_device_t *dev)
        conn->gnc_next_tx = (int) GNILND_MAX_MSG_ID - 10;
 
        /* if this fails, we have conflicts and MAX_TX is too large */
-       CLASSERT(GNILND_MAX_MSG_ID < GNILND_MSGID_CLOSE);
+       BUILD_BUG_ON(GNILND_MAX_MSG_ID >= GNILND_MSGID_CLOSE);
 
        /* get a new unique CQ id for this conn */
        write_lock(&kgnilnd_data.kgn_peer_conn_lock);
@@ -292,8 +288,8 @@ kgnilnd_create_conn(kgn_conn_t **connp, kgn_device_t *dev)
         * check context */
        conn->gnc_device = dev;
 
-       conn->gnc_timeout = MAX(*kgnilnd_tunables.kgn_timeout,
-                               GNILND_MIN_TIMEOUT);
+       conn->gnc_timeout = max(*kgnilnd_tunables.kgn_timeout,
+                                GNILND_MIN_TIMEOUT);
        kgnilnd_update_reaper_timeout(conn->gnc_timeout);
 
        /* this is the ep_handle for doing SMSG & BTE */
@@ -561,7 +557,7 @@ kgnilnd_peer_notify(kgn_peer_t *peer, int error, int alive)
             */
 
                for (i = 0; i < *kgnilnd_tunables.kgn_net_hash_size; i++) {
-                       list_for_each_entry(net , &kgnilnd_data.kgn_nets[i], gnn_list) {
+                       list_for_each_entry(net, &kgnilnd_data.kgn_nets[i], gnn_list) {
                                /* if gnn_shutdown set for any net shutdown is in progress just return */
                                if (net->gnn_shutdown) {
                                        up_read(&kgnilnd_data.kgn_net_rw_sem);
@@ -577,7 +573,7 @@ kgnilnd_peer_notify(kgn_peer_t *peer, int error, int alive)
                        return;
                }
 
-               LIBCFS_ALLOC(nets, nnets * sizeof(*nets));
+               CFS_ALLOC_PTR_ARRAY(nets, nnets);
 
                if (nets == NULL) {
                        up_read(&kgnilnd_data.kgn_net_rw_sem);
@@ -600,21 +596,21 @@ kgnilnd_peer_notify(kgn_peer_t *peer, int error, int alive)
 
                        net = nets[i];
 
-                       peer_nid = kgnilnd_lnd2lnetnid(net->gnn_ni->ni_nid,
-                                                                peer->gnp_nid);
+                       peer_nid = kgnilnd_lnd2lnetnid(
+                               lnet_nid_to_nid4(&net->gnn_ni->ni_nid),
+                               peer->gnp_nid);
 
                        CDEBUG(D_NET, "peer 0x%p->%s last_alive %lld (%llds ago)\n",
                                peer, libcfs_nid2str(peer_nid), peer->gnp_last_alive,
                                ktime_get_seconds() - peer->gnp_last_alive);
 
-                       lnet_notify(net->gnn_ni, peer_nid, alive,
-                                   (alive) ? true : false,
+                       lnet_notify(net->gnn_ni, peer_nid, alive, true,
                                    peer->gnp_last_alive);
 
                        kgnilnd_net_decref(net);
                }
 
-               LIBCFS_FREE(nets, nnets * sizeof(*nets));
+               CFS_FREE_PTR_ARRAY(nets, nnets);
        }
 }
 
@@ -880,7 +876,7 @@ kgnilnd_set_conn_params(kgn_dgram_t *dgram)
        /* set timeout vals in conn early so we can use them for the NAK */
 
        /* use max of the requested and our timeout, peer will do the same */
-       conn->gnc_timeout = MAX(conn->gnc_timeout, connreq->gncr_timeout);
+       conn->gnc_timeout = max(conn->gnc_timeout, connreq->gncr_timeout);
 
        /* only ep_bind really mucks around with the CQ */
        /* only ep bind if we are not connecting to ourself and the dstnid is not a wildcard. this check
@@ -1262,8 +1258,8 @@ kgnilnd_peer_increase_reconnect_locked(kgn_peer_t *peer)
                current_to += *kgnilnd_tunables.kgn_min_reconnect_interval / 2;
        }
 
-       current_to = MIN(current_to,
-                               *kgnilnd_tunables.kgn_max_reconnect_interval);
+       current_to = min(current_to,
+                        *kgnilnd_tunables.kgn_max_reconnect_interval);
 
        peer->gnp_reconnect_interval = current_to;
        CDEBUG(D_NET, "peer %s can reconnect at %lu interval %lu\n",
@@ -1324,7 +1320,6 @@ kgnilnd_get_peer_info(int index,
                      lnet_nid_t *id, __u32 *nic_addr,
                      int *refcount, int *connecting)
 {
-       struct list_head  *ptmp;
        kgn_peer_t        *peer;
        int               i;
        int               rc = -ENOENT;
@@ -1332,10 +1327,7 @@ kgnilnd_get_peer_info(int index,
        read_lock(&kgnilnd_data.kgn_peer_conn_lock);
 
        for (i = 0; i < *kgnilnd_tunables.kgn_peer_hash_size; i++) {
-
-               list_for_each(ptmp, &kgnilnd_data.kgn_peers[i]) {
-                       peer = list_entry(ptmp, kgn_peer_t, gnp_list);
-
+               list_for_each_entry(peer, &kgnilnd_data.kgn_peers[i], gnp_list) {
                        if (index-- > 0)
                                continue;
 
@@ -1511,8 +1503,7 @@ kgnilnd_del_conn_or_peer(kgn_net_t *net, lnet_nid_t nid, int command,
 {
        LIST_HEAD               (souls);
        LIST_HEAD               (zombies);
-       struct list_head        *ptmp, *pnxt;
-       kgn_peer_t              *peer;
+       kgn_peer_t *peer, *pnxt;
        int                     lo;
        int                     hi;
        int                     i;
@@ -1530,9 +1521,8 @@ kgnilnd_del_conn_or_peer(kgn_net_t *net, lnet_nid_t nid, int command,
        }
 
        for (i = lo; i <= hi; i++) {
-               list_for_each_safe(ptmp, pnxt, &kgnilnd_data.kgn_peers[i]) {
-                       peer = list_entry(ptmp, kgn_peer_t, gnp_list);
-
+               list_for_each_entry_safe(peer, pnxt, &kgnilnd_data.kgn_peers[i],
+                                        gnp_list) {
                        LASSERTF(peer->gnp_net != NULL,
                                "peer %p (%s) with NULL net\n",
                                 peer, libcfs_nid2str(peer->gnp_nid));
@@ -1594,20 +1584,14 @@ kgnilnd_del_conn_or_peer(kgn_net_t *net, lnet_nid_t nid, int command,
                return rc;
        }
 
-       i = 4;
-       while (atomic_read(&kgnilnd_data.kgn_npending_conns)   ||
-              atomic_read(&kgnilnd_data.kgn_npending_detach)  ||
-              atomic_read(&kgnilnd_data.kgn_npending_unlink)) {
-
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(cfs_time_seconds(1));
-               i++;
-
-               CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET, "Waiting on %d peers %d closes %d detaches\n",
+       wait_var_event_warning(&kgnilnd_data,
+                              !atomic_read(&kgnilnd_data.kgn_npending_conns) &&
+                              !atomic_read(&kgnilnd_data.kgn_npending_detach) &&
+                              !atomic_read(&kgnilnd_data.kgn_npending_unlink),
+                              "Waiting on %d peers %d closes %d detaches\n",
                                atomic_read(&kgnilnd_data.kgn_npending_unlink),
                                atomic_read(&kgnilnd_data.kgn_npending_conns),
                                atomic_read(&kgnilnd_data.kgn_npending_detach));
-       }
 
        return rc;
 }
@@ -1616,21 +1600,14 @@ kgn_conn_t *
 kgnilnd_get_conn_by_idx(int index)
 {
        kgn_peer_t        *peer;
-       struct list_head  *ptmp;
        kgn_conn_t        *conn;
-       struct list_head  *ctmp;
        int                i;
 
 
        for (i = 0; i < *kgnilnd_tunables.kgn_peer_hash_size; i++) {
                read_lock(&kgnilnd_data.kgn_peer_conn_lock);
-               list_for_each(ptmp, &kgnilnd_data.kgn_peers[i]) {
-
-                       peer = list_entry(ptmp, kgn_peer_t, gnp_list);
-
-                       list_for_each(ctmp, &peer->gnp_conns) {
-                               conn = list_entry(ctmp, kgn_conn_t, gnc_list);
-
+               list_for_each_entry(peer, &kgnilnd_data.kgn_peers[i], gnp_list) {
+                       list_for_each_entry(conn, &peer->gnp_conns, gnc_list) {
                                if (conn->gnc_state != GNILND_CONN_ESTABLISHED)
                                        continue;
 
@@ -1752,7 +1729,7 @@ kgnilnd_report_node_state(lnet_nid_t nid, int down)
                /* The nid passed in does not yet contain the net portion.
                 * Let's build it up now
                 */
-               nid = LNET_MKNID(LNET_NIDNET(net->gnn_ni->ni_nid), nid);
+               nid = LNET_MKNID(LNET_NID_NET(&net->gnn_ni->ni_nid), nid);
                rc = kgnilnd_add_peer(net, nid, &new_peer);
 
                if (rc) {
@@ -1833,7 +1810,8 @@ kgnilnd_ctl(struct lnet_ni *ni, unsigned int cmd, void *arg)
                 * LNET assumes a conn and peer per net, the LNET_MKNID/LNET_NIDADDR allows us to let Lnet see what it
                 * wants to see instead of the underlying network that is being used to send the data
                 */
-               data->ioc_nid    = LNET_MKNID(LNET_NIDNET(ni->ni_nid), LNET_NIDADDR(nid));
+               data->ioc_nid    = LNET_MKNID(LNET_NID_NET(&ni->ni_nid),
+                                             LNET_NIDADDR(nid));
                data->ioc_flags  = peer_connecting;
                data->ioc_count  = peer_refcount;
 
@@ -1884,7 +1862,8 @@ kgnilnd_ctl(struct lnet_ni *ni, unsigned int cmd, void *arg)
                        /* LNET_MKNID is used to build the correct address based on what LNET wants to see instead of
                         * the generic connection that is used to send the data
                         */
-                       data->ioc_nid    = LNET_MKNID(LNET_NIDNET(ni->ni_nid), LNET_NIDADDR(conn->gnc_peer->gnp_nid));
+                       data->ioc_nid    = LNET_MKNID(LNET_NID_NET(&ni->ni_nid),
+                                                     LNET_NIDADDR(conn->gnc_peer->gnp_nid));
                        data->ioc_u32[0] = conn->gnc_device->gnd_id;
                        kgnilnd_conn_decref(conn);
                }
@@ -1907,12 +1886,12 @@ kgnilnd_ctl(struct lnet_ni *ni, unsigned int cmd, void *arg)
        }
        case IOC_LIBCFS_REGISTER_MYNID: {
                /* Ignore if this is a noop */
-               if (data->ioc_nid == ni->ni_nid) {
+               if (data->ioc_nid == lnet_nid_to_nid4(&ni->ni_nid)) {
                        rc = 0;
                } else {
                        CERROR("obsolete IOC_LIBCFS_REGISTER_MYNID: %s(%s)\n",
                               libcfs_nid2str(data->ioc_nid),
-                              libcfs_nid2str(ni->ni_nid));
+                              libcfs_nidstr(&ni->ni_nid));
                        rc = -EINVAL;
                }
                break;
@@ -1922,77 +1901,6 @@ kgnilnd_ctl(struct lnet_ni *ni, unsigned int cmd, void *arg)
        return rc;
 }
 
-void
-kgnilnd_query(struct lnet_ni *ni, lnet_nid_t nid, time64_t *when)
-{
-       kgn_net_t               *net = ni->ni_data;
-       kgn_tx_t                *tx;
-       kgn_peer_t              *peer = NULL;
-       kgn_conn_t              *conn = NULL;
-       struct lnet_process_id       id = {
-               .nid = nid,
-               .pid = LNET_PID_LUSTRE,
-       };
-       ENTRY;
-
-       /* I expect to find him, so only take a read lock */
-       read_lock(&kgnilnd_data.kgn_peer_conn_lock);
-       peer = kgnilnd_find_peer_locked(nid);
-       if (peer != NULL) {
-               /* LIE if in a quiesce - we will update the timeouts after,
-                * but we don't want sends failing during it */
-               if (kgnilnd_data.kgn_quiesce_trigger) {
-                       *when = ktime_get_seconds();
-                       read_unlock(&kgnilnd_data.kgn_peer_conn_lock);
-                       GOTO(out, 0);
-               }
-
-               /* Update to best guess, might refine on later checks */
-               *when = peer->gnp_last_alive;
-
-               /* we have a peer, how about a conn? */
-               conn = kgnilnd_find_conn_locked(peer);
-
-               if (conn == NULL)  {
-                       /* if there is no conn, check peer last errno to see if clean disconnect
-                        * - if it was, we lie to LNet because we believe a TX would complete
-                        * on reconnect */
-                       if (kgnilnd_conn_clean_errno(peer->gnp_last_errno)) {
-                               *when = ktime_get_seconds();
-                       }
-                       /* we still want to fire a TX and new conn in this case */
-               } else {
-                       /* gnp_last_alive is valid, run for the hills */
-                       read_unlock(&kgnilnd_data.kgn_peer_conn_lock);
-                       GOTO(out, 0);
-               }
-       }
-       /* if we get here, either we have no peer or no conn for him, so fire off
-        * new TX to trigger conn setup */
-       read_unlock(&kgnilnd_data.kgn_peer_conn_lock);
-
-       /* if we couldn't find him, we'll fire up a TX and get connected -
-        * if we don't do this, after ni_peer_timeout, LNet will declare him dead.
-        * So really we treat kgnilnd_query as a bit of a 'connect now' type
-        * event because it'll only do this when it wants to send
-        *
-        * Use a real TX for this to get the proper gnp_tx_queue behavior, etc
-        * normally we'd use kgnilnd_send_ctlmsg for this, but we don't really
-        * care that this goes out quickly since we already know we need a new conn
-        * formed */
-       if (CFS_FAIL_CHECK(CFS_FAIL_GNI_NOOP_SEND))
-               return;
-
-       tx = kgnilnd_new_tx_msg(GNILND_MSG_NOOP, ni->ni_nid);
-       if (tx != NULL) {
-               kgnilnd_launch_tx(tx, net, &id);
-       }
-out:
-       CDEBUG(D_NETTRACE, "peer 0x%p->%s when %lld\n", peer,
-              libcfs_nid2str(nid), *when);
-       EXIT;
-}
-
 int
 kgnilnd_dev_init(kgn_device_t *dev)
 {
@@ -2129,16 +2037,13 @@ kgnilnd_dev_fini(kgn_device_t *dev)
                "%d physical mappings of %d pages still mapped\n",
                 dev->gnd_map_nphys, dev->gnd_map_physnop);
 
-       LASSERTF(dev->gnd_map_nvirt == 0 && dev->gnd_map_virtnob == 0,
-               "%d virtual mappings of %llu bytes still mapped\n",
-                dev->gnd_map_nvirt, dev->gnd_map_virtnob);
-
        LASSERTF(atomic_read(&dev->gnd_n_mdd) == 0 &&
                 atomic_read(&dev->gnd_n_mdd_held) == 0 &&
                 atomic64_read(&dev->gnd_nbytes_map) == 0,
-               "%d SMSG mappings of %ld bytes still mapped or held %d\n",
+                "%d SMSG mappings of %lld bytes still mapped or held %d\n",
                 atomic_read(&dev->gnd_n_mdd),
-                atomic64_read(&dev->gnd_nbytes_map), atomic_read(&dev->gnd_n_mdd_held));
+                (u64)atomic64_read(&dev->gnd_nbytes_map),
+                atomic_read(&dev->gnd_n_mdd_held));
 
        LASSERT(list_empty(&dev->gnd_map_list));
 
@@ -2199,8 +2104,7 @@ kgnilnd_dev_fini(kgn_device_t *dev)
 
 int kgnilnd_base_startup(void)
 {
-       struct timeval       tv;
-       int                  pkmem = atomic_read(&libcfs_kmemory);
+       long long            pkmem = libcfs_kmem_read();
        int                  rc;
        int                  i;
        kgn_device_t        *dev;
@@ -2229,10 +2133,9 @@ int kgnilnd_base_startup(void)
         * initialised with seconds + microseconds at startup time.  So we
         * rely on NOT creating connections more frequently on average than
         * 1MHz to ensure we don't use old connstamps when we reboot. */
-       do_gettimeofday(&tv);
        kgnilnd_data.kgn_connstamp =
                 kgnilnd_data.kgn_peerstamp =
-                       (((__u64)tv.tv_sec) * 1000000) + tv.tv_usec;
+                       ktime_get_seconds();
 
        init_rwsem(&kgnilnd_data.kgn_net_rw_sem);
 
@@ -2265,8 +2168,8 @@ int kgnilnd_base_startup(void)
                init_rwsem(&dev->gnd_conn_sem);
 
                /* alloc & setup nid based dgram table */
-               LIBCFS_ALLOC(dev->gnd_dgrams,
-                           sizeof(struct list_head) * *kgnilnd_tunables.kgn_peer_hash_size);
+               CFS_ALLOC_PTR_ARRAY(dev->gnd_dgrams,
+                                   *kgnilnd_tunables.kgn_peer_hash_size);
 
                if (dev->gnd_dgrams == NULL)
                        GOTO(failed, rc = -ENOMEM);
@@ -2277,12 +2180,14 @@ int kgnilnd_base_startup(void)
                atomic_set(&dev->gnd_ndgrams, 0);
                atomic_set(&dev->gnd_nwcdgrams, 0);
                /* setup timer for RDMAQ processing */
-               setup_timer(&dev->gnd_rdmaq_timer, kgnilnd_schedule_device_timer,
-                           (unsigned long)dev);
+               cfs_timer_setup(&dev->gnd_rdmaq_timer,
+                               kgnilnd_schedule_device_timer,
+                               (unsigned long)dev, 0);
 
                /* setup timer for mapping processing */
-               setup_timer(&dev->gnd_map_timer, kgnilnd_schedule_device_timer,
-                           (unsigned long)dev);
+               cfs_timer_setup(&dev->gnd_map_timer,
+                               kgnilnd_schedule_device_timer,
+                               (unsigned long)dev, 0);
 
        }
 
@@ -2304,12 +2209,13 @@ int kgnilnd_base_startup(void)
 
        /* OK to call kgnilnd_api_shutdown() to cleanup now */
        kgnilnd_data.kgn_init = GNILND_INIT_DATA;
-       try_module_get(THIS_MODULE);
+       if (!try_module_get(THIS_MODULE))
+               GOTO(failed, rc = -ENOENT);
 
        rwlock_init(&kgnilnd_data.kgn_peer_conn_lock);
 
-       LIBCFS_ALLOC(kgnilnd_data.kgn_peers,
-                   sizeof(struct list_head) * *kgnilnd_tunables.kgn_peer_hash_size);
+       CFS_ALLOC_PTR_ARRAY(kgnilnd_data.kgn_peers,
+                           *kgnilnd_tunables.kgn_peer_hash_size);
 
        if (kgnilnd_data.kgn_peers == NULL)
                GOTO(failed, rc = -ENOMEM);
@@ -2318,8 +2224,8 @@ int kgnilnd_base_startup(void)
                INIT_LIST_HEAD(&kgnilnd_data.kgn_peers[i]);
        }
 
-       LIBCFS_ALLOC(kgnilnd_data.kgn_conns,
-                   sizeof(struct list_head) * *kgnilnd_tunables.kgn_peer_hash_size);
+       CFS_ALLOC_PTR_ARRAY(kgnilnd_data.kgn_conns,
+                           *kgnilnd_tunables.kgn_peer_hash_size);
 
        if (kgnilnd_data.kgn_conns == NULL)
                GOTO(failed, rc = -ENOMEM);
@@ -2328,8 +2234,8 @@ int kgnilnd_base_startup(void)
                INIT_LIST_HEAD(&kgnilnd_data.kgn_conns[i]);
        }
 
-       LIBCFS_ALLOC(kgnilnd_data.kgn_nets,
-                   sizeof(struct list_head) * *kgnilnd_tunables.kgn_net_hash_size);
+       CFS_ALLOC_PTR_ARRAY(kgnilnd_data.kgn_nets,
+                           *kgnilnd_tunables.kgn_net_hash_size);
 
        if (kgnilnd_data.kgn_nets == NULL)
                GOTO(failed, rc = -ENOMEM);
@@ -2362,7 +2268,7 @@ int kgnilnd_base_startup(void)
 
        kgnilnd_data.kgn_tx_phys_cache =
                kmem_cache_create("kgn_tx_phys",
-                                  LNET_MAX_IOV * sizeof(gni_mem_segment_t),
+                                  GNILND_MAX_IOV * sizeof(gni_mem_segment_t),
                                   0, 0, NULL);
        if (kgnilnd_data.kgn_tx_phys_cache == NULL) {
                CERROR("Can't create slab for kgn_tx_phys\n");
@@ -2388,7 +2294,7 @@ int kgnilnd_base_startup(void)
                kgnilnd_data.kgn_cksum_npages * sizeof (struct page *));
 
        for (i = 0; i < kgnilnd_data.kgn_cksum_npages; i++) {
-               kgnilnd_data.kgn_cksum_map_pages[i] = kmalloc(LNET_MAX_IOV * sizeof (struct page *),
+               kgnilnd_data.kgn_cksum_map_pages[i] = kmalloc(GNILND_MAX_IOV * sizeof (struct page *),
                                                              GFP_KERNEL);
                if (kgnilnd_data.kgn_cksum_map_pages[i] == NULL) {
                        CERROR("Can't allocate vmap cksum pages for cpu %d\n", i);
@@ -2492,7 +2398,7 @@ int kgnilnd_base_startup(void)
        kgnilnd_data.kgn_init = GNILND_INIT_ALL;
        /*****************************************************/
 
-       CDEBUG(D_MALLOC, "initial kmem %d\n", pkmem);
+       CDEBUG(D_MALLOC, "initial kmem %lld\n", pkmem);
        RETURN(0);
 
 failed:
@@ -2535,8 +2441,7 @@ kgnilnd_base_shutdown(void)
 
                CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET,
                        "Waiting for conns to be cleaned up %d\n",atomic_read(&kgnilnd_data.kgn_nconns));
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(cfs_time_seconds(1));
+               schedule_timeout_uninterruptible(cfs_time_seconds(1));
        }
        /* Peer state all cleaned up BEFORE setting shutdown, so threads don't
         * have to worry about shutdown races.  NB connections may be created
@@ -2555,8 +2460,7 @@ kgnilnd_base_shutdown(void)
                i++;
                CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET,
                       "Waiting for ruhroh thread to terminate\n");
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(cfs_time_seconds(1));
+               schedule_timeout_uninterruptible(cfs_time_seconds(1));
        }
 
        /* Flag threads to terminate */
@@ -2569,13 +2473,13 @@ kgnilnd_base_shutdown(void)
                kgnilnd_unmap_fma_blocks(dev);
 
                kgnilnd_schedule_device(dev);
-               wake_up_all(&dev->gnd_dgram_waitq);
-               wake_up_all(&dev->gnd_dgping_waitq);
+               wake_up(&dev->gnd_dgram_waitq);
+               wake_up(&dev->gnd_dgping_waitq);
                LASSERT(list_empty(&dev->gnd_connd_peers));
        }
 
        spin_lock(&kgnilnd_data.kgn_reaper_lock);
-       wake_up_all(&kgnilnd_data.kgn_reaper_waitq);
+       wake_up(&kgnilnd_data.kgn_reaper_waitq);
        spin_unlock(&kgnilnd_data.kgn_reaper_lock);
 
        if (atomic_read(&kgnilnd_data.kgn_nthreads))
@@ -2588,8 +2492,7 @@ kgnilnd_base_shutdown(void)
                CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET, /* power of 2? */
                       "Waiting for %d threads to terminate\n",
                       atomic_read(&kgnilnd_data.kgn_nthreads));
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(cfs_time_seconds(1));
+               schedule_timeout_uninterruptible(cfs_time_seconds(1));
        }
 
        LASSERTF(atomic_read(&kgnilnd_data.kgn_npeers) == 0,
@@ -2599,9 +2502,8 @@ kgnilnd_base_shutdown(void)
                for (i = 0; i < *kgnilnd_tunables.kgn_peer_hash_size; i++)
                        LASSERT(list_empty(&kgnilnd_data.kgn_peers[i]));
 
-               LIBCFS_FREE(kgnilnd_data.kgn_peers,
-                           sizeof (struct list_head) *
-                           *kgnilnd_tunables.kgn_peer_hash_size);
+               CFS_FREE_PTR_ARRAY(kgnilnd_data.kgn_peers,
+                                  *kgnilnd_tunables.kgn_peer_hash_size);
        }
 
        down_write(&kgnilnd_data.kgn_net_rw_sem);
@@ -2609,9 +2511,8 @@ kgnilnd_base_shutdown(void)
                for (i = 0; i < *kgnilnd_tunables.kgn_net_hash_size; i++)
                        LASSERT(list_empty(&kgnilnd_data.kgn_nets[i]));
 
-               LIBCFS_FREE(kgnilnd_data.kgn_nets,
-                           sizeof (struct list_head) *
-                           *kgnilnd_tunables.kgn_net_hash_size);
+               CFS_FREE_PTR_ARRAY(kgnilnd_data.kgn_nets,
+                                  *kgnilnd_tunables.kgn_net_hash_size);
        }
        up_write(&kgnilnd_data.kgn_net_rw_sem);
 
@@ -2622,9 +2523,8 @@ kgnilnd_base_shutdown(void)
                for (i = 0; i < *kgnilnd_tunables.kgn_peer_hash_size; i++)
                        LASSERT(list_empty(&kgnilnd_data.kgn_conns[i]));
 
-               LIBCFS_FREE(kgnilnd_data.kgn_conns,
-                           sizeof (struct list_head) *
-                           *kgnilnd_tunables.kgn_peer_hash_size);
+               CFS_FREE_PTR_ARRAY(kgnilnd_data.kgn_conns,
+                                  *kgnilnd_tunables.kgn_peer_hash_size);
        }
 
        for (i = 0; i < kgnilnd_data.kgn_ndevs; i++) {
@@ -2635,12 +2535,12 @@ kgnilnd_base_shutdown(void)
                        "dgrams left %d\n", atomic_read(&dev->gnd_ndgrams));
 
                if (dev->gnd_dgrams != NULL) {
-                       for (i = 0; i < *kgnilnd_tunables.kgn_peer_hash_size; i++)
+                       for (i = 0; i < *kgnilnd_tunables.kgn_peer_hash_size;
+                            i++)
                                LASSERT(list_empty(&dev->gnd_dgrams[i]));
 
-                       LIBCFS_FREE(dev->gnd_dgrams,
-                                   sizeof (struct list_head) *
-                                   *kgnilnd_tunables.kgn_peer_hash_size);
+                       CFS_FREE_PTR_ARRAY(dev->gnd_dgrams,
+                                          *kgnilnd_tunables.kgn_peer_hash_size);
                }
 
                kgnilnd_free_phys_fmablk(dev);
@@ -2670,8 +2570,8 @@ kgnilnd_base_shutdown(void)
                kfree(kgnilnd_data.kgn_cksum_map_pages);
        }
 
-       CDEBUG(D_MALLOC, "after NAL cleanup: kmem %d\n",
-              atomic_read(&libcfs_kmemory));
+       CDEBUG(D_MALLOC, "after NAL cleanup: kmem %lld\n",
+              libcfs_kmem_read());
 
        kgnilnd_data.kgn_init = GNILND_INIT_NOTHING;
        module_put(THIS_MODULE);
@@ -2743,9 +2643,9 @@ kgnilnd_startup(struct lnet_ni *ni)
        atomic_set(&net->gnn_refcount, 1);
 
        /* if we have multiple devices, spread the nets around */
-       net->gnn_netnum = LNET_NETNUM(LNET_NIDNET(ni->ni_nid));
+       net->gnn_netnum = LNET_NETNUM(LNET_NID_NET(&ni->ni_nid));
 
-       devno = LNET_NIDNET(ni->ni_nid) % GNILND_MAXDEVS;
+       devno = LNET_NID_NET(&ni->ni_nid) % GNILND_MAXDEVS;
        net->gnn_dev = &kgnilnd_data.kgn_devices[devno];
 
        /* allocate a 'dummy' cdm for datagram use. We can only have a single
@@ -2756,10 +2656,10 @@ kgnilnd_startup(struct lnet_ni *ni)
        /* the instance id for the cdm is the NETNUM offset by MAXDEVS -
         * ensuring we'll have a unique id */
 
-
-       ni->ni_nid = LNET_MKNID(LNET_NIDNET(ni->ni_nid), net->gnn_dev->gnd_nid);
+       ni->ni_nid.nid_addr[0] =
+               cpu_to_be32(LNET_NIDADDR(net->gnn_dev->gnd_nid));
        CDEBUG(D_NET, "adding net %p nid=%s on dev %d \n",
-               net, libcfs_nid2str(ni->ni_nid), net->gnn_dev->gnd_id);
+               net, libcfs_nidstr(&ni->ni_nid), net->gnn_dev->gnd_id);
        /* until the gnn_list is set, we need to cleanup ourselves as
         * kgnilnd_shutdown is just gonna get confused */
 
@@ -2792,8 +2692,8 @@ kgnilnd_shutdown(struct lnet_ni *ni)
 
        /* Serialize with startup. */
        mutex_lock(&kgnilnd_data.kgn_quiesce_mutex);
-       CDEBUG(D_MALLOC, "before NAL cleanup: kmem %d\n",
-              atomic_read(&libcfs_kmemory));
+       CDEBUG(D_MALLOC, "before NAL cleanup: kmem %lld\n",
+              libcfs_kmem_read());
 
        if (net == NULL) {
                CERROR("got NULL net for ni %p\n", ni);
@@ -2840,8 +2740,7 @@ kgnilnd_shutdown(struct lnet_ni *ni)
                                "Waiting for %d references to clear on net %d\n",
                                atomic_read(&net->gnn_refcount),
                                net->gnn_netnum);
-                       set_current_state(TASK_UNINTERRUPTIBLE);
-                       schedule_timeout(cfs_time_seconds(1));
+                       schedule_timeout_uninterruptible(cfs_time_seconds(1));
                }
 
                /* release ref from kgnilnd_startup */
@@ -2872,8 +2771,8 @@ out:
                        kgnilnd_base_shutdown();
                }
        }
-       CDEBUG(D_MALLOC, "after NAL cleanup: kmem %d\n",
-              atomic_read(&libcfs_kmemory));
+       CDEBUG(D_MALLOC, "after NAL cleanup: kmem %lld\n",
+              libcfs_kmem_read());
 
        mutex_unlock(&kgnilnd_data.kgn_quiesce_mutex);
        EXIT;