ldiskfs/kernel_patches/patches/rhel7/ext4-mballoc-pa-free-mismatch.patch

   1 Index: linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/mballoc.c
   2 ===================================================================
   3 --- linux-3.10.0-123.13.2.el7.x86_64.orig/fs/ext4/mballoc.c
   4 +++ linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/mballoc.c
   5 @@ -3747,6 +3747,7 @@ ext4_mb_new_inode_pa(struct ext4_allocat
   6         INIT_LIST_HEAD(&pa->pa_group_list);
   7         pa->pa_deleted = 0;
   8         pa->pa_type = MB_INODE_PA;
   9 +       pa->pa_error = 0;
  10
  11         mb_debug(1, "new inode pa %p: %llu/%u for %u\n", pa,
  12                         pa->pa_pstart, pa->pa_len, pa->pa_lstart);
  13 @@ -3808,6 +3809,7 @@ ext4_mb_new_group_pa(struct ext4_allocat
  14         INIT_LIST_HEAD(&pa->pa_group_list);
  15         pa->pa_deleted = 0;
  16         pa->pa_type = MB_GROUP_PA;
  17 +       pa->pa_error = 0;
  18
  19         mb_debug(1, "new group pa %p: %llu/%u for %u\n", pa,
  20                         pa->pa_pstart, pa->pa_len, pa->pa_lstart);
  21 @@ -3868,7 +3870,9 @@ ext4_mb_release_inode_pa(struct ext4_bud
  22         int err = 0;
  23         int free = 0;
  24
  25 +       assert_spin_locked(ext4_group_lock_ptr(sb, e4b->bd_group));
  26         BUG_ON(pa->pa_deleted == 0);
  27 +       BUG_ON(pa->pa_inode == NULL);
  28         ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, &bit);
  29         grp_blk_start = pa->pa_pstart - EXT4_C2B(sbi, bit);
  30         BUG_ON(group != e4b->bd_group && pa->pa_len != 0);
  31 @@ -3891,12 +3895,18 @@ ext4_mb_release_inode_pa(struct ext4_bud
  32                 mb_free_blocks(pa->pa_inode, e4b, bit, next - bit);
  33                 bit = next + 1;
  34         }
  35 -       if (free != pa->pa_free) {
  36 -               ext4_msg(e4b->bd_sb, KERN_CRIT,
  37 -                        "pa %p: logic %lu, phys. %lu, len %lu",
  38 -                        pa, (unsigned long) pa->pa_lstart,
  39 -                        (unsigned long) pa->pa_pstart,
  40 -                        (unsigned long) pa->pa_len);
  41 +
  42 +       /* "free < pa->pa_free" means we maybe double alloc the same blocks,
  43 +        * otherwise maybe leave some free blocks unavailable, no need to BUG.*/
  44 +       if ((free > pa->pa_free && !pa->pa_error) || (free < pa->pa_free)) {
  45 +               ext4_error(sb, "pa free mismatch: [pa %p] "
  46 +                               "[phy %lu] [logic %lu] [len %u] [free %u] "
  47 +                               "[error %u] [inode %lu] [freed %u]", pa,
  48 +                               (unsigned long)pa->pa_pstart,
  49 +                               (unsigned long)pa->pa_lstart,
  50 +                               (unsigned)pa->pa_len, (unsigned)pa->pa_free,
  51 +                               (unsigned)pa->pa_error, pa->pa_inode->i_ino,
  52 +                               free);
  53                 ext4_grp_locked_error(sb, group, 0, 0, "free %u, pa_free %u",
  54                                         free, pa->pa_free);
  55                 /*
  56 @@ -3904,6 +3914,8 @@ ext4_mb_release_inode_pa(struct ext4_bud
  57                  * from the bitmap and continue.
  58                  */
  59         }
  60 +       /* do not verify if the file system is being umounted */
  61 +       BUG_ON(atomic_read(&sb->s_active) > 0 && pa->pa_free != free);
  62         atomic_add(free, &sbi->s_mb_discarded);
  63
  64         return err;
  65 @@ -4661,6 +4673,25 @@ errout:
  66                 ac->ac_b_ex.fe_len = 0;
  67                 ar->len = 0;
  68                 ext4_mb_show_ac(ac);
  69 +               if (ac->ac_pa) {
  70 +                       struct ext4_prealloc_space *pa = ac->ac_pa;
  71 +
  72 +                       /* We can not make sure whether the bitmap has
  73 +                        * been updated or not when fail case. So can
  74 +                        * not revert pa_free back, just mark pa_error*/
  75 +                       pa->pa_error++;
  76 +                       ext4_error(sb,
  77 +                               "Updating bitmap error: [err %d] "
  78 +                               "[pa %p] [phy %lu] [logic %lu] "
  79 +                               "[len %u] [free %u] [error %u] "
  80 +                               "[inode %lu]", *errp, pa,
  81 +                               (unsigned long)pa->pa_pstart,
  82 +                               (unsigned long)pa->pa_lstart,
  83 +                               (unsigned)pa->pa_len,
  84 +                               (unsigned)pa->pa_free,
  85 +                               (unsigned)pa->pa_error,
  86 +                               pa->pa_inode ? pa->pa_inode->i_ino : 0);
  87 +               }
  88         }
  89         ext4_mb_release_context(ac);
  90  out:
  91 Index: linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/mballoc.h
  92 ===================================================================
  93 --- linux-3.10.0-123.13.2.el7.x86_64.orig/fs/ext4/mballoc.h
  94 +++ linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/mballoc.h
  95 @@ -19,6 +19,7 @@
  96  #include <linux/seq_file.h>
  97  #include <linux/blkdev.h>
  98  #include <linux/mutex.h>
  99 +#include <linux/genhd.h>
 100  #include "ext4_jbd2.h"
 101  #include "ext4.h"
 102
 103 @@ -125,6 +126,7 @@ struct ext4_prealloc_space {
 104         ext4_grpblk_t           pa_len;         /* len of preallocated chunk */
 105         ext4_grpblk_t           pa_free;        /* how many blocks are free */
 106         unsigned short          pa_type;        /* pa type. inode or group */
 107 +       unsigned short          pa_error;
 108         spinlock_t              *pa_obj_lock;
 109         struct inode            *pa_inode;      /* hack, for history only */
 110  };