1 this patch implements feature which allows ext4 fs users (e.g. Lustre)
2 to store data in ext4 dirent.
3 data is stored in ext4 dirent after file-name, this space is accounted
4 in de->rec_len. flag EXT4_DIRENT_LUFID added to d_type if extra data
7 make use of dentry->d_fsdata to pass fid to ext4. so no
8 changes in ext4_add_entry() interface required.
10 Index: linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/dir.c
11 ===================================================================
12 --- linux-3.10.0-123.13.2.el7.x86_64.orig/fs/ext4/dir.c
13 +++ linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/dir.c
14 @@ -71,11 +71,11 @@ int __ext4_check_dir_entry(const char *f
15 const int rlen = ext4_rec_len_from_disk(de->rec_len,
16 dir->i_sb->s_blocksize);
18 - if (unlikely(rlen < EXT4_DIR_REC_LEN(1)))
19 + if (unlikely(rlen < __EXT4_DIR_REC_LEN(1)))
20 error_msg = "rec_len is smaller than minimal";
21 else if (unlikely(rlen % 4 != 0))
22 error_msg = "rec_len % 4 != 0";
23 - else if (unlikely(rlen < EXT4_DIR_REC_LEN(de->name_len)))
24 + else if (unlikely(rlen < EXT4_DIR_REC_LEN(de)))
25 error_msg = "rec_len is too small for name_len";
26 else if (unlikely(((char *) de - buf) + rlen > size))
27 error_msg = "directory entry across range";
28 @@ -208,7 +208,7 @@ revalidate:
29 * failure will be detected in the
30 * dirent test below. */
31 if (ext4_rec_len_from_disk(de->rec_len,
32 - sb->s_blocksize) < EXT4_DIR_REC_LEN(1))
33 + sb->s_blocksize) < __EXT4_DIR_REC_LEN(1))
35 i += ext4_rec_len_from_disk(de->rec_len,
37 @@ -438,12 +438,17 @@ int ext4_htree_store_dirent(struct file
38 struct fname *fname, *new_fn;
39 struct dir_private_info *info;
43 info = dir_file->private_data;
44 p = &info->root.rb_node;
46 /* Create and allocate the fname structure */
47 - len = sizeof(struct fname) + dirent->name_len + 1;
48 + if (dirent->file_type & EXT4_DIRENT_LUFID)
49 + extra_data = ext4_get_dirent_data_len(dirent);
51 + len = sizeof(struct fname) + dirent->name_len + extra_data + 1;
53 new_fn = kzalloc(len, GFP_KERNEL);
56 @@ -452,7 +457,7 @@ int ext4_htree_store_dirent(struct file
57 new_fn->inode = le32_to_cpu(dirent->inode);
58 new_fn->name_len = dirent->name_len;
59 new_fn->file_type = dirent->file_type;
60 - memcpy(new_fn->name, dirent->name, dirent->name_len);
61 + memcpy(new_fn->name, dirent->name, dirent->name_len + extra_data);
62 new_fn->name[dirent->name_len] = 0;
65 @@ -452,7 +457,7 @@ int ext4_htree_store_dirent(struct file
66 if (ext4_check_dir_entry(dir, NULL, de, bh,
67 buf, buf_size, offset))
69 - nlen = EXT4_DIR_REC_LEN(de->name_len);
70 + nlen = EXT4_DIR_REC_LEN(de);
71 rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
72 de = (struct ext4_dir_entry_2 *)((char *)de + rlen);
74 Index: linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/ext4.h
75 ===================================================================
76 --- linux-3.10.0-123.13.2.el7.x86_64.orig/fs/ext4/ext4.h
77 +++ linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/ext4.h
78 @@ -952,6 +952,7 @@ struct ext4_inode_info {
79 #define EXT4_MOUNT_ERRORS_MASK 0x00070
80 #define EXT4_MOUNT_MINIX_DF 0x00080 /* Mimics the Minix statfs */
81 #define EXT4_MOUNT_NOLOAD 0x00100 /* Don't use existing journal*/
82 +#define EXT4_MOUNT_DIRDATA 0x00200 /* Data in directory entries*/
83 #define EXT4_MOUNT_DATA_FLAGS 0x00C00 /* Mode for data writes: */
84 #define EXT4_MOUNT_JOURNAL_DATA 0x00400 /* Write data to journal */
85 #define EXT4_MOUNT_ORDERED_DATA 0x00800 /* Flush data before commit */
86 @@ -1534,6 +1535,7 @@ static inline void ext4_clear_state_flag
87 EXT4_FEATURE_INCOMPAT_64BIT| \
88 EXT4_FEATURE_INCOMPAT_FLEX_BG| \
89 EXT4_FEATURE_INCOMPAT_MMP | \
90 + EXT4_FEATURE_INCOMPAT_DIRDATA| \
91 EXT4_FEATURE_INCOMPAT_INLINE_DATA)
92 #define EXT4_FEATURE_RO_COMPAT_SUPP (EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER| \
93 EXT4_FEATURE_RO_COMPAT_LARGE_FILE| \
94 @@ -1640,6 +1642,43 @@ struct ext4_dir_entry_tail {
95 #define EXT4_FT_SYMLINK 7
98 +#define EXT4_FT_MASK 0xf
100 +#if EXT4_FT_MAX > EXT4_FT_MASK
101 +#error "conflicting EXT4_FT_MAX and EXT4_FT_MASK"
105 + * d_type has 4 unused bits, so it can hold four types data. these different
106 + * type of data (e.g. lustre data, high 32 bits of 64-bit inode number) can be
107 + * stored, in flag order, after file-name in ext4 dirent.
110 + * this flag is added to d_type if ext4 dirent has extra data after
111 + * filename. this data length is variable and length is stored in first byte
112 + * of data. data start after filename NUL byte.
113 + * This is used by Lustre FS.
115 +#define EXT4_DIRENT_LUFID 0x10
117 +#define EXT4_LUFID_MAGIC 0xAD200907UL
118 +struct ext4_dentry_param {
119 + __u32 edp_magic; /* EXT4_LUFID_MAGIC */
120 + char edp_len; /* size of edp_data in bytes */
121 + char edp_data[0]; /* packed array of data */
122 +} __attribute__((packed));
124 +static inline unsigned char *ext4_dentry_get_data(struct super_block *sb,
125 + struct ext4_dentry_param* p)
128 + if (!EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_DIRDATA))
130 + if (p && p->edp_magic == EXT4_LUFID_MAGIC)
131 + return &p->edp_len;
136 #define EXT4_FT_DIR_CSUM 0xDE
138 @@ -1650,8 +1689,11 @@ struct ext4_dir_entry_tail {
140 #define EXT4_DIR_PAD 4
141 #define EXT4_DIR_ROUND (EXT4_DIR_PAD - 1)
142 -#define EXT4_DIR_REC_LEN(name_len) (((name_len) + 8 + EXT4_DIR_ROUND) & \
143 +#define __EXT4_DIR_REC_LEN(name_len) (((name_len) + 8 + EXT4_DIR_ROUND) & \
145 +#define EXT4_DIR_REC_LEN(de) (__EXT4_DIR_REC_LEN((de)->name_len +\
146 + ext4_get_dirent_data_len(de)))
148 #define EXT4_MAX_REC_LEN ((1<<16)-1)
151 @@ -1987,11 +2029,11 @@ extern int ext4_find_dest_de(struct inod
152 struct buffer_head *bh,
153 void *buf, int buf_size,
154 const char *name, int namelen,
155 - struct ext4_dir_entry_2 **dest_de);
156 + struct ext4_dir_entry_2 **dest_de, int *dlen);
157 void ext4_insert_dentry(struct inode *inode,
158 struct ext4_dir_entry_2 *de,
160 - const char *name, int namelen);
161 + const char *name, int namelen, void *data);
162 static inline void ext4_update_dx_flag(struct inode *inode)
164 if (!EXT4_HAS_COMPAT_FEATURE(inode->i_sb,
165 @@ -2004,11 +2046,18 @@ static unsigned char ext4_filetype_table
167 static inline unsigned char get_dtype(struct super_block *sb, int filetype)
169 + int fl_index = filetype & EXT4_FT_MASK;
171 if (!EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FILETYPE) ||
172 - (filetype >= EXT4_FT_MAX))
173 + (fl_index >= EXT4_FT_MAX))
176 - return ext4_filetype_table[filetype];
177 + if (!test_opt(sb, DIRDATA))
178 + return (ext4_filetype_table[fl_index]);
180 + return (ext4_filetype_table[fl_index]) |
181 + (filetype & EXT4_DIRENT_LUFID);
186 @@ -2157,7 +2206,7 @@ extern struct buffer_head * ext4_find_en
187 struct ext4_dir_entry_2 ** res_dir,
189 extern int ext4_add_dot_dotdot(handle_t *handle, struct inode *dir,
190 - struct inode *inode);
191 + struct inode *inode, const void *, const void *);
192 extern int search_dir(struct buffer_head *bh,
195 @@ -2761,6 +2810,28 @@ extern struct mutex ext4__aio_mutex[EXT4
196 extern int ext4_resize_begin(struct super_block *sb);
197 extern void ext4_resize_end(struct super_block *sb);
200 + * Compute the total directory entry data length.
201 + * This includes the filename and an implicit NUL terminator (always present),
202 + * and optional extensions. Each extension has a bit set in the high 4 bits of
203 + * de->file_type, and the extension length is the first byte in each entry.
205 +static inline int ext4_get_dirent_data_len(struct ext4_dir_entry_2 *de)
207 + char *len = de->name + de->name_len + 1 /* NUL terminator */;
209 + __u8 extra_data_flags = (de->file_type & ~EXT4_FT_MASK) >> 4;
211 + while (extra_data_flags) {
212 + if (extra_data_flags & 1) {
213 + dlen += *len + (dlen == 0);
216 + extra_data_flags >>= 1;
221 #endif /* __KERNEL__ */
224 Index: linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/namei.c
225 ===================================================================
226 --- linux-3.10.0-123.13.2.el7.x86_64.orig/fs/ext4/namei.c
227 +++ linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/namei.c
228 @@ -239,7 +239,8 @@ static unsigned dx_get_count(struct dx_e
229 static unsigned dx_get_limit(struct dx_entry *entries);
230 static void dx_set_count(struct dx_entry *entries, unsigned value);
231 static void dx_set_limit(struct dx_entry *entries, unsigned value);
232 -static unsigned dx_root_limit(struct inode *dir, unsigned infosize);
233 +static inline unsigned dx_root_limit(struct inode *dir,
234 + struct ext4_dir_entry_2 *dot_de, unsigned infosize);
235 static unsigned dx_node_limit(struct inode *dir);
236 static struct dx_frame *dx_probe(const struct qstr *d_name,
238 @@ -504,11 +505,12 @@ ext4_next_entry(struct ext4_dir_entry_2
240 struct dx_root_info * dx_get_dx_info(struct ext4_dir_entry_2 *de)
242 - /* get dotdot first */
243 - de = (struct ext4_dir_entry_2 *)((char *)de + EXT4_DIR_REC_LEN(1));
244 + BUG_ON(de->name_len != 1);
245 + /* get dotdot first */
246 + de = (struct ext4_dir_entry_2 *)((char *)de + EXT4_DIR_REC_LEN(de));
248 - /* dx root info is after dotdot entry */
249 - de = (struct ext4_dir_entry_2 *)((char *)de + EXT4_DIR_REC_LEN(2));
250 + /* dx root info is after dotdot entry */
251 + de = (struct ext4_dir_entry_2 *)((char *)de + EXT4_DIR_REC_LEN(de));
253 return (struct dx_root_info *) de;
255 @@ -553,10 +555,16 @@ static inline void dx_set_limit(struct d
256 ((struct dx_countlimit *) entries)->limit = cpu_to_le16(value);
259 -static inline unsigned dx_root_limit(struct inode *dir, unsigned infosize)
260 +static inline unsigned dx_root_limit(struct inode *dir,
261 + struct ext4_dir_entry_2 *dot_de, unsigned infosize)
263 - unsigned entry_space = dir->i_sb->s_blocksize - EXT4_DIR_REC_LEN(1) -
264 - EXT4_DIR_REC_LEN(2) - infosize;
265 + struct ext4_dir_entry_2 *dotdot_de;
266 + unsigned entry_space;
268 + BUG_ON(dot_de->name_len != 1);
269 + dotdot_de = ext4_next_entry(dot_de, dir->i_sb->s_blocksize);
270 + entry_space = dir->i_sb->s_blocksize - EXT4_DIR_REC_LEN(dot_de) -
271 + EXT4_DIR_REC_LEN(dotdot_de) - infosize;
273 if (EXT4_HAS_RO_COMPAT_FEATURE(dir->i_sb,
274 EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))
275 @@ -566,7 +574,7 @@ static inline unsigned dx_root_limit(str
277 static inline unsigned dx_node_limit(struct inode *dir)
279 - unsigned entry_space = dir->i_sb->s_blocksize - EXT4_DIR_REC_LEN(0);
280 + unsigned entry_space = dir->i_sb->s_blocksize - __EXT4_DIR_REC_LEN(0);
282 if (EXT4_HAS_RO_COMPAT_FEATURE(dir->i_sb,
283 EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))
284 @@ -617,7 +625,7 @@ static struct stats dx_show_leaf(struct
285 printk(":%x.%u ", h.hash,
286 (unsigned) ((char *) de - base));
288 - space += EXT4_DIR_REC_LEN(de->name_len);
289 + space += EXT4_DIR_REC_LEN(de);
292 de = ext4_next_entry(de, size);
293 @@ -723,6 +731,7 @@ dx_probe(const struct qstr *d_name, stru
294 entries = (struct dx_entry *) (((char *)info) + info->info_length);
296 if (dx_get_limit(entries) != dx_root_limit(dir,
297 + (struct ext4_dir_entry_2*)bh->b_data,
298 info->info_length)) {
299 ext4_warning(dir->i_sb, "dx entry: limit != root limit");
301 @@ -916,7 +925,7 @@ static int htree_dirblock_to_tree(struct
302 de = (struct ext4_dir_entry_2 *) bh->b_data;
303 top = (struct ext4_dir_entry_2 *) ((char *) de +
304 dir->i_sb->s_blocksize -
305 - EXT4_DIR_REC_LEN(0));
306 + __EXT4_DIR_REC_LEN(0));
307 for (; de < top; de = ext4_next_entry(de, dir->i_sb->s_blocksize)) {
308 if (ext4_check_dir_entry(dir, NULL, de, bh,
309 bh->b_data, bh->b_size,
310 @@ -1508,7 +1517,7 @@ dx_move_dirents(char *from, char *to, st
312 struct ext4_dir_entry_2 *de = (struct ext4_dir_entry_2 *)
313 (from + (map->offs<<2));
314 - rec_len = EXT4_DIR_REC_LEN(de->name_len);
315 + rec_len = EXT4_DIR_REC_LEN(de);
316 memcpy (to, de, rec_len);
317 ((struct ext4_dir_entry_2 *) to)->rec_len =
318 ext4_rec_len_to_disk(rec_len, blocksize);
319 @@ -1532,7 +1541,7 @@ static struct ext4_dir_entry_2* dx_pack_
320 while ((char*)de < base + blocksize) {
321 next = ext4_next_entry(de, blocksize);
322 if (de->inode && de->name_len) {
323 - rec_len = EXT4_DIR_REC_LEN(de->name_len);
324 + rec_len = EXT4_DIR_REC_LEN(de);
326 memmove(to, de, rec_len);
327 to->rec_len = ext4_rec_len_to_disk(rec_len, blocksize);
328 @@ -1664,14 +1673,15 @@ int ext4_find_dest_de(struct inode *dir,
329 struct buffer_head *bh,
330 void *buf, int buf_size,
331 const char *name, int namelen,
332 - struct ext4_dir_entry_2 **dest_de)
333 + struct ext4_dir_entry_2 **dest_de, int *dlen)
335 struct ext4_dir_entry_2 *de;
336 - unsigned short reclen = EXT4_DIR_REC_LEN(namelen);
337 + unsigned short reclen = __EXT4_DIR_REC_LEN(namelen) + (dlen ? *dlen:0);
339 unsigned int offset = 0;
342 + dlen ? *dlen = 0: 0; /* default set to 0 */
343 de = (struct ext4_dir_entry_2 *)buf;
344 top = buf + buf_size - reclen;
345 while ((char *) de <= top) {
346 @@ -1680,10 +1690,26 @@ int ext4_find_dest_de(struct inode *dir,
348 if (ext4_match(namelen, name, de))
350 - nlen = EXT4_DIR_REC_LEN(de->name_len);
351 + nlen = EXT4_DIR_REC_LEN(de);
352 rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
353 if ((de->inode ? rlen - nlen : rlen) >= reclen)
355 + /* Then for dotdot entries, check for the smaller space
356 + * required for just the entry, no FID */
357 + if (namelen == 2 && memcmp(name, "..", 2) == 0) {
358 + if ((de->inode ? rlen - nlen : rlen) >=
359 + __EXT4_DIR_REC_LEN(namelen)) {
360 + /* set dlen=1 to indicate not
361 + * enough space store fid */
362 + dlen ? *dlen = 1 : 0;
365 + /* The new ".." entry must be written over the
366 + * previous ".." entry, which is the first
367 + * entry traversed by this scan. If it doesn't
368 + * fit, something is badly wrong, so -EIO. */
371 de = (struct ext4_dir_entry_2 *)((char *)de + rlen);
374 @@ -1697,12 +1723,12 @@ int ext4_find_dest_de(struct inode *dir,
375 void ext4_insert_dentry(struct inode *inode,
376 struct ext4_dir_entry_2 *de,
378 - const char *name, int namelen)
379 + const char *name, int namelen, void *data)
384 - nlen = EXT4_DIR_REC_LEN(de->name_len);
385 + nlen = EXT4_DIR_REC_LEN(de);
386 rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
388 struct ext4_dir_entry_2 *de1 =
389 @@ -1716,6 +1742,11 @@ void ext4_insert_dentry(struct inode *in
390 ext4_set_de_type(inode->i_sb, de, inode->i_mode);
391 de->name_len = namelen;
392 memcpy(de->name, name, namelen);
394 + de->name[namelen] = 0;
395 + memcpy(&de->name[namelen + 1], data, *(char *)data);
396 + de->file_type |= EXT4_DIRENT_LUFID;
400 * Add a new entry into a directory (leaf) block. If de is non-NULL,
401 @@ -1734,15 +1765,20 @@ static int add_dirent_to_buf(handle_t *h
402 int namelen = dentry->d_name.len;
403 unsigned int blocksize = dir->i_sb->s_blocksize;
407 + unsigned char *data;
409 + data = ext4_dentry_get_data(inode->i_sb, (struct ext4_dentry_param *)
411 if (ext4_has_metadata_csum(inode->i_sb))
412 csum_size = sizeof(struct ext4_dir_entry_tail);
416 + dlen = (*data) + 1;
417 err = ext4_find_dest_de(dir, inode,
418 bh, bh->b_data, blocksize - csum_size,
419 - name, namelen, &de);
420 + name, namelen, &de, &dlen);
424 @@ -1755,7 +1791,10 @@ static int add_dirent_to_buf(handle_t *h
427 /* By now the buffer is marked for journaling */
428 - ext4_insert_dentry(inode, de, blocksize, name, namelen);
429 + /* If we're writing the short form of "dotdot", don't add the data section */
432 + ext4_insert_dentry(inode, de, blocksize, name, namelen, data);
435 * XXX shouldn't update any times until successful
436 @@ -1866,7 +1905,8 @@ static int make_indexed_dir(handle_t *ha
438 dx_set_block(entries, 1);
439 dx_set_count(entries, 1);
440 - dx_set_limit(entries, dx_root_limit(dir, sizeof(*dx_info)));
441 + dx_set_limit(entries, dx_root_limit(dir,
442 + dot_de, sizeof(*dx_info)));
444 /* Initialize as for dx_probe */
445 hinfo.hash_version = dx_info->hash_version;
446 @@ -1909,6 +1949,8 @@ static int ext4_update_dotdot(handle_t *
447 struct buffer_head * dir_block;
448 struct ext4_dir_entry_2 * de;
449 int len, journal = 0, err = 0;
454 return PTR_ERR(handle);
455 @@ -1924,19 +1966,24 @@ static int ext4_update_dotdot(handle_t *
456 /* the first item must be "." */
457 assert(de->name_len == 1 && de->name[0] == '.');
458 len = le16_to_cpu(de->rec_len);
459 - assert(len >= EXT4_DIR_REC_LEN(1));
460 - if (len > EXT4_DIR_REC_LEN(1)) {
461 + assert(len >= __EXT4_DIR_REC_LEN(1));
462 + if (len > __EXT4_DIR_REC_LEN(1)) {
463 BUFFER_TRACE(dir_block, "get_write_access");
464 err = ext4_journal_get_write_access(handle, dir_block);
469 - de->rec_len = cpu_to_le16(EXT4_DIR_REC_LEN(1));
470 + de->rec_len = cpu_to_le16(EXT4_DIR_REC_LEN(de));
473 - len -= EXT4_DIR_REC_LEN(1);
474 - assert(len == 0 || len >= EXT4_DIR_REC_LEN(2));
475 + len -= EXT4_DIR_REC_LEN(de);
476 + data = ext4_dentry_get_data(dir->i_sb,
477 + (struct ext4_dentry_param *)dentry->d_fsdata);
480 + assert(len == 0 || len >= __EXT4_DIR_REC_LEN(2 + dlen));
482 de = (struct ext4_dir_entry_2 *)
483 ((char *) de + le16_to_cpu(de->rec_len));
485 @@ -1950,10 +1997,15 @@ static int ext4_update_dotdot(handle_t *
487 de->rec_len = cpu_to_le16(len);
489 - assert(le16_to_cpu(de->rec_len) >= EXT4_DIR_REC_LEN(2));
490 + assert(le16_to_cpu(de->rec_len) >= __EXT4_DIR_REC_LEN(2));
492 strcpy (de->name, "..");
493 - ext4_set_de_type(dir->i_sb, de, S_IFDIR);
494 + if (data != NULL && ext4_get_dirent_data_len(de) >= dlen) {
496 + memcpy(&de->name[2 + 1], data, *data);
497 + ext4_set_de_type(dir->i_sb, de, S_IFDIR);
498 + de->file_type |= EXT4_DIRENT_LUFID;
503 @@ -2428,30 +2480,61 @@ retry:
508 + struct inode *inode;
513 struct ext4_dir_entry_2 *ext4_init_dot_dotdot(struct inode *inode,
514 struct ext4_dir_entry_2 *de,
515 int blocksize, int csum_size,
516 unsigned int parent_ino, int dotdot_real_len)
518 + void *data1 = NULL, *data2 = NULL;
519 + int dot_reclen = 0;
521 + if (dotdot_real_len == 10) {
522 + struct tp_block *tpb = (struct tp_block*)inode;
523 + data1 = tpb->data1;
524 + data2 = tpb->data2;
525 + inode = tpb->inode;
526 + dotdot_real_len = 0;
528 de->inode = cpu_to_le32(inode->i_ino);
530 - de->rec_len = ext4_rec_len_to_disk(EXT4_DIR_REC_LEN(de->name_len),
532 strcpy(de->name, ".");
533 ext4_set_de_type(inode->i_sb, de, S_IFDIR);
535 + /* get packed fid data*/
536 + data1 = ext4_dentry_get_data(inode->i_sb,
537 + (struct ext4_dentry_param *) data1);
540 + memcpy(&de->name[2], data1, *(char *) data1);
541 + de->file_type |= EXT4_DIRENT_LUFID;
543 + de->rec_len = cpu_to_le16(EXT4_DIR_REC_LEN(de));
544 + dot_reclen = cpu_to_le16(de->rec_len);
545 de = ext4_next_entry(de, blocksize);
546 de->inode = cpu_to_le32(parent_ino);
548 + strcpy(de->name, "..");
549 + ext4_set_de_type(inode->i_sb, de, S_IFDIR);
550 + data2 = ext4_dentry_get_data(inode->i_sb,
551 + (struct ext4_dentry_param *) data2);
554 + memcpy(&de->name[3], data2, *(char *) data2);
555 + de->file_type |= EXT4_DIRENT_LUFID;
557 if (!dotdot_real_len)
558 de->rec_len = ext4_rec_len_to_disk(blocksize -
559 - (csum_size + EXT4_DIR_REC_LEN(1)),
560 + (csum_size + dot_reclen),
563 de->rec_len = ext4_rec_len_to_disk(
564 - EXT4_DIR_REC_LEN(de->name_len), blocksize);
565 + EXT4_DIR_REC_LEN(de), blocksize);
566 - strcpy(de->name, "..");
567 - ext4_set_de_type(inode->i_sb, de, S_IFDIR);
569 return ext4_next_entry(de, blocksize);
571 @@ -2457,8 +2540,10 @@ struct ext4_dir_entry_2 *ext4_init_dot_d
574 static int ext4_init_new_dir(handle_t *handle, struct inode *dir,
575 - struct inode *inode)
576 + struct inode *inode,
577 + const void *data1, const void *data2)
579 + struct tp_block param;
580 struct buffer_head *dir_block = NULL;
581 struct ext4_dir_entry_2 *de;
582 struct ext4_dir_entry_tail *t;
583 @@ -2488,7 +2573,11 @@ static int ext4_init_new_dir(handle_t *h
586 de = (struct ext4_dir_entry_2 *)dir_block->b_data;
587 - ext4_init_dot_dotdot(inode, de, blocksize, csum_size, dir->i_ino, 0);
588 + param.inode = inode;
589 + param.data1 = (void *)data1;
590 + param.data2 = (void *)data2;
591 + ext4_init_dot_dotdot((struct inode *)(¶m), de, blocksize,
592 + csum_size, dir->i_ino, 10);
595 t = EXT4_DIRENT_TAIL(dir_block->b_data, blocksize);
596 @@ -2508,7 +2597,8 @@ out:
597 /* Initialize @inode as a subdirectory of @dir, and add the
598 * "." and ".." entries into the first directory block. */
599 int ext4_add_dot_dotdot(handle_t *handle, struct inode * dir,
600 - struct inode *inode)
601 + struct inode *inode,
602 + const void *data1, const void *data2)
605 return PTR_ERR(handle);
606 @@ -2518,7 +2608,7 @@ int ext4_add_dot_dotdot(handle_t *handle
608 inode->i_op = &ext4_dir_inode_operations;
609 inode->i_fop = &ext4_dir_operations;
610 - return ext4_init_new_dir(handle, dir, inode);
611 + return ext4_init_new_dir(handle, dir, inode, data1, data2);
613 EXPORT_SYMBOL(ext4_add_dot_dotdot);
615 @@ -2546,7 +2636,7 @@ retry:
617 inode->i_op = &ext4_dir_inode_operations;
618 inode->i_fop = &ext4_dir_operations;
619 - err = ext4_init_new_dir(handle, dir, inode);
620 + err = ext4_init_new_dir(handle, dir, inode, NULL, NULL);
622 goto out_clear_inode;
623 err = ext4_mark_inode_dirty(handle, inode);
624 @@ -2598,7 +2688,7 @@ static int empty_dir(struct inode *inode
628 - if (inode->i_size < EXT4_DIR_REC_LEN(1) + EXT4_DIR_REC_LEN(2)) {
629 + if (inode->i_size < __EXT4_DIR_REC_LEN(1) + __EXT4_DIR_REC_LEN(2)) {
630 EXT4_ERROR_INODE(inode, "invalid size");
633 Index: linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/inline.c
634 ===================================================================
635 --- linux-3.10.0-123.13.2.el7.x86_64.orig/fs/ext4/inline.c
636 +++ linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/inline.c
637 @@ -988,7 +998,7 @@ static int ext4_add_dirent_to_inline(han
639 err = ext4_find_dest_de(dir, inode, iloc->bh,
640 inline_start, inline_size,
641 - name, namelen, &de);
642 + name, namelen, &de, NULL);
646 @@ -998,7 +998,7 @@ static int ext4_add_dirent_to_inline(han
647 err = ext4_journal_get_write_access(handle, iloc->bh);
650 - ext4_insert_dentry(inode, de, inline_size, name, namelen);
651 + ext4_insert_dentry(inode, de, inline_size, name, namelen, NULL);
653 ext4_show_inline_dir(dir, iloc->bh, inline_start, inline_size);
655 @@ -1078,7 +1078,7 @@ static int ext4_update_inline_dir(handle
656 int old_size = EXT4_I(dir)->i_inline_size - EXT4_MIN_INLINE_DATA_SIZE;
657 int new_size = get_max_inline_xattr_value_size(dir, iloc);
659 - if (new_size - old_size <= EXT4_DIR_REC_LEN(1))
660 + if (new_size - old_size <= __EXT4_DIR_REC_LEN(1))
663 ret = ext4_update_inline_data(handle, dir,
664 @@ -1348,7 +1348,7 @@ int htree_inlinedir_to_tree(struct file
666 strcpy(fake.name, ".");
667 fake.rec_len = ext4_rec_len_to_disk(
668 - EXT4_DIR_REC_LEN(fake.name_len),
669 + EXT4_DIR_REC_LEN(&fake),
671 ext4_set_de_type(inode->i_sb, &fake, S_IFDIR);
673 @@ -1358,7 +1358,7 @@ int htree_inlinedir_to_tree(struct file
675 strcpy(fake.name, "..");
676 fake.rec_len = ext4_rec_len_to_disk(
677 - EXT4_DIR_REC_LEN(fake.name_len),
678 + EXT4_DIR_REC_LEN(&fake),
680 ext4_set_de_type(inode->i_sb, &fake, S_IFDIR);
682 @@ -1455,8 +1455,8 @@ int ext4_read_inline_dir(struct file *fi
683 * So we will use extra_offset and extra_size to indicate them
684 * during the inline dir iteration.
686 - dotdot_offset = EXT4_DIR_REC_LEN(1);
687 - dotdot_size = dotdot_offset + EXT4_DIR_REC_LEN(2);
688 + dotdot_offset = __EXT4_DIR_REC_LEN(1);
689 + dotdot_size = dotdot_offset + __EXT4_DIR_REC_LEN(2);
690 extra_offset = dotdot_size - EXT4_INLINE_DOTDOT_SIZE;
691 extra_size = extra_offset + inline_size;
693 @@ -1493,7 +1493,7 @@ revalidate:
694 * failure will be detected in the
695 * dirent test below. */
696 if (ext4_rec_len_from_disk(de->rec_len,
697 - extra_size) < EXT4_DIR_REC_LEN(1))
698 + extra_size) < __EXT4_DIR_REC_LEN(1))
700 i += ext4_rec_len_from_disk(de->rec_len,
702 Index: linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/super.c
703 ===================================================================
704 --- linux-3.10.0-123.13.2.el7.x86_64.orig/fs/ext4/super.c
705 +++ linux-3.10.0-123.13.2.el7.x86_64/fs/ext4/super.c
706 @@ -1151,7 +1151,7 @@ enum {
707 Opt_data_err_abort, Opt_data_err_ignore,
708 Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota,
709 Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_jqfmt_vfsv1, Opt_quota,
710 - Opt_noquota, Opt_barrier, Opt_nobarrier, Opt_err,
711 + Opt_noquota, Opt_barrier, Opt_nobarrier, Opt_err, Opt_dirdata,
712 Opt_usrquota, Opt_grpquota, Opt_i_version,
713 Opt_stripe, Opt_delalloc, Opt_nodelalloc, Opt_mblk_io_submit,
714 Opt_nomblk_io_submit, Opt_block_validity, Opt_noblock_validity,
715 @@ -1216,6 +1216,7 @@ static const match_table_t tokens = {
716 {Opt_stripe, "stripe=%u"},
717 {Opt_delalloc, "delalloc"},
718 {Opt_nodelalloc, "nodelalloc"},
719 + {Opt_dirdata, "dirdata"},
720 {Opt_removed, "mblk_io_submit"},
721 {Opt_removed, "nomblk_io_submit"},
722 {Opt_block_validity, "block_validity"},
723 @@ -1424,6 +1425,7 @@ static const struct mount_opts {
724 {Opt_usrjquota, 0, MOPT_Q},
725 {Opt_grpjquota, 0, MOPT_Q},
726 {Opt_offusrjquota, 0, MOPT_Q},
727 + {Opt_dirdata, EXT4_MOUNT_DIRDATA, MOPT_SET},
728 {Opt_offgrpjquota, 0, MOPT_Q},
729 {Opt_jqfmt_vfsold, QFMT_VFS_OLD, MOPT_QFMT},
730 {Opt_jqfmt_vfsv0, QFMT_VFS_V0, MOPT_QFMT},