contrib/scripts/checkpatch.pl

   1 #!/usr/bin/perl -w
   2 # (c) 2001, Dave Jones. (the file handling bit)
   3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
   4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
   5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
   6 # Licensed under the terms of the GNU GPL License version 2
   7
   8 # Based on linux/scripts/checkpatch.pl from 2.6.38 but uses Lustre
   9 # specific deprecated symbol/functions/include lists rather than
  10 # Documentation/feature-removal-schedule.txt.
  11
  12 use strict;
  13
  14 my $P = $0;
  15 $P =~ s@.*/@@g;
  16
  17 my $V = '0.32';
  18
  19 use Getopt::Long qw(:config no_auto_abbrev);
  20
  21 my $quiet = 0;
  22 my $tree = 0;
  23 my $chk_signoff = 0;
  24 my $chk_patch = 1;
  25 my $tst_only;
  26 my $emacs = 0;
  27 my $terse = 0;
  28 my $file = 0;
  29 my $check = 0;
  30 my $summary = 1;
  31 my $mailback = 0;
  32 my $summary_file = 0;
  33 my $show_types = 0;
  34 my $root;
  35 my %debug;
  36 my %ignore_type = ();
  37 my @ignore = ();
  38 my $help = 0;
  39 my $configuration_file = ".checkpatch.conf";
  40
  41 sub help {
  42         my ($exitcode) = @_;
  43
  44         print << "EOM";
  45 Usage: $P [OPTION]... [FILE]...
  46 Version: $V
  47
  48 Options:
  49   -q, --quiet                quiet
  50   --no-tree                  run without a kernel tree
  51   --no-signoff               do not check for 'Signed-off-by' line
  52   --patch                    treat FILE as patchfile (default)
  53   --emacs                    emacs compile window format
  54   --terse                    one line per report
  55   -f, --file                 treat FILE as regular source file
  56   --subjective, --strict     enable more subjective tests
  57   --ignore TYPE(,TYPE2...)   ignore various comma separated message types
  58   --show-types               show the message "types" in the output
  59   --root=PATH                PATH to the kernel tree root
  60   --no-summary               suppress the per-file summary
  61   --mailback                 only produce a report in case of warnings/errors
  62   --summary-file             include the filename in summary
  63   --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
  64                              'values', 'possible', 'type', and 'attr' (default
  65                              is all off)
  66   --test-only=WORD           report only warnings/errors containing WORD
  67                              literally
  68   -h, --help, --version      display this help and exit
  69
  70 When FILE is - read standard input.
  71 EOM
  72
  73         exit($exitcode);
  74 }
  75
  76 my $conf = which_conf($configuration_file);
  77 if (-f $conf) {
  78         my @conf_args;
  79         open(my $conffile, '<', "$conf")
  80             or warn "$P: Can't find a readable $configuration_file file $!\n";
  81
  82         while (<$conffile>) {
  83                 my $line = $_;
  84
  85                 $line =~ s/\s*\n?$//g;
  86                 $line =~ s/^\s*//g;
  87                 $line =~ s/\s+/ /g;
  88
  89                 next if ($line =~ m/^\s*#/);
  90                 next if ($line =~ m/^\s*$/);
  91
  92                 my @words = split(" ", $line);
  93                 foreach my $word (@words) {
  94                         last if ($word =~ m/^#/);
  95                         push (@conf_args, $word);
  96                 }
  97         }
  98         close($conffile);
  99         unshift(@ARGV, @conf_args) if @conf_args;
 100 }
 101
 102 GetOptions(
 103         'q|quiet+'      => \$quiet,
 104         'tree!'         => \$tree,
 105         'signoff!'      => \$chk_signoff,
 106         'patch!'        => \$chk_patch,
 107         'emacs!'        => \$emacs,
 108         'terse!'        => \$terse,
 109         'f|file!'       => \$file,
 110         'subjective!'   => \$check,
 111         'strict!'       => \$check,
 112         'ignore=s'      => \@ignore,
 113         'show-types!'   => \$show_types,
 114         'root=s'        => \$root,
 115         'summary!'      => \$summary,
 116         'mailback!'     => \$mailback,
 117         'summary-file!' => \$summary_file,
 118
 119         'debug=s'       => \%debug,
 120         'test-only=s'   => \$tst_only,
 121         'h|help'        => \$help,
 122         'version'       => \$help
 123 ) or help(1);
 124
 125 help(0) if ($help);
 126
 127 my $exit = 0;
 128
 129 if ($#ARGV < 0) {
 130         print "$P: no input files\n";
 131         exit(1);
 132 }
 133
 134 @ignore = split(/,/, join(',',@ignore));
 135 foreach my $word (@ignore) {
 136         $word =~ s/\s*\n?$//g;
 137         $word =~ s/^\s*//g;
 138         $word =~ s/\s+/ /g;
 139         $word =~ tr/[a-z]/[A-Z]/;
 140
 141         next if ($word =~ m/^\s*#/);
 142         next if ($word =~ m/^\s*$/);
 143
 144         $ignore_type{$word}++;
 145 }
 146
 147 my $dbg_values = 0;
 148 my $dbg_possible = 0;
 149 my $dbg_type = 0;
 150 my $dbg_attr = 0;
 151 for my $key (keys %debug) {
 152         ## no critic
 153         eval "\${dbg_$key} = '$debug{$key}';";
 154         die "$@" if ($@);
 155 }
 156
 157 my $rpt_cleaners = 0;
 158
 159 if ($terse) {
 160         $emacs = 1;
 161         $quiet++;
 162 }
 163
 164 if ($tree) {
 165         if (defined $root) {
 166                 if (!top_of_kernel_tree($root)) {
 167                         die "$P: $root: --root does not point at a valid tree\n";
 168                 }
 169         } else {
 170                 if (top_of_kernel_tree('.')) {
 171                         $root = '.';
 172                 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
 173                                                 top_of_kernel_tree($1)) {
 174                         $root = $1;
 175                 }
 176         }
 177
 178         if (!defined $root) {
 179                 print "Must be run from the top-level dir. of a kernel tree\n";
 180                 exit(2);
 181         }
 182 }
 183
 184 my $emitted_corrupt = 0;
 185
 186 our $Ident      = qr{
 187                         [A-Za-z_][A-Za-z\d_]*
 188                         (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
 189                 }x;
 190 our $Storage    = qr{extern|static|asmlinkage};
 191 our $Sparse     = qr{
 192                         __user|
 193                         __kernel|
 194                         __force|
 195                         __iomem|
 196                         __must_check|
 197                         __init_refok|
 198                         __kprobes|
 199                         __ref|
 200                         __rcu
 201                 }x;
 202
 203 # Notes to $Attribute:
 204 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
 205 our $Attribute  = qr{
 206                         const|
 207                         __percpu|
 208                         __nocast|
 209                         __safe|
 210                         __bitwise__|
 211                         __packed__|
 212                         __packed2__|
 213                         __naked|
 214                         __maybe_unused|
 215                         __always_unused|
 216                         __noreturn|
 217                         __used|
 218                         __cold|
 219                         __noclone|
 220                         __deprecated|
 221                         __read_mostly|
 222                         __kprobes|
 223                         __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
 224                         ____cacheline_aligned|
 225                         ____cacheline_aligned_in_smp|
 226                         ____cacheline_internodealigned_in_smp|
 227                         __weak
 228                   }x;
 229 our $Modifier;
 230 our $Inline     = qr{inline|__always_inline|noinline};
 231 our $Member     = qr{->$Ident|\.$Ident|\[[^]]*\]};
 232 our $Lval       = qr{$Ident(?:$Member)*};
 233
 234 our $Constant   = qr{(?i:(?:[0-9]+|0x[0-9a-f]+)[ul]*)};
 235 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
 236 our $Compare    = qr{<=|>=|==|!=|<|>};
 237 our $Operators  = qr{
 238                         <=|>=|==|!=|
 239                         =>|->|<<|>>|<|>|!|~|
 240                         &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
 241                   }x;
 242
 243 our $NonptrType;
 244 our $Type;
 245 our $Declare;
 246
 247 our $NON_ASCII_UTF8     = qr{
 248         [\xC2-\xDF][\x80-\xBF]               # non-overlong 2-byte
 249         |  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
 250         | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
 251         |  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
 252         |  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
 253         | [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
 254         |  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
 255 }x;
 256
 257 our $UTF8       = qr{
 258         [\x09\x0A\x0D\x20-\x7E]              # ASCII
 259         | $NON_ASCII_UTF8
 260 }x;
 261
 262 our $typeTypedefs = qr{(?x:
 263         (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
 264         atomic_t
 265 )};
 266
 267 our $logFunctions = qr{(?x:
 268         printk(?:_ratelimited|_once|)|
 269         [a-z0-9]+_(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
 270         WARN(?:_RATELIMIT|_ONCE|)|
 271         panic|
 272         MODULE_[A-Z_]+
 273 )};
 274
 275 our $signature_tags = qr{(?xi:
 276         Signed-off-by:|
 277         Acked-by:|
 278         Tested-by:|
 279         Reviewed-by:|
 280         Reported-by:|
 281         To:|
 282         Cc:
 283 )};
 284
 285 our @typeList = (
 286         qr{void},
 287         qr{(?:unsigned\s+)?char},
 288         qr{(?:unsigned\s+)?short},
 289         qr{(?:unsigned\s+)?int},
 290         qr{(?:unsigned\s+)?long},
 291         qr{(?:unsigned\s+)?long\s+int},
 292         qr{(?:unsigned\s+)?long\s+long},
 293         qr{(?:unsigned\s+)?long\s+long\s+int},
 294         qr{unsigned},
 295         qr{float},
 296         qr{double},
 297         qr{bool},
 298         qr{struct\s+$Ident},
 299         qr{union\s+$Ident},
 300         qr{enum\s+$Ident},
 301         qr{${Ident}_t},
 302         qr{${Ident}_handler},
 303         qr{${Ident}_handler_fn},
 304 );
 305 our @modifierList = (
 306         qr{fastcall},
 307 );
 308
 309 our $allowed_asm_includes = qr{(?x:
 310         irq|
 311         memory
 312 )};
 313 # memory.h: ARM has a custom one
 314
 315 sub build_types {
 316         my $mods = "(?x:  \n" . join("|\n  ", @modifierList) . "\n)";
 317         my $all = "(?x:  \n" . join("|\n  ", @typeList) . "\n)";
 318         $Modifier       = qr{(?:$Attribute|$Sparse|$mods)};
 319         $NonptrType     = qr{
 320                         (?:$Modifier\s+|const\s+)*
 321                         (?:
 322                                 (?:typeof|__typeof__)\s*\([^\)]*\)|
 323                                 (?:$typeTypedefs\b)|
 324                                 (?:${all}\b)
 325                         )
 326                         (?:\s+$Modifier|\s+const)*
 327                   }x;
 328         $Type   = qr{
 329                         $NonptrType
 330                         (?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)?
 331                         (?:\s+$Inline|\s+$Modifier)*
 332                   }x;
 333         $Declare        = qr{(?:$Storage\s+)?$Type};
 334 }
 335 build_types();
 336
 337 our $match_balanced_parentheses = qr/(\((?:[^\(\)]+|(-1))*\))/;
 338
 339 our $Typecast   = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
 340 our $LvalOrFunc = qr{($Lval)\s*($match_balanced_parentheses{0,1})\s*};
 341 our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
 342
 343 sub deparenthesize {
 344         my ($string) = @_;
 345         return "" if (!defined($string));
 346         $string =~ s@^\s*\(\s*@@g;
 347         $string =~ s@\s*\)\s*$@@g;
 348         $string =~ s@\s+@ @g;
 349         return $string;
 350 }
 351
 352 $chk_signoff = 0 if ($file);
 353
 354 my %dep_includes = (
 355         'asm/types.h',                  'linux/types.h',
 356         'asm/uaccess.h',                'linux/uaccess.h',
 357 );
 358
 359 my %dep_functions = (
 360         'alloca',                       'malloc',
 361         'CFS_ATOMIC_INIT',              'ATOMIC_INIT',
 362         'cfs_atomic_add',               'atomic_add',
 363         'cfs_atomic_add_return',        'atomic_add_return',
 364         'cfs_atomic_add_unless',        'atomic_add_unless',
 365         'cfs_atomic_cmpxchg',           'atomic_cmpxchg',
 366         'cfs_atomic_dec',               'atomic_dec',
 367         'cfs_atomic_dec_and_lock',      'atomic_dec_and_lock',
 368         'cfs_atomic_dec_and_test',      'atomic_dec_and_test',
 369         'cfs_atomic_dec_return',        'atomic_dec_return',
 370         'cfs_atomic_inc',               'atomic_inc',
 371         'cfs_atomic_inc_and_test',      'atomic_inc_and_test',
 372         'cfs_atomic_inc_not_zero',      'atomic_inc_not_zero',
 373         'cfs_atomic_inc_return',        'atomic_inc_return',
 374         'cfs_atomic_read',              'atomic_read',
 375         'cfs_atomic_set',               'atomic_set',
 376         'cfs_atomic_sub',               'atomic_sub',
 377         'cfs_atomic_sub_and_test',      'atomic_sub_and_test',
 378         'cfs_atomic_sub_return',        'atomic_sub_return',
 379         'cfs_atomic_t',                 'atomic_t',
 380
 381         'CFS_HLIST_HEAD',               'HLIST_HEAD',
 382         'CFS_HLIST_HEAD_INIT',          'HLIST_HEAD_INIT',
 383         'CFS_INIT_HLIST_HEAD',          'INIT_HLIST_HEAD',
 384         'CFS_INIT_HLIST_NODE',          'INIT_HLIST_NODE',
 385         'cfs_hlist_add_after',          'hlist_add_after',
 386         'cfs_hlist_add_before',         'hlist_add_before',
 387         'cfs_hlist_add_head',           'hlist_add_head',
 388         'cfs_hlist_del',                'hlist_del',
 389         'cfs_hlist_del_init',           'hlist_del_init',
 390         'cfs_hlist_empty',              'hlist_empty',
 391         'cfs_hlist_entry',              'hlist_entry',
 392         'cfs_hlist_for_each',           'hlist_for_each',
 393         'cfs_hlist_for_each_safe',      'hlist_for_each_safe',
 394         'cfs_hlist_head_t',             'struct hlist_head',
 395         'cfs_hlist_node_t',             'struct hlist_node',
 396         'cfs_hlist_unhashed',           'hlist_unhashed',
 397
 398         'cfs_inode_t',                  'struct inode',
 399
 400         'CFS_INIT_LIST_HEAD',           'INIT_LIST_HEAD',
 401         'CFS_LIST_HEAD',                'struct list_head foo = LIST_HEAD_INIT(foo);',
 402         'CFS_LIST_HEAD_INIT',           'LIST_HEAD_INIT',
 403         'cfs_list_add',                 'list_add',
 404         'cfs_list_add_tail',            'list_add_tail',
 405         'cfs_list_del',                 'list_del',
 406         'cfs_list_del_init',            'list_del_init',
 407         'cfs_list_empty',               'list_empty',
 408         'cfs_list_empty_careful',       'list_empty_careful',
 409         'cfs_list_entry',               'list_entry',
 410         'cfs_list_for_each',            'list_for_each',
 411         'cfs_list_for_each_entry',      'list_for_each_entry',
 412         'cfs_list_for_each_entry_continue',
 413                                         'list_for_each_entry_continue',
 414         'cfs_list_for_each_entry_reverse',
 415                                         'list_for_each_entry_reverse',
 416         'cfs_list_for_each_entry_safe',
 417                                         'list_for_each_entry_safe',
 418         'cfs_list_for_each_entry_safe_from',
 419                                         'list_for_each_entry_safe_from',
 420         'cfs_list_for_each_entry_safe_reverse',
 421                                         'list_for_each_entry_safe_reverse',
 422         'cfs_list_for_each_entry_safe_typed',
 423                                         'list_for_each_entry_safe_typed',
 424         'cfs_list_for_each_entry_typed',
 425                                         'list_for_each_entry_typed',
 426         'cfs_list_for_each_prev',       'list_for_each_prev',
 427         'cfs_list_for_each_safe',       'list_for_each_safe',
 428         'cfs_list_move',                'list_move',
 429         'cfs_list_move_tail',           'list_move_tail',
 430         'cfs_list_splice',              'list_splice',
 431         'cfs_list_splice_init',         'list_splice_init',
 432         'cfs_list_splice_tail',         'list_splice_tail',
 433         'cfs_list_t',                   'struct list_head',
 434
 435         'CFS_PAGE_MASK',                'PAGE_CACHE_MASK or PAGE_MASK',
 436         'CFS_PAGE_SIZE',                'PAGE_CACHE_SIZE or PAGE_SIZE',
 437
 438         'cfs_proc_dir_entry_t',         'struct proc_dir_entry',
 439
 440         'cfs_rcu_head_t',               'struct rcu_head',
 441
 442         'cfs_hash_lock_t',              'union cfs_hash_lock',
 443         'cfs_hash_bucket_t',            'struct cfs_hash_bucket',
 444         'cfs_hash_bd_t',                'struct cfs_hash_bd',
 445         'cfs_hash_t',                   'struct cfs_hash',
 446         'cfs_hash_lock_ops_t',          'struct cfs_hash_lock_ops',
 447         'cfs_hash_hlist_ops_t',         'struct cfs_hash_hlist_ops',
 448         'cfs_hash_ops_t',               'struct cfs_hash_ops',
 449         'cfs_hash_head_t',              'struct cfs_hash_head',
 450         'cfs_hash_head_dep_t',          'struct cfs_hash_head_dep',
 451         'cfs_hash_dhead_t',             'struct cfs_hash_dhead',
 452         'cfs_hash_dhead_dep_t',         'struct cfs_hash_dhead_dep',
 453         'cfs_hash_lookup_intent_t',     'enum cfs_hash_lookup_intent',
 454         'cfs_hash_cond_arg_t',          'struct cfs_hash_cond_arg',
 455
 456         'ldlm_appetite_t',              'enum ldlm_appetite',
 457         'ldlm_cancel_flags_t',          'enum ldlm_cancel_flags',
 458         'ldlm_error_t',                 'enum ldlm_error',
 459         'ldlm_ns_hash_def_t',           'struct ldlm_ns_hash_def',
 460         'ldlm_mode_t',                  'enum ldlm_mode',
 461         'ldlm_ns_type_t',               'enum ldlm_ns_type',
 462         'ldlm_policy_data_t',           'enum ldlm_policy_data',
 463         'ldlm_policy_res_t',            'enum ldlm_policy_res',
 464         'ldlm_side_t',                  'enum ldlm_side',
 465         'ldlm_type_t',                  'enum ldlm_type',
 466         'ldlm_wire_policy_data_t',      'union ldlm_wire_policy_data',
 467
 468         'LPROCFS',                      'CONFIG_PROC_FS',
 469         'mktemp',                       'mkstemp',
 470         'sprintf',                      'snprintf',
 471         'strcpy',                       'strncpy',
 472         'strcat',                       'strncat',
 473         'tempnam',                      'mkstemp',
 474         'OBD_FREE_LARGE',               'OBD_FREE',
 475         'f_dentry',                     'f_path.dentry',
 476 );
 477
 478 my @rawlines = ();
 479 my @lines = ();
 480 my $vname;
 481 for my $filename (@ARGV) {
 482         my $FILE;
 483         if ($file) {
 484                 open($FILE, '-|', "diff -u /dev/null $filename") ||
 485                         die "$P: $filename: diff failed - $!\n";
 486         } elsif ($filename eq '-') {
 487                 open($FILE, '<&STDIN');
 488         } else {
 489                 open($FILE, '<', "$filename") ||
 490                         die "$P: $filename: open failed - $!\n";
 491         }
 492         if ($filename eq '-') {
 493                 $vname = 'Your patch';
 494         } else {
 495                 $vname = $filename;
 496         }
 497         while (<$FILE>) {
 498                 chomp;
 499                 push(@rawlines, $_);
 500         }
 501         close($FILE);
 502         if (!process($filename)) {
 503                 $exit = 1;
 504         }
 505         @rawlines = ();
 506         @lines = ();
 507 }
 508
 509 exit($exit);
 510
 511 sub top_of_kernel_tree {
 512         my ($root) = @_;
 513
 514         my @tree_check = (
 515                 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
 516                 "README", "Documentation", "arch", "include", "drivers",
 517                 "fs", "init", "ipc", "kernel", "lib", "scripts",
 518         );
 519
 520         foreach my $check (@tree_check) {
 521                 if (! -e $root . '/' . $check) {
 522                         return 0;
 523                 }
 524         }
 525         return 1;
 526     }
 527
 528 sub parse_email {
 529         my ($formatted_email) = @_;
 530
 531         my $name = "";
 532         my $address = "";
 533         my $comment = "";
 534
 535         if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
 536                 $name = $1;
 537                 $address = $2;
 538                 $comment = $3 if defined $3;
 539         } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
 540                 $address = $1;
 541                 $comment = $2 if defined $2;
 542         } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
 543                 $address = $1;
 544                 $comment = $2 if defined $2;
 545                 $formatted_email =~ s/$address.*$//;
 546                 $name = $formatted_email;
 547                 $name =~ s/^\s+|\s+$//g;
 548                 $name =~ s/^\"|\"$//g;
 549                 # If there's a name left after stripping spaces and
 550                 # leading quotes, and the address doesn't have both
 551                 # leading and trailing angle brackets, the address
 552                 # is invalid. ie:
 553                 #   "joe smith joe@smith.com" bad
 554                 #   "joe smith <joe@smith.com" bad
 555                 if ($name ne "" && $address !~ /^<[^>]+>$/) {
 556                         $name = "";
 557                         $address = "";
 558                         $comment = "";
 559                 }
 560         }
 561
 562         $name =~ s/^\s+|\s+$//g;
 563         $name =~ s/^\"|\"$//g;
 564         $address =~ s/^\s+|\s+$//g;
 565         $address =~ s/^\<|\>$//g;
 566
 567         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
 568                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
 569                 $name = "\"$name\"";
 570         }
 571
 572         return ($name, $address, $comment);
 573 }
 574
 575 sub format_email {
 576         my ($name, $address) = @_;
 577
 578         my $formatted_email;
 579
 580         $name =~ s/^\s+|\s+$//g;
 581         $name =~ s/^\"|\"$//g;
 582         $address =~ s/^\s+|\s+$//g;
 583
 584         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
 585                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
 586                 $name = "\"$name\"";
 587         }
 588
 589         if ("$name" eq "") {
 590                 $formatted_email = "$address";
 591         } else {
 592                 $formatted_email = "$name <$address>";
 593         }
 594
 595         return $formatted_email;
 596 }
 597
 598 sub which_conf {
 599         my ($conf) = @_;
 600
 601         foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
 602                 if (-e "$path/$conf") {
 603                         return "$path/$conf";
 604                 }
 605         }
 606
 607         return "";
 608 }
 609
 610 sub expand_tabs {
 611         my ($str) = @_;
 612
 613         my $res = '';
 614         my $n = 0;
 615         for my $c (split(//, $str)) {
 616                 if ($c eq "\t") {
 617                         $res .= ' ';
 618                         $n++;
 619                         for (; ($n % 8) != 0; $n++) {
 620                                 $res .= ' ';
 621                         }
 622                         next;
 623                 }
 624                 $res .= $c;
 625                 $n++;
 626         }
 627
 628         return $res;
 629 }
 630 sub copy_spacing {
 631         (my $res = shift) =~ tr/\t/ /c;
 632         return $res;
 633 }
 634
 635 sub line_stats {
 636         my ($line) = @_;
 637
 638         # Drop the diff line leader and expand tabs
 639         $line =~ s/^.//;
 640         $line = expand_tabs($line);
 641
 642         # Pick the indent from the front of the line.
 643         my ($white) = ($line =~ /^(\s*)/);
 644
 645         return (length($line), length($white));
 646 }
 647
 648 my $sanitise_quote = '';
 649
 650 sub sanitise_line_reset {
 651         my ($in_comment) = @_;
 652
 653         if ($in_comment) {
 654                 $sanitise_quote = '*/';
 655         } else {
 656                 $sanitise_quote = '';
 657         }
 658 }
 659 sub sanitise_line {
 660         my ($line) = @_;
 661
 662         my $res = '';
 663         my $l = '';
 664
 665         my $qlen = 0;
 666         my $off = 0;
 667         my $c;
 668
 669         # Always copy over the diff marker.
 670         $res = substr($line, 0, 1);
 671
 672         for ($off = 1; $off < length($line); $off++) {
 673                 $c = substr($line, $off, 1);
 674
 675                 # Comments we are wacking completly including the begin
 676                 # and end, all to $;.
 677                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
 678                         $sanitise_quote = '*/';
 679
 680                         substr($res, $off, 2, "$;$;");
 681                         $off++;
 682                         next;
 683                 }
 684                 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
 685                         $sanitise_quote = '';
 686                         substr($res, $off, 2, "$;$;");
 687                         $off++;
 688                         next;
 689                 }
 690                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
 691                         $sanitise_quote = '//';
 692
 693                         substr($res, $off, 2, $sanitise_quote);
 694                         $off++;
 695                         next;
 696                 }
 697
 698                 # A \ in a string means ignore the next character.
 699                 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
 700                     $c eq "\\") {
 701                         substr($res, $off, 2, 'XX');
 702                         $off++;
 703                         next;
 704                 }
 705                 # Regular quotes.
 706                 if ($c eq "'" || $c eq '"') {
 707                         if ($sanitise_quote eq '') {
 708                                 $sanitise_quote = $c;
 709
 710                                 substr($res, $off, 1, $c);
 711                                 next;
 712                         } elsif ($sanitise_quote eq $c) {
 713                                 $sanitise_quote = '';
 714                         }
 715                 }
 716
 717                 #print "c<$c> SQ<$sanitise_quote>\n";
 718                 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
 719                         substr($res, $off, 1, $;);
 720                 } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
 721                         substr($res, $off, 1, $;);
 722                 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
 723                         substr($res, $off, 1, 'X');
 724                 } else {
 725                         substr($res, $off, 1, $c);
 726                 }
 727         }
 728
 729         if ($sanitise_quote eq '//') {
 730                 $sanitise_quote = '';
 731         }
 732
 733         # The pathname on a #include may be surrounded by '<' and '>'.
 734         if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
 735                 my $clean = 'X' x length($1);
 736                 $res =~ s@\<.*\>@<$clean>@;
 737
 738         # The whole of a #error is a string.
 739         } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
 740                 my $clean = 'X' x length($1);
 741                 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
 742         }
 743
 744         return $res;
 745 }
 746
 747 sub ctx_statement_block {
 748         my ($linenr, $remain, $off) = @_;
 749         my $line = $linenr - 1;
 750         my $blk = '';
 751         my $soff = $off;
 752         my $coff = $off - 1;
 753         my $coff_set = 0;
 754
 755         my $loff = 0;
 756
 757         my $type = '';
 758         my $level = 0;
 759         my @stack = ();
 760         my $p;
 761         my $c;
 762         my $len = 0;
 763
 764         my $remainder;
 765         while (1) {
 766                 @stack = (['', 0]) if ($#stack == -1);
 767
 768                 #warn "CSB: blk<$blk> remain<$remain>\n";
 769                 # If we are about to drop off the end, pull in more
 770                 # context.
 771                 if ($off >= $len) {
 772                         for (; $remain > 0; $line++) {
 773                                 last if (!defined $lines[$line]);
 774                                 next if ($lines[$line] =~ /^-/);
 775                                 $remain--;
 776                                 $loff = $len;
 777                                 $blk .= $lines[$line] . "\n";
 778                                 $len = length($blk);
 779                                 $line++;
 780                                 last;
 781                         }
 782                         # Bail if there is no further context.
 783                         #warn "CSB: blk<$blk> off<$off> len<$len>\n";
 784                         if ($off >= $len) {
 785                                 last;
 786                         }
 787                         if ($level == 0 && substr($blk, $off) =~ /^.\s*#\s*define/) {
 788                                 $level++;
 789                                 $type = '#';
 790                         }
 791                 }
 792                 $p = $c;
 793                 $c = substr($blk, $off, 1);
 794                 $remainder = substr($blk, $off);
 795
 796                 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
 797
 798                 # Handle nested #if/#else.
 799                 if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
 800                         push(@stack, [ $type, $level ]);
 801                 } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
 802                         ($type, $level) = @{$stack[$#stack - 1]};
 803                 } elsif ($remainder =~ /^#\s*endif\b/) {
 804                         ($type, $level) = @{pop(@stack)};
 805                 }
 806
 807                 # Statement ends at the ';' or a close '}' at the
 808                 # outermost level.
 809                 if ($level == 0 && $c eq ';') {
 810                         last;
 811                 }
 812
 813                 # An else is really a conditional as long as its not else if
 814                 if ($level == 0 && $coff_set == 0 &&
 815                                 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
 816                                 $remainder =~ /^(else)(?:\s|{)/ &&
 817                                 $remainder !~ /^else\s+if\b/) {
 818                         $coff = $off + length($1) - 1;
 819                         $coff_set = 1;
 820                         #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
 821                         #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
 822                 }
 823
 824                 if (($type eq '' || $type eq '(') && $c eq '(') {
 825                         $level++;
 826                         $type = '(';
 827                 }
 828                 if ($type eq '(' && $c eq ')') {
 829                         $level--;
 830                         $type = ($level != 0)? '(' : '';
 831
 832                         if ($level == 0 && $coff < $soff) {
 833                                 $coff = $off;
 834                                 $coff_set = 1;
 835                                 #warn "CSB: mark coff<$coff>\n";
 836                         }
 837                 }
 838                 if (($type eq '' || $type eq '{') && $c eq '{') {
 839                         $level++;
 840                         $type = '{';
 841                 }
 842                 if ($type eq '{' && $c eq '}') {
 843                         $level--;
 844                         $type = ($level != 0)? '{' : '';
 845
 846                         if ($level == 0) {
 847                                 if (substr($blk, $off + 1, 1) eq ';') {
 848                                         $off++;
 849                                 }
 850                                 last;
 851                         }
 852                 }
 853                 # Preprocessor commands end at the newline unless escaped.
 854                 if ($type eq '#' && $c eq "\n" && $p ne "\\") {
 855                         $level--;
 856                         $type = '';
 857                         $off++;
 858                         last;
 859                 }
 860                 $off++;
 861         }
 862         # We are truly at the end, so shuffle to the next line.
 863         if ($off == $len) {
 864                 $loff = $len + 1;
 865                 $line++;
 866                 $remain--;
 867         }
 868
 869         my $statement = substr($blk, $soff, $off - $soff + 1);
 870         my $condition = substr($blk, $soff, $coff - $soff + 1);
 871
 872         #warn "STATEMENT<$statement>\n";
 873         #warn "CONDITION<$condition>\n";
 874
 875         #print "coff<$coff> soff<$off> loff<$loff>\n";
 876
 877         return ($statement, $condition,
 878                         $line, $remain + 1, $off - $loff + 1, $level);
 879 }
 880
 881 sub statement_lines {
 882         my ($stmt) = @_;
 883
 884         # Strip the diff line prefixes and rip blank lines at start and end.
 885         $stmt =~ s/(^|\n)./$1/g;
 886         $stmt =~ s/^\s*//;
 887         $stmt =~ s/\s*$//;
 888
 889         my @stmt_lines = ($stmt =~ /\n/g);
 890
 891         return $#stmt_lines + 2;
 892 }
 893
 894 sub statement_rawlines {
 895         my ($stmt) = @_;
 896
 897         my @stmt_lines = ($stmt =~ /\n/g);
 898
 899         return $#stmt_lines + 2;
 900 }
 901
 902 sub statement_block_size {
 903         my ($stmt) = @_;
 904
 905         $stmt =~ s/(^|\n)./$1/g;
 906         $stmt =~ s/^\s*{//;
 907         $stmt =~ s/}\s*$//;
 908         $stmt =~ s/^\s*//;
 909         $stmt =~ s/\s*$//;
 910
 911         my @stmt_lines = ($stmt =~ /\n/g);
 912         my @stmt_statements = ($stmt =~ /;/g);
 913
 914         my $stmt_lines = $#stmt_lines + 2;
 915         my $stmt_statements = $#stmt_statements + 1;
 916
 917         if ($stmt_lines > $stmt_statements) {
 918                 return $stmt_lines;
 919         } else {
 920                 return $stmt_statements;
 921         }
 922 }
 923
 924 sub ctx_statement_full {
 925         my ($linenr, $remain, $off) = @_;
 926         my ($statement, $condition, $level);
 927
 928         my (@chunks);
 929
 930         # Grab the first conditional/block pair.
 931         ($statement, $condition, $linenr, $remain, $off, $level) =
 932                                 ctx_statement_block($linenr, $remain, $off);
 933         #print "F: c<$condition> s<$statement> remain<$remain>\n";
 934         push(@chunks, [ $condition, $statement ]);
 935         if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
 936                 return ($level, $linenr, @chunks);
 937         }
 938
 939         # Pull in the following conditional/block pairs and see if they
 940         # could continue the statement.
 941         for (;;) {
 942                 ($statement, $condition, $linenr, $remain, $off, $level) =
 943                                 ctx_statement_block($linenr, $remain, $off);
 944                 #print "C: c<$condition> s<$statement> remain<$remain>\n";
 945                 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
 946                 #print "C: push\n";
 947                 push(@chunks, [ $condition, $statement ]);
 948         }
 949
 950         return ($level, $linenr, @chunks);
 951 }
 952
 953 sub ctx_block_get {
 954         my ($linenr, $remain, $outer, $open, $close, $off) = @_;
 955         my $line;
 956         my $start = $linenr - 1;
 957         my $blk = '';
 958         my @o;
 959         my @c;
 960         my @res = ();
 961
 962         my $level = 0;
 963         my @stack = ($level);
 964         for ($line = $start; $remain > 0; $line++) {
 965                 next if ($rawlines[$line] =~ /^-/);
 966                 $remain--;
 967
 968                 $blk .= $rawlines[$line];
 969
 970                 # Handle nested #if/#else.
 971                 if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
 972                         push(@stack, $level);
 973                 } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
 974                         $level = $stack[$#stack - 1];
 975                 } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
 976                         $level = pop(@stack);
 977                 }
 978
 979                 foreach my $c (split(//, $lines[$line])) {
 980                         ##print "C<$c>L<$level><$open$close>O<$off>\n";
 981                         if ($off > 0) {
 982                                 $off--;
 983                                 next;
 984                         }
 985
 986                         if ($c eq $close && $level > 0) {
 987                                 $level--;
 988                                 last if ($level == 0);
 989                         } elsif ($c eq $open) {
 990                                 $level++;
 991                         }
 992                 }
 993
 994                 if (!$outer || $level <= 1) {
 995                         push(@res, $rawlines[$line]);
 996                 }
 997
 998                 last if ($level == 0);
 999         }
1000
1001         return ($level, @res);
1002 }
1003 sub ctx_block_outer {
1004         my ($linenr, $remain) = @_;
1005
1006         my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
1007         return @r;
1008 }
1009 sub ctx_block {
1010         my ($linenr, $remain) = @_;
1011
1012         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
1013         return @r;
1014 }
1015 sub ctx_statement {
1016         my ($linenr, $remain, $off) = @_;
1017
1018         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
1019         return @r;
1020 }
1021 sub ctx_block_level {
1022         my ($linenr, $remain) = @_;
1023
1024         return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
1025 }
1026 sub ctx_statement_level {
1027         my ($linenr, $remain, $off) = @_;
1028
1029         return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
1030 }
1031
1032 sub ctx_locate_comment {
1033         my ($first_line, $end_line) = @_;
1034
1035         # Catch a comment on the end of the line itself.
1036         my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
1037         return $current_comment if (defined $current_comment);
1038
1039         # Look through the context and try and figure out if there is a
1040         # comment.
1041         my $in_comment = 0;
1042         $current_comment = '';
1043         for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
1044                 my $line = $rawlines[$linenr - 1];
1045                 #warn "           $line\n";
1046                 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
1047                         $in_comment = 1;
1048                 }
1049                 if ($line =~ m@/\*@) {
1050                         $in_comment = 1;
1051                 }
1052                 if (!$in_comment && $current_comment ne '') {
1053                         $current_comment = '';
1054                 }
1055                 $current_comment .= $line . "\n" if ($in_comment);
1056                 if ($line =~ m@\*/@) {
1057                         $in_comment = 0;
1058                 }
1059         }
1060
1061         chomp($current_comment);
1062         return($current_comment);
1063 }
1064 sub ctx_has_comment {
1065         my ($first_line, $end_line) = @_;
1066         my $cmt = ctx_locate_comment($first_line, $end_line);
1067
1068         ##print "LINE: $rawlines[$end_line - 1 ]\n";
1069         ##print "CMMT: $cmt\n";
1070
1071         return ($cmt ne '');
1072 }
1073
1074 sub raw_line {
1075         my ($linenr, $cnt) = @_;
1076
1077         my $offset = $linenr - 1;
1078         $cnt++;
1079
1080         my $line;
1081         while ($cnt) {
1082                 $line = $rawlines[$offset++];
1083                 next if (defined($line) && $line =~ /^-/);
1084                 $cnt--;
1085         }
1086
1087         return $line;
1088 }
1089
1090 sub cat_vet {
1091         my ($vet) = @_;
1092         my ($res, $coded);
1093
1094         $res = '';
1095         while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
1096                 $res .= $1;
1097                 if ($2 ne '') {
1098                         $coded = sprintf("^%c", unpack('C', $2) + 64);
1099                         $res .= $coded;
1100                 }
1101         }
1102         $res =~ s/$/\$/;
1103
1104         return $res;
1105 }
1106
1107 my $av_preprocessor = 0;
1108 my $av_pending;
1109 my @av_paren_type;
1110 my $av_pend_colon;
1111
1112 sub annotate_reset {
1113         $av_preprocessor = 0;
1114         $av_pending = '_';
1115         @av_paren_type = ('E');
1116         $av_pend_colon = 'O';
1117 }
1118
1119 sub annotate_values {
1120         my ($stream, $type) = @_;
1121
1122         my $res;
1123         my $var = '_' x length($stream);
1124         my $cur = $stream;
1125
1126         print "$stream\n" if ($dbg_values > 1);
1127
1128         while (length($cur)) {
1129                 @av_paren_type = ('E') if ($#av_paren_type < 0);
1130                 print " <" . join('', @av_paren_type) .
1131                                 "> <$type> <$av_pending>" if ($dbg_values > 1);
1132                 if ($cur =~ /^(\s+)/o) {
1133                         print "WS($1)\n" if ($dbg_values > 1);
1134                         if ($1 =~ /\n/ && $av_preprocessor) {
1135                                 $type = pop(@av_paren_type);
1136                                 $av_preprocessor = 0;
1137                         }
1138
1139                 } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
1140                         print "CAST($1)\n" if ($dbg_values > 1);
1141                         push(@av_paren_type, $type);
1142                         $type = 'c';
1143
1144                 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
1145                         print "DECLARE($1)\n" if ($dbg_values > 1);
1146                         $type = 'T';
1147
1148                 } elsif ($cur =~ /^($Modifier)\s*/) {
1149                         print "MODIFIER($1)\n" if ($dbg_values > 1);
1150                         $type = 'T';
1151
1152                 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
1153                         print "DEFINE($1,$2)\n" if ($dbg_values > 1);
1154                         $av_preprocessor = 1;
1155                         push(@av_paren_type, $type);
1156                         if ($2 ne '') {
1157                                 $av_pending = 'N';
1158                         }
1159                         $type = 'E';
1160
1161                 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
1162                         print "UNDEF($1)\n" if ($dbg_values > 1);
1163                         $av_preprocessor = 1;
1164                         push(@av_paren_type, $type);
1165
1166                 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
1167                         print "PRE_START($1)\n" if ($dbg_values > 1);
1168                         $av_preprocessor = 1;
1169
1170                         push(@av_paren_type, $type);
1171                         push(@av_paren_type, $type);
1172                         $type = 'E';
1173
1174                 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
1175                         print "PRE_RESTART($1)\n" if ($dbg_values > 1);
1176                         $av_preprocessor = 1;
1177
1178                         push(@av_paren_type, $av_paren_type[$#av_paren_type]);
1179
1180                         $type = 'E';
1181
1182                 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
1183                         print "PRE_END($1)\n" if ($dbg_values > 1);
1184
1185                         $av_preprocessor = 1;
1186
1187                         # Assume all arms of the conditional end as this
1188                         # one does, and continue as if the #endif was not here.
1189                         pop(@av_paren_type);
1190                         push(@av_paren_type, $type);
1191                         $type = 'E';
1192
1193                 } elsif ($cur =~ /^(\\\n)/o) {
1194                         print "PRECONT($1)\n" if ($dbg_values > 1);
1195
1196                 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
1197                         print "ATTR($1)\n" if ($dbg_values > 1);
1198                         $av_pending = $type;
1199                         $type = 'N';
1200
1201                 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
1202                         print "SIZEOF($1)\n" if ($dbg_values > 1);
1203                         if (defined $2) {
1204                                 $av_pending = 'V';
1205                         }
1206                         $type = 'N';
1207
1208                 } elsif ($cur =~ /^(if|while|for)\b/o) {
1209                         print "COND($1)\n" if ($dbg_values > 1);
1210                         $av_pending = 'E';
1211                         $type = 'N';
1212
1213                 } elsif ($cur =~/^(case)/o) {
1214                         print "CASE($1)\n" if ($dbg_values > 1);
1215                         $av_pend_colon = 'C';
1216                         $type = 'N';
1217
1218                 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
1219                         print "KEYWORD($1)\n" if ($dbg_values > 1);
1220                         $type = 'N';
1221
1222                 } elsif ($cur =~ /^(\()/o) {
1223                         print "PAREN('$1')\n" if ($dbg_values > 1);
1224                         push(@av_paren_type, $av_pending);
1225                         $av_pending = '_';
1226                         $type = 'N';
1227
1228                 } elsif ($cur =~ /^(\))/o) {
1229                         my $new_type = pop(@av_paren_type);
1230                         if ($new_type ne '_') {
1231                                 $type = $new_type;
1232                                 print "PAREN('$1') -> $type\n"
1233                                                         if ($dbg_values > 1);
1234                         } else {
1235                                 print "PAREN('$1')\n" if ($dbg_values > 1);
1236                         }
1237
1238                 } elsif ($cur =~ /^($Ident)\s*\(/o) {
1239                         print "FUNC($1)\n" if ($dbg_values > 1);
1240                         $type = 'V';
1241                         $av_pending = 'V';
1242
1243                 } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
1244                         if (defined $2 && $type eq 'C' || $type eq 'T') {
1245                                 $av_pend_colon = 'B';
1246                         } elsif ($type eq 'E') {
1247                                 $av_pend_colon = 'L';
1248                         }
1249                         print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
1250                         $type = 'V';
1251
1252                 } elsif ($cur =~ /^($Ident|$Constant)/o) {
1253                         print "IDENT($1)\n" if ($dbg_values > 1);
1254                         $type = 'V';
1255
1256                 } elsif ($cur =~ /^($Assignment)/o) {
1257                         print "ASSIGN($1)\n" if ($dbg_values > 1);
1258                         $type = 'N';
1259
1260                 } elsif ($cur =~/^(;|{|})/) {
1261                         print "END($1)\n" if ($dbg_values > 1);
1262                         $type = 'E';
1263                         $av_pend_colon = 'O';
1264
1265                 } elsif ($cur =~/^(,)/) {
1266                         print "COMMA($1)\n" if ($dbg_values > 1);
1267                         $type = 'C';
1268
1269                 } elsif ($cur =~ /^(\?)/o) {
1270                         print "QUESTION($1)\n" if ($dbg_values > 1);
1271                         $type = 'N';
1272
1273                 } elsif ($cur =~ /^(:)/o) {
1274                         print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
1275
1276                         substr($var, length($res), 1, $av_pend_colon);
1277                         if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
1278                                 $type = 'E';
1279                         } else {
1280                                 $type = 'N';
1281                         }
1282                         $av_pend_colon = 'O';
1283
1284                 } elsif ($cur =~ /^(\[)/o) {
1285                         print "CLOSE($1)\n" if ($dbg_values > 1);
1286                         $type = 'N';
1287
1288                 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1289                         my $variant;
1290
1291                         print "OPV($1)\n" if ($dbg_values > 1);
1292                         if ($type eq 'V') {
1293                                 $variant = 'B';
1294                         } else {
1295                                 $variant = 'U';
1296                         }
1297
1298                         substr($var, length($res), 1, $variant);
1299                         $type = 'N';
1300
1301                 } elsif ($cur =~ /^($Operators)/o) {
1302                         print "OP($1)\n" if ($dbg_values > 1);
1303                         if ($1 ne '++' && $1 ne '--') {
1304                                 $type = 'N';
1305                         }
1306
1307                 } elsif ($cur =~ /(^.)/o) {
1308                         print "C($1)\n" if ($dbg_values > 1);
1309                 }
1310                 if (defined $1) {
1311                         $cur = substr($cur, length($1));
1312                         $res .= $type x length($1);
1313                 }
1314         }
1315
1316         return ($res, $var);
1317 }
1318
1319 sub possible {
1320         my ($possible, $line) = @_;
1321         my $notPermitted = qr{(?:
1322                 ^(?:
1323                         $Modifier|
1324                         $Storage|
1325                         $Type|
1326                         DEFINE_\S+
1327                 )$|
1328                 ^(?:
1329                         goto|
1330                         return|
1331                         case|
1332                         else|
1333                         asm|__asm__|
1334                         do|
1335                         \#|
1336                         \#\#|
1337                 )(?:\s|$)|
1338                 ^(?:typedef|struct|enum)\b
1339             )}x;
1340         warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1341         if ($possible !~ $notPermitted) {
1342                 # Check for modifiers.
1343                 $possible =~ s/\s*$Storage\s*//g;
1344                 $possible =~ s/\s*$Sparse\s*//g;
1345                 if ($possible =~ /^\s*$/) {
1346
1347                 } elsif ($possible =~ /\s/) {
1348                         $possible =~ s/\s*$Type\s*//g;
1349                         for my $modifier (split(' ', $possible)) {
1350                                 if ($modifier !~ $notPermitted) {
1351                                         warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1352                                         push(@modifierList, $modifier);
1353                                 }
1354                         }
1355
1356                 } else {
1357                         warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1358                         push(@typeList, $possible);
1359                 }
1360                 build_types();
1361         } else {
1362                 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
1363         }
1364 }
1365
1366 my $prefix = '';
1367
1368 sub show_type {
1369        return !defined $ignore_type{$_[0]};
1370 }
1371
1372 sub report {
1373         if (!show_type($_[1]) ||
1374             (defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) {
1375                 return 0;
1376         }
1377         my $line;
1378         if ($show_types) {
1379                 $line = "$prefix$_[0]:$_[1]: $_[2]\n";
1380         } else {
1381                 $line = "$prefix$_[0]: $_[2]\n";
1382         }
1383         $line = (split('\n', $line))[0] . "\n" if ($terse);
1384
1385         push(our @report, $line);
1386
1387         return 1;
1388 }
1389 sub report_dump {
1390         our @report;
1391 }
1392
1393 sub ERROR {
1394         if (report("ERROR", $_[0], $_[1])) {
1395                 our $clean = 0;
1396                 our $cnt_error++;
1397         }
1398 }
1399 sub WARN {
1400         if (report("WARNING", $_[0], $_[1])) {
1401                 our $clean = 0;
1402                 our $cnt_warn++;
1403         }
1404 }
1405 sub CHK {
1406         if ($check && report("CHECK", $_[0], $_[1])) {
1407                 our $clean = 0;
1408                 our $cnt_chk++;
1409         }
1410 }
1411
1412 sub check_absolute_file {
1413         my ($absolute, $herecurr) = @_;
1414         my $file = $absolute;
1415
1416         ##print "absolute<$absolute>\n";
1417
1418         # See if any suffix of this path is a path within the tree.
1419         while ($file =~ s@^[^/]*/@@) {
1420                 if (-f "$root/$file") {
1421                         ##print "file<$file>\n";
1422                         last;
1423                 }
1424         }
1425         if (! -f _)  {
1426                 return 0;
1427         }
1428
1429         # It is, so see if the prefix is acceptable.
1430         my $prefix = $absolute;
1431         substr($prefix, -length($file)) = '';
1432
1433         ##print "prefix<$prefix>\n";
1434         if ($prefix ne ".../") {
1435                 WARN("USE_RELATIVE_PATH",
1436                      "use relative pathname instead of absolute in changelog text\n" . $herecurr);
1437         }
1438 }
1439
1440 sub process {
1441         my $filename = shift;
1442
1443         my $linenr=0;
1444         my $prevline="";
1445         my $prevrawline="";
1446         my $stashline="";
1447         my $stashrawline="";
1448
1449         my $length;
1450         my $indent;
1451         my $previndent=0;
1452         my $stashindent=0;
1453
1454         our $clean = 1;
1455         my $signoff = 0;
1456         my $is_patch = 0;
1457
1458         my $in_header_lines = 1;
1459         my $in_commit_log = 0;          #Scanning lines before patch
1460
1461         our @report = ();
1462         our $cnt_lines = 0;
1463         our $cnt_error = 0;
1464         our $cnt_warn = 0;
1465         our $cnt_chk = 0;
1466
1467         # Trace the real file/line as we go.
1468         my $realfile = '';
1469         my $realline = 0;
1470         my $realcnt = 0;
1471         my $here = '';
1472         my $in_comment = 0;
1473         my $comment_edge = 0;
1474         my $first_line = 0;
1475         my $p1_prefix = '';
1476
1477         my $prev_values = 'E';
1478
1479         # suppression flags
1480         my %suppress_ifbraces;
1481         my %suppress_whiletrailers;
1482         my %suppress_export;
1483         my $suppress_statement = 0;
1484
1485         # Pre-scan the patch sanitizing the lines.
1486         # Pre-scan the patch looking for any __setup documentation.
1487         #
1488         my @setup_docs = ();
1489         my $setup_docs = 0;
1490
1491         sanitise_line_reset();
1492         my $line;
1493         foreach my $rawline (@rawlines) {
1494                 $linenr++;
1495                 $line = $rawline;
1496
1497                 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1498                         $setup_docs = 0;
1499                         if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1500                                 $setup_docs = 1;
1501                         }
1502                         #next;
1503                 }
1504                 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1505                         $realline=$1-1;
1506                         if (defined $2) {
1507                                 $realcnt=$3+1;
1508                         } else {
1509                                 $realcnt=1+1;
1510                         }
1511                         $in_comment = 0;
1512
1513                         # Guestimate if this is a continuing comment.  Run
1514                         # the context looking for a comment "edge".  If this
1515                         # edge is a close comment then we must be in a comment
1516                         # at context start.
1517                         my $edge;
1518                         my $cnt = $realcnt;
1519                         for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1520                                 next if (defined $rawlines[$ln - 1] &&
1521                                          $rawlines[$ln - 1] =~ /^-/);
1522                                 $cnt--;
1523                                 #print "RAW<$rawlines[$ln - 1]>\n";
1524                                 last if (!defined $rawlines[$ln - 1]);
1525                                 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1526                                     $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1527                                         ($edge) = $1;
1528                                         last;
1529                                 }
1530                         }
1531                         if (defined $edge && $edge eq '*/') {
1532                                 $in_comment = 1;
1533                         }
1534
1535                         # Guestimate if this is a continuing comment.  If this
1536                         # is the start of a diff block and this line starts
1537                         # ' *' then it is very likely a comment.
1538                         if (!defined $edge &&
1539                             $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
1540                         {
1541                                 $in_comment = 1;
1542                         }
1543
1544                         ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1545                         sanitise_line_reset($in_comment);
1546
1547                 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1548                         # Standardise the strings and chars within the input to
1549                         # simplify matching -- only bother with positive lines.
1550                         $line = sanitise_line($rawline);
1551                 }
1552                 push(@lines, $line);
1553
1554                 if ($realcnt > 1) {
1555                         $realcnt-- if ($line =~ /^(?:\+| |$)/);
1556                 } else {
1557                         $realcnt = 0;
1558                 }
1559
1560                 #print "==>$rawline\n";
1561                 #print "-->$line\n";
1562
1563                 if ($setup_docs && $line =~ /^\+/) {
1564                         push(@setup_docs, $line);
1565                 }
1566         }
1567
1568         $prefix = '';
1569
1570         $realcnt = 0;
1571         $linenr = 0;
1572         foreach my $line (@lines) {
1573                 $linenr++;
1574
1575                 my $rawline = $rawlines[$linenr - 1];
1576
1577 #extract the line range in the file after the patch is applied
1578                 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1579                         $is_patch = 1;
1580                         $first_line = $linenr + 1;
1581                         $realline=$1-1;
1582                         if (defined $2) {
1583                                 $realcnt=$3+1;
1584                         } else {
1585                                 $realcnt=1+1;
1586                         }
1587                         annotate_reset();
1588                         $prev_values = 'E';
1589
1590                         %suppress_ifbraces = ();
1591                         %suppress_whiletrailers = ();
1592                         %suppress_export = ();
1593                         $suppress_statement = 0;
1594                         next;
1595
1596 # track the line number as we move through the hunk, note that
1597 # new versions of GNU diff omit the leading space on completely
1598 # blank context lines so we need to count that too.
1599                 } elsif ($line =~ /^( |\+|$)/) {
1600                         $realline++;
1601                         $realcnt-- if ($realcnt != 0);
1602
1603                         # Measure the line length and indent.
1604                         ($length, $indent) = line_stats($rawline);
1605
1606                         # Track the previous line.
1607                         ($prevline, $stashline) = ($stashline, $line);
1608                         ($previndent, $stashindent) = ($stashindent, $indent);
1609                         ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1610
1611                         #warn "line<$line>\n";
1612
1613                 } elsif ($realcnt == 1) {
1614                         $realcnt--;
1615                 }
1616
1617                 my $hunk_line = ($realcnt != 0);
1618
1619 #make up the handle for any error we report on this line
1620                 $prefix = "$filename:$realline: " if ($emacs && $file);
1621                 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1622
1623                 $here = "#$linenr: " if (!$file);
1624                 $here = "#$realline: " if ($file);
1625
1626                 # extract the filename as it passes
1627                 if ($line =~ /^diff --git.*?(\S+)$/) {
1628                         $realfile = $1;
1629                         $realfile =~ s@^([^/]*)/@@;
1630                         $in_commit_log = 0;
1631                 } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
1632                         $realfile = $1;
1633                         $realfile =~ s@^([^/]*)/@@;
1634                         $in_commit_log = 0;
1635
1636                         $p1_prefix = $1;
1637                         if (!$file && $tree && $p1_prefix ne '' &&
1638                             -e "$root/$p1_prefix") {
1639                                 WARN("PATCH_PREFIX",
1640                                      "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
1641                         }
1642
1643                         if ($realfile =~ m@^include/asm/@) {
1644                                 ERROR("MODIFIED_INCLUDE_ASM",
1645                                       "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1646                         }
1647                         next;
1648                 }
1649
1650                 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1651
1652                 my $hereline = "$here\n$rawline\n";
1653                 my $herecurr = "$here\n$rawline\n";
1654                 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1655
1656                 $cnt_lines++ if ($realcnt != 0);
1657
1658 # Check for incorrect file permissions
1659                 if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
1660                         my $permhere = $here . "FILE: $realfile\n";
1661                         if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
1662                                 ERROR("EXECUTE_PERMISSIONS",
1663                                       "do not set execute permissions for source files\n" . $permhere);
1664                         }
1665                 }
1666
1667 # Check the patch for a signoff:
1668                 if ($line =~ /^\s*signed-off-by:/i) {
1669                         $signoff++;
1670                         $in_commit_log = 0;
1671                 }
1672
1673 # Check signature styles
1674                 if (!$in_header_lines &&
1675                     $line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
1676                         my $space_before = $1;
1677                         my $sign_off = $2;
1678                         my $space_after = $3;
1679                         my $email = $4;
1680                         my $ucfirst_sign_off = ucfirst(lc($sign_off));
1681
1682                         if (defined $space_before && $space_before ne "") {
1683                                 WARN("BAD_SIGN_OFF",
1684                                      "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
1685                         }
1686                         if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
1687                                 WARN("BAD_SIGN_OFF",
1688                                      "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
1689                         }
1690                         if (!defined $space_after || $space_after ne " ") {
1691                                 WARN("BAD_SIGN_OFF",
1692                                      "Use a single space after $ucfirst_sign_off\n" . $herecurr);
1693                         }
1694
1695                         my ($email_name, $email_address, $comment) = parse_email($email);
1696                         my $suggested_email = format_email(($email_name, $email_address));
1697                         if ($suggested_email eq "") {
1698                                 ERROR("BAD_SIGN_OFF",
1699                                       "Unrecognized email address: '$email'\n" . $herecurr);
1700                         } else {
1701                                 my $dequoted = $suggested_email;
1702                                 $dequoted =~ s/^"//;
1703                                 $dequoted =~ s/" </ </;
1704                                 # Don't force email to have quotes
1705                                 # Allow just an angle bracketed address
1706                                 if ("$dequoted$comment" ne $email &&
1707                                     "<$email_address>$comment" ne $email &&
1708                                     "$suggested_email$comment" ne $email) {
1709                                         WARN("BAD_SIGN_OFF",
1710                                              "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
1711                                 }
1712                         }
1713                 }
1714
1715 # Check for wrappage within a valid hunk of the file
1716                 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1717                         ERROR("CORRUPTED_PATCH",
1718                               "patch seems to be corrupt (line wrapped?)\n" .
1719                                 $herecurr) if (!$emitted_corrupt++);
1720                 }
1721
1722 # Check for absolute kernel paths.
1723                 if ($tree) {
1724                         while ($line =~ m{(?:^|\s)(/\S*)}g) {
1725                                 my $file = $1;
1726
1727                                 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1728                                     check_absolute_file($1, $herecurr)) {
1729                                         #
1730                                 } else {
1731                                         check_absolute_file($file, $herecurr);
1732                                 }
1733                         }
1734                 }
1735
1736 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1737                 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1738                     $rawline !~ m/^$UTF8*$/) {
1739                         my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1740
1741                         my $blank = copy_spacing($rawline);
1742                         my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1743                         my $hereptr = "$hereline$ptr\n";
1744
1745                         CHK("INVALID_UTF8",
1746                             "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1747                 }
1748
1749 # Check if it's the start of a commit log
1750 # (not a header line and we haven't seen the patch filename)
1751                 if ($in_header_lines && $realfile =~ /^$/ &&
1752                     $rawline !~ /^(commit\b|from\b|[\w-]+:).+$/i) {
1753                         $in_header_lines = 0;
1754                         $in_commit_log = 1;
1755                 }
1756
1757 # Still not yet in a patch, check for any UTF-8
1758                 if ($in_commit_log && $realfile =~ /^$/ &&
1759                     $rawline =~ /$NON_ASCII_UTF8/) {
1760                         CHK("UTF8_BEFORE_PATCH",
1761                             "8-bit UTF-8 used in possible commit log\n" . $herecurr);
1762                 }
1763
1764 # ignore non-hunk lines and lines being removed
1765                 next if (!$hunk_line || $line =~ /^-/);
1766
1767 #trailing whitespace
1768                 if ($line =~ /^\+.*\015/) {
1769                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1770                         ERROR("DOS_LINE_ENDINGS",
1771                               "DOS line endings\n" . $herevet);
1772
1773                 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1774                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1775                         ERROR("TRAILING_WHITESPACE",
1776                               "trailing whitespace\n" . $herevet);
1777                         $rpt_cleaners = 1;
1778                 }
1779
1780 # check for Kconfig help text having a real description
1781 # Only applies when adding the entry originally, after that we do not have
1782 # sufficient context to determine whether it is indeed long enough.
1783                 if ($realfile =~ /Kconfig/ &&
1784                     $line =~ /.\s*config\s+/) {
1785                         my $length = 0;
1786                         my $cnt = $realcnt;
1787                         my $ln = $linenr + 1;
1788                         my $f;
1789                         my $is_start = 0;
1790                         my $is_end = 0;
1791                         for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
1792                                 $f = $lines[$ln - 1];
1793                                 $cnt-- if ($lines[$ln - 1] !~ /^-/);
1794                                 $is_end = $lines[$ln - 1] =~ /^\+/;
1795
1796                                 next if ($f =~ /^-/);
1797
1798                                 if ($lines[$ln - 1] =~ /.\s*(?:bool|tristate)\s*\"/) {
1799                                         $is_start = 1;
1800                                 } elsif ($lines[$ln - 1] =~ /.\s*(?:---)?help(?:---)?$/) {
1801                                         $length = -1;
1802                                 }
1803
1804                                 $f =~ s/^.//;
1805                                 $f =~ s/#.*//;
1806                                 $f =~ s/^\s+//;
1807                                 next if ($f =~ /^$/);
1808                                 if ($f =~ /^\s*config\s/) {
1809                                         $is_end = 1;
1810                                         last;
1811                                 }
1812                                 $length++;
1813                         }
1814                         WARN("CONFIG_DESCRIPTION",
1815                              "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
1816                         #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
1817                 }
1818
1819                 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
1820                     ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
1821                         my $flag = $1;
1822                         my $replacement = {
1823                                 'EXTRA_AFLAGS' =>   'asflags-y',
1824                                 'EXTRA_CFLAGS' =>   'ccflags-y',
1825                                 'EXTRA_CPPFLAGS' => 'cppflags-y',
1826                                 'EXTRA_LDFLAGS' =>  'ldflags-y',
1827                         };
1828
1829                         WARN("DEPRECATED_VARIABLE",
1830                              "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
1831                 }
1832
1833 # check we are in a valid source file if not then ignore this hunk
1834                 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1835
1836 #80 column limit
1837                 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1838                     $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1839                     !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
1840                     $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
1841                     $length > 80)
1842                 {
1843                         WARN("LONG_LINE",
1844                              "line over 80 characters\n" . $herecurr);
1845                 }
1846
1847 # check for spaces before a quoted newline
1848                 if ($rawline =~ /^.*\".*\s\\n/) {
1849                         WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
1850                              "unnecessary whitespace before a quoted newline\n" . $herecurr);
1851                 }
1852
1853 # check for adding lines without a newline.
1854                 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1855                         WARN("MISSING_EOF_NEWLINE",
1856                              "adding a line without newline at end of file\n" . $herecurr);
1857                 }
1858
1859 # Blackfin: use hi/lo macros
1860                 if ($realfile =~ m@arch/blackfin/.*\.S$@) {
1861                         if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
1862                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1863                                 ERROR("LO_MACRO",
1864                                       "use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
1865                         }
1866                         if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
1867                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1868                                 ERROR("HI_MACRO",
1869                                       "use the HI() macro, not (... >> 16)\n" . $herevet);
1870                         }
1871                 }
1872
1873 # check we are in a valid source file C, perl or bash script
1874 # if not then ignore this hunk
1875                 next if ($realfile !~ /\.(h|c|pl|sh)$/);
1876
1877 # at the beginning of a line any tabs must come first and anything
1878 # more than 8 must use tabs.
1879                 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1880                     $rawline =~ /^\+\s*        \s*/) {
1881                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1882                         ERROR("CODE_INDENT",
1883                               "code indent should use tabs where possible\n" . $herevet);
1884                         $rpt_cleaners = 1;
1885                 }
1886
1887 # check for space before tabs.
1888                 if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
1889                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1890                         WARN("SPACE_BEFORE_TAB",
1891                              "please, no space before tabs\n" . $herevet);
1892                 }
1893
1894 # check for spaces at the beginning of a line.
1895 # Exceptions:
1896 #  1) within comments
1897 #  2) indented preprocessor commands
1898 #  3) hanging labels
1899                 if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/)  {
1900                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1901                         WARN("LEADING_SPACE",
1902                              "please, no spaces at the start of a line\n" . $herevet);
1903                 }
1904
1905 # check we are in a valid C source file if not then ignore this hunk
1906                 next if ($realfile !~ /\.(h|c)$/);
1907
1908 # check for RCS/CVS revision markers
1909                 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1910                         WARN("CVS_KEYWORD",
1911                              "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1912                 }
1913
1914 # Blackfin: don't use __builtin_bfin_[cs]sync
1915                 if ($line =~ /__builtin_bfin_csync/) {
1916                         my $herevet = "$here\n" . cat_vet($line) . "\n";
1917                         ERROR("CSYNC",
1918                               "use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
1919                 }
1920                 if ($line =~ /__builtin_bfin_ssync/) {
1921                         my $herevet = "$here\n" . cat_vet($line) . "\n";
1922                         ERROR("SSYNC",
1923                               "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
1924                 }
1925
1926 # Check for potential 'bare' types
1927                 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
1928                     $realline_next);
1929 #print "LINE<$line>\n";
1930                 if ($linenr >= $suppress_statement &&
1931                     $realcnt && $line =~ /.\s*\S/) {
1932                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
1933                                 ctx_statement_block($linenr, $realcnt, 0);
1934                         $stat =~ s/\n./\n /g;
1935                         $cond =~ s/\n./\n /g;
1936
1937 #print "linenr<$linenr> <$stat>\n";
1938                         # If this statement has no statement boundaries within
1939                         # it there is no point in retrying a statement scan
1940                         # until we hit end of it.
1941                         my $frag = $stat; $frag =~ s/;+\s*$//;
1942                         if ($frag !~ /(?:{|;)/) {
1943 #print "skip<$line_nr_next>\n";
1944                                 $suppress_statement = $line_nr_next;
1945                         }
1946
1947                         # Find the real next line.
1948                         $realline_next = $line_nr_next;
1949                         if (defined $realline_next &&
1950                             (!defined $lines[$realline_next - 1] ||
1951                              substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
1952                                 $realline_next++;
1953                         }
1954
1955                         my $s = $stat;
1956                         $s =~ s/{.*$//s;
1957
1958                         # Ignore goto labels.
1959                         if ($s =~ /$Ident:\*$/s) {
1960
1961                         # Ignore functions being called
1962                         } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1963
1964                         } elsif ($s =~ /^.\s*else\b/s) {
1965
1966                         # declarations always start with types
1967                         } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
1968                                 my $type = $1;
1969                                 $type =~ s/\s+/ /g;
1970                                 possible($type, "A:" . $s);
1971
1972                         # definitions in global scope can only start with types
1973                         } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
1974                                 possible($1, "B:" . $s);
1975                         }
1976
1977                         # any (foo ... *) is a pointer cast, and foo is a type
1978                         while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
1979                                 possible($1, "C:" . $s);
1980                         }
1981
1982                         # Check for any sort of function declaration.
1983                         # int foo(something bar, other baz);
1984                         # void (*store_gdt)(x86_descr_ptr *);
1985                         if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1986                                 my ($name_len) = length($1);
1987
1988                                 my $ctx = $s;
1989                                 substr($ctx, 0, $name_len + 1, '');
1990                                 $ctx =~ s/\)[^\)]*$//;
1991
1992                                 for my $arg (split(/\s*,\s*/, $ctx)) {
1993                                         if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
1994
1995                                                 possible($1, "D:" . $s);
1996                                         }
1997                                 }
1998                         }
1999
2000                 }
2001
2002 #
2003 # Checks which may be anchored in the context.
2004 #
2005
2006 # Check for switch () and associated case and default
2007 # statements should be at the same indent.
2008                 if ($line=~/\bswitch\s*\(.*\)/) {
2009                         my $err = '';
2010                         my $sep = '';
2011                         my @ctx = ctx_block_outer($linenr, $realcnt);
2012                         shift(@ctx);
2013                         for my $ctx (@ctx) {
2014                                 my ($clen, $cindent) = line_stats($ctx);
2015                                 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
2016                                                         $indent != $cindent) {
2017                                         $err .= "$sep$ctx\n";
2018                                         $sep = '';
2019                                 } else {
2020                                         $sep = "[...]\n";
2021                                 }
2022                         }
2023                         if ($err ne '') {
2024                                 ERROR("SWITCH_CASE_INDENT_LEVEL",
2025                                       "switch and case should be at the same indent\n$hereline$err");
2026                         }
2027                 }
2028
2029 # if/while/etc brace do not go on next line, unless defining a do while loop,
2030 # or if that brace on the next line is for something else
2031                 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
2032                         my $pre_ctx = "$1$2";
2033
2034                         my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
2035
2036                         if ($line =~ /^\+\t{6,}/) {
2037                                 WARN("DEEP_INDENTATION",
2038                                      "Too many leading tabs - consider code refactoring\n" . $herecurr);
2039                         }
2040
2041                         my $ctx_cnt = $realcnt - $#ctx - 1;
2042                         my $ctx = join("\n", @ctx);
2043
2044                         my $ctx_ln = $linenr;
2045                         my $ctx_skip = $realcnt;
2046
2047                         while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
2048                                         defined $lines[$ctx_ln - 1] &&
2049                                         $lines[$ctx_ln - 1] =~ /^-/)) {
2050                                 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2051                                 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
2052                                 $ctx_ln++;
2053                         }
2054
2055                         #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2056                         #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2057
2058                         if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
2059                                 ERROR("OPEN_BRACE",
2060                                       "that open brace { should be on the previous line\n" .
2061                                         "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2062                         }
2063                         if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
2064                             $ctx =~ /\)\s*\;\s*$/ &&
2065                             defined $lines[$ctx_ln - 1])
2066                         {
2067                                 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
2068                                 if ($nindent > $indent) {
2069                                         WARN("TRAILING_SEMICOLON",
2070                                              "trailing semicolon indicates no statements, indent implies otherwise\n" .
2071                                                 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2072                                 }
2073                         }
2074                 }
2075
2076 # Check relative indent for conditionals and blocks.
2077                 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2078                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2079                                 ctx_statement_block($linenr, $realcnt, 0)
2080                                         if (!defined $stat);
2081                         my ($s, $c) = ($stat, $cond);
2082
2083                         substr($s, 0, length($c), '');
2084
2085                         # Make sure we remove the line prefixes as we have
2086                         # none on the first line, and are going to readd them
2087                         # where necessary.
2088                         $s =~ s/\n./\n/gs;
2089
2090                         # Find out how long the conditional actually is.
2091                         my @newlines = ($c =~ /\n/gs);
2092                         my $cond_lines = 1 + $#newlines;
2093
2094                         # We want to check the first line inside the block
2095                         # starting at the end of the conditional, so remove:
2096                         #  1) any blank line termination
2097                         #  2) any opening brace { on end of the line
2098                         #  3) any do (...) {
2099                         my $continuation = 0;
2100                         my $check = 0;
2101                         $s =~ s/^.*\bdo\b//;
2102                         $s =~ s/^\s*{//;
2103                         if ($s =~ s/^\s*\\//) {
2104                                 $continuation = 1;
2105                         }
2106                         if ($s =~ s/^\s*?\n//) {
2107                                 $check = 1;
2108                                 $cond_lines++;
2109                         }
2110
2111                         # Also ignore a loop construct at the end of a
2112                         # preprocessor statement.
2113                         if (($prevline =~ /^.\s*#\s*define\s/ ||
2114                             $prevline =~ /\\\s*$/) && $continuation == 0) {
2115                                 $check = 0;
2116                         }
2117
2118                         my $cond_ptr = -1;
2119                         $continuation = 0;
2120                         while ($cond_ptr != $cond_lines) {
2121                                 $cond_ptr = $cond_lines;
2122
2123                                 # If we see an #else/#elif then the code
2124                                 # is not linear.
2125                                 if ($s =~ /^\s*\#\s*(?:else|elif)/) {
2126                                         $check = 0;
2127                                 }
2128
2129                                 # Ignore:
2130                                 #  1) blank lines, they should be at 0,
2131                                 #  2) preprocessor lines, and
2132                                 #  3) labels.
2133                                 if ($continuation ||
2134                                     $s =~ /^\s*?\n/ ||
2135                                     $s =~ /^\s*#\s*?/ ||
2136                                     $s =~ /^\s*$Ident\s*:/) {
2137                                         $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
2138                                         if ($s =~ s/^.*?\n//) {
2139                                                 $cond_lines++;
2140                                         }
2141                                 }
2142                         }
2143
2144                         my (undef, $sindent) = line_stats("+" . $s);
2145                         my $stat_real = raw_line($linenr, $cond_lines);
2146
2147                         # Check if either of these lines are modified, else
2148                         # this is not this patch's fault.
2149                         if (!defined($stat_real) ||
2150                             $stat !~ /^\+/ && $stat_real !~ /^\+/) {
2151                                 $check = 0;
2152                         }
2153                         if (defined($stat_real) && $cond_lines > 1) {
2154                                 $stat_real = "[...]\n$stat_real";
2155                         }
2156
2157                         #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2158
2159                         if ($check && (($sindent % 8) != 0 ||
2160                             ($sindent <= $indent && $s ne ''))) {
2161                                 WARN("SUSPECT_CODE_INDENT",
2162                                      "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2163                         }
2164                 }
2165
2166                 # Track the 'values' across context and added lines.
2167                 my $opline = $line; $opline =~ s/^./ /;
2168                 my ($curr_values, $curr_vars) =
2169                                 annotate_values($opline . "\n", $prev_values);
2170                 $curr_values = $prev_values . $curr_values;
2171                 if ($dbg_values) {
2172                         my $outline = $opline; $outline =~ s/\t/ /g;
2173                         print "$linenr > .$outline\n";
2174                         print "$linenr > $curr_values\n";
2175                         print "$linenr >  $curr_vars\n";
2176                 }
2177                 $prev_values = substr($curr_values, -1);
2178
2179 #ignore lines not being added
2180                 if ($line=~/^[^\+]/) {next;}
2181
2182 # TEST: allow direct testing of the type matcher.
2183                 if ($dbg_type) {
2184                         if ($line =~ /^.\s*$Declare\s*$/) {
2185                                 ERROR("TEST_TYPE",
2186                                       "TEST: is type\n" . $herecurr);
2187                         } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
2188                                 ERROR("TEST_NOT_TYPE",
2189                                       "TEST: is not type ($1 is)\n". $herecurr);
2190                         }
2191                         next;
2192                 }
2193 # TEST: allow direct testing of the attribute matcher.
2194                 if ($dbg_attr) {
2195                         if ($line =~ /^.\s*$Modifier\s*$/) {
2196                                 ERROR("TEST_ATTR",
2197                                       "TEST: is attr\n" . $herecurr);
2198                         } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
2199                                 ERROR("TEST_NOT_ATTR",
2200                                       "TEST: is not attr ($1 is)\n". $herecurr);
2201                         }
2202                         next;
2203                 }
2204
2205 # check for initialisation to aggregates open brace on the next line
2206                 if ($line =~ /^.\s*{/ &&
2207                     $prevline =~ /(?:^|[^=])=\s*$/) {
2208                         ERROR("OPEN_BRACE",
2209                               "that open brace { should be on the previous line\n" . $hereprev);
2210                 }
2211
2212 #
2213 # Checks which are anchored on the added line.
2214 #
2215
2216 # check for malformed paths in #include statements (uses RAW line)
2217                 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
2218                         my $path = $1;
2219                         if ($path =~ m{//}) {
2220                                 ERROR("MALFORMED_INCLUDE",
2221                                       "malformed #include filename\n" .
2222                                         $herecurr);
2223                         }
2224                 }
2225
2226 # no C99 // comments
2227                 if ($line =~ m{//}) {
2228                         ERROR("C99_COMMENTS",
2229                               "do not use C99 // comments\n" . $herecurr);
2230                 }
2231                 # Remove C99 comments.
2232                 $line =~ s@//.*@@;
2233                 $opline =~ s@//.*@@;
2234
2235 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
2236 # the whole statement.
2237 #print "APW <$lines[$realline_next - 1]>\n";
2238                 if (defined $realline_next &&
2239                     exists $lines[$realline_next - 1] &&
2240                     !defined $suppress_export{$realline_next} &&
2241                     ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2242                      $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2243                         # Handle definitions which produce identifiers with
2244                         # a prefix:
2245                         #   XXX(foo);
2246                         #   EXPORT_SYMBOL(something_foo);
2247                         my $name = $1;
2248                         if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
2249                             $name =~ /^${Ident}_$2/) {
2250 #print "FOO C name<$name>\n";
2251                                 $suppress_export{$realline_next} = 1;
2252
2253                         } elsif ($stat !~ /(?:
2254                                 \n.}\s*$|
2255                                 ^.DEFINE_$Ident\(\Q$name\E\)|
2256                                 ^.DECLARE_$Ident\(\Q$name\E\)|
2257                                 ^.LIST_HEAD\(\Q$name\E\)|
2258                                 ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
2259                                 \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
2260                             )/x) {
2261 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
2262                                 $suppress_export{$realline_next} = 2;
2263                         } else {
2264                                 $suppress_export{$realline_next} = 1;
2265                         }
2266                 }
2267                 if (!defined $suppress_export{$linenr} &&
2268                     $prevline =~ /^.\s*$/ &&
2269                     ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2270                      $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2271 #print "FOO B <$lines[$linenr - 1]>\n";
2272                         $suppress_export{$linenr} = 2;
2273                 }
2274                 if (defined $suppress_export{$linenr} &&
2275                     $suppress_export{$linenr} == 2) {
2276                         WARN("EXPORT_SYMBOL",
2277                              "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
2278                 }
2279
2280 # check for global initialisers.
2281                 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
2282                         ERROR("GLOBAL_INITIALISERS",
2283                               "do not initialise globals to 0 or NULL\n" .
2284                                 $herecurr);
2285                 }
2286 # check for static initialisers.
2287                 if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
2288                         ERROR("INITIALISED_STATIC",
2289                               "do not initialise statics to 0 or NULL\n" .
2290                                 $herecurr);
2291                 }
2292
2293 # check for static const char * arrays.
2294                 if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
2295                         WARN("STATIC_CONST_CHAR_ARRAY",
2296                              "static const char * array should probably be static const char * const\n" .
2297                                 $herecurr);
2298                }
2299
2300 # check for static char foo[] = "bar" declarations.
2301                 if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
2302                         WARN("STATIC_CONST_CHAR_ARRAY",
2303                              "static char array declaration should probably be static const char\n" .
2304                                 $herecurr);
2305                }
2306
2307 # check for declarations of struct pci_device_id
2308                 if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
2309                         WARN("DEFINE_PCI_DEVICE_TABLE",
2310                              "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
2311                 }
2312
2313 # check for new typedefs, only function parameters and sparse annotations
2314 # make sense.
2315                 if ($line =~ /\btypedef\s/ &&
2316                     $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
2317                     $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
2318                     $line !~ /\b$typeTypedefs\b/ &&
2319                     $line !~ /\b__bitwise(?:__|)\b/) {
2320                         WARN("NEW_TYPEDEFS",
2321                              "do not add new typedefs\n" . $herecurr);
2322                 }
2323
2324 # * goes on variable not on type
2325                 # (char*[ const])
2326                 while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
2327                         #print "AA<$1>\n";
2328                         my ($from, $to) = ($2, $2);
2329
2330                         # Should start with a space.
2331                         $to =~ s/^(\S)/ $1/;
2332                         # Should not end with a space.
2333                         $to =~ s/\s+$//;
2334                         # '*'s should not have spaces between.
2335                         while ($to =~ s/\*\s+\*/\*\*/) {
2336                         }
2337
2338                         #print "from<$from> to<$to>\n";
2339                         if ($from ne $to) {
2340                                 ERROR("POINTER_LOCATION",
2341                                       "\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr);
2342                         }
2343                 }
2344                 while ($line =~ m{(\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident))}g) {
2345                         #print "BB<$1>\n";
2346                         my ($from, $to, $ident) = ($2, $2, $3);
2347
2348                         # Should start with a space.
2349                         $to =~ s/^(\S)/ $1/;
2350                         # Should not end with a space.
2351                         $to =~ s/\s+$//;
2352                         # '*'s should not have spaces between.
2353                         while ($to =~ s/\*\s+\*/\*\*/) {
2354                         }
2355                         # Modifiers should have spaces.
2356                         $to =~ s/(\b$Modifier$)/$1 /;
2357
2358                         #print "from<$from> to<$to> ident<$ident>\n";
2359                         if ($from ne $to && $ident !~ /^$Modifier$/) {
2360                                 ERROR("POINTER_LOCATION",
2361                                       "\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr);
2362                         }
2363                 }
2364
2365 # # no BUG() or BUG_ON()
2366 #               if ($line =~ /\b(BUG|BUG_ON)\b/) {
2367 #                       print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
2368 #                       print "$herecurr";
2369 #                       $clean = 0;
2370 #               }
2371
2372                 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
2373                         WARN("LINUX_VERSION_CODE",
2374                              "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
2375                 }
2376
2377 # check for uses of printk_ratelimit
2378                 if ($line =~ /\bprintk_ratelimit\s*\(/) {
2379                         WARN("PRINTK_RATELIMITED",
2380 "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
2381                 }
2382
2383 # printk should use KERN_* levels.  Note that follow on printk's on the
2384 # same line do not need a level, so we use the current block context
2385 # to try and find and validate the current printk.  In summary the current
2386 # printk includes all preceding printk's which have no newline on the end.
2387 # we assume the first bad printk is the one to report.
2388                 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
2389                         my $ok = 0;
2390                         for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
2391                                 #print "CHECK<$lines[$ln - 1]\n";
2392                                 # we have a preceding printk if it ends
2393                                 # with "\n" ignore it, else it is to blame
2394                                 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
2395                                         if ($rawlines[$ln - 1] !~ m{\\n"}) {
2396                                                 $ok = 1;
2397                                         }
2398                                         last;
2399                                 }
2400                         }
2401                         if ($ok == 0) {
2402                                 WARN("PRINTK_WITHOUT_KERN_LEVEL",
2403                                      "printk() should include KERN_ facility level\n" . $herecurr);
2404                         }
2405                 }
2406
2407 # function brace can't be on same line, except for #defines of do while,
2408 # or if closed on same line
2409                 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
2410                     !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
2411                         ERROR("OPEN_BRACE",
2412                               "open brace '{' following function declarations go on the next line\n" . $herecurr);
2413                 }
2414
2415 # open braces for enum, union and struct go on the same line.
2416                 if ($line =~ /^.\s*{/ &&
2417                     $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
2418                         ERROR("OPEN_BRACE",
2419                               "open brace '{' following $1 go on the same line\n" . $hereprev);
2420                 }
2421
2422 # missing space after union, struct or enum definition
2423                 if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) {
2424                     WARN("SPACING",
2425                          "missing space after $1 definition\n" . $herecurr);
2426                 }
2427
2428 # check for spacing round square brackets; allowed:
2429 #  1. with a type on the left -- int [] a;
2430 #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
2431 #  3. inside a curly brace -- = { [0...10] = 5 }
2432                 while ($line =~ /(.*?\s)\[/g) {
2433                         my ($where, $prefix) = ($-[1], $1);
2434                         if ($prefix !~ /$Type\s+$/ &&
2435                             ($where != 0 || $prefix !~ /^.\s+$/) &&
2436                             $prefix !~ /{\s+$/) {
2437                                 ERROR("BRACKET_SPACE",
2438                                       "space prohibited before open square bracket '['\n" . $herecurr);
2439                         }
2440                 }
2441
2442 # check for spaces between functions and their parentheses.
2443                 while ($line =~ /($Ident)\s+\(/g) {
2444                         my $name = $1;
2445                         my $ctx_before = substr($line, 0, $-[1]);
2446                         my $ctx = "$ctx_before$name";
2447
2448                         # Ignore those directives where spaces _are_ permitted.
2449                         if ($name =~ /^(?:
2450                                 if|for|while|switch|return|case|
2451                                 volatile|__volatile__|
2452                                 __attribute__|format|__extension__|
2453                                 asm|__asm__)$/x)
2454                         {
2455
2456                         # cpp #define statements have non-optional spaces, ie
2457                         # if there is a space between the name and the open
2458                         # parenthesis it is simply not a parameter group.
2459                         } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
2460
2461                         # cpp #elif statement condition may start with a (
2462                         } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
2463
2464                         # If this whole things ends with a type its most
2465                         # likely a typedef for a function.
2466                         } elsif ($ctx =~ /$Type$/) {
2467
2468                         } else {
2469                                 WARN("SPACING",
2470                                      "space prohibited between function name and open parenthesis '('\n" . $herecurr);
2471                         }
2472                 }
2473 # Check operator spacing.
2474                 if (!($line=~/\#\s*include/)) {
2475                         my $ops = qr{
2476                                 <<=|>>=|<=|>=|==|!=|
2477                                 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
2478                                 =>|->|<<|>>|<|>|=|!|~|
2479                                 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
2480                                 \?|:
2481                         }x;
2482                         my @elements = split(/($ops|;)/, $opline);
2483                         my $off = 0;
2484
2485                         my $blank = copy_spacing($opline);
2486
2487                         for (my $n = 0; $n < $#elements; $n += 2) {
2488                                 $off += length($elements[$n]);
2489
2490                                 # Pick up the preceding and succeeding characters.
2491                                 my $ca = substr($opline, 0, $off);
2492                                 my $cc = '';
2493                                 if (length($opline) >= ($off + length($elements[$n + 1]))) {
2494                                         $cc = substr($opline, $off + length($elements[$n + 1]));
2495                                 }
2496                                 my $cb = "$ca$;$cc";
2497
2498                                 my $a = '';
2499                                 $a = 'V' if ($elements[$n] ne '');
2500                                 $a = 'W' if ($elements[$n] =~ /\s$/);
2501                                 $a = 'C' if ($elements[$n] =~ /$;$/);
2502                                 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
2503                                 $a = 'O' if ($elements[$n] eq '');
2504                                 $a = 'E' if ($ca =~ /^\s*$/);
2505
2506                                 my $op = $elements[$n + 1];
2507
2508                                 my $c = '';
2509                                 if (defined $elements[$n + 2]) {
2510                                         $c = 'V' if ($elements[$n + 2] ne '');
2511                                         $c = 'W' if ($elements[$n + 2] =~ /^\s/);
2512                                         $c = 'C' if ($elements[$n + 2] =~ /^$;/);
2513                                         $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
2514                                         $c = 'O' if ($elements[$n + 2] eq '');
2515                                         $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
2516                                 } else {
2517                                         $c = 'E';
2518                                 }
2519
2520                                 my $ctx = "${a}x${c}";
2521
2522                                 my $at = "(ctx:$ctx)";
2523
2524                                 my $ptr = substr($blank, 0, $off) . "^";
2525                                 my $hereptr = "$hereline$ptr\n";
2526
2527                                 # Pull out the value of this operator.
2528                                 my $op_type = substr($curr_values, $off + 1, 1);
2529
2530                                 # Get the full operator variant.
2531                                 my $opv = $op . substr($curr_vars, $off, 1);
2532
2533                                 # Ignore operators passed as parameters.
2534                                 if ($op_type ne 'V' &&
2535                                     $ca =~ /\s$/ && $cc =~ /^\s*,/) {
2536
2537 #                               # Ignore comments
2538 #                               } elsif ($op =~ /^$;+$/) {
2539
2540                                 # ; should have either the end of line or a space or \ after it
2541                                 } elsif ($op eq ';') {
2542                                         if ($ctx !~ /.x[WEBC]/ &&
2543                                             $cc !~ /^\\/ && $cc !~ /^;/) {
2544                                                 ERROR("SPACING",
2545                                                       "space required after that '$op' $at\n" . $hereptr);
2546                                         }
2547
2548                                 # // is a comment
2549                                 } elsif ($op eq '//') {
2550
2551                                 # No spaces for:
2552                                 #   ->
2553                                 #   :   when part of a bitfield
2554                                 } elsif ($op eq '->' || $opv eq ':B') {
2555                                         if ($ctx =~ /Wx.|.xW/) {
2556                                                 ERROR("SPACING",
2557                                                       "spaces prohibited around that '$op' $at\n" . $hereptr);
2558                                         }
2559
2560                                 # , must have a space on the right.
2561                                 } elsif ($op eq ',') {
2562                                         if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
2563                                                 ERROR("SPACING",
2564                                                       "space required after that '$op' $at\n" . $hereptr);
2565                                         }
2566
2567                                 # '*' as part of a type definition -- reported already.
2568                                 } elsif ($opv eq '*_') {
2569                                         #warn "'*' is part of type\n";
2570
2571                                 # unary operators should have a space before and
2572                                 # none after.  May be left adjacent to another
2573                                 # unary operator, or a cast
2574                                 } elsif ($op eq '!' || $op eq '~' ||
2575                                          $opv eq '*U' || $opv eq '-U' ||
2576                                          $opv eq '&U' || $opv eq '&&U') {
2577                                         if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
2578                                                 ERROR("SPACING",
2579                                                       "space required before that '$op' $at\n" . $hereptr);
2580                                         }
2581                                         if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
2582                                                 # A unary '*' may be const
2583
2584                                         } elsif ($ctx =~ /.xW/) {
2585                                                 ERROR("SPACING",
2586                                                       "space prohibited after that '$op' $at\n" . $hereptr);
2587                                         }
2588
2589                                 # unary ++ and unary -- are allowed no space on one side.
2590                                 } elsif ($op eq '++' or $op eq '--') {
2591                                         if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
2592                                                 ERROR("SPACING",
2593                                                       "space required one side of that '$op' $at\n" . $hereptr);
2594                                         }
2595                                         if ($ctx =~ /Wx[BE]/ ||
2596                                             ($ctx =~ /Wx./ && $cc =~ /^;/)) {
2597                                                 ERROR("SPACING",
2598                                                       "space prohibited before that '$op' $at\n" . $hereptr);
2599                                         }
2600                                         if ($ctx =~ /ExW/) {
2601                                                 ERROR("SPACING",
2602                                                       "space prohibited after that '$op' $at\n" . $hereptr);
2603                                         }
2604
2605
2606                                 # << and >> may either have or not have spaces both sides
2607                                 } elsif ($op eq '<<' or $op eq '>>' or
2608                                          $op eq '&' or $op eq '^' or $op eq '|' or
2609                                          $op eq '+' or $op eq '-' or
2610                                          $op eq '*' or $op eq '/' or
2611                                          $op eq '%')
2612                                 {
2613                                         if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
2614                                                 ERROR("SPACING",
2615                                                       "need consistent spacing around '$op' $at\n" .
2616                                                         $hereptr);
2617                                         }
2618
2619                                 # A colon needs no spaces before when it is
2620                                 # terminating a case value or a label.
2621                                 } elsif ($opv eq ':C' || $opv eq ':L') {
2622                                         if ($ctx =~ /Wx./) {
2623                                                 ERROR("SPACING",
2624                                                       "space prohibited before that '$op' $at\n" . $hereptr);
2625                                         }
2626
2627                                 # All the others need spaces both sides.
2628                                 } elsif ($ctx !~ /[EWC]x[CWE]/) {
2629                                         my $ok = 0;
2630
2631                                         # Ignore email addresses <foo@bar>
2632                                         if (($op eq '<' &&
2633                                              $cc =~ /^\S+\@\S+>/) ||
2634                                             ($op eq '>' &&
2635                                              $ca =~ /<\S+\@\S+$/))
2636                                         {
2637                                                 $ok = 1;
2638                                         }
2639
2640                                         # Ignore ?:
2641                                         if (($opv eq ':O' && $ca =~ /\?$/) ||
2642                                             ($op eq '?' && $cc =~ /^:/)) {
2643                                                 $ok = 1;
2644                                         }
2645
2646                                         if ($ok == 0) {
2647                                                 ERROR("SPACING",
2648                                                       "spaces required around that '$op' $at\n" . $hereptr);
2649                                         }
2650                                 }
2651                                 $off += length($elements[$n + 1]);
2652                         }
2653                 }
2654
2655 # check for multiple assignments
2656                 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
2657                         CHK("MULTIPLE_ASSIGNMENTS",
2658                             "multiple assignments should be avoided\n" . $herecurr);
2659                 }
2660
2661 ## # check for multiple declarations, allowing for a function declaration
2662 ## # continuation.
2663 ##              if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
2664 ##                  $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
2665 ##
2666 ##                      # Remove any bracketed sections to ensure we do not
2667 ##                      # falsly report the parameters of functions.
2668 ##                      my $ln = $line;
2669 ##                      while ($ln =~ s/\([^\(\)]*\)//g) {
2670 ##                      }
2671 ##                      if ($ln =~ /,/) {
2672 ##                              WARN("MULTIPLE_DECLARATION",
2673 ##                                   "declaring multiple variables together should be avoided\n" . $herecurr);
2674 ##                      }
2675 ##              }
2676
2677 #need space before brace following if, while, etc
2678                 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
2679                     $line =~ /do{/) {
2680                         ERROR("SPACING",
2681                               "space required before the open brace '{'\n" . $herecurr);
2682                 }
2683
2684 # closing brace should have a space following it when it has anything
2685 # on the line
2686                 if ($line =~ /}(?!(?:,|;|\)))\S/) {
2687                         ERROR("SPACING",
2688                               "space required after that close brace '}'\n" . $herecurr);
2689                 }
2690
2691 # check spacing on square brackets
2692                 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
2693                         ERROR("SPACING",
2694                               "space prohibited after that open square bracket '['\n" . $herecurr);
2695                 }
2696                 if ($line =~ /\s\]/) {
2697                         ERROR("SPACING",
2698                               "space prohibited before that close square bracket ']'\n" . $herecurr);
2699                 }
2700
2701 # check spacing on parentheses
2702                 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
2703                     $line !~ /for\s*\(\s+;/) {
2704                         ERROR("SPACING",
2705                               "space prohibited after that open parenthesis '('\n" . $herecurr);
2706                 }
2707                 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
2708                     $line !~ /for\s*\(.*;\s+\)/ &&
2709                     $line !~ /:\s+\)/) {
2710                         ERROR("SPACING",
2711                               "space prohibited before that close parenthesis ')'\n" . $herecurr);
2712                 }
2713
2714 #goto labels aren't indented, allow a single space however
2715                 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
2716                    !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
2717                         WARN("INDENTED_LABEL",
2718                              "labels should not be indented\n" . $herecurr);
2719                 }
2720
2721 # Return is not a function.
2722                 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
2723                         my $spacing = $1;
2724                         my $value = $2;
2725
2726                         # Flatten any parentheses
2727                         $value =~ s/\(/ \(/g;
2728                         $value =~ s/\)/\) /g;
2729                         while ($value =~ s/\[[^\[\]]*\]/1/ ||
2730                                $value !~ /(?:$Ident|-?$Constant)\s*
2731                                              $Compare\s*
2732                                              (?:$Ident|-?$Constant)/x &&
2733                                $value =~ s/\([^\(\)]*\)/1/) {
2734                         }
2735 #print "value<$value>\n";
2736                         if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
2737                                 ERROR("RETURN_PARENTHESES",
2738                                       "return is not a function, parentheses are not required\n" . $herecurr);
2739
2740                         } elsif ($spacing !~ /\s+/) {
2741                                 ERROR("SPACING",
2742                                       "space required before the open parenthesis '('\n" . $herecurr);
2743                         }
2744                 }
2745 # Return of what appears to be an errno should normally be -'ve
2746                 if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
2747                         my $name = $1;
2748                         if ($name ne 'EOF' && $name ne 'ERROR') {
2749                                 WARN("USE_NEGATIVE_ERRNO",
2750                                      "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
2751                         }
2752                 }
2753
2754 # Need a space before open parenthesis after if, while etc
2755                 if ($line=~/\b(if|while|for|switch)\(/) {
2756                         ERROR("SPACING", "space required before the open parenthesis '('\n" . $herecurr);
2757                 }
2758
2759 # Check for illegal assignment in if conditional -- and check for trailing
2760 # statements after the conditional.
2761                 if ($line =~ /do\s*(?!{)/) {
2762                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2763                                 ctx_statement_block($linenr, $realcnt, 0)
2764                                         if (!defined $stat);
2765                         my ($stat_next) = ctx_statement_block($line_nr_next,
2766                                                 $remain_next, $off_next);
2767                         $stat_next =~ s/\n./\n /g;
2768                         ##print "stat<$stat> stat_next<$stat_next>\n";
2769
2770                         if ($stat_next =~ /^\s*while\b/) {
2771                                 # If the statement carries leading newlines,
2772                                 # then count those as offsets.
2773                                 my ($whitespace) =
2774                                         ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
2775                                 my $offset =
2776                                         statement_rawlines($whitespace) - 1;
2777
2778                                 $suppress_whiletrailers{$line_nr_next +
2779                                                                 $offset} = 1;
2780                         }
2781                 }
2782                 if (!defined $suppress_whiletrailers{$linenr} &&
2783                     $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
2784                         my ($s, $c) = ($stat, $cond);
2785
2786                         if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
2787                                 ERROR("ASSIGN_IN_IF",
2788                                       "do not use assignment in if condition\n" . $herecurr);
2789                         }
2790
2791                         # Find out what is on the end of the line after the
2792                         # conditional.
2793                         substr($s, 0, length($c), '');
2794                         $s =~ s/\n.*//g;
2795                         $s =~ s/$;//g;  # Remove any comments
2796                         if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
2797                             $c !~ /}\s*while\s*/)
2798                         {
2799                                 # Find out how long the conditional actually is.
2800                                 my @newlines = ($c =~ /\n/gs);
2801                                 my $cond_lines = 1 + $#newlines;
2802                                 my $stat_real = '';
2803
2804                                 $stat_real = raw_line($linenr, $cond_lines)
2805                                                         . "\n" if ($cond_lines);
2806                                 if (defined($stat_real) && $cond_lines > 1) {
2807                                         $stat_real = "[...]\n$stat_real";
2808                                 }
2809
2810                                 ERROR("TRAILING_STATEMENTS",
2811                                       "trailing statements should be on next line\n" . $herecurr . $stat_real);
2812                         }
2813                 }
2814
2815 # Check for bitwise tests written as boolean
2816                 if ($line =~ /
2817                         (?:
2818                                 (?:\[|\(|\&\&|\|\|)
2819                                 \s*0[xX][0-9]+\s*
2820                                 (?:\&\&|\|\|)
2821                         |
2822                                 (?:\&\&|\|\|)
2823                                 \s*0[xX][0-9]+\s*
2824                                 (?:\&\&|\|\||\)|\])
2825                         )/x)
2826                 {
2827                         WARN("HEXADECIMAL_BOOLEAN_TEST",
2828                              "boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
2829                 }
2830
2831 # if and else should not have general statements after it
2832                 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
2833                         my $s = $1;
2834                         $s =~ s/$;//g;  # Remove any comments
2835                         if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
2836                                 ERROR("TRAILING_STATEMENTS",
2837                                       "trailing statements should be on next line\n" . $herecurr);
2838                         }
2839                 }
2840 # if should not continue a brace
2841                 if ($line =~ /}\s*if\b/) {
2842                         ERROR("TRAILING_STATEMENTS",
2843                               "trailing statements should be on next line\n" .
2844                                 $herecurr);
2845                 }
2846 # case and default should not have general statements after them
2847                 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
2848                     $line !~ /\G(?:
2849                         (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
2850                         \s*return\s+
2851                     )/xg)
2852                 {
2853                         ERROR("TRAILING_STATEMENTS",
2854                               "trailing statements should be on next line\n" . $herecurr);
2855                 }
2856
2857                 # Check for }<nl>else {, these must be at the same
2858                 # indent level to be relevant to each other.
2859                 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
2860                                                 $previndent == $indent) {
2861                         ERROR("ELSE_AFTER_BRACE",
2862                               "else should follow close brace '}'\n" . $hereprev);
2863                 }
2864
2865                 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
2866                                                 $previndent == $indent) {
2867                         my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
2868
2869                         # Find out what is on the end of the line after the
2870                         # conditional.
2871                         substr($s, 0, length($c), '');
2872                         $s =~ s/\n.*//g;
2873
2874                         if ($s =~ /^\s*;/) {
2875                                 ERROR("WHILE_AFTER_BRACE",
2876                                       "while should follow close brace '}'\n" . $hereprev);
2877                         }
2878                 }
2879
2880 #studly caps, commented out until figure out how to distinguish between use of existing and adding new
2881 #               if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
2882 #                   print "No studly caps, use _\n";
2883 #                   print "$herecurr";
2884 #                   $clean = 0;
2885 #               }
2886
2887 #no spaces allowed after \ in define
2888                 if ($line=~/\#\s*define.*\\\s$/) {
2889                         WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
2890                              "Whitepspace after \\ makes next lines useless\n" . $herecurr);
2891                 }
2892
2893 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
2894                 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
2895                         my $file = "$1.h";
2896                         my $checkfile = "include/linux/$file";
2897                         if (-f "$root/$checkfile" &&
2898                             $realfile ne $checkfile &&
2899                             $1 !~ /$allowed_asm_includes/)
2900                         {
2901                                 if ($realfile =~ m{^arch/}) {
2902                                         CHK("ARCH_INCLUDE_LINUX",
2903                                             "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2904                                 } else {
2905                                         WARN("INCLUDE_LINUX",
2906                                              "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2907                                 }
2908                         }
2909                 }
2910
2911 # multi-statement macros should be enclosed in a do while loop, grab the
2912 # first statement and ensure its the whole macro if its not enclosed
2913 # in a known good container
2914                 if ($realfile !~ m@/vmlinux.lds.h$@ &&
2915                     $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
2916                         my $ln = $linenr;
2917                         my $cnt = $realcnt;
2918                         my ($off, $dstat, $dcond, $rest);
2919                         my $ctx = '';
2920                         ($dstat, $dcond, $ln, $cnt, $off) =
2921                                 ctx_statement_block($linenr, $realcnt, 0);
2922                         $ctx = $dstat;
2923                         #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
2924                         #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
2925
2926                         $dstat =~ s/^.\s*\#\s*define\s+$Ident(?:\([^\)]*\))?\s*//;
2927                         $dstat =~ s/$;//g;
2928                         $dstat =~ s/\\\n.//g;
2929                         $dstat =~ s/^\s*//s;
2930                         $dstat =~ s/\s*$//s;
2931
2932                         # Flatten any parentheses and braces
2933                         while ($dstat =~ s/\([^\(\)]*\)/1/ ||
2934                                $dstat =~ s/\{[^\{\}]*\}/1/ ||
2935                                $dstat =~ s/\[[^\[\]]*\]/1/)
2936                         {
2937                         }
2938
2939                         my $exceptions = qr{
2940                                 $Declare|
2941                                 module_param_named|
2942                                 MODULE_PARAM_DESC|
2943                                 DECLARE_PER_CPU|
2944                                 DEFINE_PER_CPU|
2945                                 __typeof__\(|
2946                                 union|
2947                                 struct|
2948                                 \.$Ident\s*=\s*|
2949                                 ^\"|\"$
2950                         }x;
2951                         #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
2952                         if ($dstat ne '' &&
2953                             $dstat !~ /^(?:$Ident|-?$Constant),$/ &&                    # 10, // foo(),
2954                             $dstat !~ /^(?:$Ident|-?$Constant);$/ &&                    # foo();
2955                             $dstat !~ /^(?:$Ident|-?$Constant)$/ &&                     # 10 // foo()
2956                             $dstat !~ /$exceptions/ &&
2957                             $dstat !~ /^\.$Ident\s*=/ &&                                # .foo =
2958                             $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ &&       # do {...} while (...); // do {...} while (...)
2959                             $dstat !~ /^for\s*$Constant$/ &&                            # for (...)
2960                             $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ &&   # for (...) bar()
2961                             $dstat !~ /^do\s*{/ &&                                      # do {...
2962                             $dstat !~ /^\({/)                                           # ({...
2963                         {
2964                                 $ctx =~ s/\n*$//;
2965                                 my $herectx = $here . "\n";
2966                                 my $cnt = statement_rawlines($ctx);
2967
2968                                 for (my $n = 0; $n < $cnt; $n++) {
2969                                         $herectx .= raw_line($linenr, $n) . "\n";
2970                                 }
2971
2972                                 if ($dstat =~ /;/) {
2973                                         ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
2974                                               "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
2975                                 } else {
2976                                         ERROR("COMPLEX_MACRO",
2977                                               "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
2978                                 }
2979                         }
2980                 }
2981
2982 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
2983 # all assignments may have only one of the following with an assignment:
2984 #       .
2985 #       ALIGN(...)
2986 #       VMLINUX_SYMBOL(...)
2987                 if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
2988                         WARN("MISSING_VMLINUX_SYMBOL",
2989                              "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
2990                 }
2991
2992 # check for redundant bracing round if etc
2993                 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
2994                         my ($level, $endln, @chunks) =
2995                                 ctx_statement_full($linenr, $realcnt, 1);
2996                         #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
2997                         #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
2998                         if ($#chunks > 0 && $level == 0) {
2999                                 my $allowed = 0;
3000                                 my $seen = 0;
3001                                 my $herectx = $here . "\n";
3002                                 my $ln = $linenr - 1;
3003                                 for my $chunk (@chunks) {
3004                                         my ($cond, $block) = @{$chunk};
3005
3006                                         # If the condition carries leading newlines, then count those as offsets.
3007                                         my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
3008                                         my $offset = statement_rawlines($whitespace) - 1;
3009
3010                                         #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
3011
3012                                         # We have looked at and allowed this specific line.
3013                                         $suppress_ifbraces{$ln + $offset} = 1;
3014
3015                                         $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
3016                                         $ln += statement_rawlines($block) - 1;
3017
3018                                         substr($block, 0, length($cond), '');
3019
3020                                         $seen++ if ($block =~ /^\s*{/);
3021
3022                                         #print "cond<$cond> block<$block> allowed<$allowed>\n";
3023                                         if (statement_lines($cond) > 1) {
3024                                                 #print "APW: ALLOWED: cond<$cond>\n";
3025                                                 $allowed = 1;
3026                                         }
3027                                         if ($block =~/\b(?:if|for|while)\b/) {
3028                                                 #print "APW: ALLOWED: block<$block>\n";
3029                                                 $allowed = 1;
3030                                         }
3031                                         if (statement_block_size($block) > 1) {
3032                                                 #print "APW: ALLOWED: lines block<$block>\n";
3033                                                 $allowed = 1;
3034                                         }
3035                                 }
3036                                 if ($seen && !$allowed) {
3037                                         WARN("BRACES",
3038                                              "braces {} are not necessary for any arm of this statement\n" . $herectx);
3039                                 }
3040                         }
3041                 }
3042                 if (!defined $suppress_ifbraces{$linenr - 1} &&
3043                                         $line =~ /\b(if|while|for|else)\b/) {
3044                         my $allowed = 0;
3045
3046                         # Check the pre-context.
3047                         if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
3048                                 #print "APW: ALLOWED: pre<$1>\n";
3049                                 $allowed = 1;
3050                         }
3051
3052                         my ($level, $endln, @chunks) =
3053                                 ctx_statement_full($linenr, $realcnt, $-[0]);
3054
3055                         # Check the condition.
3056                         my ($cond, $block) = @{$chunks[0]};
3057                         #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
3058                         if (defined $cond) {
3059                                 substr($block, 0, length($cond), '');
3060                         }
3061                         if (statement_lines($cond) > 1) {
3062                                 #print "APW: ALLOWED: cond<$cond>\n";
3063                                 $allowed = 1;
3064                         }
3065                         if ($block =~/\b(?:if|for|while)\b/) {
3066                                 #print "APW: ALLOWED: block<$block>\n";
3067                                 $allowed = 1;
3068                         }
3069                         if (statement_block_size($block) > 1) {
3070                                 #print "APW: ALLOWED: lines block<$block>\n";
3071                                 $allowed = 1;
3072                         }
3073                         # Check the post-context.
3074                         if (defined $chunks[1]) {
3075                                 my ($cond, $block) = @{$chunks[1]};
3076                                 if (defined $cond) {
3077                                         substr($block, 0, length($cond), '');
3078                                 }
3079                                 if ($block =~ /^\s*\{/) {
3080                                         #print "APW: ALLOWED: chunk-1 block<$block>\n";
3081                                         $allowed = 1;
3082                                 }
3083                         }
3084                         if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
3085                                 my $herectx = $here . "\n";
3086                                 my $cnt = statement_rawlines($block);
3087
3088                                 for (my $n = 0; $n < $cnt; $n++) {
3089                                         $herectx .= raw_line($linenr, $n) . "\n";
3090                                 }
3091
3092                                 WARN("BRACES",
3093                                      "braces {} are not necessary for single statement blocks\n" . $herectx);
3094                         }
3095                 }
3096
3097 # don't include deprecated include files (uses RAW line)
3098                 for my $inc (keys %dep_includes) {
3099                         if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
3100                                 ERROR("DEPRECATED_INCLUDE",
3101                                       "Don't use <$inc>, include " .
3102                                       "$dep_includes{$inc} instead\n" .
3103                                       $herecurr);
3104                         }
3105                 }
3106
3107 # don't use deprecated functions
3108                 for my $func (keys %dep_functions) {
3109                         if ($line =~ /\b$func\b/) {
3110                                 ERROR("DEPRECATED_FUNCTION",
3111                                       "$func is deprecated, " .
3112                                       "use $dep_functions{$func} instead\n" .
3113                                       $herecurr);
3114                         }
3115                 }
3116
3117 # try to replace assertions with error handling
3118                 if ($line =~ /\bLASSERTF?\s*\(/) {
3119                     WARN("LASSERT",
3120                          "try to replace assertions with error handling\n" .
3121                          $herecurr);
3122                 }
3123
3124 # avoid new console messages
3125                 if ($line =~ /\bLCONSOLE[A-Z_]*\s*\(/) {
3126                     WARN("LCONSOLE",
3127                          "avoid adding new console messages\n" .
3128                          $herecurr);
3129                 }
3130
3131 # minimize new CERROR messages
3132                 if ($line =~ /\bC(EMERG|ERROR|NETERR|WARN)\s*\(/) {
3133                     WARN("LCONSOLE",
3134                          "think hard before adding new CERROR messages\n" .
3135                          $herecurr);
3136                 }
3137
3138 # no volatiles please
3139                 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
3140                 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
3141                         WARN("VOLATILE",
3142                              "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
3143                 }
3144
3145 # warn about #if 0
3146                 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
3147                         CHK("REDUNDANT_CODE",
3148                             "if this code is redundant consider removing it\n" .
3149                                 $herecurr);
3150                 }
3151
3152 # check for needless kfree() checks
3153                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3154                         my $expr = $1;
3155                         if ($line =~ /\bkfree\(\Q$expr\E\);/) {
3156                                 WARN("NEEDLESS_KFREE",
3157                                      "kfree(NULL) is safe this check is probably not required\n" . $hereprev);
3158                         }
3159                 }
3160 # check for needless usb_free_urb() checks
3161                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3162                         my $expr = $1;
3163                         if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
3164                                 WARN("NEEDLESS_USB_FREE_URB",
3165                                      "usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
3166                         }
3167                 }
3168
3169 # prefer usleep_range over udelay
3170                 if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
3171                         # ignore udelay's < 10, however
3172                         if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
3173                                 CHK("USLEEP_RANGE",
3174                                     "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
3175                         }
3176                 }
3177
3178 # warn about unexpectedly long msleep's
3179                 if ($line =~ /\bmsleep\s*\((\d+)\);/) {
3180                         if ($1 < 20) {
3181                                 WARN("MSLEEP",
3182                                      "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
3183                         }
3184                 }
3185
3186 # warn about #ifdefs in C files
3187 #               if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
3188 #                       print "#ifdef in C files should be avoided\n";
3189 #                       print "$herecurr";
3190 #                       $clean = 0;
3191 #               }
3192
3193 # warn about spacing in #ifdefs
3194                 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
3195                         ERROR("SPACING",
3196                               "exactly one space required after that #$1\n" . $herecurr);
3197                 }
3198
3199 # check for spinlock_t definitions without a comment.
3200                 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
3201                     $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
3202                         my $which = $1;
3203                         if (!ctx_has_comment($first_line, $linenr)) {
3204                                 CHK("UNCOMMENTED_DEFINITION",
3205                                     "$1 definition without comment\n" . $herecurr);
3206                         }
3207                 }
3208 # check for memory barriers without a comment.
3209                 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
3210                         if (!ctx_has_comment($first_line, $linenr)) {
3211                                 CHK("MEMORY_BARRIER",
3212                                     "memory barrier without comment\n" . $herecurr);
3213                         }
3214                 }
3215 # check of hardware specific defines
3216                 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
3217                         CHK("ARCH_DEFINES",
3218                             "architecture specific defines should be avoided\n" .  $herecurr);
3219                 }
3220
3221 # Check that the storage class is at the beginning of a declaration
3222                 if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
3223                         WARN("STORAGE_CLASS",
3224                              "storage class should be at the beginning of the declaration\n" . $herecurr)
3225                 }
3226
3227 # check the location of the inline attribute, that it is between
3228 # storage class and type.
3229                 if ($line =~ /\b$Type\s+$Inline\b/ ||
3230                     $line =~ /\b$Inline\s+$Storage\b/) {
3231                         ERROR("INLINE_LOCATION",
3232                               "inline keyword should sit between storage class and type\n" . $herecurr);
3233                 }
3234
3235 # Check for __inline__ and __inline, prefer inline
3236                 if ($line =~ /\b(__inline__|__inline)\b/) {
3237                         WARN("INLINE",
3238                              "plain inline is preferred over $1\n" . $herecurr);
3239                 }
3240
3241 # Check for __attribute__ packed, prefer __packed
3242                 if ($line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
3243                         WARN("PREFER_PACKED",
3244                              "__packed is preferred over __attribute__((packed))\n" . $herecurr);
3245                 }
3246
3247 # Check for __attribute__ aligned, prefer __aligned
3248                 if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
3249                         WARN("PREFER_ALIGNED",
3250                              "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
3251                 }
3252
3253 # Check for __attribute__ format(printf, prefer __printf
3254                 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
3255                         WARN("PREFER_PRINTF",
3256                              "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr);
3257                 }
3258
3259 # check for sizeof(&)
3260                 if ($line =~ /\bsizeof\s*\(\s*\&/) {
3261                         WARN("SIZEOF_ADDRESS",
3262                              "sizeof(& should be avoided\n" . $herecurr);
3263                 }
3264
3265 # check for line continuations in quoted strings with odd counts of "
3266                 if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
3267                         WARN("LINE_CONTINUATIONS",
3268                              "Avoid line continuations in quoted strings\n" . $herecurr);
3269                 }
3270
3271 # Check for misused memsets
3272                 if (defined $stat &&
3273                     $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) {
3274
3275                         my $ms_addr = $2;
3276                         my $ms_val = $8;
3277                         my $ms_size = $14;
3278
3279                         if ($ms_size =~ /^(0x|)0$/i) {
3280                                 ERROR("MEMSET",
3281                                       "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
3282                         } elsif ($ms_size =~ /^(0x|)1$/i) {
3283                                 WARN("MEMSET",
3284                                      "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
3285                         }
3286                 }
3287
3288 # typecasts on min/max could be min_t/max_t
3289                 if (defined $stat &&
3290                     $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
3291                         if (defined $2 || defined $8) {
3292                                 my $call = $1;
3293                                 my $cast1 = deparenthesize($2);
3294                                 my $arg1 = $3;
3295                                 my $cast2 = deparenthesize($8);
3296                                 my $arg2 = $9;
3297                                 my $cast;
3298
3299                                 if ($cast1 ne "" && $cast2 ne "") {
3300                                         $cast = "$cast1 or $cast2";
3301                                 } elsif ($cast1 ne "") {
3302                                         $cast = $cast1;
3303                                 } else {
3304                                         $cast = $cast2;
3305                                 }
3306                                 WARN("MINMAX",
3307                                      "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
3308                         }
3309                 }
3310
3311 # check for new externs in .c files.
3312                 if ($realfile =~ /\.c$/ && defined $stat &&
3313                     $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
3314                 {
3315                         my $function_name = $1;
3316                         my $paren_space = $2;
3317
3318                         my $s = $stat;
3319                         if (defined $cond) {
3320                                 substr($s, 0, length($cond), '');
3321                         }
3322                         if ($s =~ /^\s*;/ &&
3323                             $function_name ne 'uninitialized_var')
3324                         {
3325                                 WARN("AVOID_EXTERNS",
3326                                      "externs should be avoided in .c files\n" .  $herecurr);
3327                         }
3328
3329                         if ($paren_space =~ /\n/) {
3330                                 WARN("FUNCTION_ARGUMENTS",
3331                                      "arguments for function declarations should follow identifier\n" . $herecurr);
3332                         }
3333
3334                 } elsif ($realfile =~ /\.c$/ && defined $stat &&
3335                     $stat =~ /^.\s*extern\s+/)
3336                 {
3337                         WARN("AVOID_EXTERNS",
3338                              "externs should be avoided in .c files\n" .  $herecurr);
3339                 }
3340
3341 # checks for new __setup's
3342                 if ($rawline =~ /\b__setup\("([^"]*)"/) {
3343                         my $name = $1;
3344
3345                         if (!grep(/$name/, @setup_docs)) {
3346                                 CHK("UNDOCUMENTED_SETUP",
3347                                     "__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
3348                         }
3349                 }
3350
3351 # check for pointless casting of kmalloc return
3352                 if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
3353                         WARN("UNNECESSARY_CASTS",
3354                              "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
3355                 }
3356
3357 # check for multiple semicolons
3358                 if ($line =~ /;\s*;\s*$/) {
3359                     WARN("ONE_SEMICOLON",
3360                          "Statements terminations use 1 semicolon\n" . $herecurr);
3361                 }
3362
3363 # check for gcc specific __FUNCTION__
3364                 if ($line =~ /__FUNCTION__/) {
3365                         WARN("USE_FUNC",
3366                              "__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
3367                 }
3368
3369 # check for semaphores initialized locked
3370                 if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
3371                         WARN("CONSIDER_COMPLETION",
3372                              "consider using a completion\n" . $herecurr);
3373
3374                 }
3375 # recommend kstrto* over simple_strto* and strict_strto*
3376                 if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
3377                         WARN("CONSIDER_KSTRTO",
3378                              "$1 is obsolete, use k$3 instead\n" . $herecurr);
3379                 }
3380 # check for __initcall(), use device_initcall() explicitly please
3381                 if ($line =~ /^.\s*__initcall\s*\(/) {
3382                         WARN("USE_DEVICE_INITCALL",
3383                              "please use device_initcall() instead of __initcall()\n" . $herecurr);
3384                 }
3385 # check for various ops structs, ensure they are const.
3386                 my $struct_ops = qr{acpi_dock_ops|
3387                                 address_space_operations|
3388                                 backlight_ops|
3389                                 block_device_operations|
3390                                 dentry_operations|
3391                                 dev_pm_ops|
3392                                 dma_map_ops|
3393                                 extent_io_ops|
3394                                 file_lock_operations|
3395                                 file_operations|
3396                                 hv_ops|
3397                                 ide_dma_ops|
3398                                 intel_dvo_dev_ops|
3399                                 item_operations|
3400                                 iwl_ops|
3401                                 kgdb_arch|
3402                                 kgdb_io|
3403                                 kset_uevent_ops|
3404                                 lock_manager_operations|
3405                                 microcode_ops|
3406                                 mtrr_ops|
3407                                 neigh_ops|
3408                                 nlmsvc_binding|
3409                                 pci_raw_ops|
3410                                 pipe_buf_operations|
3411                                 platform_hibernation_ops|
3412                                 platform_suspend_ops|
3413                                 proto_ops|
3414                                 rpc_pipe_ops|
3415                                 seq_operations|
3416                                 snd_ac97_build_ops|
3417                                 soc_pcmcia_socket_ops|
3418                                 stacktrace_ops|
3419                                 sysfs_ops|
3420                                 tty_operations|
3421                                 usb_mon_operations|
3422                                 wd_ops}x;
3423                 if ($line !~ /\bconst\b/ &&
3424                     $line =~ /\bstruct\s+($struct_ops)\b/) {
3425                         WARN("CONST_STRUCT",
3426                              "struct $1 should normally be const\n" .
3427                                 $herecurr);
3428                 }
3429
3430 # use of NR_CPUS is usually wrong
3431 # ignore definitions of NR_CPUS and usage to define arrays as likely right
3432                 if ($line =~ /\bNR_CPUS\b/ &&
3433                     $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
3434                     $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
3435                     $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
3436                     $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
3437                     $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
3438                 {
3439                         WARN("NR_CPUS",
3440                              "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
3441                 }
3442
3443 # check for %L{u,d,i} in strings
3444                 my $string;
3445                 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
3446                         $string = substr($rawline, $-[1], $+[1] - $-[1]);
3447                         $string =~ s/%%/__/g;
3448                         if ($string =~ /(?<!%)%L[udi]/) {
3449                                 WARN("PRINTF_L",
3450                                      "\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
3451                                 last;
3452                         }
3453                 }
3454
3455 # whine mightly about in_atomic
3456                 if ($line =~ /\bin_atomic\s*\(/) {
3457                         if ($realfile =~ m@^drivers/@) {
3458                                 ERROR("IN_ATOMIC",
3459                                       "do not use in_atomic in drivers\n" . $herecurr);
3460                         } elsif ($realfile !~ m@^kernel/@) {
3461                                 WARN("IN_ATOMIC",
3462                                      "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
3463                         }
3464                 }
3465
3466 # check for lockdep_set_novalidate_class
3467                 if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
3468                     $line =~ /__lockdep_no_validate__\s*\)/ ) {
3469                         if ($realfile !~ m@^kernel/lockdep@ &&
3470                             $realfile !~ m@^include/linux/lockdep@ &&
3471                             $realfile !~ m@^drivers/base/core@) {
3472                                 ERROR("LOCKDEP",
3473                                       "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
3474                         }
3475                 }
3476
3477                 if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
3478                     $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
3479                         WARN("EXPORTED_WORLD_WRITABLE",
3480                              "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
3481                 }
3482
3483                 if ($rawline =~ /version 3/) {
3484                         WARN("GPLV3",
3485                              "using GPLv3 is usually wrong\n" . $herecurr);
3486                 }
3487         }
3488
3489         # If we have no input at all, then there is nothing to report on
3490         # so just keep quiet.
3491         if ($#rawlines == -1) {
3492                 exit(0);
3493         }
3494
3495         # In mailback mode only produce a report in the negative, for
3496         # things that appear to be patches.
3497         if ($mailback && ($clean == 1 || !$is_patch)) {
3498                 exit(0);
3499         }
3500
3501         # This is not a patch, and we are are in 'no-patch' mode so
3502         # just keep quiet.
3503         if (!$chk_patch && !$is_patch) {
3504                 exit(0);
3505         }
3506
3507         if (!$is_patch) {
3508                 ERROR("NOT_UNIFIED_DIFF",
3509                       "Does not appear to be a unified-diff format patch\n");
3510         }
3511         if ($is_patch && $chk_signoff && $signoff == 0) {
3512                 ERROR("MISSING_SIGN_OFF",
3513                       "Missing Signed-off-by: line(s)\n");
3514         }
3515
3516         print report_dump();
3517         if ($summary && !($clean == 1 && $quiet == 1)) {
3518                 print "$filename " if ($summary_file);
3519                 print "total: $cnt_error errors, $cnt_warn warnings, " .
3520                         (($check)? "$cnt_chk checks, " : "") .
3521                         "$cnt_lines lines checked\n";
3522                 print "\n" if ($quiet == 0);
3523         }
3524
3525         if ($quiet == 0) {
3526                 # If there were whitespace errors which cleanpatch can fix
3527                 # then suggest that.
3528                 if ($rpt_cleaners) {
3529                         print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
3530                         print "      scripts/cleanfile\n\n";
3531                         $rpt_cleaners = 0;
3532                 }
3533         }
3534
3535         if (keys %ignore_type) {
3536             print "NOTE: Ignored message types:";
3537             foreach my $ignore (sort keys %ignore_type) {
3538                 print " $ignore";
3539             }
3540             print "\n";
3541             print "\n" if ($quiet == 0);
3542         }
3543
3544         if ($clean == 1 && $quiet == 0) {
3545                 print "$vname has no obvious style problems and is ready for submission.\n"
3546         }
3547         if ($clean == 0 && $quiet == 0) {
3548                 print << "EOM";
3549 $vname has style problems, please review.
3550
3551 If any of these errors are false positives, please report
3552 them to the maintainer, see CHECKPATCH in MAINTAINERS.
3553 EOM
3554         }
3555
3556         return $clean;
3557 }