LU-17065 build: Remove snmp support Last patched in 2012 and not well tended to before that, snmp support can probably be removed. Signed-off-by: Patrick Farrell <pfarrell@whamcloud.com> Signed-off-by: Timothy Day <timday@amazon.com> Change-Id: I1831aed42e560531e57a6ff8aa978f3e5286fd44 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52194 Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Reviewed-by: Oleg Drokin <green@whamcloud.com> Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com>
LU-15838 autoconf: fix use of obsolete macros This patch fixes the following warnings when using autoconf 2.71: configure.ac:2: warning: AC_INIT: not a literal: "m4_esyscmd(sh -c "./LUSTRE-VERSION-GEN | tr -d '\n'")" configure.ac:10: warning: The macro `AC_CANONICAL_SYSTEM' is obsolete. configure.ac:16: warning: The macro `AC_PROG_LIBTOOL' is obsolete. configure.ac:24: warning: The macro `AC_HELP_STRING' is obsolete. Like m4_esyscmd, macro m4_esyscmd_s (introduced in autoconf 2.64) expands to the result of running command in a shell. The difference is that any trailing newlines are removed. Since autoconf 2.50, macro 'AC_CANONICAL_TARGET' has been the new name of 'AC_CANONICAL_SYSTEM': AU_ALIAS([AC_CANONICAL_SYSTEM], [AC_CANONICAL_TARGET]) Since autoconf 2.58, macro 'AS_HELP_STRING' has been added to replace 'AC_HELP_STRING'. Since libtool 2.0, new 'LT_INIT' interface has been added to replace 'AC_PROG_LIBTOOL'. Change-Id: I3c06c21460d7a2cf643fe825e72a26a5416609cf Signed-off-by: Jian Yu <yujian@whamcloud.com> Reviewed-on: https://review.whamcloud.com/47288 Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Neil Brown <neilb@suse.de> Reviewed-by: James Simmons <jsimmons@infradead.org> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-15420 uapi: avoid gcc-11 -Werror=stringop-overread GCC 11 warns about string and memory operations on fixed address: In function ‘strlen’, inlined from ‘changelog_rec_sname’ at include/uapi/linux/lustre/lustre_user.h:1981:19, inlined from ‘mdd_changelog_rec_ext_rename’ at lustre/mdd/mdd_dir.c:932:2, inlined from ‘mdd_changelog_ns_store’ at lustre/mdd/mdd_dir.c:1061:3: include/linux/fortify-string.h:25:33: error: ‘__builtin_strlen’ reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread] 25 | #define __underlying_strlen __builtin_strlen The reason is that we are looking for an address right after the end of the chanelog record header which gcc thinks is an overrun. Rework the code to allow us to index the memory right after the changelog record header. Also fix a long hidden bug in the lustre snmp code. Change-Id: I13479b9074a392330d39f01656b26f9e9a91a8ec Signed-off-by: James Simmons <jsimmons@infradead.org> Reviewed-on: https://review.whamcloud.com/46319 Tested-by: jenkins <devops@whamcloud.com> Reviewed-by: Alexey Lyashkov <alexey.lyashkov@hpe.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Jian Yu <yujian@whamcloud.com> Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
LU-14487 lustre: remove references to Sun Trademark. "lustre" is no longer a Trademark of Sun Microsystems. There is no need to acknowledge the trademark is every file, so just remove all these claims. Test-Parameters: trivial Signed-off-by: Mr NeilBrown <neilb@suse.de> Change-Id: I214670b39c5718f2b691193f268a64856e0cd743 Reviewed-on: https://review.whamcloud.com/41880 Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Reviewed-by: James Simmons <jsimmons@infradead.org>
LU-9679 general: avoid bare return; at end of void function Having: return; } at the end of a void function is unnecessary noise. Where it is the *only* statement in the function, it can be useful, so that remain unchanged. The rest have been removed. Test-Parameters: trivial Signed-off-by: Mr NeilBrown <neilb@suse.de> Change-Id: If02f6f5b91d4134cf95a68ebccc83df28c360fb2 Reviewed-on: https://review.whamcloud.com/36654 Tested-by: jenkins <devops@whamcloud.com> Reviewed-by: Shaun Tancheff <stancheff@cray.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Petros Koutoupis <pkoutoupis@cray.com> Reviewed-by: Ben Evans <bevans@cray.com> Reviewed-by: James Simmons <jsimmons@infradead.org> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-5541 build: move libcfs and liblustreapi over to libtool Change libcfs into a convenience library using libtool. This allows use to embbed libcfs library into both liblnetconfig and liblustreapi so their is no longer a need to link applications to libcfs.a anymore. With this change we need migrate liblustreapi to libtool. libtool knows how to build both static and dymanic libraries for liblusteapi, so no need to hack the Makefile. As two added benefits, the utilities will now use the dynamic version, thus reducing their footprint, and calling make twice in a row won't rebuild objects already built. Test-Parameters: trivial Change-Id: Icc1e5d42df503b9bf393396fe09f4e4f1f242486 Signed-off-by: frank zago <fzago@cray.com> Signed-off-by: James Simmons <uja.ornl@yahoo.com> Reviewed-on: https://review.whamcloud.com/30562 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-6210 snmp: Change positional struct initializers to C99 This patch makes no functional changes. Struct initializers in the snmp directory that use C89 or GCC-only syntax are updated to C99 syntax. The C99 syntax prevents incorrect initialization if values are accidently placed in the wrong position, allows changes in the struct definition, and clears any members that are not given an explicit value. The following struct initializers have been updated: snmp/lustre-snmp.c: struct variable7 clusterFileSystems_variables[] struct oid_table osd_table[] struct oid_table osc_table[] struct oid_table mds_table[] struct oid_table mdc_table[] struct oid_table cli_table[] struct oid_table lov_table[] struct oid_table ldlm_table[] Test-Parameters: trivial Signed-off-by: Steve Guminski <stephenx.guminski@intel.com> Change-Id: Iaedd0165bca2a2af2ce6a0f535602a85c6217da8 Reviewed-on: https://review.whamcloud.com/23463 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Frank Zago <fzago@cray.com> Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: James Simmons <uja.ornl@yahoo.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-8648 all: remove all Sun license and URL references The link to the GPL license at Sun is no longer there. Also Sun Inc is gone so lets remove all references to it in our source code. Test-Parameters: trivial Change-Id: Ib47d07dcef49a1ef624d0d8a4a91b9731f486278 Signed-off-by: James Simmons <uja.ornl@yahoo.com> Reviewed-on: http://review.whamcloud.com/22800 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: John L. Hammond <john.hammond@intel.com> Reviewed-by: Frank Zago <fzago@cray.com>
LU-5030 snmp: migrate lustre SNMP utilites to use cfs_get_paths Move the SNMP lustre tools to use cfs_get_paths so the tools function with the upstream client as well. Change-Id: I18d76e10c45a9c8c582e77917a33bb2afa86aac4 Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by: James Simmons <uja.ornl@yahoo.com> Signed-off-by: Wang Chao <chao.ornl@gmail.com> Reviewed-on: http://review.whamcloud.com/17465 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Emoly Liu <emoly.liu@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-7356 build: handle library configure options for SNMP/LNet Currently if you build lustre with configure options --disable-shared and/or --disable-static it will fail to build in the case of the mount plugins or just plain ignore the configure request. This work enables the ability to create only static or only dynamic libraries for lustre SNMP and libnetconfig. Change-Id: I8b526acd50a7b8eb4f65e7a3bdd0a664e9144376 Signed-off-by: James Simmons <uja.ornl@yahoo.com> Reviewed-on: http://review.whamcloud.com/17576 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com> Reviewed-by: Bob Glossman <bob.glossman@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-5710 all: third batch of corrected typos and grammar errors All the typos are in comments or logs. Signed-off-by: frank zago <fzago@cray.com> Change-Id: I3af7baa3cda6774b48e5651fd0591b2dade1131e Reviewed-on: http://review.whamcloud.com/14424 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: James Simmons <uja.ornl@yahoo.com> Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-5710 all: second batch of corrected typos and grammar errors Most of them are in comments, but there was a few in user visible help. Signed-off-by: frank zago <fzago@cray.com> Change-Id: I32730030f84b85e0ae08b683d64bbad5e33bf0b4 Reviewed-on: http://review.whamcloud.com/12933 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: James Simmons <uja.ornl@gmail.com> Reviewed-by: Bob Glossman <bob.glossman@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-2675 build: assume __linux__ and __KERNEL__ Assume that __linux__is defined everywhere and that __KERNEL__ is defined in most of lustre/. Signed-off-by: John L. Hammond <john.hammond@intel.com> Change-Id: Ia04e7ed4c3ab3e8ca205e14eaa1824536aedd1e3 Reviewed-on: http://review.whamcloud.com/11437 Reviewed-by: Bob Glossman <bob.glossman@intel.com> Tested-by: Jenkins Reviewed-by: Oleg Drokin <oleg.drokin@intel.com> Tested-by: Oleg Drokin <oleg.drokin@intel.com>
LU-4606 utils: Mount uses so for backing fstype Make mount/mkfs/tunefs functionality a per backing FSTYPE shared object that is loadable, and seperately buildable and installable in the appropriate lustre-osd-FSTYPE rpm. For ZFS this allows the shared object to be directly linked to libzfs and thus remove the hardcoding of a libzfs.so version in the lustre source. This also has the benefit of making lustre-osd-zfs explicitly requires libzfs (which it needs to do mount/mkfs operations). Adjust build system to allow building of loadable module. Including requiering libtool as part of the build. Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com> Change-Id: I8fc0f41161dc08405c1f951f12e675f364ff62c3 Reviewed-on: http://review.whamcloud.com/10193 Tested-by: Jenkins Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com> Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-3953 build: cache the results of configure between runs This modification allow configure script cache the results of heavy (required compilation) configure tests run on this system so they can be shared between configure scripts and configure runs, see configure's option --config-cache. This is very useful for several configurations on the same machine with different --enable/disable options. The time of first clean pass: time ./configure -C real 1m9.879s user 0m33.390s sys 0m30.392s The time of second pass with cached results: time ./configure -C real 0m10.190s user 0m2.900s sys 0m4.832s Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com> Change-Id: I41b8091331e8f5260262829ad3e24f34ee34c76b Reviewed-on: http://review.whamcloud.com/9582 Tested-by: Jenkins Reviewed-by: Bob Glossman <bob.glossman@intel.com> Reviewed-by: Brian J. Murrell <brian.murrell@intel.com> Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-3404 build: fix 'incorrect expression' errors Fix 'program hangs' defects found by Coverity version 6.5.1: Array compared against 0 (NO_EFFECT) Comparing an array to null is not useful. Copy-paste error (COPY_PASTE_ERROR) This line looks like a copy-paste error. Self assignment (NO_EFFECT) Assignment operation has no effect. Side effect in assertion (ASSERT_SIDE_EFFECT) Assignment has a side effect. This code will work differently in a non-debug build. You might have intended to use a comparison instead. Wrong sizeof argument (SIZEOF_MISMATCH) Passing argument is suspicious. Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net> Change-Id: Iad370305cb8540f7c1b918e53ceae32e9ccbba8f Reviewed-on: http://review.whamcloud.com/6465 Tested-by: Hudson Tested-by: Maloo <whamcloud.maloo@gmail.com> Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
LU-1460 snmp: Expose lnet stats through SNMP Add to the MIB and lustre functionality to monitor lnet stats via SNMP Signed-off-by: Jeremy Filizetti <jeremy.filizetti@gmail.com> Change-Id: I9ae360d7e100af5aef34a6b645fce963376928d1 Reviewed-on: http://review.whamcloud.com/4823 Tested-by: Hudson Tested-by: Maloo <whamcloud.maloo@gmail.com> Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
LU-2446 build: Update Whamcloud copyright messages for Intel Update the copyright messages for master branch for Intel. This is the result of the updatecw.sh script. Signed-off-by: Keith Mannthey <keith.mannthey@intel.com> Change-Id: Id8dc454e7a5b6dffef64aa6efefeaaaea966d780 Reviewed-on: http://review.whamcloud.com/4812 Tested-by: Hudson Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Tested-by: Maloo <whamcloud.maloo@gmail.com> Reviewed-by: Bob Glossman <bob.glossman@intel.com>
LU-1808 build: Lustre build does not support FC15. Change lbuild to support for FC15 and calm down warning message. Signed-off-by: yang sheng <ys@whamcloud.com> Change-Id: I365f708f82c01b0f72aeffa3c09e46800ca770d5 Reviewed-on: http://review.whamcloud.com/3849 Tested-by: Hudson Reviewed-by: Jinshan Xiong <jinshan.xiong@whamcloud.com> Reviewed-by: Chris Gearing <chris.gearing@intel.com> Reviewed-by: Brian J. Murrell <brian@whamcloud.com> Tested-by: Maloo <whamcloud.maloo@gmail.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-1617 build: skip generated files in .gitignore Ignore automatically generated files via .gitignore so that a large number of spurious files are not listed at "git commit" time. Also consolidate many duplicate ignored files in the top-level .gitignore file, since we don't need to list the exceptions in every directory like the original .cvsignore files that they were generated from. Signed-off-by: Andreas Dilger <adilger@whamcloud.com> Change-Id: I5f9c60dc498f98abcd8c91042fc72408a915500c Reviewed-on: http://review.whamcloud.com/3364 Reviewed-by: Yu Jian <yujian@whamcloud.com> Tested-by: Hudson Tested-by: Maloo <whamcloud.maloo@gmail.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>