LU-16861 obdfilter: Exclude quotes when getting NIDs In get_targets(), when getting NIDs the quotes were also included. Exclude quotes when generating NIDs as they are not required. Use $LCTL instead of $lctl, and make it also work in Janitor testing. Test-Parameters: trivial testlist=obdfilter-survey Fixes: 9ef9906d7 ("LU-6863 tests: change obdfilter-survey.sh for CLIENTONLY mode") Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com> Change-Id: I8642539fc6b396f1339e20e4fef8bc78cda2d969 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53620 Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: James Simmons <jsimmons@infradead.org> Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Reviewed-by: Alex Deiter <alex.deiter@gmail.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-16827 obdfilter: Fix "emfperf obdfilter-survey" error This patch fixes the definition of the lctl variable. It changes the logic so that the LCTL value is assigned only when it was defined earlier. Fixes: 91a3b286ba ("LU-16827 obdfilter: Fix obdfilter-survery/1a") Test-Parameters: trivial testlist=obdfilter-survey Signed-off-by: Vitaliy Kuznetsov <vkuznetsov@ddn.com> Change-Id: I4dfd7e3d1f78208b33b897d8e6680e59b690014c Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53083 Reviewed-by: Oleg Drokin <green@whamcloud.com> Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Reviewed-by: Arshad Hussain <arshad.hussain@aeoncomputing.com> Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com>
LU-16834 obdfilter: Do not attach device if already present Running obdfilter-survey where "case=disk" and targets are repeated with same OST's names. obdfilter-survey throws "error: attach: File exists". This is because the on the first iteration the attach and setup is already done and subsequently the attach fails as the device/uuid is already present. Test-Parameters: trivial testlist=obdfilter-survey Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com> Change-Id: I8ab9ea905ec86b9e1aa8906bebcc38fee0fdbc23 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51034 Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com> Reviewed-by: Timothy Day <timday@amazon.com> Reviewed-by: Chris Horn <chris.horn@hpe.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-16827 obdfilter: Fix obdfilter-survery/1a local_node() under test-framework is used to determine if the node is remote or local local_node() returns "true" if the node is local. Else for remote node it return "false" This patch fixes obdfilter/1a test case which which was making reverse logic call to local_node() to determine remote/local node This patch modifies local_node() to return "true"/"false" instead of 0/1 This patch also replaces lctl with $LCTL Test-Parameters: testlist=obdfilter-survey Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com> Change-Id: I7bcb483975ec46d9847e0050e5a1f22f68663c80 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51035 Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-15357 iokit: fix the obsolete usage of cfg_device The LCTL command "cfg_device" is obsolete and some operations (such as "cleanup", "detach") don't support it anymore. In mds_survey and lfsck-performance it causes the echo client device not to be destroyed and causes LBUG when umounting the related Lustre device. Change-Id: If7f6eff080906e395023289652fcd2a78dfb6fb7 Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Signed-off-by: Mikhail Pershin <mpershin@whamcloud.com> Reviewed-on: https://review.whamcloud.com/45872 Tested-by: jenkins <devops@whamcloud.com> Reviewed-by: Colin Faber <cfaber@ddn.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-10994 test: remove netdisk from obdfilter-survey Remove the netdisk case from obdfilter-survey. Remove subtests that use echo_client over osc devices. Signed-off-by: John L. Hammond <jhammond@whamcloud.com> Change-Id: I260001241cee3027f68e62077e5817221bd0c08b Reviewed-on: https://review.whamcloud.com/47239 Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com> Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Bobi Jam <bobijam@hotmail.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-14487 lustre: remove references to Sun Trademark. "lustre" is no longer a Trademark of Sun Microsystems. There is no need to acknowledge the trademark is every file, so just remove all these claims. Test-Parameters: trivial Signed-off-by: Mr NeilBrown <neilb@suse.de> Change-Id: I214670b39c5718f2b691193f268a64856e0cd743 Reviewed-on: https://review.whamcloud.com/41880 Tested-by: jenkins <devops@whamcloud.com> Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Reviewed-by: James Simmons <jsimmons@infradead.org>
LU-12219 obdfilter: changes PAGE_SIZE variable obdfilter-survey uses PAGE_SIZE in KBytes. After LU-11597 PAGE_SIZE exported from test-framework.sh in bytes. So it confuses obdfilter-survey and lead to error: /usr/bin/obdfilter-survey: line 509: size * 1024 / (actual_rsz * thr): division by 0 (error token is ")") Patch changes the name to PAGE_SIZE_KB. Fixes: f602b5ec7f4 ("LU-11597 tests: fix O_DIRECT test usage for ARM") Test-Parameters: trivial testlist=obdfilter-survey Signed-off-by: Alexander Boyko <c17825@cray.com> Cray-bug-id: LUS-7214 Change-Id: Ie8be852c9634569c59a770ba49c3d1c36f53fdb2 Reviewed-on: https://review.whamcloud.com/34754 Reviewed-by: Elena Gryaznova <c17455@cray.com> Reviewed-by: Andreas Dilger <adilger@whamcloud.com> Tested-by: Jenkins Tested-by: Maloo <maloo@whamcloud.com> Reviewed-by: Oleg Drokin <green@whamcloud.com>
LU-3665 tests: Cleanup echo client after obdfilter-survey Some failures of obdfilter-survey do not cause an error in obdfilter-survey.sh In some cases obdfilter-survey did not cleanup echo clients it had created and that could hang umount of osts. Change test-framework.sh::cleanupall to remove echo clients before trying to umount to prevent the echo clients from holding the OST or MDS/MGS open forever. Test-Parameters: trivial testlist=obdfilter-survey osscount=1 ostcount=2 mdscount=1 mdtcount=1 Test-Parameters: trivial testlist=obdfilter-survey mdtfilesystemtype=zfs ostfilesystemtype=zfs osscount=1 ostcount=2 mdscount=1 mdtcount=1 Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com> Change-Id: I63ae59da84101c782aa9d5e7216cce3b3b1ff2fe Reviewed-on: https://review.whamcloud.com/9350 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Mike Pershin <mike.pershin@intel.com> Reviewed-by: Andriy Skulysh <c17819@cray.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-7420 echo: fix echo server to work with unified target After Unified Target introduction the echo server lost its ability to serve incoming request, i.e. works like fake OFD. Patch restores that functionality, so echo server is able to process requests from the echo client via network. Test-Parameters: trivial testlist=obdfilter-survey Signed-off-by: Mikhail Pershin <mike.pershin@intel.com> Signed-off-by: Elena Gryaznova <c17455@cray.com> Change-Id: I0c0d347486463ce320c7c66a1f85f6979b9a3681 Reviewed-on: https://review.whamcloud.com/18443 Reviewed-by: Alexey Lyashkov <c17817@cray.com> Reviewed-by: Andriy Skulysh <c17819@cray.com> Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-6863 tests: change obdfilter-survey.sh for CLIENTONLY mode obdfilter-survey.sh requires server access and can not be used for CLIENTONLY mode: get_devs $oss -> do_nodes $oss "lctl dl" host_nids_address $oss -> do_nodes $oss "$LCTL list_nids" Patch fixes the script to compose the targets list without access to servers. Test-Parameters: trivial testlist=obdfilter-survey Signed-off-by: Elena Gryaznova <c17455@cray.com> Cray-bug-id: MRP-1757 Reviewed-by: Alexey Lyashkov <c17817@cray.com> Reviewed-by: Vitaly Fertman <c17818@cray.com> Change-Id: I910afc940a29ea4f5d8928131652f9b6ef809ce7 Reviewed-on: https://review.whamcloud.com/15631 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Jian Yu <jian.yu@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-10308 misc: update Intel copyright messages for 2017 Update copyright messages for files updated in 2016, excluding trivial patches. Add trivial patches to updatecw.sh script exclude list. Revert some changes that were incorrectly attributed to the 2016 (d10200a80770f0029d1d665af954187b9ad883df) and 2015 (0754bc8f2623bea184111af216f7567608db35b6) copyright update patches themselves, since they were not in the exclude list when the subsequent script was run. Test-Parameters: trivial Signed-off-by: Andreas Dilger <andreas.dilger@intel.com> Change-Id: I82f21c30c4dac75792bb49fc139bee2ca51f5545 Reviewed-on: https://review.whamcloud.com/30341 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Jian Yu <jian.yu@intel.com> Reviewed-by: James Nunez <james.a.nunez@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-9533 tests: fix get_lustre_version in obdfilter-survey Retrieve the lustre version using the same method as in test-framework.sh so that it works for every versions of Lustre. Signed-off-by: Gregoire Pichon <gregoire.pichon@bull.net> Change-Id: I1fb14961b4ef1d5f3365ba78590459c5e6a75aef Reviewed-on: https://review.whamcloud.com/27338 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Justin Miller <jmiller@cray.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
LU-9521 tests: Avoid cleanup() being called twice. /usr/bin/*-survey when ran, - calls cleanup() twice, resulting in non-zero exit status, - and attempts to cleanup already cleaned/detached echo client, resulting in invalid argument. This patch fixes the same. Test-Parameters: trivial testlist=obdfilter-survey Signed-off-by: Parinay Kondekar <Parinay.Kondekar@seagate.com> Change-Id: I5bb1fe5d7e6adf15e81d88501d6edbda1c5ef3c3 Reviewed-on: https://review.whamcloud.com/27160 Tested-by: Jenkins Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Bob Glossman <bob.glossman@intel.com>
LU-9231 tests: cleanup obdecho before iokit exit Otherwise under some failure cases, it may leave the FID_SEQ_LOCAL_NAME local object which is used by the obdecho in the system, then the subsequent tests can NOT exit cleanly. Lustre-commit: c5675497b411d8b3f0f08fec3271fd528b4a52cf Lustre-change: http://review.whamcloud.com/23738 Test-Parameters: alwaysuploadlogs envdefinitions=PTLDEBUG=-1,DEBUG_SIZE=150 mdtfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs clientdistro=el7 ossdistro=el7 mdsdistro=el7 mdscount=2 mdtcount=4 testlist=mds-survey,mmp,mds-survey,mmp,mds-survey,mmp Signed-off-by: Fan Yong <fan.yong@intel.com> Signed-off-by: Bob Glossman <bob.glossman@intel.com> Change-Id: I741cf20875df679ecdf72d5461cc14eec166e3ae Reviewed-by: Jian Yu <jian.yu@intel.com> Reviewed-by: John L. Hammond <john.hammond@intel.com> Reviewed-on: https://review.whamcloud.com/26092 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-8648 all: remove all Sun license and URL references The link to the GPL license at Sun is no longer there. Also Sun Inc is gone so lets remove all references to it in our source code. Test-Parameters: trivial Change-Id: Ib47d07dcef49a1ef624d0d8a4a91b9731f486278 Signed-off-by: James Simmons <uja.ornl@yahoo.com> Reviewed-on: http://review.whamcloud.com/22800 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: John L. Hammond <john.hammond@intel.com> Reviewed-by: Frank Zago <fzago@cray.com>
LU-8078 iokit: correct obdfilter-survey output data format A space is needed between min and max status numbers in the obdfilter-survey script, otherwise plot-obdfilter can't parse the summary file correctly, so that the related .dat files and graphs can't be generated correctly. Test-Parameters: trivial testlist=obdfilter-survey Signed-off-by: Emoly Liu <emoly.liu@intel.com> Change-Id: I5bf4790f2db1ee11cb6a7cc95d5527cb0d68e35a Reviewed-on: http://review.whamcloud.com/19841 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Bobi Jam <bobijam@hotmail.com> Reviewed-by: Jian Yu <jian.yu@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-7209 doc: more accurate documentation for obdfilter-survey Make the the description of obdfilter-survey accurate and precise. Signed-off-by: Richard Henwood <richard.henwood@intel.com> Change-Id: Icdd4adf53643e91dc8a2539f63977aae5fe28fe0 Reviewed-on: http://review.whamcloud.com/16646 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Omkar Kulkarni <omkar.kulkarni@intel.com> Tested-by: Omkar Kulkarni <omkar.kulkarni@intel.com> Reviewed-by: Cliff White <cliff.white@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-6385 tests: sync I/O in obdfilter-survey This ensures I/O is synced before each test. Previous patch http://review.whamcloud.com/14143 works only with the Lustre test framework. This will ensure I/O is always sysnced. Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com> Change-Id: Ib19a9e4afd8ca83deceb78fe8fdb4d231da0bc40 Reviewed-on: http://review.whamcloud.com/16942 Tested-by: Jenkins Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com> Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Bob Glossman <bob.glossman@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-6385 tests: Sync OSTs between tests in obdfilter-survey osd-ldiskfs and osd-zfs operate differently with regards to writeback cache. This adds a force sync between test runs so that a test list of "write read" will have all writes finished before reads starts for both ldiskfs and zfs. Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com> Change-Id: I3414a595220d9eb65145f8246ed5e243c112b866 Reviewed-on: http://review.whamcloud.com/14143 Tested-by: Jenkins Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>