From 9a7c0e1207becd10fb70672193ca39cbfabdcf84 Mon Sep 17 00:00:00 2001 From: Sebastien Buisson Date: Thu, 11 Aug 2016 18:36:00 +0900 Subject: [PATCH] LU-7845 lnet: check if ni is in current net namespace Add new 'ni_net_ns' field to struct lnet_ni to hold a reference to original net namespace in which ni is created. In LNetDist(), check if ni was created in same net namespace as current's one. If not, assign order above 0xffff0000, to make this ni not a priority. Signed-off-by: Sebastien Buisson Change-Id: I5abde6e325983352b42c0eafe16aef22567e3e0e Reviewed-on: http://review.whamcloud.com/21884 Tested-by: Jenkins Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Tested-by: Maloo Reviewed-by: Oleg Drokin --- lnet/include/lnet/lib-types.h | 1 + lnet/lnet/config.c | 14 ++++++++++++++ lnet/lnet/lib-move.c | 19 ++++++++++++++----- 3 files changed, 29 insertions(+), 5 deletions(-) diff --git a/lnet/include/lnet/lib-types.h b/lnet/include/lnet/lib-types.h index 1a1b090..c8f0fb5 100644 --- a/lnet/include/lnet/lib-types.h +++ b/lnet/include/lnet/lib-types.h @@ -291,6 +291,7 @@ typedef struct lnet_ni { struct lnet_ioctl_config_lnd_tunables *ni_lnd_tunables; /* equivalent interfaces to use */ char *ni_interfaces[LNET_MAX_INTERFACES]; + struct net *ni_net_ns; /* original net namespace */ } lnet_ni_t; #define LNET_PROTO_PING_MATCHBITS 0x8000000000000000LL diff --git a/lnet/lnet/config.c b/lnet/lnet/config.c index 1105231..93ab8ba 100644 --- a/lnet/lnet/config.c +++ b/lnet/lnet/config.c @@ -35,6 +35,8 @@ */ #define DEBUG_SUBSYSTEM S_LNET +#include +#include #include /* tmp struct for parsing routes */ @@ -116,6 +118,11 @@ lnet_ni_free(struct lnet_ni *ni) LIBCFS_FREE(ni->ni_interfaces[i], strlen(ni->ni_interfaces[i]) + 1); } + + /* release reference to net namespace */ + if (ni->ni_net_ns != NULL) + put_net(ni->ni_net_ns); + LIBCFS_FREE(ni, sizeof(*ni)); } @@ -177,6 +184,13 @@ lnet_ni_alloc(__u32 net, struct cfs_expr_list *el, struct list_head *nilist) /* LND will fill in the address part of the NID */ ni->ni_nid = LNET_MKNID(net, 0); + + /* Store net namespace in which current ni is being created */ + if (current->nsproxy->net_ns != NULL) + ni->ni_net_ns = get_net(current->nsproxy->net_ns); + else + ni->ni_net_ns = NULL; + ni->ni_last_alive = cfs_time_current_sec(); list_add_tail(&ni->ni_list, nilist); return ni; diff --git a/lnet/lnet/lib-move.c b/lnet/lnet/lib-move.c index cd7c0e9..cacc500 100644 --- a/lnet/lnet/lib-move.c +++ b/lnet/lnet/lib-move.c @@ -41,6 +41,8 @@ #define DEBUG_SUBSYSTEM S_LNET #include +#include +#include static int local_nid_dist_zero = 1; module_param(local_nid_dist_zero, int, 0444); @@ -2497,11 +2499,18 @@ LNetDist(lnet_nid_t dstnid, lnet_nid_t *srcnidp, __u32 *orderp) return local_nid_dist_zero ? 0 : 1; } - if (LNET_NIDNET(ni->ni_nid) == dstnet) { - if (srcnidp != NULL) - *srcnidp = ni->ni_nid; - if (orderp != NULL) - *orderp = order; + if (LNET_NIDNET(ni->ni_nid) == dstnet) { + /* Check if ni was originally created in + * current net namespace. + * If not, assign order above 0xffff0000, + * to make this ni not a priority. */ + if (!net_eq(ni->ni_net_ns, current->nsproxy->net_ns)) + order += 0xffff0000; + + if (srcnidp != NULL) + *srcnidp = ni->ni_nid; + if (orderp != NULL) + *orderp = order; lnet_net_unlock(cpt); return 1; } -- 1.8.3.1