From d4335dcd8caaf43cd442e0e91a46d8dae2fdf2e0 Mon Sep 17 00:00:00 2001 From: Sebastien Buisson Date: Thu, 6 Jun 2013 14:35:51 +0200 Subject: [PATCH] LU-2744 build: fix 'data race condition' issues Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by: Sebastien Buisson Change-Id: I706e4facef8d29a3b072f977c7a903e6c1772b71 Reviewed-on: http://review.whamcloud.com/6568 Reviewed-by: Bob Glossman Tested-by: Hudson Tested-by: Maloo Reviewed-by: Andreas Dilger --- lnet/selftest/framework.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lnet/selftest/framework.c b/lnet/selftest/framework.c index 305659e..2e32c3d 100644 --- a/lnet/selftest/framework.c +++ b/lnet/selftest/framework.c @@ -1005,9 +1005,8 @@ sfw_run_test (swi_workitem_t *wi) cfs_list_add_tail(&rpc->crpc_list, &tsi->tsi_active_rpcs); spin_unlock(&tsi->tsi_lock); - rpc->crpc_timeout = rpc_timeout; - spin_lock(&rpc->crpc_lock); + rpc->crpc_timeout = rpc_timeout; srpc_post_rpc(rpc); spin_unlock(&rpc->crpc_lock); return 0; -- 1.8.3.1