From ecbba77d0d8f1446cb1d712815b88985abb71fcb Mon Sep 17 00:00:00 2001 From: Dmitry Eremin Date: Tue, 10 Jun 2014 21:36:17 +0400 Subject: [PATCH] LU-4629 llite: Fix uninitialized variable 'f.f_flags' might be used uninitialized in this function. xattr.c:248: 'f.f_flags' is declared. xattr.c:244: lump!= ( (void* )0) is true xattr.c:254: 'f.f_flags' is used, but is uninitialized. Signed-off-by: Dmitry Eremin Change-Id: I99a3679b99f2980b6e78ebfb32dfa34e047c9756 Reviewed-on: http://review.whamcloud.com/10663 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- lustre/llite/xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lustre/llite/xattr.c b/lustre/llite/xattr.c index dfa3e55..37d439f 100644 --- a/lustre/llite/xattr.c +++ b/lustre/llite/xattr.c @@ -250,6 +250,7 @@ int ll_setxattr(struct dentry *dentry, const char *name, int lum_size = (lump->lmm_magic == LOV_USER_MAGIC_V1) ? sizeof(*lump) : sizeof(struct lov_user_md_v3); + memset(&f, 0, sizeof(f)); /* f.f_flags is used below */ f.f_dentry = dentry; rc = ll_lov_setstripe_ea_info(inode, &f, it_flags, lump, lum_size); -- 1.8.3.1