From c448689521c57edf2def9c3f2cdff2ec9236ec18 Mon Sep 17 00:00:00 2001 From: Etienne AUJAMES Date: Thu, 7 Oct 2021 10:12:55 +0200 Subject: [PATCH] LUDOC-496 nrs: Format of TBF rule name field is not defined Lustre manual should define the format (alphanumeric + '_') and length (15 characters) of a TBF rule name field. This is important because there is buffer overflow for the TBF rule name (LU-15059): the length is not checked by ptlrpc. Change-Id: I29efb7e5891c0fba308b683bf92b26e4fefa7695 Signed-off-by: Etienne AUJAMES Reviewed-on: https://review.whamcloud.com/45144 Tested-by: jenkins Reviewed-by: Andreas Dilger --- LustreTuning.xml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/LustreTuning.xml b/LustreTuning.xml index a8bde00..9460749 100644 --- a/LustreTuning.xml +++ b/LustreTuning.xml @@ -1636,10 +1636,13 @@ $ lctl set_param ost.OSS.ost_io.nrs_policies="tbf gid" lctl set_param x.x.x.nrs_tbf_rule= "[reg|hp] start rule_name arguments..." - 'rule_name' is a string of the TBF - policy rule's name and 'arguments' is a - string to specify the detailed rule according to the different types. - + 'rule_name' is a string up to 15 + characters which identifies the TBF policy rule's name. Alphanumeric + characters and underscores are accepted (e.g: "test_rule_A1"). + + 'arguments' is a string to specify the + detailed rule according to the different types. + Next, the different types of TBF policies will be described. -- 1.8.3.1