From 3a6568a6d595caf61d67b971d561b936040606b9 Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Tue, 7 May 2024 01:29:03 -0400 Subject: [PATCH] LU-17000 obdclass: Add NULL check for parms under class_exp2cliimp This patch adds NULL pointer check for parameters passed under class_exp2cliimp() Test-Parameters: trivial CoverityID: 424699 ("Dereference before null check") Signed-off-by: Arshad Hussain Change-Id: Ie7d96c10086959a3f31b290d56621261da480a36 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55030 Reviewed-by: Andreas Dilger Reviewed-by: Shaun Tancheff Reviewed-by: Timothy Day Reviewed-by: Oleg Drokin Tested-by: jenkins Tested-by: Maloo --- lustre/obdclass/genops.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lustre/obdclass/genops.c b/lustre/obdclass/genops.c index 0e46ae7..413d134 100644 --- a/lustre/obdclass/genops.c +++ b/lustre/obdclass/genops.c @@ -860,11 +860,16 @@ EXPORT_SYMBOL(class_exp2obd); struct obd_import *class_exp2cliimp(struct obd_export *exp) { - struct obd_device *obd = exp->exp_obd; + struct obd_device *obd; + + if (!exp || !exp->exp_obd) + goto out; + + obd = exp->exp_obd; - if (obd == NULL) - return NULL; return obd->u.cli.cl_import; +out: + return NULL; } EXPORT_SYMBOL(class_exp2cliimp); -- 1.8.3.1