From 36a1074ca0225d675c1e3272c07b1f1990e1c3cb Mon Sep 17 00:00:00 2001 From: Hongchao Zhang Date: Mon, 15 Apr 2024 07:13:57 +0800 Subject: [PATCH] LU-14535 utils: fix FORWARD_NULL issue from Coverity Fixing the possible NULL pointer issued reported from Coverity case 'e': CID 424708: (FORWARD_NULL) Passing null pointer "optarg" to "strtoul", which dereferences it. end_qid = strtoul(optarg, NULL, 0); break; CoverityID: 424708 ("FORWARD NULL") Signed-off-by: Hongchao Zhang Change-Id: Idfb5cb4c6fe63ec08dd9048742f3f280b125eb8a Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54827 Reviewed-by: Arshad Hussain Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin Tested-by: jenkins Tested-by: Maloo --- lustre/utils/lfs.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/lustre/utils/lfs.c b/lustre/utils/lfs.c index c85a572..b40d7f2 100644 --- a/lustre/utils/lfs.c +++ b/lustre/utils/lfs.c @@ -9502,6 +9502,13 @@ static int lfs_quota(int argc, char **argv) qctl->qc_cmd = LUSTRE_Q_ITERQUOTA; break; case 'e': + if (optarg == NULL || *optarg == '\0') { + fprintf(stderr, + "%s quota: invalid start quota ID\n", + progname); + rc = CMD_HELP; + goto out; + } end_qid = strtoul(optarg, NULL, 0); break; case 'G': @@ -9592,6 +9599,13 @@ static int lfs_quota(int argc, char **argv) quiet = 1; break; case 's': + if (optarg == NULL || *optarg == '\0') { + fprintf(stderr, + "%s quota: invalid start quota ID\n", + progname); + rc = CMD_HELP; + goto out; + } start_qid = strtoul(optarg, NULL, 0); break; case 't': -- 1.8.3.1