From fb3b8f657deb13a00e3cea77f178f339d83930b1 Mon Sep 17 00:00:00 2001 From: Patrick Farrell Date: Wed, 18 Oct 2023 13:40:51 -0400 Subject: [PATCH] EX-7601 osd: osd_bufs_put does not always handle all pages osd_bufs_put asserts that the dio pages used after are always zero, but there's no reason for this to be true and compression specifically violates this by using 1 page at a time. Without this patch, we hit this assert and crash when nonrotational = 1. Signed-off-by: Patrick Farrell Change-Id: If6bdb11f254c260e2da4cabe11a82693a468e6fb Reviewed-on: https://review.whamcloud.com/c/ex/lustre-release/+/52750 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: Alex Zhuravlev --- lustre/osd-ldiskfs/osd_io.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lustre/osd-ldiskfs/osd_io.c b/lustre/osd-ldiskfs/osd_io.c index d967f9e..f2bbaa4 100644 --- a/lustre/osd-ldiskfs/osd_io.c +++ b/lustre/osd-ldiskfs/osd_io.c @@ -819,8 +819,6 @@ static int osd_bufs_put(const struct lu_env *env, struct dt_object *dt, lnb[i].lnb_page = NULL; } - LASSERTF(oti->oti_dio_pages_used == 0, "%d\n", oti->oti_dio_pages_used); - /* Release any partial pagevec */ pagevec_release(&pvec); -- 1.8.3.1