From f2a96b6eb96a044e81c8f5425c417dd0925bdead Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Tue, 27 Jan 2015 13:11:25 -0500 Subject: [PATCH] tune2fs: abort when trying to enable/disable metadata_csum on mounted fs Earlier, I tried to make tune2fs abort if the user tried to enable or disable metadata_csum on a mounted FS, but forgot the exit() call. Supply it now. Signed-off-by: Darrick J. Wong Signed-off-by: Theodore Ts'o --- misc/tune2fs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/misc/tune2fs.c b/misc/tune2fs.c index f01b05b..e33b0d3 100644 --- a/misc/tune2fs.c +++ b/misc/tune2fs.c @@ -1110,9 +1110,11 @@ mmp_error: EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) { if (check_fsck_needed(fs)) exit(1); - if (mount_flags & EXT2_MF_MOUNTED) + if (mount_flags & EXT2_MF_MOUNTED) { fputs(_("Cannot enable metadata_csum on a mounted " "filesystem!\n"), stderr); + exit(1); + } if (!EXT2_HAS_INCOMPAT_FEATURE(fs->super, EXT3_FEATURE_INCOMPAT_EXTENTS)) printf("%s", @@ -1152,9 +1154,11 @@ mmp_error: if (check_fsck_needed(fs)) exit(1); - if (mount_flags & EXT2_MF_MOUNTED) + if (mount_flags & EXT2_MF_MOUNTED) { fputs(_("Cannot disable metadata_csum on a mounted " "filesystem!\n"), stderr); + exit(1); + } rewrite_checksums = 1; /* Enable uninit_bg unless the user expressly turned it off */ -- 1.8.3.1