From ecea24d843f7b2f5fdd5a72fde06eac9237542fc Mon Sep 17 00:00:00 2001 From: Serguei Smirnov Date: Thu, 31 Aug 2023 12:34:00 -0700 Subject: [PATCH] LU-17071 o2iblnd: IBLND_REJECT_EARLY condition causes Oops The message printed when kiblnd_passive_connect recognizes IBLND_REJECT_EARLY condition introduced by LU-16393 is trying to derefence a NULL pointer in the parameter list. Fix this. Test-parameters: trivial Fixes: 673ff86a84a ("LU-16393 o2iblnd: add IBLND_REJECT_EARLY reject reason") Signed-off-by: Serguei Smirnov Change-Id: I711e5855383c140b9f7c35b27f48995f3f0e25ee Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52202 Reviewed-by: Frank Sehr Reviewed-by: Cyril Bordage Reviewed-by: Oleg Drokin Tested-by: Maloo Tested-by: jenkins --- lnet/klnds/o2iblnd/o2iblnd_cb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lnet/klnds/o2iblnd/o2iblnd_cb.c b/lnet/klnds/o2iblnd/o2iblnd_cb.c index 3fbc283..d0ce634 100644 --- a/lnet/klnds/o2iblnd/o2iblnd_cb.c +++ b/lnet/klnds/o2iblnd/o2iblnd_cb.c @@ -2575,9 +2575,8 @@ kiblnd_passive_connect(struct rdma_cm_id *cmid, void *priv, int priv_nob) } else { if (ibdev->ibd_nnets == 0) { rej.ibr_why = IBLND_REJECT_EARLY; - CNETERR("Can't accept conn from %s on %s (%s:%d:%pI4h): net for nid %s not added yet\n", + CNETERR("Can't accept conn from %s (%s:%d:%pI4h): net for nid %s not added yet\n", libcfs_nid2str(nid), - libcfs_nidstr(&net->ibn_ni->ni_nid), ibdev->ibd_ifname, ibdev->ibd_nnets, &ibdev->ibd_ifip, libcfs_nid2str(reqmsg->ibm_dstnid)); -- 1.8.3.1