From ece2d5884b97270a767c734147148c08656b8595 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Sun, 5 Jan 2014 01:12:49 -0500 Subject: [PATCH] libext2fs: fix potential memory leak in qcow2_write_raw_image() Addresses-Coverity-ID: #1049179 Addresses-Coverity-ID: #1049180 Signed-off-by: "Theodore Ts'o" --- lib/ext2fs/qcow2.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ext2fs/qcow2.c b/lib/ext2fs/qcow2.c index 547edc0..c7cdbee 100644 --- a/lib/ext2fs/qcow2.c +++ b/lib/ext2fs/qcow2.c @@ -235,8 +235,10 @@ int qcow2_write_raw_image(int qcow2_fd, int raw_fd, } /* Resize the output image to the filesystem size */ - if (ext2fs_llseek(raw_fd, img.image_size - 1, SEEK_SET) < 0) - return errno; + if (ext2fs_llseek(raw_fd, img.image_size - 1, SEEK_SET) < 0) { + ret = errno; + goto out; + } ((char *)copy_buf)[0] = 0; size = write(raw_fd, copy_buf, 1); -- 1.8.3.1