From e732c9fa1c6a8089c94639de559cf2cf236644ba Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Sat, 14 Aug 2021 10:39:13 -0400 Subject: [PATCH] mke2fs: warn that bigalloc is experimental only for large cluster sizes Since we have done a lot of testing with a cluster size equal to 64k (or 16 times the default 4k block size), mke2fs will only warn for bigalloc file systems where the cluster size is greater than 16 times the block size. Signed-off-by: Theodore Ts'o --- misc/mke2fs.c | 11 ++++++----- tests/d_fallocate_bigalloc/expect.gz | Bin 2673 -> 2696 bytes tests/d_punch_bigalloc/expect | 4 ---- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/misc/mke2fs.c b/misc/mke2fs.c index a457397..effe963 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -2526,11 +2526,12 @@ profile_error: exit(1); } - if (!quiet && ext2fs_has_feature_bigalloc(&fs_param)) - fprintf(stderr, "%s", _("\nWarning: the bigalloc feature is " - "still under development\n" - "See https://ext4.wiki.kernel.org/" - "index.php/Bigalloc for more information\n\n")); + if (!quiet && ext2fs_has_feature_bigalloc(&fs_param) && + EXT2_CLUSTER_SIZE(&fs_param) > 16 * EXT2_BLOCK_SIZE(&fs_param)) + fprintf(stderr, "%s", _("\nWarning: bigalloc file systems " + "with a cluster size greater than\n" + "16 times the block size is considered " + "experimental\n")); /* * Since sparse_super is the default, we would only have a problem diff --git a/tests/d_fallocate_bigalloc/expect.gz b/tests/d_fallocate_bigalloc/expect.gz index 8640bc29dc71b09810f110d07d84d883b1109b88..167c069e262988204af9064c2571fa06c6cfbb87 100644 GIT binary patch literal 2696 zcmV;33U~D%iwFSo6&PUv1KnF)kK4EveGU982owdfMUoLOc_}GCQ7m>RK!7Z|Kw2#N zR5%{Z#LbKy*q%*he|<&r$fiChiM8jY1_H)o9#cF=x;&Sc{%Kb&59`gHxLw~@`=|Y( zdJx~%htI+=DvF#r z@~!ykbG7<%yqNtfO!}4k&i(q2dcLkJ1zm5}yJ~gV?w-W{uzOq`9(R@Rqy{^!wwq1; z-}Ue7!;|l)gMPc}w%S#jRVCa-V>k|ac#ijv4-d=w+kzP_4%PnfZ%q8Hkn+mOWM55k9)D+i)?XIeR{mR-HUHE z)0O|W=5KFB^<7*o7aywMt9x<1IqcT;Q2zB{d$(RK@BN!!KR@l=yARdouD++<-7oL< z3z1!kto~G9)&E?-OuV*@Duuf;`%cP2xzBVa{<&Fi)`#}!`{l#e`|1*xplvsaOQ>7H znSbY6_ma&eG&nlq6mZJ*SHP(VPBl0(9#^+@fB(+4!#I7!mB5v*e+gXK!L_LRR9uWE zQDC}MGnHlbUES92+>0k^BIWukk0Vc$9HB`ASGfKfxFRxMkEZ&Lvi(bsQ)OqoHcjQ_ zXevXRG=^u;q-WB^pvffCWI&Tiq{-kq^KqJFcKN5y@lWE|D*!5@NID*qhoCyUfjl(G{7*cg{+~8V*C@dIie8E`JSvPJ=5D^NZ z8smYN9uP!?D~uv9h{6ifpJ-1Icc&|?Fsi@8bOkxy>Du+z!09PL0^e-=LlE8b%`rj9 z5rUP;wryNTkh7kUwj*ruYrt>b<99TYs2uzj^COAl2`iH-z*BF$q5Q)32T#QWPv&`e z(wXN;%QT)eRwkXWG8xxj1DD2=#>%9}^RN}=&%~1kPn^gTRwkXWGUcv6crv-a=w3z> z;R!2~ZAW>!V8YtssQ^!9B2QRoI5ERuWEea@!*Dz?77W{t@^rzBHROpA|G6LkM|onz ze@@IW81bLyXBeI*#BrX8GjlaODq>kpQ4*yntZrL*>CPh+Zq4A0G94RFH#nc{*$oEwCBPLi95*=sRN4H_ehJo2Nim#haEgF) zyFge=q>1732IppETkFLLv6Z5H7DpU-VV4Ah7mD&yHaG?^#^oTT-yKuft?J=q*5C|y z$t^Ehd7M@;oNRD8c*&h-#BQ9oJX1$ZeeFDyNdWej(`UkdP2vLgpLj^U2?OX+#B z`_6W41un`gea%1d*)HYWzAMz+HwM_`-i)?i(=L+V-BOS|fQNhkia^iy7g+EC! zU&o`cjyEBgui)8su3%C@Fr6rvhG2TOV2BrzXA8yVl>Y*HmXDOe7{ibTN*2v*D%tbkzUY{5#*re|?Ff}K^Uj0;9x&oL#KuWV9S z*_?R72%dvxdk%u@EkPTa}YcS&GsAw&p{KO-FpUivJ+L7&ESQEl(gWsbSTGF(65aHR2&Q3fEqD8Y9HJFECUA{eI% zrXg5#=QSdjhG0BfFqk7fV2&b!!GJ_}TL%PlbAmYvP6SK|26Ggg1?UQP!L7@dU}dUc z1q6$h0wRJH5UiXn7|f9#*pV3)jA10A+uQ?!S(C#sIUF%LeZd$eCpeVQ73_k0m!V)h zZdUq&G0X~&nw7p_470)!v(gugVOBU|Rt5xvS&7ycVuHb}@W75tL@<~Rj+&11&P9v} zmTEc}rh^kr2g7vmY}3Io9X#7~Fic0ZuoDvurh^A|WO{P;f$1=_O^1Q$FtbgEf$4}=)FOfzm<}_rBhwd5x}GIQI^}&W!Pb|PONVlG zEQc}!*_#gKLhvy9xIE9w-V7{Eh% z-a?7TTL{NnC_LUWda#9Xu!X{dEp6JrT;d#-pZ6)YNt{rT;R%)22`q&_T7;{`H)m7I z(k~JAOw7OuEG7K0mDi}@*E91zrO2ImD}pmE{};bYez&Wt=GWs6Exzrx_Lt_{9Z-MD z#7oXIdgVW_ZvM)K%nxrC@7CY{CZ6oC%wu2jvd+7tIRQ1-DzuQD-$nn$zQnutAFjp6 ze|`MN^)KSLA3us;{{Hj(cki!%_8)g3-2N#w)0=YOx75xzj{cZhF8&K_)%HGE7&&g$cOx2ZO_SK@G2ici(; z`r%=FEk2j)!}G2b)n4om)x(2$-rSTsaZ~b|Snts#l&azaaTF8JKz5b-akK;yWk3gyI5aeZ=W|9;&{j52&>hv>-}EHEAi7^ zd3}GpnEh+q^lNv{ef6LEeqC1zy53Z~^7^pdeXCX4JzqDH`A%xE)Ae?(pZ{=nE z&-Kg14^5-2a97qGNm(fOozBER>X)QCbVuK>ADBBi9b&^bu!)v#!4d&h~H}sy-EGqe&FFU8m&E!S(-?>{>tOX(l{xu^W$6aq#}8;o+p{5@gy@1TpCX@^E^p8!;@Tw zC#gJ7Ql;@E6?oE#JZbQx6M4dOFL{P1S|WQPeme6 z1$eSEJgH@PBI$Xe_}R|!LZ7?*k>o)|oFB2S3plo-beahww4 zI3bSHTpZ`$!;=gRoXo=Ui>%|-Rkmt+wg5gQ7J3W+qKDJmm}Vq`?y>@`Ra5C(KN_>kpnxK9bRl@PwJEX(xFq7UHP@Pd1S!Of;OB zVK6cbj?XY0PmBqpX(xHI%kadA|E$t@V#I$=%rF@7pLHTnh~qpH$5plvPl)537{?iL zoQp)B5XU(o!^m8J@YEVC8sSMU!;?WAH;HlFAdZ{F48tIfn}iHQy8fOgqhv4scX+xv zA4@u932%XE?V62b2~pf6<`)K0+$7`|?D~VH9QHXMWT{*xyD+KQg+X><60-|~pl>3w zi#90v@jN|w)_>Wi&1{|-;L^-&p0(pm2Eor~&n=oqq_DP|TL>A-Ax#HRy9JxMSkSca z4#j{Rz`4a{>3Z7ZVza|F?SLE&PWqm1;mNJOVpUO(ji+0jPxhJx26qzRiZL9wIR92P z`CW4o%$<_PaHhp60?w@hVJ?wo441b!cSlXzcrik3rBObMBM!WV_KJ}-XVxo)MKbHIxk<)wXIq+g}1Upe>M`}-^W zczID2gRlKqpb&m^XLPBAQ!opG~=$f8WAe5Bq_QffL@3%)N3JG&ZbSy%N5xwmB^s?db zx~G>M(94E;Y24vU)oM;JhF%=47eg0ga`VrG z&oRBS5TSfVVfk!MFblzKv|!c?)|T301@j?~!cyCeV7|y!w=z~RA0FvgmKzmJE+beo z@h1u9>v$B_@n!_`6}+a66-+7!rV|Cz5KKo4hIk=4S}=xSJR=w_B$!DMENcKc1bZnc z4hTk}U0{{X9QEr2u4|=V7{_RVP$jX4I_9C ziuN1?&q0ZvgWx$R+H(**2Ss}hg6E(a&mr|fg6UMj7=m%MU@#pNZ8`|1gAz>#!E{ix z=^&U6iZ&gDctLZfgBKEP+H~Zng28kIrQ42Rd2d;TP_(76XxkAi@0Du_p)Lv%)Q|Bea59Q3Gbh91)?=3T8zOn3cRmbc9wgD{9)T+$~cQuE$koswABEmTd?n z;ijEfwgE0o`xN=KuPr5qWU7+~gk4Vs#OWJ7EVP1=P-7|kfY7?>50f)qc7BojWu=Z# zcBZiGd@6UaMn@<(Q&@2B3(X4&olgpFPK7oQ+Dr+3n%^q}q4Qy(PeZq_W;gAy(5InW z!GMgeJq3YShl0Tz1@-UKK-?7!<|wFq_XRV{2&QGCV7^G+v}uBAEXZgXE0~5k(lS;s z4FfW|=r+T@U_eG!TL%Pl z_XKkk>4CW}<3(yy=SV%CNDp&!*ibTN*2xg-NgE`VRRxpN<7+vNb5Uepd43onn zCg)TzhRF#wCG-We%Lv9QQ80#CVM-H>VOChh3dS%itfB>jSz%5T3}%IOv|unDJZd^r zwvb?{rh{QRIMH-4Ob17s4uE*;9%vmD9{WN$i@ z3&F$alMQ>5*_(moFdUn`8CVX(vDuq} zv87A<{WBAPuh13R!3wym@^{QAzkPbqR| z-ilyP%m2milHcyivi?GC6vWa2x{GkWd6FK_heE8>wzrXoKeEji)_~mauzkB=c&CmYp f9)!C;rDnRY1HYwqzH#!$)N=J-JwLQM>OTMg)z2kH diff --git a/tests/d_punch_bigalloc/expect b/tests/d_punch_bigalloc/expect index caeb3a6..be841e6 100644 --- a/tests/d_punch_bigalloc/expect +++ b/tests/d_punch_bigalloc/expect @@ -1,7 +1,3 @@ - -Warning: the bigalloc feature is still under development -See https://ext4.wiki.kernel.org/index.php/Bigalloc for more information - Creating filesystem with 65536 1k blocks and 4096 inodes Allocating group tables: done -- 1.8.3.1