From e7246c5e1c275ca4987b55fc30033891956991af Mon Sep 17 00:00:00 2001 From: Jeff Mahoney Date: Tue, 24 Sep 2013 12:03:37 -0400 Subject: [PATCH] LU-4000 lloop: Fix build failure on ppc64 On ppc64 with 64k pages, we get a build failure in lloop: drivers/staging/lustre/lustre/llite/lloop.c:527:2: note: in expansion of macro 'CLASSERT' CLASSERT(PAGE_CACHE_SIZE < (1 << (sizeof(unsigned short) * 8))); There's no need to change the queue's logical block size. Even if it could accept a 64k value, that would result in any file system on top of it needing to also use 64k blocks. It'd be safe to set it to 4k, but there's no actual need for it. It's not used to split requests except for WRITE_SAME, which lloop doesn't implement anyway. Change-ID: Ib36959ca2323ab0dfdc1fb34aeffb778cffd6c92 Signed-off-by: Jeff Mahoney Reviewed-on: http://review.whamcloud.com/7745 Reviewed-by: Jinshan Xiong Tested-by: Hudson Tested-by: Maloo Reviewed-by: Minh Diep Reviewed-by: Oleg Drokin --- lustre/llite/lloop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lustre/llite/lloop.c b/lustre/llite/lloop.c index 9854d84..30a55d6 100644 --- a/lustre/llite/lloop.c +++ b/lustre/llite/lloop.c @@ -540,9 +540,6 @@ static int loop_set_fd(struct lloop_device *lo, struct file *unused, #endif /* queue parameters */ - CLASSERT(PAGE_CACHE_SIZE < (1 << (sizeof(unsigned short) * 8))); - blk_queue_logical_block_size(lo->lo_queue, - (unsigned short)PAGE_CACHE_SIZE); blk_queue_max_hw_sectors(lo->lo_queue, LLOOP_MAX_SEGMENTS << (PAGE_CACHE_SHIFT - 9)); blk_queue_max_segments(lo->lo_queue, LLOOP_MAX_SEGMENTS); -- 1.8.3.1