From e13b2a1f5ee9bcbaecdcf8779d87975aebd40e2e Mon Sep 17 00:00:00 2001 From: Jian Yu Date: Wed, 17 Apr 2013 22:46:16 +0800 Subject: [PATCH] LU-2008 utils: quote TUNE2FS options in ldiskfs_label_lustre This patch improves ldiskfs_label_lustre() to quote the options for TUNE2FS in case the label contains space(s). Test-Parameters: envdefinitions=SLOW=yes \ clientcount=4 osscount=2 mdscount=2 \ austeroptions=-R failover=true useiscsi=true \ testlist=mmp Signed-off-by: Jian Yu Change-Id: I3eaeb604517dba29e07f9750aeb3afed9443e94f Reviewed-on: http://review.whamcloud.com/6077 Tested-by: Hudson Tested-by: Maloo Reviewed-by: Niu Yawei Reviewed-by: Li Wei Reviewed-by: Oleg Drokin --- lustre/utils/mount_utils_ldiskfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lustre/utils/mount_utils_ldiskfs.c b/lustre/utils/mount_utils_ldiskfs.c index 53dab0c..45c491e 100644 --- a/lustre/utils/mount_utils_ldiskfs.c +++ b/lustre/utils/mount_utils_ldiskfs.c @@ -1017,7 +1017,7 @@ int ldiskfs_label_lustre(struct mount_opts *mop) int rc; snprintf(label_cmd, sizeof(label_cmd), - TUNE2FS" -f -L %s %s >/dev/null 2>&1", + TUNE2FS" -f -L '%s' '%s' >/dev/null 2>&1", mop->mo_ldd.ldd_svname, mop->mo_source); rc = run_command(label_cmd, sizeof(label_cmd)); -- 1.8.3.1