From ce54b5281c3172401ce4526a4de65d2d584fa0e7 Mon Sep 17 00:00:00 2001 From: Alex Zhuravlev Date: Mon, 4 Sep 2023 20:30:26 +0300 Subject: [PATCH] LU-17084 lod: fix comparision in lod_striping_load() in if (rc > sizeof(struct lmv_foreign_md)) the latter is unsigned and gcc treats rc (which is defined as int and can be negative to encode an error) as unsigned. this way -EIO becomes greater than the size of the structure. make sizeof() signed to avoid confusion. Signed-off-by: Alex Zhuravlev Change-Id: Ie6735578649e397ed05b6951fab941f97051305b Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52265 Tested-by: jenkins Tested-by: Maloo Reviewed-by: xinliang Reviewed-by: Mikhail Pershin Reviewed-by: Oleg Drokin Reviewed-by: Neil Brown --- lustre/lod/lod_lov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lustre/lod/lod_lov.c b/lustre/lod/lod_lov.c index 0a1d571..2b4d5ec 100644 --- a/lustre/lod/lod_lov.c +++ b/lustre/lod/lod_lov.c @@ -1629,7 +1629,8 @@ int lod_striping_load(const struct lu_env *env, struct lod_object *lo) lo->ldo_comp_cached = 1; } else if (S_ISDIR(lod2lu_obj(lo)->lo_header->loh_attr)) { rc = lod_get_lmv_ea(env, lo); - if (rc > sizeof(struct lmv_foreign_md)) { + + if (rc > (int)sizeof(struct lmv_foreign_md)) { struct lmv_foreign_md *lfm = info->lti_ea_store; if (le32_to_cpu(lfm->lfm_magic) == LMV_MAGIC_FOREIGN) { -- 1.8.3.1