From c4eda808997691941d755d9f6c503c0b816ad259 Mon Sep 17 00:00:00 2001 From: adilger Date: Wed, 25 Jan 2006 11:59:26 +0000 Subject: [PATCH] Branch b_release_1_4_6 Remove bogus check for NULL dchild in mds_open_by_fid(). We will always get either a valid dentry or ERR_PTR() back from ll_lookup_one_len(). This extra check provokes a false deref-before-NULL error in Coverity (COV:717,718) b=10098 r=nikita --- lustre/mds/mds_open.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lustre/mds/mds_open.c b/lustre/mds/mds_open.c index d696ac5..652b7eb 100644 --- a/lustre/mds/mds_open.c +++ b/lustre/mds/mds_open.c @@ -799,9 +799,8 @@ static int mds_open_by_fid(struct ptlrpc_request *req, struct ll_fid *fid, intent_set_disposition(rep, DISP_LOOKUP_POS); open: - rc = mds_finish_open(req, dchild, body, flags, &handle, rec, rep, - NULL); - rc = mds_finish_transno(mds, dchild ? dchild->d_inode : NULL, handle, + rc = mds_finish_open(req, dchild, body, flags, &handle, rec, rep, NULL); + rc = mds_finish_transno(mds, dchild->d_inode, handle, req, rc, rep ? rep->lock_policy_res1 : 0); /* XXX what do we do here if mds_finish_transno itself failed? */ -- 1.8.3.1