From b208a3e5e027a445fb69412a4f140247b8823f2a Mon Sep 17 00:00:00 2001 From: grev Date: Thu, 16 Jul 2009 10:40:59 +0000 Subject: [PATCH] b=19215 i=Robert.Read verbose do_nodes do_node print HOSTNAME for no_dsh --- lustre/tests/test-framework.sh | 40 ++++++++++++++++++++++++++++++++++------ 1 file changed, 34 insertions(+), 6 deletions(-) diff --git a/lustre/tests/test-framework.sh b/lustre/tests/test-framework.sh index d96d0e61..dd295cc 100644 --- a/lustre/tests/test-framework.sh +++ b/lustre/tests/test-framework.sh @@ -1205,7 +1205,14 @@ change_active() { } do_node() { - HOST=$1 + local verbose=false + # do not stripe off hostname if verbose, bug 19215 + if [ x$1 = x--verbose ]; then + shift + verbose=true + fi + + local HOST=$1 shift local myPDSH=$PDSH if [ "$HOST" = "$HOSTNAME" ]; then @@ -1229,7 +1236,17 @@ do_node() { [ -n "$($myPDSH $HOST cat $command_status)" ] && return 1 || true return 0 fi - $myPDSH $HOST "(PATH=\$PATH:$RLUSTRE/utils:$RLUSTRE/tests:/sbin:/usr/sbin; cd $RPWD; sh -c \"$@\")" | sed "s/^${HOST}: //" + + if $verbose ; then + # print HOSTNAME for myPDSH="no_dsh" + if [[ $myPDSH = no_dsh ]]; then + $myPDSH $HOST "(PATH=\$PATH:$RLUSTRE/utils:$RLUSTRE/tests:/sbin:/usr/sbin; cd $RPWD; sh -c \"$@\")" | sed -e "s/^/${HOSTNAME}: /" + else + $myPDSH $HOST "(PATH=\$PATH:$RLUSTRE/utils:$RLUSTRE/tests:/sbin:/usr/sbin; cd $RPWD; sh -c \"$@\")" + fi + else + $myPDSH $HOST "(PATH=\$PATH:$RLUSTRE/utils:$RLUSTRE/tests:/sbin:/usr/sbin; cd $RPWD; sh -c \"$@\")" | sed "s/^${HOST}: //" + fi return ${PIPESTATUS[0]} } @@ -1238,11 +1255,18 @@ single_local_node () { } do_nodes() { + local verbose=false + # do not stripe off hostname if verbose, bug 19215 + if [ x$1 = x--verbose ]; then + shift + verbose=true + fi + local rnodes=$1 shift if $(single_local_node $rnodes); then - do_node $rnodes $@ + do_node --verbose $rnodes $@ return $? fi @@ -1257,7 +1281,11 @@ do_nodes() { $myPDSH $rnodes $LCTL mark "$@" > /dev/null 2>&1 || : fi - $myPDSH $rnodes "(PATH=\$PATH:$RLUSTRE/utils:$RLUSTRE/tests:/sbin:/usr/sbin; cd $RPWD; sh -c \"$@\")" | sed -re "s/\w+:\s//g" + if $verbose ; then + $myPDSH $rnodes "(PATH=\$PATH:$RLUSTRE/utils:$RLUSTRE/tests:/sbin:/usr/sbin; cd $RPWD; sh -c \"$@\")" + else + $myPDSH $rnodes "(PATH=\$PATH:$RLUSTRE/utils:$RLUSTRE/tests:/sbin:/usr/sbin; cd $RPWD; sh -c \"$@\")" | sed -re "s/\w+:\s//g" + fi return ${PIPESTATUS[0]} } @@ -2379,7 +2407,7 @@ calc_osc_kbytes () { # generate a stream of formatted strings ( =) save_lustre_params() { local s - do_node $1 "lctl get_param $2" | while read s; do echo "$1 $s"; done + do_nodes --verbose $1 "lctl get_param $2 | while read s; do echo \\\$s; done" } # restore lustre parameters from input stream, produces by save_lustre_params @@ -2388,7 +2416,7 @@ restore_lustre_params() { local name local val while IFS=" =" read node name val; do - do_node $node "lctl set_param -n $name $val" + do_node ${node//:/} "lctl set_param -n $name $val" done } -- 1.8.3.1