From a91b5d4a990c6a870774e1e856cc41f665a88854 Mon Sep 17 00:00:00 2001 From: Patrick Farrell Date: Sat, 18 Dec 2021 16:23:52 -0500 Subject: [PATCH] LU-15317 llite: Make iotrace logging quieter Most of the time, we don't read any pages with readahead, since we're moving through the window and aren't ready to read more yet. That's important for readahead debug, but there's no need to log it for iotrace. (This matters because without this change, this messsage is the large majority of iotrace messages.) test-parameters: trivial Signed-off-by: Patrick Farrell Change-Id: I58197acd1ef97c903320a2433ec1d5dcb0e46bd0 Reviewed-on: https://review.whamcloud.com/45887 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: Sebastien Buisson Reviewed-by: Oleg Drokin --- lustre/llite/rw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lustre/llite/rw.c b/lustre/llite/rw.c index b6bc138..5bfd5d6 100644 --- a/lustre/llite/rw.c +++ b/lustre/llite/rw.c @@ -1691,7 +1691,10 @@ int ll_io_read_page(const struct lu_env *env, struct cl_io *io, rc2 = ll_readahead(env, io, &queue->c2_qin, ras, uptodate, file, skip_index, &ra_start_index); - CDEBUG(D_READA|D_IOTRACE, + /* to keep iotrace clean, we only print here if we actually + * read pages + */ + CDEBUG(D_READA | (rc2 ? D_IOTRACE : 0), DFID " %d pages read ahead at %lu, triggered by user read at %lu\n", PFID(ll_inode2fid(inode)), rc2, ra_start_index, vvp_index(vpg)); -- 1.8.3.1