From 9bb52e03b0a267baa1eb96662c16be18ef20fd32 Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Fri, 19 Jan 2024 19:28:05 +0000 Subject: [PATCH] LU-16913 revert "EX-7849 quota: extra debug messages" This reverts commit 02242f6f1ba1867756ee5b91abd2207f646436cf. Extra debugging is no longer needed. Change-Id: I083b70a911ac85fb5a1054c8409146bb393e94b0 Test-Parameters: trivial testlist=sanity-quota Signed-off-by: Andreas Dilger Reviewed-on: https://review.whamcloud.com/c/ex/lustre-release/+/53746 Reviewed-by: Sergey Cheremencev Tested-by: jenkins Tested-by: Maloo --- lustre/quota/lquota_entry.c | 5 +---- lustre/quota/lquota_internal.h | 6 +----- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lustre/quota/lquota_entry.c b/lustre/quota/lquota_entry.c index e52e832..ae495d8 100644 --- a/lustre/quota/lquota_entry.c +++ b/lustre/quota/lquota_entry.c @@ -341,7 +341,6 @@ struct lquota_entry *lqe_locate_find(const struct lu_env *env, "hash:%s\n", qid->qid_uid, site->lqs_hash->hs_name); RETURN(ERR_PTR(-ENOMEM)); } - CDEBUG(D_QUOTA, "Allocated lqe %p\n", new); atomic_set(&new->lqe_ref, 1); /* hold 1 for caller */ new->lqe_id = *qid; @@ -366,9 +365,7 @@ struct lquota_entry *lqe_locate_find(const struct lu_env *env, if (lqe == new) new = NULL; out: - if (new) { - CDEBUG(D_QUOTA, "new %p lqe %p\n", new, lqe); + if (new) lqe_putref(new); - } RETURN(lqe); } diff --git a/lustre/quota/lquota_internal.h b/lustre/quota/lquota_internal.h index e1718cf..93e687e 100644 --- a/lustre/quota/lquota_internal.h +++ b/lustre/quota/lquota_internal.h @@ -277,12 +277,8 @@ static inline void lqe_putref(struct lquota_entry *lqe) { LASSERT(lqe != NULL); LASSERT(atomic_read(&lqe->lqe_ref) > 0); - if (atomic_dec_and_test(&lqe->lqe_ref)) { - CDEBUG(D_QUOTA, "free lqe %p lqe_gl %d\n", lqe, lqe->lqe_gl); - if (unlikely(lqe->lqe_gl)) - dump_stack(); + if (atomic_dec_and_test(&lqe->lqe_ref)) OBD_SLAB_FREE_PTR(lqe, lqe_kmem); - } } static inline int lqe_is_master(struct lquota_entry *lqe) -- 1.8.3.1