From 9b01faa8b24909fca2d220efbdc989285796f6c4 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Mon, 21 May 2012 21:58:39 -0400 Subject: [PATCH] e2fsck: fix precedence bug in built-in quota support The operator precedence bug means that we might pay atteion to s_grp_quota_inum even if the RO_COMPAT_QUOTA feature flag is clear. However, fortunately, this is unlikely to happen in practice. Cc: Aditya Kali Signed-off-by: "Theodore Ts'o" --- e2fsck/pass1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c index c7645d1..c6aae6e 100644 --- a/e2fsck/pass1.c +++ b/e2fsck/pass1.c @@ -928,8 +928,8 @@ void e2fsck_pass1(e2fsck_t ctx) ext2fs_mark_inode_bitmap2(ctx->inode_used_map, ino); if ((fs->super->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA) && - (fs->super->s_usr_quota_inum == ino) || - (fs->super->s_grp_quota_inum == ino)) { + ((fs->super->s_usr_quota_inum == ino) || + (fs->super->s_grp_quota_inum == ino))) { if (!LINUX_S_ISREG(inode->i_mode) && fix_problem(ctx, PR_1_QUOTA_BAD_MODE, &pctx)) { -- 1.8.3.1