From 966f6bb550be52e4bf5dd7fd38a0d707fe2a5072 Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Fri, 17 Jul 2020 04:08:08 -0600 Subject: [PATCH] LU-9114 ldlm: don't compute sumsq for pool stats Remove the calculation of sumsq from the LDLM pool stats, since these stats are almost never used, while conversely the pools are updated frequently. Signed-off-by: Andreas Dilger Change-Id: I90612b613fb76f4500ca6cd5613f5c121b3ebbe5 Reviewed-on: https://review.whamcloud.com/39435 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Jian Yu Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- lustre/ldlm/ldlm_pool.c | 33 +++++++++++---------------------- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/lustre/ldlm/ldlm_pool.c b/lustre/ldlm/ldlm_pool.c index bdba328..c670ef8 100644 --- a/lustre/ldlm/ldlm_pool.c +++ b/lustre/ldlm/ldlm_pool.c @@ -846,38 +846,27 @@ static int ldlm_pool_debugfs_init(struct ldlm_pool *pl) GOTO(out, rc = -ENOMEM); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANTED_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "granted", "locks"); + LPROCFS_CNTR_AVGMINMAX, "granted", "locks"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "grant", "locks"); + LPROCFS_CNTR_AVGMINMAX, "grant", "locks"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "cancel", "locks"); + LPROCFS_CNTR_AVGMINMAX, "cancel", "locks"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_RATE_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "grant_rate", "locks/s"); + LPROCFS_CNTR_AVGMINMAX, "grant_rate", "locks/s"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_RATE_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "cancel_rate", "locks/s"); + LPROCFS_CNTR_AVGMINMAX, "cancel_rate", "locks/s"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_PLAN_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "grant_plan", "locks/s"); + LPROCFS_CNTR_AVGMINMAX, "grant_plan", "locks/s"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SLV_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "slv", "slv"); + LPROCFS_CNTR_AVGMINMAX, "slv", "slv"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_REQTD_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "shrink_request", "locks"); + LPROCFS_CNTR_AVGMINMAX, "shrink_request", "locks"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_FREED_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "shrink_freed", "locks"); + LPROCFS_CNTR_AVGMINMAX, "shrink_freed", "locks"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_RECALC_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "recalc_freed", "locks"); + LPROCFS_CNTR_AVGMINMAX, "recalc_freed", "locks"); lprocfs_counter_init(pl->pl_stats, LDLM_POOL_TIMING_STAT, - LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV, - "recalc_timing", "sec"); + LPROCFS_CNTR_AVGMINMAX, "recalc_timing", "sec"); debugfs_create_file("stats", 0644, pl->pl_debugfs_entry, pl->pl_stats, &ldebugfs_stats_seq_fops); -- 1.8.3.1