From 94dee86fbcf72ded71c633f7de1bdf2713d6d769 Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Thu, 3 Mar 2022 14:20:52 +0530 Subject: [PATCH 1/1] LU-15614 tests: Variable incorrectly used in sanity-flr/203 Under sanity-flr.sh/203 variable 'old_id' and 'new_id' is defined incorrectly as 'oldid' and 'newid'. This was exposed using shellcheck. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In lustre/tests/sanity-flr.sh line 3258: [[ x$oldid = x$newid ]] || ^-- SC2154: oldid is referenced but not assigned (did you mean 'old_id'?). ^-- SC2154: newid is referenced but not assigned (did you mean 'new_id'?). ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Test-Parameters: trivial testlist=sanity-flr Signed-off-by: Arshad Hussain Change-Id: I37949035f50dfdd33e5181ad888f68fcb204c385 Reviewed-on: https://review.whamcloud.com/46690 Tested-by: jenkins Reviewed-by: James Nunez Tested-by: Maloo Reviewed-by: Andreas Dilger --- lustre/tests/sanity-flr.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lustre/tests/sanity-flr.sh b/lustre/tests/sanity-flr.sh index f39bdc2..32ba63e 100644 --- a/lustre/tests/sanity-flr.sh +++ b/lustre/tests/sanity-flr.sh @@ -3258,7 +3258,7 @@ test_203() { local new_id=$($LFS getstripe --mirror-id=2 -I $tf) count=$($LFS getstripe --mirror-id=2 -c $tf) || error "getstripe count of mirror 2" - [[ x$oldid = x$newid ]] || + [[ x$old_id = x$new_id ]] || error "mirror 2 changed ID from $old_id to $new_id" [[ x$count = x1 ]] || error "mirror 2 stripe count $count is not 1" -- 1.8.3.1