From 91a3b286ba57bb491b5c17600d7cec9e516a428f Mon Sep 17 00:00:00 2001
From: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Date: Thu, 24 Aug 2023 01:58:14 -0400
Subject: [PATCH] LU-16827 obdfilter: Fix obdfilter-survery/1a

local_node() under test-framework is used
to determine if the node is remote or local
local_node() returns "true" if the node is
local. Else for remote node it return "false"

This patch fixes obdfilter/1a test case which
which was making reverse logic call to
local_node() to determine remote/local node

This patch modifies local_node() to return
"true"/"false" instead of 0/1

This patch also replaces lctl with $LCTL

Test-Parameters: testlist=obdfilter-survey
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: I7bcb483975ec46d9847e0050e5a1f22f68663c80
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51035
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
---
 lustre-iokit/obdfilter-survey/obdfilter-survey |  2 +-
 lustre/tests/obdfilter-survey.sh               |  2 +-
 lustre/tests/test-framework.sh                 | 15 ++++++++++-----
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/lustre-iokit/obdfilter-survey/obdfilter-survey b/lustre-iokit/obdfilter-survey/obdfilter-survey
index 03239c8..60143fb 100755
--- a/lustre-iokit/obdfilter-survey/obdfilter-survey
+++ b/lustre-iokit/obdfilter-survey/obdfilter-survey
@@ -338,7 +338,7 @@ if [ "$lustre_root" == " " ]; then
 fi
 
 if [ -z "$lustre_root" ]; then
-	lctl=lctl
+	lctl=$LCTL
 else
 	lctl=${lustre_root}/utils/lctl
 fi
diff --git a/lustre/tests/obdfilter-survey.sh b/lustre/tests/obdfilter-survey.sh
index d1b86dc..ad944a5 100644
--- a/lustre/tests/obdfilter-survey.sh
+++ b/lustre/tests/obdfilter-survey.sh
@@ -48,7 +48,7 @@ get_targets () {
 		#    $ nobjhi=2 thrhi=2 size=1024
 		#      targets="$nid:$FSNAME-OST0000 $nid:$FSNAME-OST0001 ..."
 		#                 ./obdfilter-survey
-		local_node && [ "$1" == "disk" ] || target=$nid:$target
+		! local_node && [ "$1" == "disk" ] || target=$nid:$target
 		targets="$targets $target"
 	done
 	echo $targets
diff --git a/lustre/tests/test-framework.sh b/lustre/tests/test-framework.sh
index bae1d6a..9e36524 100755
--- a/lustre/tests/test-framework.sh
+++ b/lustre/tests/test-framework.sh
@@ -7261,6 +7261,8 @@ lnet_if_list() {
 	return 0
 }
 
+# return 1 if addr is remote
+# return 0 if addr is local
 is_local_addr() {
 	local addr=$1
 	# Cache address list to avoid mutiple execution of local_addr_list
@@ -7272,22 +7274,25 @@ is_local_addr() {
 	return 1
 }
 
+# return true(0) if host_name is local
+# return false(1) if host_name is remote
 local_node() {
 	local host_name=$1
 	local is_local="IS_LOCAL_$(host_id $host_name)"
+
 	if [ -z "${!is_local-}" ] ; then
-		eval $is_local=0
+		eval $is_local=false
 		local host_ip=$(getent ahostsv4 $host_name |
 					awk 'NR == 1 { print $1 }')
-		is_local_addr "$host_ip" && eval $is_local=1
+		is_local_addr "$host_ip" && eval $is_local=true
 	fi
-	[[ "${!is_local}" == "1" ]]
+	${!is_local}
 }
 
 remote_node () {
 	local node=$1
-	local_node $node && return 1
-	return 0
+
+	! local_node $node
 }
 
 remote_mds ()
-- 
1.8.3.1