From 8fa28e42ce38cb3b6834284f7793e3e74e776c75 Mon Sep 17 00:00:00 2001 From: Patrick Farrell Date: Wed, 1 Mar 2023 10:43:49 -0500 Subject: [PATCH] LU-13805 llite: Improve sync_io comments Correct and improve comments on cl_sync_io_wait_recycle. Test-parameters: trivial Signed-off-by: Patrick Farrell Change-Id: I7784aa75df46831d1b501c823ec1ada48376b227 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/50167 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Oleg Drokin Reviewed-by: Andreas Dilger Reviewed-by: Qian Yingjin --- lustre/obdclass/cl_io.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lustre/obdclass/cl_io.c b/lustre/obdclass/cl_io.c index 9a14e69..e288e42 100644 --- a/lustre/obdclass/cl_io.c +++ b/lustre/obdclass/cl_io.c @@ -1365,6 +1365,10 @@ void cl_sync_io_note(const struct lu_env *env, struct cl_sync_io *anchor, } EXPORT_SYMBOL(cl_sync_io_note); +/* this function waits for completion of outstanding io and then re-initializes + * the anchor used to track it. This is used to wait to complete DIO before + * returning to userspace, and is never called for true AIO + */ int cl_sync_io_wait_recycle(const struct lu_env *env, struct cl_sync_io *anchor, long timeout, int ioret) { @@ -1377,10 +1381,8 @@ int cl_sync_io_wait_recycle(const struct lu_env *env, struct cl_sync_io *anchor, * count to be zero. */ cl_sync_io_note(env, anchor, ioret); - /* Wait for completion of normal dio. - * This replaces the EIOCBQEUED return from the DIO/AIO - * path, and this is where AIO and DIO implementations - * split. + /* Wait for completion of outstanding dio before re-initializing for + * possible restart */ rc = cl_sync_io_wait(env, anchor, timeout); /** -- 1.8.3.1