From 89aac3d3b39f68982530287e11fb29fef0edf456 Mon Sep 17 00:00:00 2001 From: Mr NeilBrown Date: Wed, 12 Apr 2023 09:29:58 -0400 Subject: [PATCH] LU-10391 obdclass: remove class_parse_nid4() class_parse_nid4() not used any more. Signed-off-by: Mr NeilBrown Change-Id: Iefff39a5eaeed8a8ba6fd016e3392db9e92d5422 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/50095 Tested-by: jenkins Tested-by: Maloo Reviewed-by: James Simmons Reviewed-by: Alex Zhuravlev Reviewed-by: Oleg Drokin --- lustre/include/obd_class.h | 2 -- lustre/obdclass/obd_config.c | 31 +------------------------------ 2 files changed, 1 insertion(+), 32 deletions(-) diff --git a/lustre/include/obd_class.h b/lustre/include/obd_class.h index f3c3a1d..171f8c3 100644 --- a/lustre/include/obd_class.h +++ b/lustre/include/obd_class.h @@ -174,8 +174,6 @@ struct cfg_interop_param *class_find_old_param(const char *param, struct cfg_interop_param *ptr); int class_get_next_param(char **params, char *copy); int class_match_param(char *buf, const char *key, char **valp); -int class_parse_nid4(char *buf, lnet_nid_t *nid4, char **endh); -int class_parse_nid4_quiet(char *buf, lnet_nid_t *nid4, char **endh); int class_parse_nid(char *buf, struct lnet_nid *nid, char **endh); int class_parse_nid_quiet(char *buf, struct lnet_nid *nid, char **endh); int class_parse_net(char *buf, u32 *net, char **endh); diff --git a/lustre/obdclass/obd_config.c b/lustre/obdclass/obd_config.c index 861c58b..a4f6907 100644 --- a/lustre/obdclass/obd_config.c +++ b/lustre/obdclass/obd_config.c @@ -408,19 +408,6 @@ int class_match_param(char *buf, const char *key, char **valp) } EXPORT_SYMBOL(class_match_param); -static int parse_nid4(char *buf, void *value, int quiet) -{ - lnet_nid_t *nid4 = (lnet_nid_t *)value; - - *nid4 = libcfs_str2nid(buf); - if (*nid4 != LNET_NID_ANY) - return 0; - - if (!quiet) - LCONSOLE_ERROR_MSG(0x159, "Can't parse NID '%s'\n", buf); - return -EINVAL; -} - static int parse_nid(char *buf, void *value, int quiet) { struct lnet_nid *nid = value; @@ -443,8 +430,7 @@ static int parse_net(char *buf, void *value) } enum { - CLASS_PARSE_NID4 = 1, - CLASS_PARSE_NID, + CLASS_PARSE_NID = 1, CLASS_PARSE_NET, }; @@ -478,9 +464,6 @@ static int class_parse_value(char *buf, int opc, void *value, char **endh, switch (opc) { default: LBUG(); - case CLASS_PARSE_NID4: - rc = parse_nid4(buf, value, quiet); - break; case CLASS_PARSE_NID: rc = parse_nid(buf, value, quiet); break; @@ -496,18 +479,6 @@ static int class_parse_value(char *buf, int opc, void *value, char **endh, return 0; } -int class_parse_nid4(char *buf, lnet_nid_t *nid4, char **endh) -{ - return class_parse_value(buf, CLASS_PARSE_NID4, (void *)nid4, endh, 0); -} -EXPORT_SYMBOL(class_parse_nid4); - -int class_parse_nid4_quiet(char *buf, lnet_nid_t *nid4, char **endh) -{ - return class_parse_value(buf, CLASS_PARSE_NID4, (void *)nid4, endh, 1); -} -EXPORT_SYMBOL(class_parse_nid4_quiet); - int class_parse_nid(char *buf, struct lnet_nid *nid, char **endh) { return class_parse_value(buf, CLASS_PARSE_NID, (void *)nid, endh, 0); -- 1.8.3.1