From 86bc90f4f11df090f86dc764a4ea2d6dd5c13ffe Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Wed, 4 Apr 2007 21:42:42 -0400 Subject: [PATCH] Fix potential reference (and free) to an uninitialized pointer in e2fsck This was introduced recently when fixing a problem noted by Coverty. Oops! Signed-off-by: "Theodore Ts'o" --- e2fsck/ChangeLog | 6 ++++++ e2fsck/pass1.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/e2fsck/ChangeLog b/e2fsck/ChangeLog index 1eb1064..cc35955 100644 --- a/e2fsck/ChangeLog +++ b/e2fsck/ChangeLog @@ -1,3 +1,9 @@ +2007-04-04 Theodore Tso + + * pass1.c (check_ext_attr): Make sure the region variable is + initialized to zero to avoid checking and then freeing an + uninitialized pointer if there is a corrupted EA block. + 2007-03-31 Theodore Tso * pass1.c (e2fsck_pass1, check_is_really_dir): Check for an edge diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c index 6f816df..d45c498 100644 --- a/e2fsck/pass1.c +++ b/e2fsck/pass1.c @@ -1231,7 +1231,7 @@ static int check_ext_attr(e2fsck_t ctx, struct problem_context *pctx, struct ext2_ext_attr_header *header; struct ext2_ext_attr_entry *entry; int count; - region_t region; + region_t region = 0; blk = inode->i_file_acl; if (blk == 0) -- 1.8.3.1