From 80d8eb2f45adc1b8c327c356be018c98922ba734 Mon Sep 17 00:00:00 2001 From: "Mr. NeilBrown" Date: Wed, 22 Mar 2023 10:33:37 -0400 Subject: [PATCH] LU-9859 libcfs: discard MKSTR() macro This is only used for tracing when some strings might be NULL. NULL strings are not a problem for tracing, vnsprintf() will report them as "(null)" which is probably better (easier to parse) than an empty string. Linux-commit: dd0393a5f29633f0e3d52e4c26ae4123c873c016 Test-Parameters: trivial Change-Id: Ia305ea0d0dc05602a03dea589f928b6a599ee55e Signed-off-by: Mr. NeilBrown Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/50376 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: Arshad Hussain Reviewed-by: Oleg Drokin --- libcfs/include/libcfs/libcfs_private.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libcfs/include/libcfs/libcfs_private.h b/libcfs/include/libcfs/libcfs_private.h index 02fc165..fb42b99 100644 --- a/libcfs/include/libcfs/libcfs_private.h +++ b/libcfs/include/libcfs/libcfs_private.h @@ -333,8 +333,6 @@ do { \ /* logical equivalence */ #define equi(a, b) (!!(a) == !!(b)) -#define MKSTR(ptr) ((ptr))? (ptr) : "" - #ifndef HAVE_CFS_SIZE_ROUND static inline size_t cfs_size_round(size_t val) { -- 1.8.3.1