From 76c6ad03369b9c38ecdc12e5290ea20b139389a5 Mon Sep 17 00:00:00 2001 From: Original Author Olaf Faaland Date: Wed, 24 Mar 2021 18:35:10 -0700 Subject: [PATCH] LU-14553 changelog: eliminate mdd_changelog_clear warning When handling a changelog_clear request, the user may specify a range of indices which do not exist. Similarly, the user may specify a changelog user which does not exist. Neither indicates a problem within Lustre that justifies a a console warning. Change those cases to CDEBUG. Lustre-change: https://review.whamcloud.com/43125 Lustre-commit: 6b183927e19715d093c80a35ebc42a1cda5e70e2 Test-Parameters: trivial fortestonly Signed-off-by: Olaf Faaland Change-Id: I64bab12ef4978c4bf7139f5f36a39f9b109616fb Reviewed-by: Sebastien Buisson Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin Signed-off-by: Gian-Carlo DeFazio Reviewed-on: https://review.whamcloud.com/44172 Tested-by: jenkins --- lustre/mdd/mdd_device.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lustre/mdd/mdd_device.c b/lustre/mdd/mdd_device.c index cd03553..e059117 100644 --- a/lustre/mdd/mdd_device.c +++ b/lustre/mdd/mdd_device.c @@ -1815,7 +1815,11 @@ static int mdd_changelog_clear(const struct lu_env *env, mdd_changelog_clear_cb, (void *)&mcuc, 0, 0); - if (rc < 0) { + if (rc == -EINVAL) { + CDEBUG(D_IOCTL, "%s: No changelog recnum <= %llu to clear\n", + mdd2obd_dev(mdd)->obd_name, (unsigned long long) endrec); + RETURN(-EINVAL); + } else if (rc < 0) { CWARN("%s: Failure to clear the changelog for user %d: %d\n", mdd2obd_dev(mdd)->obd_name, id, rc); } else if (mcuc.mcuc_flush) { @@ -1830,7 +1834,7 @@ static int mdd_changelog_clear(const struct lu_env *env, mcuc.mcuc_minrec); } } else { - CWARN("%s: No entry for user %d\n", + CDEBUG(D_IOCTL, "%s: No entry for user %d\n", mdd2obd_dev(mdd)->obd_name, id); rc = -ENOENT; } -- 1.8.3.1