From 765e59d37dc2b4c85e9bdaea2765c9023226778b Mon Sep 17 00:00:00 2001 From: Sebastien Buisson Date: Mon, 19 Jun 2023 13:38:07 +0200 Subject: [PATCH] LU-16911 sec: quiet messages from identity upcall retry mech Do not use CERROR to print messages about failed identity acquire upcalls. And make a difference between initial attempt before retry, and final failure. Fixes: 61c3b3a9bb ("LU-16165 sec: retry mechanism for identity cache") Signed-off-by: Sebastien Buisson Change-Id: I35e04ca31b623d6037bb49e4ded4ea96d653f074 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51355 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- lustre/obdclass/upcall_cache.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lustre/obdclass/upcall_cache.c b/lustre/obdclass/upcall_cache.c index 94a150b..325ccac 100644 --- a/lustre/obdclass/upcall_cache.c +++ b/lustre/obdclass/upcall_cache.c @@ -229,15 +229,18 @@ find_again: if (UC_CACHE_IS_ACQUIRING(entry)) { /* we're interrupted or upcall failed in the middle */ rc = left > 0 ? -EINTR : -ETIMEDOUT; - CERROR("acquire for key %llu: error %d\n", - entry->ue_key, rc); put_entry(cache, entry); if (!failedacquiring) { spin_unlock(&cache->uc_lock); failedacquiring = true; new = NULL; + CDEBUG(D_OTHER, + "retry acquire for key %llu (got %d)\n", + entry->ue_key, rc); goto find_again; } + CERROR("acquire for key %llu: error %d\n", + entry->ue_key, rc); GOTO(out, entry = ERR_PTR(rc)); } } -- 1.8.3.1