From 6e85adde784e6f27731752ca8b1d80cb5d7cb004 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Fri, 10 Jan 2014 21:53:08 -0500 Subject: [PATCH] libblkid: remove unneeded pointer checks Addresses-Coverity-Id: #207522 Addresses-Coverity-Id: #207523 Signed-off-by: "Theodore Ts'o" --- lib/blkid/cache.c | 2 -- lib/blkid/devname.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/blkid/cache.c b/lib/blkid/cache.c index 8bdd239..2a2df13 100644 --- a/lib/blkid/cache.c +++ b/lib/blkid/cache.c @@ -167,8 +167,6 @@ void blkid_gc_cache(blkid_cache cache) list_for_each_safe(p, pnext, &cache->bic_devs) { blkid_dev dev = list_entry(p, struct blkid_struct_dev, bid_devs); - if (!p) - break; if (stat(dev->bid_name, &st) < 0) { DBG(DEBUG_CACHE, printf("freeing %s\n", dev->bid_name)); diff --git a/lib/blkid/devname.c b/lib/blkid/devname.c index a6673c1..3e2efa9 100644 --- a/lib/blkid/devname.c +++ b/lib/blkid/devname.c @@ -91,8 +91,6 @@ blkid_dev blkid_get_dev(blkid_cache cache, const char *devname, int flags) */ list_for_each_safe(p, pnext, &cache->bic_devs) { blkid_dev dev2; - if (!p) - break; dev2 = list_entry(p, struct blkid_struct_dev, bid_devs); if (dev2->bid_flags & BLKID_BID_FL_VERIFIED) continue; -- 1.8.3.1