From 6826fe0efefc03e22ad723104866b15b59fa68ed Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Mon, 8 Jan 2024 14:32:24 +0530 Subject: [PATCH] LU-17000 lnet: don't assign unused return codes In lnet_peer_discovery() return from lnet_peer_ping_failed() and lnet_peer_push_failed() is unused and return value of former get quashed without getting used. Remove rc assignment and cast function to void to make it clear the return code can be ignored. Test-Parameters: trivial CoverityID: 412758 ("Unused Value") CoverityID: 412759 ("Unused Value") Signed-off-by: Arshad Hussain Change-Id: I02d5e883fc02814d5dbe307b78f028703023db52 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53608 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Chris Horn Reviewed-by: Timothy Day Reviewed-by: Oleg Drokin Reviewed-by: Andreas Dilger --- lnet/lnet/peer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lnet/lnet/peer.c b/lnet/lnet/peer.c index 4811fb0..540f7a7 100644 --- a/lnet/lnet/peer.c +++ b/lnet/lnet/peer.c @@ -4146,9 +4146,9 @@ static int lnet_peer_discovery(void *arg) lnet_net_unlock(LNET_LOCK_EX); spin_lock(&lp->lp_lock); if (lp->lp_state & LNET_PEER_PING_FAILED) - rc = lnet_peer_ping_failed(lp); + (void)lnet_peer_ping_failed(lp); if (lp->lp_state & LNET_PEER_PUSH_FAILED) - rc = lnet_peer_push_failed(lp); + (void)lnet_peer_push_failed(lp); spin_unlock(&lp->lp_lock); lnet_net_lock(LNET_LOCK_EX); lnet_peer_discovery_complete(lp, -ESHUTDOWN); -- 1.8.3.1