From 5f327f6670d31f53927598116a00ec6b219a9046 Mon Sep 17 00:00:00 2001 From: Patrick Farrell Date: Thu, 27 Jul 2017 10:18:08 -0500 Subject: [PATCH] LU-8358 vvp: Print discarded page warning on -EIO On client eviction, the client sometimes has dirty pages outstanding, which are then discarded. The client is supposed to print an error when this happens, from vvp_vmpage_error->ll_dirty_page_discard_warn. However, the client looks for specific errors, and newer Lustre clients will sometimes return -EIO to I/O requests on eviction, instead of -EINTR. Since they can still return -EINTR, we must add -EIO as a new condition and keep -EINTR. Signed-off-by: Patrick Farrell Change-Id: I22ac82570a3840782c3fc6db40281b4a2c1cba1c Reviewed-on: https://review.whamcloud.com/21111 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Chris Horn Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin --- lustre/llite/vvp_page.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lustre/llite/vvp_page.c b/lustre/llite/vvp_page.c index 541f795..4f7e6d5 100644 --- a/lustre/llite/vvp_page.c +++ b/lustre/llite/vvp_page.c @@ -242,8 +242,8 @@ static void vvp_vmpage_error(struct inode *inode, struct page *vmpage, int ioret else set_bit(AS_EIO, &inode->i_mapping->flags); - if ((ioret == -ESHUTDOWN || ioret == -EINTR) && - obj->vob_discard_page_warned == 0) { + if ((ioret == -ESHUTDOWN || ioret == -EINTR || + ioret == -EIO) && obj->vob_discard_page_warned == 0) { obj->vob_discard_page_warned = 1; ll_dirty_page_discard_warn(vmpage, ioret); } -- 1.8.3.1