From 5b88c865b994b84060ffb5eaada5e9777ddaf675 Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Thu, 12 Oct 2023 04:46:43 -0400 Subject: [PATCH] LU-17000 coverity: Fix leak under mgc_request.c This patch fixes resource leak error reported by coverity run. CoverityID: 403113 ("Resource leak"): mgc_request.c Test-Parameters: trivial Signed-off-by: Arshad Hussain Change-Id: Ie569a18cbacdb48c186d38ccc466ce86eeb1b28f Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52656 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- lustre/mgc/mgc_request.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lustre/mgc/mgc_request.c b/lustre/mgc/mgc_request.c index 2efb6c1..0d4777c 100644 --- a/lustre/mgc/mgc_request.c +++ b/lustre/mgc/mgc_request.c @@ -1319,6 +1319,9 @@ static int mgc_apply_recover_logs(struct obd_device *mgc, if (cname == NULL) { CERROR("mgc %s: invalid logname %s\n", mgc->obd_name, obdname); + if (entry->mne_nid_type == 0) + OBD_FREE_PTR_ARRAY(nidlist, + entry->mne_nid_count); break; } -- 1.8.3.1